cookstyle 6.9.0 → 6.14.7

Sign up to get free protection for your applications and to get access to all the features.
Files changed (227) hide show
  1. checksums.yaml +4 -4
  2. data/Gemfile +6 -0
  3. data/bin/cookstyle +1 -0
  4. data/bin/cookstyle-profile +31 -0
  5. data/config/cookstyle.yml +146 -28
  6. data/config/disable_all.yml +18 -0
  7. data/config/upstream.yml +103 -10
  8. data/cookstyle.gemspec +1 -0
  9. data/lib/cookstyle.rb +6 -4
  10. data/lib/cookstyle/version.rb +3 -2
  11. data/lib/rubocop/chef.rb +1 -0
  12. data/lib/rubocop/chef/autocorrect_helpers.rb +1 -0
  13. data/lib/rubocop/chef/cookbook_helpers.rb +1 -0
  14. data/lib/rubocop/chef/platform_helpers.rb +1 -0
  15. data/lib/rubocop/cop/chef/correctness/block_guard_clause_string_only.rb +2 -1
  16. data/lib/rubocop/cop/chef/correctness/cb_depends_on_self.rb +2 -1
  17. data/lib/rubocop/cop/chef/correctness/chef_application_fatal.rb +2 -1
  18. data/lib/rubocop/cop/chef/correctness/conditional_ruby_shellout.rb +2 -1
  19. data/lib/rubocop/cop/chef/correctness/dnf_package_allow_downgrades.rb +2 -1
  20. data/lib/rubocop/cop/chef/correctness/incorrect_library_injection.rb +12 -1
  21. data/lib/rubocop/cop/chef/correctness/invalid_default_action.rb +48 -0
  22. data/lib/rubocop/cop/chef/correctness/invalid_notification_timing.rb +2 -1
  23. data/lib/rubocop/cop/chef/correctness/invalid_platform_family_helper.rb +28 -4
  24. data/lib/rubocop/cop/chef/correctness/invalid_platform_family_values_in_case.rb +2 -1
  25. data/lib/rubocop/cop/chef/correctness/invalid_platform_helper.rb +2 -1
  26. data/lib/rubocop/cop/chef/correctness/invalid_platform_metadata.rb +2 -1
  27. data/lib/rubocop/cop/chef/correctness/invalid_platform_values_in_case.rb +2 -1
  28. data/lib/rubocop/cop/chef/correctness/invalid_value_for_platform_family_helper.rb +2 -1
  29. data/lib/rubocop/cop/chef/correctness/invalid_value_for_platform_helper.rb +2 -1
  30. data/lib/rubocop/cop/chef/correctness/invalid_version_metadata.rb +2 -1
  31. data/lib/rubocop/cop/chef/correctness/lazy_eval_node_attribute_defaults.rb +2 -1
  32. data/lib/rubocop/cop/chef/correctness/macos_userdefaults_invalid_type.rb +68 -0
  33. data/lib/rubocop/cop/chef/correctness/malformed_value_for_platform.rb +1 -0
  34. data/lib/rubocop/cop/chef/correctness/metadata_missing_name.rb +2 -1
  35. data/lib/rubocop/cop/chef/correctness/node_normal.rb +2 -1
  36. data/lib/rubocop/cop/chef/correctness/node_normal_unless.rb +2 -1
  37. data/lib/rubocop/cop/chef/correctness/node_save.rb +2 -1
  38. data/lib/rubocop/cop/chef/correctness/notifies_action_not_symbol.rb +6 -5
  39. data/lib/rubocop/cop/chef/correctness/openssl_password_helpers.rb +2 -1
  40. data/lib/rubocop/cop/chef/correctness/powershell_delete_file.rb +2 -1
  41. data/lib/rubocop/cop/chef/correctness/resource_sets_internal_properties.rb +2 -1
  42. data/lib/rubocop/cop/chef/correctness/resource_sets_name_property.rb +2 -1
  43. data/lib/rubocop/cop/chef/correctness/resource_with_none_action.rb +2 -1
  44. data/lib/rubocop/cop/chef/correctness/scoped_file_exist.rb +2 -1
  45. data/lib/rubocop/cop/chef/correctness/service_resource.rb +2 -1
  46. data/lib/rubocop/cop/chef/correctness/supports_must_be_float.rb +52 -0
  47. data/lib/rubocop/cop/chef/correctness/tmp_path.rb +2 -1
  48. data/lib/rubocop/cop/chef/deprecation/ use_automatic_resource_name.rb +52 -0
  49. data/lib/rubocop/cop/chef/deprecation/chef_handler_recipe.rb +55 -0
  50. data/lib/rubocop/cop/chef/deprecation/chef_handler_supports.rb +2 -1
  51. data/lib/rubocop/cop/chef/deprecation/chef_rest.rb +2 -1
  52. data/lib/rubocop/cop/chef/deprecation/chef_rewind.rb +2 -1
  53. data/lib/rubocop/cop/chef/deprecation/chef_windows_platform_helper.rb +2 -1
  54. data/lib/rubocop/cop/chef/deprecation/chefdk_generators.rb +60 -0
  55. data/lib/rubocop/cop/chef/deprecation/cheffile.rb +3 -2
  56. data/lib/rubocop/cop/chef/deprecation/chefspec_coverage_report.rb +2 -1
  57. data/lib/rubocop/cop/chef/deprecation/chefspec_legacy_runner.rb +2 -1
  58. data/lib/rubocop/cop/chef/deprecation/chocolatey_package_uninstall_action.rb +2 -1
  59. data/lib/rubocop/cop/chef/deprecation/depends_compat_resource.rb +2 -1
  60. data/lib/rubocop/cop/chef/deprecation/depends_partial_search.rb +2 -1
  61. data/lib/rubocop/cop/chef/deprecation/depends_poise.rb +2 -1
  62. data/lib/rubocop/cop/chef/deprecation/deprecated_chefspec_platform.rb +2 -1
  63. data/lib/rubocop/cop/chef/deprecation/deprecated_mixins.rb +2 -1
  64. data/lib/rubocop/cop/chef/deprecation/deprecated_platform_methods.rb +2 -1
  65. data/lib/rubocop/cop/chef/deprecation/deprecated_shellout_methods.rb +2 -1
  66. data/lib/rubocop/cop/chef/deprecation/deprecated_windows_version_check.rb +2 -1
  67. data/lib/rubocop/cop/chef/deprecation/deprecated_yum_repository_properties.rb +2 -1
  68. data/lib/rubocop/cop/chef/deprecation/easy_install.rb +2 -1
  69. data/lib/rubocop/cop/chef/deprecation/eol_audit_mode.rb +3 -2
  70. data/lib/rubocop/cop/chef/deprecation/epic_fail.rb +2 -1
  71. data/lib/rubocop/cop/chef/deprecation/erl_call.rb +2 -1
  72. data/lib/rubocop/cop/chef/deprecation/hwrp_without_provides.rb +2 -1
  73. data/lib/rubocop/cop/chef/deprecation/inherits_compat_resource.rb +2 -1
  74. data/lib/rubocop/cop/chef/deprecation/launchd_deprecated_hash_property.rb +2 -1
  75. data/lib/rubocop/cop/chef/deprecation/legacy_notify_syntax.rb +3 -2
  76. data/lib/rubocop/cop/chef/deprecation/legacy_yum_cookbook_recipes.rb +2 -1
  77. data/lib/rubocop/cop/chef/deprecation/locale_lc_all_property.rb +2 -1
  78. data/lib/rubocop/cop/chef/deprecation/log_resource_notifications.rb +2 -1
  79. data/lib/rubocop/cop/chef/deprecation/macos_userdefaults_global_property.rb +61 -0
  80. data/lib/rubocop/cop/chef/deprecation/name_property_and_default.rb +2 -1
  81. data/lib/rubocop/cop/chef/deprecation/node_deep_fetch.rb +8 -21
  82. data/lib/rubocop/cop/chef/deprecation/node_methods_not_attributes.rb +2 -1
  83. data/lib/rubocop/cop/chef/deprecation/node_set.rb +2 -1
  84. data/lib/rubocop/cop/chef/deprecation/node_set_unless.rb +2 -1
  85. data/lib/rubocop/cop/chef/deprecation/node_set_without_level.rb +2 -1
  86. data/lib/rubocop/cop/chef/deprecation/partial_search_class_usage.rb +2 -1
  87. data/lib/rubocop/cop/chef/deprecation/partial_search_helper_usage.rb +2 -1
  88. data/lib/rubocop/cop/chef/deprecation/poise_archive.rb +4 -3
  89. data/lib/rubocop/cop/chef/deprecation/powershell_cookbook_helpers.rb +2 -1
  90. data/lib/rubocop/cop/chef/deprecation/require_recipe.rb +2 -1
  91. data/lib/rubocop/cop/chef/deprecation/resource_overrides_provides_method.rb +2 -1
  92. data/lib/rubocop/cop/chef/deprecation/resource_uses_dsl_name_method.rb +2 -1
  93. data/lib/rubocop/cop/chef/deprecation/resource_uses_only_resource_name.rb +3 -2
  94. data/lib/rubocop/cop/chef/deprecation/resource_uses_provider_base_method.rb +2 -1
  95. data/lib/rubocop/cop/chef/deprecation/resource_uses_updated_method.rb +2 -1
  96. data/lib/rubocop/cop/chef/deprecation/ruby_27_keyword_argument_warnings.rb +3 -2
  97. data/lib/rubocop/cop/chef/deprecation/ruby_block_create_action.rb +2 -1
  98. data/lib/rubocop/cop/chef/deprecation/run_command_helper.rb +2 -1
  99. data/lib/rubocop/cop/chef/deprecation/search_uses_positional_parameters.rb +2 -1
  100. data/lib/rubocop/cop/chef/deprecation/use_inline_resources.rb +2 -1
  101. data/lib/rubocop/cop/chef/deprecation/user_supports_property.rb +2 -1
  102. data/lib/rubocop/cop/chef/deprecation/verify_property_file_expansion.rb +2 -1
  103. data/lib/rubocop/cop/chef/deprecation/windows_feature_servermanagercmd.rb +2 -1
  104. data/lib/rubocop/cop/chef/deprecation/windows_task_change_action.rb +2 -1
  105. data/lib/rubocop/cop/chef/deprecation/windows_version_helpers.rb +2 -1
  106. data/lib/rubocop/cop/chef/deprecation/xml_ruby_recipe.rb +2 -1
  107. data/lib/rubocop/cop/chef/deprecation/yum_dnf_compat_recipe.rb +2 -1
  108. data/lib/rubocop/cop/chef/effortless/berksfile.rb +2 -1
  109. data/lib/rubocop/cop/chef/effortless/data_bags.rb +2 -1
  110. data/lib/rubocop/cop/chef/effortless/node_environment.rb +3 -2
  111. data/lib/rubocop/cop/chef/effortless/node_policygroup.rb +2 -1
  112. data/lib/rubocop/cop/chef/effortless/node_roles.rb +5 -4
  113. data/lib/rubocop/cop/chef/effortless/search_for_environments_or_roles.rb +2 -1
  114. data/lib/rubocop/cop/chef/effortless/search_used.rb +2 -1
  115. data/lib/rubocop/cop/chef/modernize/action_method_in_resource.rb +57 -0
  116. data/lib/rubocop/cop/chef/modernize/allowed_actions_initializer.rb +4 -3
  117. data/lib/rubocop/cop/chef/modernize/apt_default_recipe.rb +2 -1
  118. data/lib/rubocop/cop/chef/modernize/berksfile_source.rb +2 -1
  119. data/lib/rubocop/cop/chef/modernize/build_essential.rb +2 -1
  120. data/lib/rubocop/cop/chef/modernize/chef_14_resources.rb +2 -1
  121. data/lib/rubocop/cop/chef/modernize/chef_gem_nokogiri.rb +2 -1
  122. data/lib/rubocop/cop/chef/modernize/compile_time_resources.rb +2 -1
  123. data/lib/rubocop/cop/chef/modernize/conditional_using_test.rb +57 -0
  124. data/lib/rubocop/cop/chef/modernize/cron_d_file_or_template.rb +88 -0
  125. data/lib/rubocop/cop/chef/modernize/cron_manage_resource.rb +2 -1
  126. data/lib/rubocop/cop/chef/modernize/databag_helpers.rb +2 -1
  127. data/lib/rubocop/cop/chef/modernize/default_action_initializer.rb +5 -4
  128. data/lib/rubocop/cop/chef/modernize/defines_chefspec_matchers.rb +2 -1
  129. data/lib/rubocop/cop/chef/modernize/definitions.rb +3 -2
  130. data/lib/rubocop/cop/chef/modernize/depends_zypper_cookbook.rb +2 -1
  131. data/lib/rubocop/cop/chef/modernize/dsl_include_in_resource.rb +2 -1
  132. data/lib/rubocop/cop/chef/modernize/empty_resource_initialize.rb +2 -1
  133. data/lib/rubocop/cop/chef/modernize/execute_apt_update.rb +3 -2
  134. data/lib/rubocop/cop/chef/modernize/execute_sc_exe.rb +2 -1
  135. data/lib/rubocop/cop/chef/modernize/execute_sleep.rb +2 -1
  136. data/lib/rubocop/cop/chef/modernize/execute_sysctl.rb +2 -1
  137. data/lib/rubocop/cop/chef/modernize/execute_tzutil.rb +2 -1
  138. data/lib/rubocop/cop/chef/modernize/foodcritic_comments.rb +2 -1
  139. data/lib/rubocop/cop/chef/modernize/if_provides_default_action.rb +2 -1
  140. data/lib/rubocop/cop/chef/modernize/includes_mixin_shellout.rb +2 -1
  141. data/lib/rubocop/cop/chef/modernize/libarchive_file.rb +2 -1
  142. data/lib/rubocop/cop/chef/modernize/macos_user_defaults.rb +2 -1
  143. data/lib/rubocop/cop/chef/modernize/minitest_handler_usage.rb +2 -1
  144. data/lib/rubocop/cop/chef/modernize/node_init_package.rb +18 -9
  145. data/lib/rubocop/cop/chef/modernize/node_roles_include.rb +2 -1
  146. data/lib/rubocop/cop/chef/modernize/ohai_default_recipe.rb +2 -1
  147. data/lib/rubocop/cop/chef/modernize/openssl_rsa_key_resource.rb +2 -1
  148. data/lib/rubocop/cop/chef/modernize/openssl_x509_resource.rb +2 -1
  149. data/lib/rubocop/cop/chef/modernize/osx_config_profile_resource.rb +2 -1
  150. data/lib/rubocop/cop/chef/modernize/powershell_expand_archive.rb +2 -1
  151. data/lib/rubocop/cop/chef/modernize/powershell_guard_interpreter.rb +2 -1
  152. data/lib/rubocop/cop/chef/modernize/powershell_install_package.rb +2 -1
  153. data/lib/rubocop/cop/chef/modernize/powershell_install_windowsfeature.rb +2 -1
  154. data/lib/rubocop/cop/chef/modernize/property_with_name_attribute.rb +2 -1
  155. data/lib/rubocop/cop/chef/modernize/provides_initializer.rb +5 -4
  156. data/lib/rubocop/cop/chef/modernize/resource_name_initializer.rb +4 -3
  157. data/lib/rubocop/cop/chef/modernize/resource_set_or_return.rb +2 -1
  158. data/lib/rubocop/cop/chef/modernize/resource_with_attributes.rb +2 -1
  159. data/lib/rubocop/cop/chef/modernize/respond_to_compile_time.rb +2 -1
  160. data/lib/rubocop/cop/chef/modernize/respond_to_metadata.rb +2 -1
  161. data/lib/rubocop/cop/chef/modernize/respond_to_provides.rb +2 -1
  162. data/lib/rubocop/cop/chef/modernize/respond_to_resource_name.rb +2 -1
  163. data/lib/rubocop/cop/chef/modernize/sc_windows_resource.rb +2 -1
  164. data/lib/rubocop/cop/chef/modernize/seven_zip_archive.rb +2 -1
  165. data/lib/rubocop/cop/chef/modernize/shell_out_helper.rb +2 -1
  166. data/lib/rubocop/cop/chef/modernize/shellouts_to_chocolatey.rb +2 -1
  167. data/lib/rubocop/cop/chef/modernize/simplify_apt_ppa_setup.rb +2 -1
  168. data/lib/rubocop/cop/chef/modernize/systctl_param_resource.rb +2 -1
  169. data/lib/rubocop/cop/chef/modernize/unnecessary_mixlib_shellout_require.rb +2 -1
  170. data/lib/rubocop/cop/chef/modernize/use_multipackage_installs.rb +4 -3
  171. data/lib/rubocop/cop/chef/modernize/use_require_relative.rb +2 -1
  172. data/lib/rubocop/cop/chef/modernize/whyrun_supported_true.rb +2 -1
  173. data/lib/rubocop/cop/chef/modernize/windows_default_recipe.rb +2 -1
  174. data/lib/rubocop/cop/chef/modernize/windows_registry_uac.rb +2 -1
  175. data/lib/rubocop/cop/chef/modernize/windows_zipfile.rb +2 -1
  176. data/lib/rubocop/cop/chef/modernize/zipfile_resource.rb +2 -1
  177. data/lib/rubocop/cop/chef/modernize/zypper_repo.rb +2 -1
  178. data/lib/rubocop/cop/chef/redundant/apt_repository_distribution_default.rb +2 -1
  179. data/lib/rubocop/cop/chef/redundant/apt_repository_notifies_apt_update.rb +2 -1
  180. data/lib/rubocop/cop/chef/redundant/attribute_metadata.rb +2 -1
  181. data/lib/rubocop/cop/chef/redundant/conflicts_metadata.rb +2 -1
  182. data/lib/rubocop/cop/chef/redundant/custom_resource_with_allowed_actions.rb +2 -1
  183. data/lib/rubocop/cop/chef/redundant/double_compile_time.rb +65 -0
  184. data/lib/rubocop/cop/chef/redundant/grouping_metadata.rb +2 -1
  185. data/lib/rubocop/cop/chef/redundant/long_description_metadata.rb +2 -1
  186. data/lib/rubocop/cop/chef/redundant/multiple_platform_checks.rb +61 -0
  187. data/lib/rubocop/cop/chef/redundant/name_property_and_required.rb +2 -1
  188. data/lib/rubocop/cop/chef/redundant/ohai_attribute_to_string.rb +69 -0
  189. data/lib/rubocop/cop/chef/redundant/property_splat_regex.rb +2 -1
  190. data/lib/rubocop/cop/chef/redundant/property_with_default_and_required.rb +2 -1
  191. data/lib/rubocop/cop/chef/redundant/provides_metadata.rb +2 -1
  192. data/lib/rubocop/cop/chef/redundant/recipe_metadata.rb +2 -1
  193. data/lib/rubocop/cop/chef/redundant/replaces_metadata.rb +2 -1
  194. data/lib/rubocop/cop/chef/redundant/resource_with_nothing_action.rb +2 -1
  195. data/lib/rubocop/cop/chef/redundant/sensitive_property_in_resource.rb +2 -1
  196. data/lib/rubocop/cop/chef/redundant/string_property_with_nil_default.rb +2 -1
  197. data/lib/rubocop/cop/chef/redundant/suggests_metadata.rb +2 -1
  198. data/lib/rubocop/cop/chef/redundant/unnecessary_desired_state.rb +2 -1
  199. data/lib/rubocop/cop/chef/redundant/unnecessary_name_property.rb +2 -1
  200. data/lib/rubocop/cop/chef/redundant/use_create_if_missing.rb +2 -1
  201. data/lib/rubocop/cop/chef/sharing/default_maintainer_metadata.rb +2 -1
  202. data/lib/rubocop/cop/chef/sharing/empty_metadata_field.rb +2 -1
  203. data/lib/rubocop/cop/chef/sharing/include_property_descriptions.rb +3 -2
  204. data/lib/rubocop/cop/chef/sharing/include_resource_descriptions.rb +3 -2
  205. data/lib/rubocop/cop/chef/sharing/include_resource_examples.rb +60 -0
  206. data/lib/rubocop/cop/chef/sharing/insecure_cookbook_url.rb +2 -1
  207. data/lib/rubocop/cop/chef/sharing/invalid_license_string.rb +2 -1
  208. data/lib/rubocop/cop/chef/style/attribute_keys.rb +2 -1
  209. data/lib/rubocop/cop/chef/style/chef_whaaat.rb +2 -1
  210. data/lib/rubocop/cop/chef/style/comment_sentence_spacing.rb +2 -1
  211. data/lib/rubocop/cop/chef/style/comments_copyright_format.rb +2 -1
  212. data/lib/rubocop/cop/chef/style/comments_default_copyright.rb +2 -1
  213. data/lib/rubocop/cop/chef/style/comments_format.rb +2 -1
  214. data/lib/rubocop/cop/chef/style/file_mode.rb +39 -19
  215. data/lib/rubocop/cop/chef/style/immediate_notification_timing.rb +2 -1
  216. data/lib/rubocop/cop/chef/style/include_recipe_with_parentheses.rb +58 -0
  217. data/lib/rubocop/cop/chef/style/negating_only_if.rb +2 -1
  218. data/lib/rubocop/cop/chef/style/overly_complex_supports_depends_metadata.rb +2 -1
  219. data/lib/rubocop/cop/chef/style/simplify_platform_major_version_check.rb +2 -1
  220. data/lib/rubocop/cop/chef/style/true_false_resource_properties.rb +2 -1
  221. data/lib/rubocop/cop/chef/style/unnecessary_os_check.rb +3 -3
  222. data/lib/rubocop/cop/chef/style/unnecessary_platform_case_statement.rb +3 -2
  223. data/lib/rubocop/cop/chef/style/use_platform_helpers.rb +3 -3
  224. data/lib/rubocop/monkey_patches/{cop.rb → base.rb} +2 -1
  225. data/lib/rubocop/monkey_patches/comment_config.rb +1 -0
  226. data/lib/rubocop/monkey_patches/registry_cop.rb +15 -0
  227. metadata +22 -5
@@ -1,3 +1,4 @@
1
+ # frozen_string_literal: true
1
2
  #
2
3
  # Copyright:: Copyright 2019, Chef Software Inc.
3
4
  # Author:: Tim Smith (<tsmith@chef.io>)
@@ -33,7 +34,7 @@ module RuboCop
33
34
  # source_url 'http://gitlab.com/something/something'
34
35
  #
35
36
  class InsecureCookbookURL < Cop
36
- MSG = 'Insecure http Github or Gitlab URLs for metadata source_url/issues_url fields'.freeze
37
+ MSG = 'Insecure http Github or Gitlab URLs for metadata source_url/issues_url fields'
37
38
 
38
39
  def_node_matcher :insecure_cb_url?, <<-PATTERN
39
40
  (send nil? {:source_url :issues_url} (str #insecure_url?))
@@ -1,3 +1,4 @@
1
+ # frozen_string_literal: true
1
2
  #
2
3
  # Copyright:: 2019, Chef Software Inc.
3
4
  # Author:: Tim Smith (<tsmith@chef.io>)
@@ -454,7 +455,7 @@ module RuboCop
454
455
  'UNLICENSED': 'all rights reserved',
455
456
  }.freeze
456
457
 
457
- MSG = 'Cookbook metadata.rb does not use a SPDX compliant license string or "all rights reserved". See https://spdx.org/licenses/ for a complete list of license identifiers.'.freeze
458
+ MSG = 'Cookbook metadata.rb does not use a SPDX compliant license string or "all rights reserved". See https://spdx.org/licenses/ for a complete list of license identifiers.'
458
459
 
459
460
  def_node_matcher :license?, '(send nil? :license $str ...)'
460
461
 
@@ -1,3 +1,4 @@
1
+ # frozen_string_literal: true
1
2
  #
2
3
  # Copyright:: 2016, Noah Kantrowitz
3
4
  #
@@ -43,7 +44,7 @@ module RuboCop
43
44
  class AttributeKeys < Cop
44
45
  include RuboCop::Cop::ConfigurableEnforcedStyle
45
46
 
46
- MSG = 'Use %s to access node attributes'.freeze
47
+ MSG = 'Use %s to access node attributes'
47
48
 
48
49
  def_node_matcher :node_attribute_access?, <<-PATTERN
49
50
  (send (send _ :node) :[] _)
@@ -1,3 +1,4 @@
1
+ # frozen_string_literal: true
1
2
  #
2
3
  # Copyright:: 2020, Chef Software, Inc.
3
4
  # Author:: Tim Smith (<tsmith@chef.io>)
@@ -32,7 +33,7 @@ module RuboCop
32
33
  # Chef Infra configures your systems
33
34
  #
34
35
  class ChefWhaaat < Cop
35
- MSG = 'Do you mean Chef (the company) or a Chef product (e.g. Chef Infra, Chef InSpec, etc)?'.freeze
36
+ MSG = 'Do you mean Chef (the company) or a Chef product (e.g. Chef Infra, Chef InSpec, etc)?'
36
37
 
37
38
  def investigate(processed_source)
38
39
  return unless processed_source.ast
@@ -1,3 +1,4 @@
1
+ # frozen_string_literal: true
1
2
  #
2
3
  # Copyright:: 2016-2019, Chef Software, Inc.
3
4
  # Author:: Tim Smith (<tsmith@chef.io>)
@@ -22,7 +23,7 @@ module RuboCop
22
23
  # Replaces double spaces between sentences with a single space.
23
24
  # Note: This is DISABLED by default.
24
25
  class CommentSentenceSpacing < Cop
25
- MSG = 'Use a single space after sentences in comments'.freeze
26
+ MSG = 'Use a single space after sentences in comments'
26
27
 
27
28
  def investigate(processed_source)
28
29
  return unless processed_source.ast
@@ -1,3 +1,4 @@
1
+ # frozen_string_literal: true
1
2
  #
2
3
  # Copyright:: 2016-2019, Chef Software, Inc.
3
4
  # Author:: Tim Smith (<tsmith@chef.io>)
@@ -40,7 +41,7 @@ module RuboCop
40
41
  class CopyrightCommentFormat < Cop
41
42
  require 'date'
42
43
 
43
- MSG = 'Properly format copyrights header comments'.freeze
44
+ MSG = 'Properly format copyrights header comments'
44
45
 
45
46
  def investigate(processed_source)
46
47
  return unless processed_source.ast
@@ -1,3 +1,4 @@
1
+ # frozen_string_literal: true
1
2
  #
2
3
  # Copyright:: 2016-2019, Chef Software, Inc.
3
4
  # Author:: Tim Smith (<tsmith@chef.io>)
@@ -32,7 +33,7 @@ module RuboCop
32
33
  # Copyright:: 2019 Chef Software, Inc.
33
34
  #
34
35
  class DefaultCopyrightComments < Cop
35
- MSG = 'Cookbook copyright comment headers should be updated for a real person or organization.'.freeze
36
+ MSG = 'Cookbook copyright comment headers should be updated for a real person or organization.'
36
37
 
37
38
  def investigate(processed_source)
38
39
  return unless processed_source.ast
@@ -1,3 +1,4 @@
1
+ # frozen_string_literal: true
1
2
  #
2
3
  # Copyright:: 2016-2019, Chef Software, Inc.
3
4
  # Author:: Tim Smith (<tsmith@chef.io>)
@@ -40,7 +41,7 @@ module RuboCop
40
41
  # Cookbook:: Tomcat
41
42
  #
42
43
  class CommentFormat < Cop
43
- MSG = 'Properly format header comments'.freeze
44
+ MSG = 'Properly format header comments'
44
45
 
45
46
  def investigate(processed_source)
46
47
  return unless processed_source.ast
@@ -1,3 +1,4 @@
1
+ # frozen_string_literal: true
1
2
  #
2
3
  # Copyright:: 2016, Noah Kantrowitz
3
4
  #
@@ -18,39 +19,58 @@ module RuboCop
18
19
  module Cop
19
20
  module Chef
20
21
  module ChefStyle
21
- # Check the file modes are given as strings instead of integers.
22
+ # Use strings to represent file modes to avoid confusion between octal and base 10 integer formats.
22
23
  #
23
24
  # @example
24
25
  #
25
26
  # # bad
26
- # mode 644
27
- # mode 0644
27
+ # remote_directory '/etc/my.conf' do
28
+ # content 'some content'
29
+ # mode 0600
30
+ # action :create
31
+ # end
32
+ #
33
+ # remote_directory 'handler' do
34
+ # source 'handlers'
35
+ # recursive true
36
+ # files_mode 644
37
+ # action :create
38
+ # end
28
39
  #
29
40
  # # good
30
- # mode '644'
41
+ # remote_directory '/etc/my.conf' do
42
+ # content 'some content'
43
+ # mode '600'
44
+ # action :create
45
+ # end
46
+ #
47
+ # remote_directory 'handler' do
48
+ # source 'handlers'
49
+ # recursive true
50
+ # files_mode '644'
51
+ # action :create
52
+ # end
31
53
  #
32
- class FileMode < Cop
33
- MSG = 'Use strings for file modes'.freeze
54
+ class FileMode < Base
55
+ extend RuboCop::Cop::AutoCorrector
56
+
57
+ MSG = 'Use strings to represent file modes to avoid confusion between octal and base 10 integer formats'
34
58
 
35
59
  def_node_matcher :resource_mode?, <<-PATTERN
36
- (send nil? :mode $int)
60
+ (send nil? {:mode :files_mode} $int)
37
61
  PATTERN
38
62
 
39
63
  def on_send(node)
40
64
  resource_mode?(node) do |mode_int|
41
- add_offense(mode_int, location: :expression, message: MSG, severity: :refactor)
42
- end
43
- end
44
-
45
- def autocorrect(node)
46
- lambda do |corrector|
47
- # If it was an octal literal, make sure we write out the right number.
48
- replacement_base = octal?(node) ? 8 : 10
49
- replacement_mode = node.children.first.to_s(replacement_base)
65
+ add_offense(mode_int.loc.expression, message: MSG, severity: :refactor) do |corrector|
66
+ # If it was an octal literal, make sure we write out the right number.
67
+ replacement_base = octal?(mode_int) ? 8 : 10
68
+ replacement_mode = mode_int.children.first.to_s(replacement_base)
50
69
 
51
- # we build our own escaped string instead of using .inspect because that way
52
- # we can use single quotes instead of the double quotes that .inspect adds
53
- corrector.replace(node.loc.expression, "\'#{replacement_mode}\'")
70
+ # we build our own escaped string instead of using .inspect because that way
71
+ # we can use single quotes instead of the double quotes that .inspect adds
72
+ corrector.replace(mode_int.loc.expression, "\'#{replacement_mode}\'")
73
+ end
54
74
  end
55
75
  end
56
76
 
@@ -1,3 +1,4 @@
1
+ # frozen_string_literal: true
1
2
  #
2
3
  # Copyright:: 2019, Chef Software, Inc.
3
4
  # Author:: Tim Smith (<tsmith@chef.io>)
@@ -35,7 +36,7 @@ module RuboCop
35
36
  # end
36
37
  #
37
38
  class ImmediateNotificationTiming < Cop
38
- MSG = 'Use :immediately instead of :immediate for resource notification timing'.freeze
39
+ MSG = 'Use :immediately instead of :immediate for resource notification timing'
39
40
 
40
41
  def_node_matcher :immediate_notify?, <<-PATTERN
41
42
  (send nil? :notifies (sym _) (...) $(sym :immediate))
@@ -0,0 +1,58 @@
1
+ # frozen_string_literal: true
2
+ #
3
+ # Copyright:: 2020, Chef Software, Inc.
4
+ # Author:: Tim Smith (<tsmith@chef.io>)
5
+ #
6
+ # Licensed under the Apache License, Version 2.0 (the "License");
7
+ # you may not use this file except in compliance with the License.
8
+ # You may obtain a copy of the License at
9
+ #
10
+ # http://www.apache.org/licenses/LICENSE-2.0
11
+ #
12
+ # Unless required by applicable law or agreed to in writing, software
13
+ # distributed under the License is distributed on an "AS IS" BASIS,
14
+ # WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
15
+ # See the License for the specific language governing permissions and
16
+ # limitations under the License.
17
+ #
18
+
19
+ module RuboCop
20
+ module Cop
21
+ module Chef
22
+ module ChefStyle
23
+ # There is no need to wrap the recipe in parentheses when using the include_recipe helper.
24
+ #
25
+ # @example
26
+ #
27
+ # # bad
28
+ # include_recipe('foo::bar')
29
+ #
30
+ # # good
31
+ # include_recipe 'foo::bar'
32
+ #
33
+ class IncludeRecipeWithParentheses < Base
34
+ extend RuboCop::Cop::AutoCorrector
35
+
36
+ MSG = 'There is no need to wrap the recipe in parentheses when using the include_recipe helper'
37
+
38
+ def_node_matcher :include_recipe?, <<-PATTERN
39
+ (send nil? :include_recipe $(str _))
40
+ PATTERN
41
+
42
+ def on_send(node)
43
+ include_recipe?(node) do |recipe|
44
+ return unless node.parenthesized?
45
+
46
+ # avoid chefspec: expect(chef_run).to include_recipe('foo')
47
+ return if node.parent&.send_type?
48
+
49
+ add_offense(node.loc.expression, message: MSG, severity: :refactor) do |corrector|
50
+ corrector.replace(node.loc.expression, "include_recipe #{recipe.source}")
51
+ end
52
+ end
53
+ end
54
+ end
55
+ end
56
+ end
57
+ end
58
+ end
@@ -1,3 +1,4 @@
1
+ # frozen_string_literal: true
1
2
  #
2
3
  # Copyright:: 2020, Chef Software, Inc.
3
4
  # Author:: Tim Smith (<tsmith@chef.io>)
@@ -33,7 +34,7 @@ module RuboCop
33
34
  # end
34
35
  #
35
36
  class NegatingOnlyIf < Cop
36
- MSG = 'Instead of using only_if conditionals with ! to negate the returned value, use not_if which is easier to read'.freeze
37
+ MSG = 'Instead of using only_if conditionals with ! to negate the returned value, use not_if which is easier to read'
37
38
 
38
39
  def_node_matcher :negated_only_if?, <<-PATTERN
39
40
  (block
@@ -1,3 +1,4 @@
1
+ # frozen_string_literal: true
1
2
  #
2
3
  # Copyright:: 2020, Chef Software, Inc.
3
4
  # Author:: Tim Smith (<tsmith@chef.io>)
@@ -41,7 +42,7 @@ module RuboCop
41
42
  # depends 'yum'
42
43
  #
43
44
  class OverlyComplexSupportsDependsMetadata < Cop
44
- MSG = "Don't loop over an array to set cookbook dependencies or supported platforms if you have fewer than three values to set.".freeze
45
+ MSG = "Don't loop over an array to set cookbook dependencies or supported platforms if you have fewer than three values to set."
45
46
 
46
47
  def_node_matcher :supports_depends_array?, <<-PATTERN
47
48
  (block
@@ -1,3 +1,4 @@
1
+ # frozen_string_literal: true
1
2
  #
2
3
  # Copyright:: 2019, Chef Software, Inc.
3
4
  # Author:: Tim Smith (<tsmith@chef.io>)
@@ -34,7 +35,7 @@ module RuboCop
34
35
  # if node['platform_version'].to_i == 7
35
36
  #
36
37
  class SimplifyPlatformMajorVersionCheck < Cop
37
- MSG = "Use node['platform_version'].to_i instead of node['platform_version'].split('.').first or node['platform_version'].split('.')[0]".freeze
38
+ MSG = "Use node['platform_version'].to_i instead of node['platform_version'].split('.').first or node['platform_version'].split('.')[0]"
38
39
 
39
40
  def_node_matcher :platform_version_check?, <<-PATTERN
40
41
  (send (send (send nil? :node) :[] (str "platform_version") ) :split (str ".") )
@@ -1,3 +1,4 @@
1
+ # frozen_string_literal: true
1
2
  #
2
3
  # Copyright:: 2019, Chef Software, Inc.
3
4
  # Author:: Tim Smith (<tsmith@chef.io>)
@@ -29,7 +30,7 @@ module RuboCop
29
30
  # property :foo, [true, false]
30
31
  #
31
32
  class TrueClassFalseClassResourceProperties < Cop
32
- MSG = "When setting the allowed types for a resource to accept either true or false values it's much simpler to use true and false instead of TrueClass and FalseClass.".freeze
33
+ MSG = "When setting the allowed types for a resource to accept either true or false values it's much simpler to use true and false instead of TrueClass and FalseClass."
33
34
 
34
35
  def_node_matcher :trueclass_falseclass_property?, <<-PATTERN
35
36
  (send nil? {:property :attribute} (sym _) $(array (const nil? :TrueClass) (const nil? :FalseClass)) ... )
@@ -1,3 +1,4 @@
1
+ # frozen_string_literal: true
1
2
  #
2
3
  # Copyright:: 2020, Chef Software, Inc.
3
4
  # Author:: Tim Smith (<tsmith@chef.io>)
@@ -35,7 +36,7 @@ module RuboCop
35
36
  # platform_family?('netbsd', 'openbsd', 'freebsd)
36
37
  #
37
38
  class UnnecessaryOSCheck < Cop
38
- MSG = "Use the platform_family?() helpers instead of node['os] == 'foo' for platform_families that match 1:1 with OS values.".freeze
39
+ MSG = "Use the platform_family?() helpers instead of node['os] == 'foo' for platform_families that match 1:1 with OS values."
39
40
 
40
41
  # sorted list of all the os values that match 1:1 with a platform_family
41
42
  UNNECESSARY_OS_VALUES = %w(aix darwin dragonflybsd freebsd netbsd openbsd solaris2 windows).freeze
@@ -89,8 +90,7 @@ module RuboCop
89
90
  def autocorrect(node)
90
91
  lambda do |corrector|
91
92
  os_equals?(node) do |operator, plat|
92
- corrected_string = operator == :!= ? '!' : ''
93
- corrected_string << "platform_family?('#{sanitized_platform(plat.value)}')"
93
+ corrected_string = (operator == :!= ? '!' : '') + "platform_family?('#{sanitized_platform(plat.value)}')"
94
94
  corrector.replace(node.loc.expression, corrected_string)
95
95
  end
96
96
 
@@ -1,3 +1,4 @@
1
+ # frozen_string_literal: true
1
2
  #
2
3
  # Copyright:: 2019, Chef Software, Inc.
3
4
  # Author:: Tim Smith (<tsmith@chef.io>)
@@ -45,7 +46,7 @@ module RuboCop
45
46
  class UnnecessaryPlatformCaseStatement < Cop
46
47
  include RangeHelp
47
48
 
48
- MSG = 'Use the platform?() and platform_family?() helpers instead of a case statement that only includes a single when statement.'.freeze
49
+ MSG = 'Use the platform?() and platform_family?() helpers instead of a case statement that only includes a single when statement.'
49
50
 
50
51
  def_node_matcher :platform_case?, <<-PATTERN
51
52
  ( case $( send (send nil? :node) :[] $(str {"platform" "platform_family"})) ... )
@@ -66,7 +67,7 @@ module RuboCop
66
67
  condition_string = node.when_branches.first.conditions.map(&:source).join(', ')
67
68
 
68
69
  # single line bodies without an else statement should be transformed into `X if platform?('ubuntu')` style statements
69
- # while multiline statements should just have the case and when bits replace with `if platform?('ubuntu')`
70
+ # while multi-line statements should just have the case and when bits replace with `if platform?('ubuntu')`
70
71
  if !node.else? && !node.when_branches.first.body.multiline?
71
72
  new_source = "#{node.when_branches.first.body.source} if #{type.value}?(#{condition_string})"
72
73
  corrector.replace(node.loc.expression, new_source)
@@ -1,3 +1,4 @@
1
+ # frozen_string_literal: true
1
2
  #
2
3
  # Copyright:: 2019, Chef Software, Inc.
3
4
  # Author:: Tim Smith (<tsmith@chef.io>)
@@ -38,7 +39,7 @@ module RuboCop
38
39
  # platform_family?('rhel', 'suse')
39
40
  #
40
41
  class UsePlatformHelpers < Cop
41
- MSG = "Use platform? and platform_family? helpers to check a node's platform".freeze
42
+ MSG = "Use platform? and platform_family? helpers to check a node's platform"
42
43
 
43
44
  def_node_matcher :platform_equals?, <<-PATTERN
44
45
  (send (send (send nil? :node) :[] $(str {"platform" "platform_family"}) ) ${:== :!=} $str )
@@ -69,8 +70,7 @@ module RuboCop
69
70
  def autocorrect(node)
70
71
  lambda do |corrector|
71
72
  platform_equals?(node) do |type, operator, plat|
72
- corrected_string = operator == :!= ? '!' : ''
73
- corrected_string << "#{type.value}?('#{plat.value}')"
73
+ corrected_string = (operator == :!= ? '!' : '') + "#{type.value}?('#{plat.value}')"
74
74
  corrector.replace(node.loc.expression, corrected_string)
75
75
  end
76
76
 
@@ -1,6 +1,7 @@
1
+ # frozen_string_literal: true
1
2
  module RuboCop
2
3
  module Cop
3
- class Cop
4
+ class Base
4
5
  # This is a copy of the #target_rails_version method from rubocop-rails
5
6
  def target_chef_version
6
7
  @config.target_chef_version
@@ -1,3 +1,4 @@
1
+ # frozen_string_literal: true
1
2
  module RuboCop
2
3
  # we're monkey patching the config regex to allow for # cookstyle: disable whatever
3
4
  # in addition to the # rubocop: disable whatever that comes with RuboCop
@@ -0,0 +1,15 @@
1
+ # frozen_string_literal: true
2
+ module RuboCop
3
+ module Cop
4
+ class Registry
5
+ # we monkeypatch this warning to replace rubocop with cookstyle
6
+ def print_warning(name, path)
7
+ message = "#{path}: Warning: no department given for #{name}."
8
+ if path.end_with?('.rb')
9
+ message += ' Run `cookstyle -a --only Migration/DepartmentName` to fix.'
10
+ end
11
+ warn message
12
+ end
13
+ end
14
+ end
15
+ end
metadata CHANGED
@@ -1,7 +1,7 @@
1
1
  --- !ruby/object:Gem::Specification
2
2
  name: cookstyle
3
3
  version: !ruby/object:Gem::Version
4
- version: 6.9.0
4
+ version: 6.14.7
5
5
  platform: ruby
6
6
  authors:
7
7
  - Thom May
@@ -9,7 +9,7 @@ authors:
9
9
  autorequire:
10
10
  bindir: bin
11
11
  cert_chain: []
12
- date: 2020-06-25 00:00:00.000000000 Z
12
+ date: 2020-07-30 00:00:00.000000000 Z
13
13
  dependencies:
14
14
  - !ruby/object:Gem::Dependency
15
15
  name: rubocop
@@ -17,14 +17,14 @@ dependencies:
17
17
  requirements:
18
18
  - - '='
19
19
  - !ruby/object:Gem::Version
20
- version: 0.86.0
20
+ version: 0.88.0
21
21
  type: :runtime
22
22
  prerelease: false
23
23
  version_requirements: !ruby/object:Gem::Requirement
24
24
  requirements:
25
25
  - - '='
26
26
  - !ruby/object:Gem::Version
27
- version: 0.86.0
27
+ version: 0.88.0
28
28
  description:
29
29
  email:
30
30
  - thom@chef.io
@@ -37,6 +37,7 @@ files:
37
37
  - Gemfile
38
38
  - LICENSE
39
39
  - bin/cookstyle
40
+ - bin/cookstyle-profile
40
41
  - config/cookstyle.yml
41
42
  - config/default.yml
42
43
  - config/disable_all.yml
@@ -55,6 +56,7 @@ files:
55
56
  - lib/rubocop/cop/chef/correctness/conditional_ruby_shellout.rb
56
57
  - lib/rubocop/cop/chef/correctness/dnf_package_allow_downgrades.rb
57
58
  - lib/rubocop/cop/chef/correctness/incorrect_library_injection.rb
59
+ - lib/rubocop/cop/chef/correctness/invalid_default_action.rb
58
60
  - lib/rubocop/cop/chef/correctness/invalid_notification_timing.rb
59
61
  - lib/rubocop/cop/chef/correctness/invalid_platform_family_helper.rb
60
62
  - lib/rubocop/cop/chef/correctness/invalid_platform_family_values_in_case.rb
@@ -65,6 +67,7 @@ files:
65
67
  - lib/rubocop/cop/chef/correctness/invalid_value_for_platform_helper.rb
66
68
  - lib/rubocop/cop/chef/correctness/invalid_version_metadata.rb
67
69
  - lib/rubocop/cop/chef/correctness/lazy_eval_node_attribute_defaults.rb
70
+ - lib/rubocop/cop/chef/correctness/macos_userdefaults_invalid_type.rb
68
71
  - lib/rubocop/cop/chef/correctness/malformed_value_for_platform.rb
69
72
  - lib/rubocop/cop/chef/correctness/metadata_missing_name.rb
70
73
  - lib/rubocop/cop/chef/correctness/node_normal.rb
@@ -78,11 +81,15 @@ files:
78
81
  - lib/rubocop/cop/chef/correctness/resource_with_none_action.rb
79
82
  - lib/rubocop/cop/chef/correctness/scoped_file_exist.rb
80
83
  - lib/rubocop/cop/chef/correctness/service_resource.rb
84
+ - lib/rubocop/cop/chef/correctness/supports_must_be_float.rb
81
85
  - lib/rubocop/cop/chef/correctness/tmp_path.rb
86
+ - lib/rubocop/cop/chef/deprecation/ use_automatic_resource_name.rb
87
+ - lib/rubocop/cop/chef/deprecation/chef_handler_recipe.rb
82
88
  - lib/rubocop/cop/chef/deprecation/chef_handler_supports.rb
83
89
  - lib/rubocop/cop/chef/deprecation/chef_rest.rb
84
90
  - lib/rubocop/cop/chef/deprecation/chef_rewind.rb
85
91
  - lib/rubocop/cop/chef/deprecation/chef_windows_platform_helper.rb
92
+ - lib/rubocop/cop/chef/deprecation/chefdk_generators.rb
86
93
  - lib/rubocop/cop/chef/deprecation/cheffile.rb
87
94
  - lib/rubocop/cop/chef/deprecation/chefspec_coverage_report.rb
88
95
  - lib/rubocop/cop/chef/deprecation/chefspec_legacy_runner.rb
@@ -107,6 +114,7 @@ files:
107
114
  - lib/rubocop/cop/chef/deprecation/legacy_yum_cookbook_recipes.rb
108
115
  - lib/rubocop/cop/chef/deprecation/locale_lc_all_property.rb
109
116
  - lib/rubocop/cop/chef/deprecation/log_resource_notifications.rb
117
+ - lib/rubocop/cop/chef/deprecation/macos_userdefaults_global_property.rb
110
118
  - lib/rubocop/cop/chef/deprecation/name_property_and_default.rb
111
119
  - lib/rubocop/cop/chef/deprecation/node_deep_fetch.rb
112
120
  - lib/rubocop/cop/chef/deprecation/node_methods_not_attributes.rb
@@ -142,6 +150,7 @@ files:
142
150
  - lib/rubocop/cop/chef/effortless/node_roles.rb
143
151
  - lib/rubocop/cop/chef/effortless/search_for_environments_or_roles.rb
144
152
  - lib/rubocop/cop/chef/effortless/search_used.rb
153
+ - lib/rubocop/cop/chef/modernize/action_method_in_resource.rb
145
154
  - lib/rubocop/cop/chef/modernize/allowed_actions_initializer.rb
146
155
  - lib/rubocop/cop/chef/modernize/apt_default_recipe.rb
147
156
  - lib/rubocop/cop/chef/modernize/berksfile_source.rb
@@ -149,6 +158,8 @@ files:
149
158
  - lib/rubocop/cop/chef/modernize/chef_14_resources.rb
150
159
  - lib/rubocop/cop/chef/modernize/chef_gem_nokogiri.rb
151
160
  - lib/rubocop/cop/chef/modernize/compile_time_resources.rb
161
+ - lib/rubocop/cop/chef/modernize/conditional_using_test.rb
162
+ - lib/rubocop/cop/chef/modernize/cron_d_file_or_template.rb
152
163
  - lib/rubocop/cop/chef/modernize/cron_manage_resource.rb
153
164
  - lib/rubocop/cop/chef/modernize/databag_helpers.rb
154
165
  - lib/rubocop/cop/chef/modernize/default_action_initializer.rb
@@ -207,9 +218,12 @@ files:
207
218
  - lib/rubocop/cop/chef/redundant/attribute_metadata.rb
208
219
  - lib/rubocop/cop/chef/redundant/conflicts_metadata.rb
209
220
  - lib/rubocop/cop/chef/redundant/custom_resource_with_allowed_actions.rb
221
+ - lib/rubocop/cop/chef/redundant/double_compile_time.rb
210
222
  - lib/rubocop/cop/chef/redundant/grouping_metadata.rb
211
223
  - lib/rubocop/cop/chef/redundant/long_description_metadata.rb
224
+ - lib/rubocop/cop/chef/redundant/multiple_platform_checks.rb
212
225
  - lib/rubocop/cop/chef/redundant/name_property_and_required.rb
226
+ - lib/rubocop/cop/chef/redundant/ohai_attribute_to_string.rb
213
227
  - lib/rubocop/cop/chef/redundant/property_splat_regex.rb
214
228
  - lib/rubocop/cop/chef/redundant/property_with_default_and_required.rb
215
229
  - lib/rubocop/cop/chef/redundant/provides_metadata.rb
@@ -226,6 +240,7 @@ files:
226
240
  - lib/rubocop/cop/chef/sharing/empty_metadata_field.rb
227
241
  - lib/rubocop/cop/chef/sharing/include_property_descriptions.rb
228
242
  - lib/rubocop/cop/chef/sharing/include_resource_descriptions.rb
243
+ - lib/rubocop/cop/chef/sharing/include_resource_examples.rb
229
244
  - lib/rubocop/cop/chef/sharing/insecure_cookbook_url.rb
230
245
  - lib/rubocop/cop/chef/sharing/invalid_license_string.rb
231
246
  - lib/rubocop/cop/chef/style/attribute_keys.rb
@@ -236,6 +251,7 @@ files:
236
251
  - lib/rubocop/cop/chef/style/comments_format.rb
237
252
  - lib/rubocop/cop/chef/style/file_mode.rb
238
253
  - lib/rubocop/cop/chef/style/immediate_notification_timing.rb
254
+ - lib/rubocop/cop/chef/style/include_recipe_with_parentheses.rb
239
255
  - lib/rubocop/cop/chef/style/negating_only_if.rb
240
256
  - lib/rubocop/cop/chef/style/overly_complex_supports_depends_metadata.rb
241
257
  - lib/rubocop/cop/chef/style/simplify_platform_major_version_check.rb
@@ -244,9 +260,10 @@ files:
244
260
  - lib/rubocop/cop/chef/style/unnecessary_platform_case_statement.rb
245
261
  - lib/rubocop/cop/chef/style/use_platform_helpers.rb
246
262
  - lib/rubocop/cop/target_chef_version.rb
263
+ - lib/rubocop/monkey_patches/base.rb
247
264
  - lib/rubocop/monkey_patches/comment_config.rb
248
265
  - lib/rubocop/monkey_patches/config.rb
249
- - lib/rubocop/monkey_patches/cop.rb
266
+ - lib/rubocop/monkey_patches/registry_cop.rb
250
267
  - lib/rubocop/monkey_patches/team.rb
251
268
  homepage:
252
269
  licenses: