cookstyle 6.7.3 → 6.12.6

data/lib/rubocop/monkey_patches/registry_cop.rb

@@ -0,0 +1,15 @@
+# frozen_string_literal: true
+module RuboCop
+  module Cop
+    class Registry
+      # we monkeypatch this warning to replace rubocop with cookstyle
+      def print_warning(name, path)
+        message = "#{path}: Warning: no department given for #{name}."
+        if path.end_with?('.rb')
+          message += ' Run `cookstyle -a --only Migration/DepartmentName` to fix.'
+        end
+        warn message
+      end
+    end
+  end
+end

metadata

@@ -1,7 +1,7 @@
 --- !ruby/object:Gem::Specification
 name: cookstyle
 version: !ruby/object:Gem::Version
-  version: 6.7.3
+  version: 6.12.6
 platform: ruby
 authors:
 - Thom May
@@ -9,7 +9,7 @@ authors:
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2020-06-02 00:00:00.000000000 Z
+date: 2020-07-14 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: rubocop
@@ -17,14 +17,14 @@ dependencies:
     requirements:
     - - '='
       - !ruby/object:Gem::Version
-        version: 0.85.0
+        version: 0.88.0
   type: :runtime
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
     - - '='
       - !ruby/object:Gem::Version
-        version: 0.85.0
+        version: 0.88.0
 description: 
 email:
 - thom@chef.io
@@ -37,6 +37,7 @@ files:
 - Gemfile
 - LICENSE
 - bin/cookstyle
+- bin/cookstyle-profile
 - config/cookstyle.yml
 - config/default.yml
 - config/disable_all.yml
@@ -79,10 +80,13 @@ files:
 - lib/rubocop/cop/chef/correctness/scoped_file_exist.rb
 - lib/rubocop/cop/chef/correctness/service_resource.rb
 - lib/rubocop/cop/chef/correctness/tmp_path.rb
+- lib/rubocop/cop/chef/deprecation/ use_automatic_resource_name.rb
+- lib/rubocop/cop/chef/deprecation/chef_handler_recipe.rb
 - lib/rubocop/cop/chef/deprecation/chef_handler_supports.rb
 - lib/rubocop/cop/chef/deprecation/chef_rest.rb
 - lib/rubocop/cop/chef/deprecation/chef_rewind.rb
 - lib/rubocop/cop/chef/deprecation/chef_windows_platform_helper.rb
+- lib/rubocop/cop/chef/deprecation/chefdk_generators.rb
 - lib/rubocop/cop/chef/deprecation/cheffile.rb
 - lib/rubocop/cop/chef/deprecation/chefspec_coverage_report.rb
 - lib/rubocop/cop/chef/deprecation/chefspec_legacy_runner.rb
@@ -100,6 +104,7 @@ files:
 - lib/rubocop/cop/chef/deprecation/eol_audit_mode.rb
 - lib/rubocop/cop/chef/deprecation/epic_fail.rb
 - lib/rubocop/cop/chef/deprecation/erl_call.rb
+- lib/rubocop/cop/chef/deprecation/hwrp_without_provides.rb
 - lib/rubocop/cop/chef/deprecation/inherits_compat_resource.rb
 - lib/rubocop/cop/chef/deprecation/launchd_deprecated_hash_property.rb
 - lib/rubocop/cop/chef/deprecation/legacy_notify_syntax.rb
@@ -122,7 +127,6 @@ files:
 - lib/rubocop/cop/chef/deprecation/resource_uses_only_resource_name.rb
 - lib/rubocop/cop/chef/deprecation/resource_uses_provider_base_method.rb
 - lib/rubocop/cop/chef/deprecation/resource_uses_updated_method.rb
-- lib/rubocop/cop/chef/deprecation/resource_without_name_or_provides.rb
 - lib/rubocop/cop/chef/deprecation/ruby_27_keyword_argument_warnings.rb
 - lib/rubocop/cop/chef/deprecation/ruby_block_create_action.rb
 - lib/rubocop/cop/chef/deprecation/run_command_helper.rb
@@ -149,6 +153,7 @@ files:
 - lib/rubocop/cop/chef/modernize/chef_14_resources.rb
 - lib/rubocop/cop/chef/modernize/chef_gem_nokogiri.rb
 - lib/rubocop/cop/chef/modernize/compile_time_resources.rb
+- lib/rubocop/cop/chef/modernize/conditional_using_test.rb
 - lib/rubocop/cop/chef/modernize/cron_manage_resource.rb
 - lib/rubocop/cop/chef/modernize/databag_helpers.rb
 - lib/rubocop/cop/chef/modernize/default_action_initializer.rb
@@ -209,7 +214,9 @@ files:
 - lib/rubocop/cop/chef/redundant/custom_resource_with_allowed_actions.rb
 - lib/rubocop/cop/chef/redundant/grouping_metadata.rb
 - lib/rubocop/cop/chef/redundant/long_description_metadata.rb
+- lib/rubocop/cop/chef/redundant/multiple_platform_checks.rb
 - lib/rubocop/cop/chef/redundant/name_property_and_required.rb
+- lib/rubocop/cop/chef/redundant/ohai_attribute_to_string.rb
 - lib/rubocop/cop/chef/redundant/property_splat_regex.rb
 - lib/rubocop/cop/chef/redundant/property_with_default_and_required.rb
 - lib/rubocop/cop/chef/redundant/provides_metadata.rb
@@ -226,6 +233,7 @@ files:
 - lib/rubocop/cop/chef/sharing/empty_metadata_field.rb
 - lib/rubocop/cop/chef/sharing/include_property_descriptions.rb
 - lib/rubocop/cop/chef/sharing/include_resource_descriptions.rb
+- lib/rubocop/cop/chef/sharing/include_resource_examples.rb
 - lib/rubocop/cop/chef/sharing/insecure_cookbook_url.rb
 - lib/rubocop/cop/chef/sharing/invalid_license_string.rb
 - lib/rubocop/cop/chef/style/attribute_keys.rb
@@ -236,6 +244,7 @@ files:
 - lib/rubocop/cop/chef/style/comments_format.rb
 - lib/rubocop/cop/chef/style/file_mode.rb
 - lib/rubocop/cop/chef/style/immediate_notification_timing.rb
+- lib/rubocop/cop/chef/style/include_recipe_with_parentheses.rb
 - lib/rubocop/cop/chef/style/negating_only_if.rb
 - lib/rubocop/cop/chef/style/overly_complex_supports_depends_metadata.rb
 - lib/rubocop/cop/chef/style/simplify_platform_major_version_check.rb
@@ -247,6 +256,7 @@ files:
 - lib/rubocop/monkey_patches/comment_config.rb
 - lib/rubocop/monkey_patches/config.rb
 - lib/rubocop/monkey_patches/cop.rb
+- lib/rubocop/monkey_patches/registry_cop.rb
 - lib/rubocop/monkey_patches/team.rb
 homepage: 
 licenses:

data/lib/rubocop/cop/chef/deprecation/resource_without_name_or_provides.rb

@@ -1,81 +0,0 @@
-#
-# Copyright:: 2020, Chef Software Inc.
-# Author:: Tim Smith (<tsmith@chef.io>)
-#
-# Licensed under the Apache License, Version 2.0 (the "License");
-# you may not use this file except in compliance with the License.
-# You may obtain a copy of the License at
-#
-# http://www.apache.org/licenses/LICENSE-2.0
-#
-# Unless required by applicable law or agreed to in writing, software
-# distributed under the License is distributed on an "AS IS" BASIS,
-# WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
-# See the License for the specific language governing permissions and
-# limitations under the License.
-#
-
-module RuboCop
-  module Cop
-    module Chef
-      module ChefDeprecations
-        # In Chef Infra Client 16 and later a legacy HWRP resource must use either `resource_name` or `provides` to define the resource name.
-        #
-        # @example
-        #
-        #   # bad
-        #   class Chef
-        #     class Resource
-        #       class UlimitRule < Chef::Resource
-        #         property :type, [Symbol, String], required: true
-        #         property :item, [Symbol, String], required: true
-        #
-        #         # additional resource code
-        #       end
-        #     end
-        #   end
-        #
-        #  # good
-        #   class Chef
-        #     class Resource
-        #       class UlimitRule < Chef::Resource
-        #         resource_name :ulimit_rule
-        #
-        #         property :type, [Symbol, String], required: true
-        #         property :item, [Symbol, String], required: true
-        #
-        #         # additional resource code
-        #       end
-        #     end
-        #   end
-        #
-        #  # better
-        #  Convert your legacy HWRPs to custom resources
-        #
-        class ResourceWithoutNameOrProvides < Cop
-          MSG = 'In Chef Infra Client 16 and later legacy HWRP resources must use either `resource_name` or `provides` to define the resource name.'.freeze
-
-          def_node_matcher :HWRP?, <<-PATTERN
-          (class
-            (const nil? :Chef) nil?
-            (class
-              (const nil? :Resource) nil?
-              $(class
-                (const nil? ... )
-                (const
-                  (const nil? :Chef) :Resource)
-                  (begin ... ))))
-          PATTERN
-
-          def_node_search :provides_or_resource_name?, '(send nil? {:provides :resource_name} ...)'
-
-          def on_class(node)
-            HWRP?(node) do |inherit|
-              add_offense(inherit, location: :expression, message: MSG, severity: :warning) if provides_or_resource_name?(processed_source.ast).nil?
-            end
-          end
-        end
-      end
-    end
-  end
-end