cookstyle 6.21.1 → 7.3.11

data/lib/rubocop/cop/chef/sharing/default_maintainer_metadata.rb

@@ -19,7 +19,7 @@
 module RuboCop
   module Cop
     module Chef
-      module ChefSharing
+      module Sharing
         # Metadata contains default maintainer information from the `chef generate cookbook` command. This should be updated to reflect that actual maintainer of the cookbook.
         #
         # @example

data/lib/rubocop/cop/chef/sharing/empty_metadata_field.rb

@@ -19,7 +19,7 @@
 module RuboCop
   module Cop
     module Chef
-      module ChefSharing
+      module Sharing
         # metadata.rb should not include fields with an empty string. Either don't include the field or add a value.
         #
         # @example

data/lib/rubocop/cop/chef/sharing/include_property_descriptions.rb

@@ -18,7 +18,7 @@
 module RuboCop
   module Cop
     module Chef
-      module ChefSharing
+      module Sharing
         # Resource properties should include description fields to allow automated documentation. Requires Chef Infra Client 13.9 or later.
         #
         # @example

data/lib/rubocop/cop/chef/sharing/include_resource_descriptions.rb

@@ -18,7 +18,7 @@
 module RuboCop
   module Cop
     module Chef
-      module ChefSharing
+      module Sharing
         # Resources should include description fields to allow automated documentation. Requires Chef Infra Client 13.9 or later.
         #
         # @example

data/lib/rubocop/cop/chef/sharing/include_resource_examples.rb

@@ -18,7 +18,7 @@
 module RuboCop
   module Cop
     module Chef
-      module ChefSharing
+      module Sharing
         # Resources should include examples field to allow automated documentation. Requires Chef Infra Client 13.9 or later.
         #
         # @example

data/lib/rubocop/cop/chef/sharing/insecure_cookbook_url.rb

@@ -18,7 +18,7 @@
 module RuboCop
   module Cop
     module Chef
-      module ChefSharing
+      module Sharing
         # Use secure Github and Gitlab URLs for source_url and issues_url
         #
         # @example

data/lib/rubocop/cop/chef/sharing/invalid_license_string.rb

@@ -19,7 +19,7 @@
 module RuboCop
   module Cop
     module Chef
-      module ChefSharing
+      module Sharing
         # metadata.rb license field should include a SPDX compliant string or "all right reserved" (not case sensitive)
         #
         # @example

data/lib/rubocop/cop/chef/style/attribute_keys.rb

@@ -18,7 +18,7 @@
 module RuboCop
   module Cop
     module Chef
-      module ChefStyle
+      module Style
         # Check which style of keys are used to access node attributes.
         #
         # There are two supported styles: "symbols" and "strings".

data/lib/rubocop/cop/chef/style/chef_whaaat.rb

@@ -19,7 +19,7 @@
 module RuboCop
   module Cop
     module Chef
-      module ChefStyle
+      module Style
         # Checks for comments that mention "Chef" without context. Do you mean Chef Infra or Chef Software?
         #
         # @example

data/lib/rubocop/cop/chef/style/comment_sentence_spacing.rb

@@ -19,14 +19,14 @@
 module RuboCop
   module Cop
     module Chef
-      module ChefStyle
+      module Style
         # Replaces double spaces between sentences with a single space.
         # Note: This is DISABLED by default.
         class CommentSentenceSpacing < Base
           extend AutoCorrector
           MSG = 'Use a single space after sentences in comments'
 
-          def investigate(processed_source)
+          def on_new_investigation
             return unless processed_source.ast
 
             processed_source.comments.each do |comment|

data/lib/rubocop/cop/chef/style/comments_copyright_format.rb

@@ -19,7 +19,7 @@
 module RuboCop
   module Cop
     module Chef
-      module ChefStyle
+      module Style
         # Checks for incorrectly formatted copyright comments.
         #
         # @example
@@ -38,7 +38,8 @@ module RuboCop
         #   Copyright:: 2013-2019 Tim Smith
         #   Copyright:: 2019 37Signals, Inc.
         #
-        class CopyrightCommentFormat < Cop
+        class CopyrightCommentFormat < Base
+          extend AutoCorrector
           require 'date'
 
           MSG = 'Properly format copyrights header comments'
@@ -49,7 +50,7 @@ module RuboCop
             processed_source.comments.each do |comment|
               next unless comment.inline? && invalid_copyright_comment?(comment) # headers aren't in blocks
 
-              add_offense(comment, location: comment, message: MSG, severity: :refactor) do |corrector|
+              add_offense(comment, message: MSG, severity: :refactor) do |corrector|
                 correct_comment = "# Copyright:: #{copyright_date_range(comment)}, #{copyright_holder(comment)}"
                 corrector.replace(comment, correct_comment)
               end

data/lib/rubocop/cop/chef/style/comments_default_copyright.rb

@@ -19,7 +19,7 @@
 module RuboCop
   module Cop
     module Chef
-      module ChefStyle
+      module Style
         # Checks for default copyright comments from the chef generator cookbook command
         #
         # @example

data/lib/rubocop/cop/chef/style/comments_format.rb

@@ -19,7 +19,7 @@
 module RuboCop
   module Cop
     module Chef
-      module ChefStyle
+      module Style
         # Checks for incorrectly formatted headers
         #
         # @example

data/lib/rubocop/cop/chef/style/file_mode.rb

@@ -18,7 +18,7 @@
 module RuboCop
   module Cop
     module Chef
-      module ChefStyle
+      module Style
         # Use strings to represent file modes to avoid confusion between octal and base 10 integer formats.
         #
         # @example

data/lib/rubocop/cop/chef/style/immediate_notification_timing.rb

@@ -18,7 +18,7 @@
 module RuboCop
   module Cop
     module Chef
-      module ChefStyle
+      module Style
         # Use :immediately instead of :immediate for resource notification timing
         #
         # @example

data/lib/rubocop/cop/chef/style/include_recipe_with_parentheses.rb

@@ -19,7 +19,7 @@
 module RuboCop
   module Cop
     module Chef
-      module ChefStyle
+      module Style
         # There is no need to wrap the recipe in parentheses when using the include_recipe helper.
         #
         # @example

data/lib/rubocop/cop/chef/style/negating_only_if.rb

@@ -18,7 +18,7 @@
 module RuboCop
   module Cop
     module Chef
-      module ChefStyle
+      module Style
         # Instead of using only_if conditionals with ! to negate the returned value, use not_if which is easier to read
         #
         # @example

data/lib/rubocop/cop/chef/style/overly_complex_supports_depends_metadata.rb

@@ -18,7 +18,7 @@
 module RuboCop
   module Cop
     module Chef
-      module ChefStyle
+      module Style
         # Don't loop over an array to set cookbook dependencies or supported platforms if you have fewer than three values to set. Setting multiple `supports` or `depends` values is simpler and easier to understand for new users.
         #
         # @example

data/lib/rubocop/cop/chef/style/simplify_platform_major_version_check.rb

@@ -18,7 +18,7 @@
 module RuboCop
   module Cop
     module Chef
-      module ChefStyle
+      module Style
         # When checking the major version number of a platform you can take the node['platform_version'] attribute and transform it to an integer to strip it down to just the major version number. This simple way of determining the major version number of a platform should be used instead of splitting the platform into multiple fields with '.' as the delimiter.
         #
         # @example

data/lib/rubocop/cop/chef/style/true_false_resource_properties.rb

@@ -18,7 +18,7 @@
 module RuboCop
   module Cop
     module Chef
-      module ChefStyle
+      module Style
         # When setting the allowed types for a resource to accept either true or false values it's much simpler to use true and false instead of TrueClass and FalseClass.
         #
         # @example

data/lib/rubocop/cop/chef/style/unnecessary_os_check.rb

@@ -18,7 +18,7 @@
 module RuboCop
   module Cop
     module Chef
-      module ChefStyle
+      module Style
         # Use the platform_family?() helpers instead of node['os] == 'foo' for platform_families that match one-to-one with OS values. These helpers are easier to read and can accept multiple platform arguments, which greatly simplifies complex platform logic. All values of `os` from Ohai match one-to-one with `platform_family` values except for `linux`, which has no single equivalent `plaform_family`.
         #
         # @example

data/lib/rubocop/cop/chef/style/unnecessary_platform_case_statement.rb

@@ -18,7 +18,7 @@
 module RuboCop
   module Cop
     module Chef
-      module ChefStyle
+      module Style
         # Use the platform?() and platform_family?() helpers instead of a case statement that only includes a single when statement.
         #
         # @example

data/lib/rubocop/cop/chef/style/use_platform_helpers.rb

@@ -18,7 +18,7 @@
 module RuboCop
   module Cop
     module Chef
-      module ChefStyle
+      module Style
         # Use the platform?() and platform_family?() helpers instead of node['platform] == 'foo' and node['platform_family'] == 'bar'. These helpers are easier to read and can accept multiple platform arguments, which greatly simplifies complex platform logic.
         #
         # @example

data/lib/rubocop/monkey_patches/comment_config.rb

@@ -5,7 +5,7 @@ module RuboCop
   class CommentConfig
     remove_const('COMMENT_DIRECTIVE_REGEXP')
     COMMENT_DIRECTIVE_REGEXP = Regexp.new(
-      ('# (?:rubocop|cookstyle) : ((?:dis|en)able)\b ' + COPS_PATTERN).gsub(' ', '\s*')
+      "# (?:rubocop|cookstyle): ((?:disable|enable|todo))\\b #{COPS_PATTERN}".gsub(' ', '\s*')
     )
   end
 end

metadata

@@ -1,7 +1,7 @@
 --- !ruby/object:Gem::Specification
 name: cookstyle
 version: !ruby/object:Gem::Version
-  version: 6.21.1
+  version: 7.3.11
 platform: ruby
 authors:
 - Thom May
@@ -9,7 +9,7 @@ authors:
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2020-10-15 00:00:00.000000000 Z
+date: 2020-12-04 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: rubocop
@@ -17,14 +17,14 @@ dependencies:
     requirements:
     - - '='
       - !ruby/object:Gem::Version
-        version: 0.93.1
+        version: 1.5.2
   type: :runtime
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
     - - '='
       - !ruby/object:Gem::Version
-        version: 0.93.1
+        version: 1.5.2
 description: 
 email:
 - thom@chef.io
@@ -92,6 +92,7 @@ files:
 - lib/rubocop/cop/chef/deprecation/chef_rest.rb
 - lib/rubocop/cop/chef/deprecation/chef_rewind.rb
 - lib/rubocop/cop/chef/deprecation/chef_shellout.rb
+- lib/rubocop/cop/chef/deprecation/chef_sugar_helpers.rb
 - lib/rubocop/cop/chef/deprecation/chef_windows_platform_helper.rb
 - lib/rubocop/cop/chef/deprecation/chefdk_generators.rb
 - lib/rubocop/cop/chef/deprecation/cheffile.rb
@@ -106,6 +107,7 @@ files:
 - lib/rubocop/cop/chef/deprecation/deprecated_platform_methods.rb
 - lib/rubocop/cop/chef/deprecation/deprecated_shellout_methods.rb
 - lib/rubocop/cop/chef/deprecation/deprecated_windows_version_check.rb
+- lib/rubocop/cop/chef/deprecation/deprecated_yum_repository_actions.rb
 - lib/rubocop/cop/chef/deprecation/deprecated_yum_repository_properties.rb
 - lib/rubocop/cop/chef/deprecation/easy_install.rb
 - lib/rubocop/cop/chef/deprecation/eol_audit_mode.rb
@@ -113,11 +115,13 @@ files:
 - lib/rubocop/cop/chef/deprecation/erl_call.rb
 - lib/rubocop/cop/chef/deprecation/execute_path_property.rb
 - lib/rubocop/cop/chef/deprecation/execute_relative_creates_without_cwd.rb
+- lib/rubocop/cop/chef/deprecation/foodcritic_testing.rb
 - lib/rubocop/cop/chef/deprecation/hwrp_without_provides.rb
 - lib/rubocop/cop/chef/deprecation/inherits_compat_resource.rb
 - lib/rubocop/cop/chef/deprecation/launchd_deprecated_hash_property.rb
 - lib/rubocop/cop/chef/deprecation/legacy_notify_syntax.rb
 - lib/rubocop/cop/chef/deprecation/legacy_yum_cookbook_recipes.rb
+- lib/rubocop/cop/chef/deprecation/librarian_chefspec.rb
 - lib/rubocop/cop/chef/deprecation/locale_lc_all_property.rb
 - lib/rubocop/cop/chef/deprecation/log_resource_notifications.rb
 - lib/rubocop/cop/chef/deprecation/macos_userdefaults_global_property.rb