cookstyle 6.16.4 → 6.17.6

data/lib/rubocop/cop/chef/modernize/zipfile_resource.rb

@@ -36,6 +36,7 @@ module RuboCop
           minimum_target_chef_version '15.0'
 
           MSG = 'Use the archive_file resource built into Chef Infra Client 15+ instead of the zipfile resource from the zipfile cookbook.'
+          RESTRICT_ON_SEND = [:depends].freeze
 
           def_node_matcher :depends_zipfile?, <<-PATTERN
             (send nil? :depends (str "zipfile"))

data/lib/rubocop/cop/chef/modernize/zypper_repo.rb

@@ -46,9 +46,9 @@ module RuboCop
           minimum_target_chef_version '13.3'
 
           MSG = 'The zypper_repo resource was renamed zypper_repository when it was added to Chef Infra Client 13.3.'
+          RESTRICT_ON_SEND = [:zypper_repo].freeze
 
           def on_send(node)
-            return unless node.method_name == :zypper_repo
             add_offense(node, message: MSG, severity: :refactor) do |corrector|
               corrector.replace(node.loc.expression, node.source.gsub(/^zypper_repo/, 'zypper_repository'))
             end

data/lib/rubocop/cop/chef/redundant/attribute_metadata.rb

@@ -39,9 +39,9 @@ module RuboCop
           extend AutoCorrector
 
           MSG = 'The attribute metadata.rb method is not used and is unnecessary in cookbooks.'
+          RESTRICT_ON_SEND = [:attribute].freeze
 
           def on_send(node)
-            return unless node.method_name == :attribute
             add_offense(node, message: MSG, severity: :refactor) do |corrector|
               corrector.remove(range_with_surrounding_space(range: expression_including_heredocs(node), side: :left))
             end

data/lib/rubocop/cop/chef/redundant/conflicts_metadata.rb

@@ -33,9 +33,9 @@ module RuboCop
           extend AutoCorrector
 
           MSG = 'The conflicts metadata.rb method is not used and is unnecessary in cookbooks.'
+          RESTRICT_ON_SEND = [:conflicts].freeze
 
           def on_send(node)
-            return unless node.method_name == :conflicts
             add_offense(node, message: MSG, severity: :refactor) do |corrector|
               corrector.remove(range_with_surrounding_space(range: node.loc.expression, side: :right))
             end

data/lib/rubocop/cop/chef/redundant/custom_resource_with_allowed_actions.rb

@@ -35,10 +35,7 @@ module RuboCop
           extend AutoCorrector
 
           MSG = 'It is not necessary to set `actions` or `allowed_actions` in custom resources as Chef Infra Client determines these automatically from the set of all actions defined in the resource'
-
-          def_node_matcher :allowed_actions?, <<-PATTERN
-            (send nil? {:allowed_actions :actions} ... )
-          PATTERN
+          RESTRICT_ON_SEND = [:allowed_actions, :actions].freeze
 
           def_node_search :poise_require, '(send nil? :require (str "poise"))'
 
@@ -47,13 +44,14 @@ module RuboCop
           PATTERN
 
           def on_send(node)
+            # avoid triggering on things like new_resource.actions
+            return unless node.receiver.nil?
+
             # if the resource requires poise then bail out since we're in a poise resource where @allowed_actions is legit
-            return if poise_require(processed_source.ast).any? && !resource_actions?(processed_source.ast)
+            return if poise_require(processed_source.ast).any? || !resource_actions?(processed_source.ast)
 
-            allowed_actions?(node) do
-              add_offense(node, message: MSG, severity: :refactor) do |corrector|
-                corrector.remove(range_with_surrounding_space(range: node.loc.expression, side: :left))
-              end
+            add_offense(node, message: MSG, severity: :refactor) do |corrector|
+              corrector.remove(range_with_surrounding_space(range: node.loc.expression, side: :left))
             end
           end
         end

data/lib/rubocop/cop/chef/redundant/grouping_metadata.rb

@@ -33,10 +33,9 @@ module RuboCop
           extend AutoCorrector
 
           MSG = 'The grouping metadata.rb method is not used and is unnecessary in cookbooks.'
+          RESTRICT_ON_SEND = [:grouping].freeze
 
           def on_send(node)
-            return unless node.method_name == :grouping
-
             add_offense(node, message: MSG, severity: :refactor) do |corrector|
               corrector.remove(range_with_surrounding_space(range: expression_including_heredocs(node), side: :left))
             end

data/lib/rubocop/cop/chef/redundant/long_description_metadata.rb

@@ -33,10 +33,9 @@ module RuboCop
           extend AutoCorrector
 
           MSG = 'The long_description metadata.rb method is not used and is unnecessary in cookbooks.'
+          RESTRICT_ON_SEND = [:long_description].freeze
 
           def on_send(node)
-            return unless node.method_name == :long_description
-
             add_offense(node, message: MSG, severity: :refactor) do |corrector|
               corrector.remove(range_with_surrounding_space(range: expression_including_heredocs(node), side: :left))
             end

data/lib/rubocop/cop/chef/redundant/property_with_default_and_required.rb

@@ -37,6 +37,7 @@ module RuboCop
           extend AutoCorrector
 
           MSG = 'Resource properties should not be both required and have a default value. This will fail on Chef Infra Client 13+'
+          RESTRICT_ON_SEND = [:property, :attribute].freeze
 
           # match on a property or attribute that has any name and any type and a hash that
           # contains default: true and required: true. These are wrapped in <> which means

data/lib/rubocop/cop/chef/redundant/provides_metadata.rb

@@ -33,10 +33,9 @@ module RuboCop
           extend AutoCorrector
 
           MSG = 'The provides metadata.rb method is not used and is unnecessary in cookbooks.'
+          RESTRICT_ON_SEND = [:provides].freeze
 
           def on_send(node)
-            return unless node.method_name == :provides
-
             add_offense(node, message: MSG, severity: :refactor) do |corrector|
               corrector.remove(range_with_surrounding_space(range: node.loc.expression, side: :left))
             end

data/lib/rubocop/cop/chef/redundant/recipe_metadata.rb

@@ -34,10 +34,9 @@ module RuboCop
           extend AutoCorrector
 
           MSG = "The recipe metadata.rb method is not used and is unnecessary in cookbooks. Recipes should be documented in the cookbook's README.md file instead."
+          RESTRICT_ON_SEND = [:recipe].freeze
 
           def on_send(node)
-            return unless node.method_name == :recipe
-
             add_offense(node, message: MSG, severity: :refactor) do |corrector|
               corrector.remove(range_with_surrounding_space(range: expression_including_heredocs(node), side: :left))
             end

data/lib/rubocop/cop/chef/redundant/replaces_metadata.rb

@@ -33,10 +33,9 @@ module RuboCop
           extend AutoCorrector
 
           MSG = 'The replaces metadata.rb method is not used and is unnecessary in cookbooks.'
+          RESTRICT_ON_SEND = [:replaces].freeze
 
           def on_send(node)
-            return unless node.method_name == :replaces
-
             add_offense(node, message: MSG, severity: :refactor) do |corrector|
               corrector.remove(range_with_surrounding_space(range: node.loc.expression, side: :left))
             end

data/lib/rubocop/cop/chef/redundant/sensitive_property_in_resource.rb

@@ -28,6 +28,7 @@ module RuboCop
           extend AutoCorrector
 
           MSG = 'Every Chef Infra resource already includes a sensitive property with a default value of false.'
+          RESTRICT_ON_SEND = [:property, :attribute].freeze
 
           def_node_matcher :sensitive_property?, <<-PATTERN
             (send nil? {:property :attribute} (sym :sensitive) ... (hash (pair (sym :default) (false))))

data/lib/rubocop/cop/chef/redundant/string_property_with_nil_default.rb

@@ -36,6 +36,7 @@ module RuboCop
           extend AutoCorrector
 
           MSG = 'Properties have a nil value by default so there is no need to set the default value to nil.'
+          RESTRICT_ON_SEND = [:property].freeze
 
           def_node_matcher :string_property_with_nil_default?, <<-PATTERN
             (send nil? :property (sym _)

data/lib/rubocop/cop/chef/redundant/suggests_metadata.rb

@@ -33,10 +33,9 @@ module RuboCop
           extend AutoCorrector
 
           MSG = 'The suggests metadata.rb method is not used and is unnecessary in cookbooks.'
+          RESTRICT_ON_SEND = [:suggests].freeze
 
           def on_send(node)
-            return unless node.method_name == :suggests
-
             add_offense(node, message: MSG, severity: :refactor) do |corrector|
               corrector.remove(range_with_surrounding_space(range: node.loc.expression, side: :left))
             end

data/lib/rubocop/cop/chef/redundant/unnecessary_desired_state.rb

@@ -30,6 +30,7 @@ module RuboCop
           include RangeHelp
 
           MSG = 'There is no need to set a property to desired_state: true as all properties have a desired_state of true by default.'
+          RESTRICT_ON_SEND = [:property, :attribute].freeze
 
           def_node_matcher :property?, <<-PATTERN
             (send nil? {:property :attribute} (sym _) ... $(hash ...))

data/lib/rubocop/cop/chef/redundant/unnecessary_name_property.rb

@@ -33,6 +33,7 @@ module RuboCop
           extend AutoCorrector
 
           MSG = 'There is no need to define a property or attribute named :name in a resource as Chef Infra defines this on all resources by default.'
+          RESTRICT_ON_SEND = [:property, :attribute].freeze
 
           def_node_matcher :name_attribute?, <<-PATTERN
           (send nil? :attribute

data/lib/rubocop/cop/chef/sharing/default_maintainer_metadata.rb

@@ -35,6 +35,7 @@ module RuboCop
         #
         class DefaultMetadataMaintainer < Base
           MSG = 'Metadata contains default maintainer information from the cookbook generator. Add actual cookbook maintainer information to the metadata.rb.'
+          RESTRICT_ON_SEND = [:maintainer, :maintainer_email].freeze
 
           def_node_matcher :default_metadata?, '(send nil? {:maintainer :maintainer_email} (str {"YOUR_COMPANY_NAME" "The Authors" "YOUR_EMAIL" "you@example.com"}))'
 

data/lib/rubocop/cop/chef/sharing/include_property_descriptions.rb

@@ -35,6 +35,7 @@ module RuboCop
           minimum_target_chef_version '13.9'
 
           MSG = 'Resource properties should include description fields to allow automated documentation. Requires Chef Infra Client 13.9 or later.'
+          RESTRICT_ON_SEND = [:property].freeze
 
           # any method named property being called with a symbol argument and anything else
           def_node_matcher :property?, '(send nil? :property (sym _) ...)'

data/lib/rubocop/cop/chef/sharing/insecure_cookbook_url.rb

@@ -37,6 +37,7 @@ module RuboCop
           extend AutoCorrector
 
           MSG = 'Insecure http Github or Gitlab URLs for metadata source_url/issues_url fields'
+          RESTRICT_ON_SEND = [:source_url, :issues_url].freeze
 
           def_node_matcher :insecure_cb_url?, <<-PATTERN
             (send nil? {:source_url :issues_url} (str #insecure_url?))

data/lib/rubocop/cop/chef/sharing/invalid_license_string.rb

@@ -458,6 +458,7 @@ module RuboCop
           }.freeze
 
           MSG = 'Cookbook metadata.rb does not use a SPDX compliant license string or "all rights reserved". See https://spdx.org/licenses/ for a complete list of license identifiers.'
+          RESTRICT_ON_SEND = [:license].freeze
 
           def_node_matcher :license?, '(send nil? :license $str ...)'
 

data/lib/rubocop/cop/chef/style/file_mode.rb

@@ -55,6 +55,7 @@ module RuboCop
           extend RuboCop::Cop::AutoCorrector
 
           MSG = 'Use strings to represent file modes to avoid confusion between octal and base 10 integer formats'
+          RESTRICT_ON_SEND = [:mode, :files_mode].freeze
 
           def_node_matcher :resource_mode?, <<-PATTERN
             (send nil? {:mode :files_mode} $int)

data/lib/rubocop/cop/chef/style/immediate_notification_timing.rb

@@ -39,6 +39,7 @@ module RuboCop
           extend AutoCorrector
 
           MSG = 'Use :immediately instead of :immediate for resource notification timing'
+          RESTRICT_ON_SEND = [:notifies].freeze
 
           def_node_matcher :immediate_notify?, <<-PATTERN
             (send nil? :notifies (sym _) (...) $(sym :immediate))

data/lib/rubocop/cop/chef/style/include_recipe_with_parentheses.rb

@@ -34,6 +34,7 @@ module RuboCop
           extend RuboCop::Cop::AutoCorrector
 
           MSG = 'There is no need to wrap the recipe in parentheses when using the include_recipe helper'
+          RESTRICT_ON_SEND = [:include_recipe].freeze
 
           def_node_matcher :include_recipe?, <<-PATTERN
             (send nil? :include_recipe $(str _))

data/lib/rubocop/cop/chef/style/true_false_resource_properties.rb

@@ -31,7 +31,9 @@ module RuboCop
         #
         class TrueClassFalseClassResourceProperties < Base
           extend AutoCorrector
+
           MSG = "When setting the allowed types for a resource to accept either true or false values it's much simpler to use true and false instead of TrueClass and FalseClass."
+          RESTRICT_ON_SEND = [:property, :attribute].freeze
 
           def_node_matcher :trueclass_falseclass_property?, <<-PATTERN
             (send nil? {:property :attribute} (sym _) $(array (const nil? :TrueClass) (const nil? :FalseClass)) ... )

metadata

@@ -1,7 +1,7 @@
 --- !ruby/object:Gem::Specification
 name: cookstyle
 version: !ruby/object:Gem::Version
-  version: 6.16.4
+  version: 6.17.6
 platform: ruby
 authors:
 - Thom May
@@ -9,7 +9,7 @@ authors:
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2020-09-01 00:00:00.000000000 Z
+date: 2020-09-14 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: rubocop
@@ -88,6 +88,7 @@ files:
 - lib/rubocop/cop/chef/deprecation/chef_handler_supports.rb
 - lib/rubocop/cop/chef/deprecation/chef_rest.rb
 - lib/rubocop/cop/chef/deprecation/chef_rewind.rb
+- lib/rubocop/cop/chef/deprecation/chef_shellout.rb
 - lib/rubocop/cop/chef/deprecation/chef_windows_platform_helper.rb
 - lib/rubocop/cop/chef/deprecation/chefdk_generators.rb
 - lib/rubocop/cop/chef/deprecation/cheffile.rb
@@ -107,6 +108,8 @@ files:
 - lib/rubocop/cop/chef/deprecation/eol_audit_mode.rb
 - lib/rubocop/cop/chef/deprecation/epic_fail.rb
 - lib/rubocop/cop/chef/deprecation/erl_call.rb
+- lib/rubocop/cop/chef/deprecation/execute_path_property.rb
+- lib/rubocop/cop/chef/deprecation/execute_relative_creates_without_cwd.rb
 - lib/rubocop/cop/chef/deprecation/hwrp_without_provides.rb
 - lib/rubocop/cop/chef/deprecation/inherits_compat_resource.rb
 - lib/rubocop/cop/chef/deprecation/launchd_deprecated_hash_property.rb
@@ -139,6 +142,7 @@ files:
 - lib/rubocop/cop/chef/deprecation/user_supports_property.rb
 - lib/rubocop/cop/chef/deprecation/verify_property_file_expansion.rb
 - lib/rubocop/cop/chef/deprecation/windows_feature_servermanagercmd.rb
+- lib/rubocop/cop/chef/deprecation/windows_package_installer_type_string.rb
 - lib/rubocop/cop/chef/deprecation/windows_task_change_action.rb
 - lib/rubocop/cop/chef/deprecation/windows_version_helpers.rb
 - lib/rubocop/cop/chef/deprecation/xml_ruby_recipe.rb
@@ -203,7 +207,7 @@ files:
 - lib/rubocop/cop/chef/modernize/shell_out_helper.rb
 - lib/rubocop/cop/chef/modernize/shellouts_to_chocolatey.rb
 - lib/rubocop/cop/chef/modernize/simplify_apt_ppa_setup.rb
-- lib/rubocop/cop/chef/modernize/systctl_param_resource.rb
+- lib/rubocop/cop/chef/modernize/sysctl_param_resource.rb
 - lib/rubocop/cop/chef/modernize/unnecessary_mixlib_shellout_require.rb
 - lib/rubocop/cop/chef/modernize/use_multipackage_installs.rb
 - lib/rubocop/cop/chef/modernize/use_require_relative.rb