cookstyle 6.15.9 → 6.17.5

data/lib/rubocop/cop/chef/style/use_platform_helpers.rb

@@ -38,7 +38,9 @@ module RuboCop
         #   !platform_family?('debian')
         #   platform_family?('rhel', 'suse')
         #
-        class UsePlatformHelpers < Cop
+        class UsePlatformHelpers < Base
+          extend AutoCorrector
+
           MSG = "Use platform? and platform_family? helpers to check a node's platform"
 
           def_node_matcher :platform_equals?, <<-PATTERN
@@ -54,33 +56,23 @@ module RuboCop
           PATTERN
 
           def on_send(node)
-            platform_equals?(node) do
-              add_offense(node, location: :expression, message: MSG, severity: :refactor)
-            end
-
-            platform_include?(node) do
-              add_offense(node, location: :expression, message: MSG, severity: :refactor)
-            end
-
-            platform_eql?(node) do
-              add_offense(node, location: :expression, message: MSG, severity: :refactor)
-            end
-          end
-
-          def autocorrect(node)
-            lambda do |corrector|
-              platform_equals?(node) do |type, operator, plat|
+            platform_equals?(node) do |type, operator, plat|
+              add_offense(node.loc.expression, message: MSG, severity: :refactor) do |corrector|
                 corrected_string = (operator == :!= ? '!' : '') + "#{type.value}?('#{plat.value}')"
                 corrector.replace(node.loc.expression, corrected_string)
               end
+            end
 
-              platform_include?(node) do |plats, type|
+            platform_include?(node) do |plats, type|
+              add_offense(node.loc.expression, message: MSG, severity: :refactor) do |corrector|
                 platforms = plats.values.map { |x| x.str_type? ? "'#{x.value}'" : x.source }
                 corrected_string = "#{type.value}?(#{platforms.join(', ')})"
                 corrector.replace(node.loc.expression, corrected_string)
               end
+            end
 
-              platform_eql?(node) do |type, plat|
+            platform_eql?(node) do |type, plat|
+              add_offense(node.loc.expression, message: MSG, severity: :refactor) do |corrector|
                 corrected_string = "#{type.value}?('#{plat.value}')"
                 corrector.replace(node.loc.expression, corrected_string)
               end

metadata

@@ -1,7 +1,7 @@
 --- !ruby/object:Gem::Specification
 name: cookstyle
 version: !ruby/object:Gem::Version
-  version: 6.15.9
+  version: 6.17.5
 platform: ruby
 authors:
 - Thom May
@@ -9,7 +9,7 @@ authors:
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2020-08-24 00:00:00.000000000 Z
+date: 2020-09-11 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: rubocop
@@ -17,14 +17,14 @@ dependencies:
     requirements:
     - - '='
       - !ruby/object:Gem::Version
-        version: 0.89.1
+        version: 0.90.0
   type: :runtime
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
     - - '='
       - !ruby/object:Gem::Version
-        version: 0.89.1
+        version: 0.90.0
 description: 
 email:
 - thom@chef.io
@@ -51,7 +51,6 @@ files:
 - lib/rubocop/chef/cookbook_only.rb
 - lib/rubocop/chef/platform_helpers.rb
 - lib/rubocop/cop/chef/correctness/block_guard_clause_string_only.rb
-- lib/rubocop/cop/chef/correctness/cb_depends_on_self.rb
 - lib/rubocop/cop/chef/correctness/chef_application_fatal.rb
 - lib/rubocop/cop/chef/correctness/conditional_ruby_shellout.rb
 - lib/rubocop/cop/chef/correctness/dnf_package_allow_downgrades.rb
@@ -84,10 +83,12 @@ files:
 - lib/rubocop/cop/chef/correctness/supports_must_be_float.rb
 - lib/rubocop/cop/chef/correctness/tmp_path.rb
 - lib/rubocop/cop/chef/deprecation/ use_automatic_resource_name.rb
+- lib/rubocop/cop/chef/deprecation/cb_depends_on_self.rb
 - lib/rubocop/cop/chef/deprecation/chef_handler_recipe.rb
 - lib/rubocop/cop/chef/deprecation/chef_handler_supports.rb
 - lib/rubocop/cop/chef/deprecation/chef_rest.rb
 - lib/rubocop/cop/chef/deprecation/chef_rewind.rb
+- lib/rubocop/cop/chef/deprecation/chef_shellout.rb
 - lib/rubocop/cop/chef/deprecation/chef_windows_platform_helper.rb
 - lib/rubocop/cop/chef/deprecation/chefdk_generators.rb
 - lib/rubocop/cop/chef/deprecation/cheffile.rb
@@ -107,6 +108,8 @@ files:
 - lib/rubocop/cop/chef/deprecation/eol_audit_mode.rb
 - lib/rubocop/cop/chef/deprecation/epic_fail.rb
 - lib/rubocop/cop/chef/deprecation/erl_call.rb
+- lib/rubocop/cop/chef/deprecation/execute_path_property.rb
+- lib/rubocop/cop/chef/deprecation/execute_relative_creates_without_cwd.rb
 - lib/rubocop/cop/chef/deprecation/hwrp_without_provides.rb
 - lib/rubocop/cop/chef/deprecation/inherits_compat_resource.rb
 - lib/rubocop/cop/chef/deprecation/launchd_deprecated_hash_property.rb
@@ -139,6 +142,7 @@ files:
 - lib/rubocop/cop/chef/deprecation/user_supports_property.rb
 - lib/rubocop/cop/chef/deprecation/verify_property_file_expansion.rb
 - lib/rubocop/cop/chef/deprecation/windows_feature_servermanagercmd.rb
+- lib/rubocop/cop/chef/deprecation/windows_package_installer_type_string.rb
 - lib/rubocop/cop/chef/deprecation/windows_task_change_action.rb
 - lib/rubocop/cop/chef/deprecation/windows_version_helpers.rb
 - lib/rubocop/cop/chef/deprecation/xml_ruby_recipe.rb
@@ -203,7 +207,7 @@ files:
 - lib/rubocop/cop/chef/modernize/shell_out_helper.rb
 - lib/rubocop/cop/chef/modernize/shellouts_to_chocolatey.rb
 - lib/rubocop/cop/chef/modernize/simplify_apt_ppa_setup.rb
-- lib/rubocop/cop/chef/modernize/systctl_param_resource.rb
+- lib/rubocop/cop/chef/modernize/sysctl_param_resource.rb
 - lib/rubocop/cop/chef/modernize/unnecessary_mixlib_shellout_require.rb
 - lib/rubocop/cop/chef/modernize/use_multipackage_installs.rb
 - lib/rubocop/cop/chef/modernize/use_require_relative.rb