cookstyle 6.15.3 → 6.16.9

data/lib/rubocop/cop/chef/modernize/execute_sleep.rb

@@ -43,32 +43,28 @@ module RuboCop
           minimum_target_chef_version '15.5'
 
           MSG = 'Chef Infra Client 15.5 and later include a chef_sleep resource that should be used to sleep between executing resources if necessary instead of using the bash or execute resources to run the sleep command.'
+          RESTRICT_ON_SEND = [:execute].freeze
 
           # non block execute resources
           def on_send(node)
-            return unless node.method_name == :execute
-
             # use a regex on source instead of .value in case there's string interpolation which adds a complex dstr type
             # with a nested string and a begin. Source allows us to avoid a lot of defensive programming here
-            if node&.arguments.first&.source&.match?(/^("|')sleep/)
-              add_offense(node, location: :expression, message: MSG, severity: :refactor)
-            end
+            return unless node&.arguments.first&.source&.match?(/^("|')sleep/)
+            add_offense(node, message: MSG, severity: :refactor)
           end
 
           # block execute resources
           def on_block(node)
             match_property_in_resource?(:execute, 'command', node) do |code_property|
               property_data = method_arg_ast_to_string(code_property)
-              if property_data && property_data.match?(/^sleep/i)
-                add_offense(node, location: :expression, message: MSG, severity: :refactor)
-              end
+              next unless property_data && property_data.match?(/^sleep/i)
+              add_offense(node, message: MSG, severity: :refactor)
             end
 
             match_property_in_resource?(:bash, 'code', node) do |code_property|
               property_data = method_arg_ast_to_string(code_property)
-              if property_data && property_data.match?(/^sleep/i)
-                add_offense(node, location: :expression, message: MSG, severity: :refactor)
-              end
+              next unless property_data && property_data.match?(/^sleep/i)
+              add_offense(node, message: MSG, severity: :refactor)
             end
           end
         end

data/lib/rubocop/cop/chef/modernize/execute_sysctl.rb

@@ -36,32 +36,29 @@ module RuboCop
         #     value '9000 65500'
         #   end
         #
-        class ExecuteSysctl < Cop
+        class ExecuteSysctl < Base
           include RuboCop::Chef::CookbookHelpers
           extend TargetChefVersion
 
           minimum_target_chef_version '14.0'
 
           MSG = 'Chef Infra Client 14.0 and later includes a sysctl resource that should be used to idempotently load sysctl values instead of templating files and using execute to load them.'
+          RESTRICT_ON_SEND = [:execute].freeze
 
           # non block execute resources
           def on_send(node)
-            return unless node.method_name == :execute
-
             # use a regex on source instead of .value in case there's string interpolation which adds a complex dstr type
             # with a nested string and a begin. Source allows us to avoid a lot of defensive programming here
-            if node&.arguments.first&.source&.match?(/^("|')sysctl -p/)
-              add_offense(node, location: :expression, message: MSG, severity: :refactor)
-            end
+            return unless node&.arguments.first&.source&.match?(/^("|')sysctl -p/)
+            add_offense(node, message: MSG, severity: :refactor)
           end
 
           # block execute resources
           def on_block(node)
             match_property_in_resource?(:execute, 'command', node) do |code_property|
               property_data = method_arg_ast_to_string(code_property)
-              if property_data && property_data.match?(%r{^(/sbin/)?sysctl -p}i)
-                add_offense(node, location: :expression, message: MSG, severity: :refactor)
-              end
+              return unless property_data && property_data.match?(%r{^(/sbin/)?sysctl -p}i)
+              add_offense(node, message: MSG, severity: :refactor)
             end
           end
         end

data/lib/rubocop/cop/chef/modernize/execute_tzutil.rb

@@ -37,13 +37,14 @@ module RuboCop
         #   # good
         #   timezone 'UTC'
         #
-        class ExecuteTzUtil < Cop
+        class ExecuteTzUtil < Base
           include RuboCop::Chef::CookbookHelpers
           extend TargetChefVersion
 
           minimum_target_chef_version '14.6'
 
           MSG = 'Use the timezone resource included in Chef Infra Client 14.6+ instead of shelling out to tzutil'
+          RESTRICT_ON_SEND = [:execute].freeze
 
           def_node_matcher :execute_resource?, <<-PATTERN
             (send nil? :execute $str)
@@ -51,17 +52,20 @@ module RuboCop
 
           def on_send(node)
             execute_resource?(node) do
-              add_offense(node, location: :expression, message: MSG, severity: :refactor) if node.arguments.first.value.match?(/^tzutil/i)
+              return unless node.arguments.first.value.match?(/^tzutil/i)
+              add_offense(node, message: MSG, severity: :refactor)
             end
           end
 
           def on_block(node)
             match_property_in_resource?(:execute, 'command', node) do |code_property|
-              add_offense(node, location: :expression, message: MSG, severity: :refactor) if calls_tzutil?(code_property)
+              next unless calls_tzutil?(code_property)
+              add_offense(node, message: MSG, severity: :refactor)
             end
 
             match_property_in_resource?(:powershell_script, 'code', node) do |code_property|
-              add_offense(node, location: :expression, message: MSG, severity: :refactor) if calls_tzutil?(code_property)
+              next unless calls_tzutil?(code_property)
+              add_offense(node, message: MSG, severity: :refactor)
             end
           end
 

data/lib/rubocop/cop/chef/modernize/foodcritic_comments.rb

@@ -27,24 +27,19 @@ module RuboCop
         #   # bad
         #   # ~FC013
         #
-        class FoodcriticComments < Cop
-          MSG = 'Remove legacy code comments that disable Foodcritic rules'
+        class FoodcriticComments < Base
+          extend AutoCorrector
 
-          def investigate(processed_source)
-            return unless processed_source.ast
+          MSG = 'Remove legacy code comments that disable Foodcritic rules'
 
+          def on_new_investigation
             processed_source.comments.each do |comment|
-              if comment.text.match?(/#\s*~FC\d{3}.*/)
-                add_offense(comment, location: :expression, message: MSG, severity: :refactor)
+              next unless comment.text.match?(/#\s*~FC\d{3}.*/)
+              add_offense(comment, message: MSG, severity: :refactor) do |corrector|
+                corrector.remove(comment.loc.expression)
               end
             end
           end
-
-          def autocorrect(node)
-            lambda do |corrector|
-              corrector.remove(node.loc.expression)
-            end
-          end
         end
       end
     end

data/lib/rubocop/cop/chef/modernize/if_provides_default_action.rb

@@ -29,17 +29,15 @@ module RuboCop
         #   # good
         #   default_action :foo
         #
-        class IfProvidesDefaultAction < Cop
+        class IfProvidesDefaultAction < Base
+          extend AutoCorrector
+
           MSG = 'if defined?(default_action) is no longer necessary in Chef Resources as default_action shipped in Chef 10.8.'
 
           def on_defined?(node)
             return unless node.arguments.first == s(:send, nil, :default_action)
             node = node.parent if node.parent.respond_to?(:if?) && node.parent.if? # we want the whole if statement
-            add_offense(node, location: :expression, message: MSG, severity: :refactor)
-          end
-
-          def autocorrect(node)
-            lambda do |corrector|
+            add_offense(node, message: MSG, severity: :refactor) do |corrector|
               corrector.replace(node.loc.expression, node.children[1].source)
             end
           end

data/lib/rubocop/cop/chef/modernize/includes_mixin_shellout.rb

@@ -30,10 +30,12 @@ module RuboCop
         #   require 'chef/mixin/powershell_out'
         #   include Chef::Mixin::PowershellOut
         #
-        class IncludingMixinShelloutInResources < Cop
+        class IncludingMixinShelloutInResources < Base
+          extend AutoCorrector
           include RangeHelp
 
           MSG = 'There is no need to include Chef::Mixin::ShellOut or Chef::Mixin::PowershellOut in resources or providers as this is already done by Chef Infra Client 12.4+.'
+          RESTRICT_ON_SEND = [:include, :require].freeze
 
           def_node_matcher :include_shellout?, <<-PATTERN
             (send nil? :include (const (const (const nil? :Chef) :Mixin) {:ShellOut :PowershellOut}))
@@ -60,7 +62,9 @@ module RuboCop
 
             # only add offenses when we're in a custom resource or HWRP, but not a plain old library
             if containing_dir == 'resources' || hwrp_classes?(processed_source.ast)
-              add_offense(node, location: :expression, message: MSG, severity: :refactor)
+              add_offense(node, message: MSG, severity: :refactor) do |corrector|
+                corrector.remove(range_with_surrounding_space(range: node.loc.expression, side: :left))
+              end
             end
           end
 
@@ -73,12 +77,6 @@ module RuboCop
               check_for_offenses(node)
             end
           end
-
-          def autocorrect(node)
-            lambda do |corrector|
-              corrector.remove(range_with_surrounding_space(range: node.loc.expression, side: :left))
-            end
-          end
         end
       end
     end

data/lib/rubocop/cop/chef/modernize/libarchive_file.rb

@@ -34,28 +34,32 @@ module RuboCop
         #     path 'C:\expand_here'
         #   end
         #
-        class LibarchiveFileResource < Cop
+        class LibarchiveFileResource < Base
           extend TargetChefVersion
+          extend AutoCorrector
 
           minimum_target_chef_version '15.0'
 
           MSG = 'Use the archive_file resource built into Chef Infra Client 15+ instead of the libarchive file resource'
+          RESTRICT_ON_SEND = [:libarchive_file, :notifies, :subscribes].freeze
 
           def_node_matcher :notification_property?, <<-PATTERN
             (send nil? {:notifies :subscribes} (sym _) $(...) (sym _))
           PATTERN
 
           def on_send(node)
-            add_offense(node, location: :expression, message: MSG, severity: :refactor) if node.method_name == :libarchive_file
-
-            notification_property?(node) do |val|
-              add_offense(val, location: :expression, message: MSG, severity: :refactor) if val.str_content&.start_with?('libarchive_file')
+            # The need for this goes away once https://github.com/rubocop-hq/rubocop/pull/8365 is pulled into Cookstyle
+            if node.method_name == :libarchive_file
+              add_offense(node, message: MSG, severity: :refactor) do |corrector|
+                corrector.replace(node.loc.expression, node.source.gsub('libarchive_file', 'archive_file'))
+              end
             end
-          end
 
-          def autocorrect(node)
-            lambda do |corrector|
-              corrector.replace(node.loc.expression, node.source.gsub('libarchive_file', 'archive_file'))
+            notification_property?(node) do |val|
+              next unless val.str_content&.start_with?('libarchive_file')
+              add_offense(val, message: MSG, severity: :refactor) do |corrector|
+                corrector.replace(node.loc.expression, node.source.gsub('libarchive_file', 'archive_file'))
+              end
             end
           end
         end

data/lib/rubocop/cop/chef/modernize/macos_user_defaults.rb

@@ -36,19 +36,17 @@ module RuboCop
         #     value '2'
         #   end
         #
-        class MacOsXUserdefaults < Cop
+        class MacOsXUserdefaults < Base
           extend TargetChefVersion
+          extend AutoCorrector
 
           minimum_target_chef_version '14.0'
 
           MSG = 'The mac_os_x_userdefaults resource was renamed to macos_userdefaults when it was added to Chef Infra Client 14.0. The new resource name should be used.'
+          RESTRICT_ON_SEND = [:mac_os_x_userdefaults].freeze
 
           def on_send(node)
-            add_offense(node, location: :expression, message: MSG, severity: :refactor) if node.method_name == :mac_os_x_userdefaults
-          end
-
-          def autocorrect(node)
-            lambda do |corrector|
+            add_offense(node, message: MSG, severity: :refactor) do |corrector|
               corrector.replace(node.loc.expression, node.source.gsub(/^mac_os_x_userdefaults/, 'macos_userdefaults'))
             end
           end

data/lib/rubocop/cop/chef/modernize/minitest_handler_usage.rb

@@ -26,10 +26,12 @@ module RuboCop
         #   # bad
         #   depends 'minitest-handler'
         #
-        class MinitestHandlerUsage < Cop
+        class MinitestHandlerUsage < Base
+          extend AutoCorrector
           include RangeHelp
 
           MSG = 'Use Chef InSpec for testing instead of the Minitest Handler cookbook pattern.'
+          RESTRICT_ON_SEND = [:depends].freeze
 
           def_node_matcher :minitest_depends?, <<-PATTERN
             (send nil? :depends (str "minitest-handler"))
@@ -37,13 +39,9 @@ module RuboCop
 
           def on_send(node)
             minitest_depends?(node) do
-              add_offense(node, location: :expression, message: MSG, severity: :refactor)
-            end
-          end
-
-          def autocorrect(node)
-            lambda do |corrector|
-              corrector.remove(range_with_surrounding_space(range: node.loc.expression, side: :left))
+              add_offense(node, message: MSG, severity: :refactor) do |corrector|
+                corrector.remove(range_with_surrounding_space(range: node.loc.expression, side: :left))
+              end
             end
           end
         end

data/lib/rubocop/cop/chef/modernize/node_roles_include.rb

@@ -29,7 +29,9 @@ module RuboCop
         #   # good
         #   node.role?('foo')
         #
-        class NodeRolesInclude < Cop
+        class NodeRolesInclude < Base
+          extend AutoCorrector
+
           MSG = "Use `node.role?('foo')` to check if a node includes a role instead of `node['roles'].include?('foo')`."
 
           def_node_matcher :node_role_include?, <<-PATTERN
@@ -41,14 +43,8 @@ module RuboCop
           PATTERN
 
           def on_send(node)
-            node_role_include?(node) do
-              add_offense(node, location: :expression, message: MSG, severity: :refactor)
-            end
-          end
-
-          def autocorrect(node)
-            lambda do |corrector|
-              node_role_include?(node) do |val|
+            node_role_include?(node) do |val|
+              add_offense(node, message: MSG, severity: :refactor) do |corrector|
                 corrector.replace(node.loc.expression, "node.role?(#{val.source})")
               end
             end

data/lib/rubocop/cop/chef/modernize/ohai_default_recipe.rb

@@ -29,8 +29,9 @@ module RuboCop
         #   include_recipe 'ohai::default'
         #   include_recipe 'ohai'
         #
-        class IncludingOhaiDefaultRecipe < Cop
+        class IncludingOhaiDefaultRecipe < Base
           MSG = "Use the ohai_plugin resource to ship custom Ohai plugins instead of using the ohai::default recipe. If you're not shipping custom Ohai plugins, then you can remove this recipe entirely"
+          RESTRICT_ON_SEND = [:include_recipe].freeze
 
           def_node_matcher :ohai_recipe_usage?, <<-PATTERN
             (send nil? :include_recipe (str {"ohai" "ohai::default"}))
@@ -38,7 +39,7 @@ module RuboCop
 
           def on_send(node)
             ohai_recipe_usage?(node) do
-              add_offense(node, location: :expression, message: MSG, severity: :refactor)
+              add_offense(node, message: MSG, severity: :refactor)
             end
           end
         end

data/lib/rubocop/cop/chef/modernize/openssl_rsa_key_resource.rb

@@ -32,19 +32,17 @@ module RuboCop
         #     key_length 2048
         #   end
         #
-        class OpensslRsaKeyResource < Cop
+        class OpensslRsaKeyResource < Base
           extend TargetChefVersion
+          extend AutoCorrector
 
           minimum_target_chef_version '14.0'
 
           MSG = 'The openssl_rsa_key resource was renamed to openssl_rsa_private_key in Chef Infra Client 14.0. The new resource name should be used.'
+          RESTRICT_ON_SEND = [:openssl_rsa_key].freeze
 
           def on_send(node)
-            add_offense(node, location: :expression, message: MSG, severity: :refactor) if node.method_name == :openssl_rsa_key
-          end
-
-          def autocorrect(node)
-            lambda do |corrector|
+            add_offense(node, message: MSG, severity: :refactor) do |corrector|
               corrector.replace(node.loc.expression, node.source.gsub(/^openssl_rsa_key/, 'openssl_rsa_private_key'))
             end
           end

data/lib/rubocop/cop/chef/modernize/openssl_x509_resource.rb

@@ -38,19 +38,17 @@ module RuboCop
         #     country 'US'
         #   end
         #
-        class OpensslX509Resource < Cop
+        class OpensslX509Resource < Base
           extend TargetChefVersion
+          extend AutoCorrector
 
           minimum_target_chef_version '14.4'
 
           MSG = 'The openssl_x509 resource was renamed to openssl_x509_certificate in Chef Infra Client 14.4. The new resource name should be used.'
+          RESTRICT_ON_SEND = [:openssl_x509].freeze
 
           def on_send(node)
-            add_offense(node, location: :expression, message: MSG, severity: :refactor) if node.method_name == :openssl_x509
-          end
-
-          def autocorrect(node)
-            lambda do |corrector|
+            add_offense(node, message: MSG, severity: :refactor) do |corrector|
               corrector.replace(node.loc.expression, node.source.gsub(/^openssl_x509/, 'openssl_x509_certificate'))
             end
           end

data/lib/rubocop/cop/chef/modernize/osx_config_profile_resource.rb

@@ -32,15 +32,14 @@ module RuboCop
         #     profile 'screensaver/com.company.screensaver.mobileconfig'
         #   end
         #
-        class OsxConfigProfileResource < Cop
+        class OsxConfigProfileResource < Base
+          extend AutoCorrector
+
           MSG = 'The osx_config_profile resource was renamed to osx_profile. The new resource name should be used.'
+          RESTRICT_ON_SEND = [:osx_config_profile].freeze
 
           def on_send(node)
-            add_offense(node, location: :expression, message: MSG, severity: :refactor) if node.method_name == :osx_config_profile
-          end
-
-          def autocorrect(node)
-            lambda do |corrector|
+            add_offense(node, message: MSG, severity: :refactor) do |corrector|
               corrector.replace(node.loc.expression, node.source.gsub(/^osx_config_profile/, 'osx_profile'))
             end
           end

data/lib/rubocop/cop/chef/modernize/powershell_expand_archive.rb

@@ -29,7 +29,7 @@ module RuboCop
         #     code 'Expand-Archive "C:\\file.zip" -DestinationPath "C:\\inetpub\\wwwroot\\" -Force'
         #   end
         #
-        class PowershellScriptExpandArchive < Cop
+        class PowershellScriptExpandArchive < Base
           include RuboCop::Chef::CookbookHelpers
           extend TargetChefVersion
 
@@ -40,9 +40,8 @@ module RuboCop
           def on_block(node)
             match_property_in_resource?(:powershell_script, 'code', node) do |code_property|
               property_data = method_arg_ast_to_string(code_property)
-              if property_data && property_data.match?(/^expand-archive/i)
-                add_offense(node, location: :expression, message: MSG, severity: :refactor)
-              end
+              return unless property_data && property_data.match?(/^expand-archive/i)
+              add_offense(node, message: MSG, severity: :refactor)
             end
           end
         end