cookstyle 5.7.0 → 5.8.1

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: e79627357ca125484e3ab900401f64dfef191b650282118279129b9fc3e1e65c
-  data.tar.gz: c6633c204e5cf76711518d7f25cbb03c49814eb4a0534bf108fba69bd58c4f61
+  metadata.gz: 3125819fab3d282926b73935652abee3c33badfdd12bbb257d983df77f575968
+  data.tar.gz: 74522c27e329921082c8f04e4ba0570ae45e39ae897f13f87ffa5c54c8658974
 SHA512:
-  metadata.gz: 04db3d494e31f545987ee9a5d74b5b238fb22e5a3c46904cee0956f3903c5402a0cedb1f922270a54eec3fa44691af0e79767e0fa2cf643bdd727e5d28abf30b
-  data.tar.gz: b7459b727077fc0079872053a7f7dd4c07822e254a6c9476d99390d22dcf4b7c9284ca5aa1b908ba66673fd9f2116495eacfb19706b3cf69ce6d0c57d282f12b
+  metadata.gz: 1c0daefee8ecb8249105e48d6c9ff1578fd150847fa5abf55bb07e175367c923481dcfa1e57339ae757f61bc94a5f23a7856ac3b320ca5f13c9c554f56be12fa
+  data.tar.gz: 8128f87b453e15356b7814dec8e7b87e6ba73f60dde690de6db480b856711fbbd73b77acec3ebaae078251b4d74ad96fb422c53f3a401d0bbdfd8e8865240113

data/config/cookstyle.yml

@@ -71,6 +71,13 @@ ChefStyle/UsePlatformHelpers:
     - '**/metadata.rb'
     - '**/libraries/*'
 
+ChefStyle/SimplifyPlatformMajorVersionCheck:
+  Description: Use node['platform_version'].to_i instead of node['platform_version'].split('.').first or node['platform_version'].split('.')[0]
+  Enabled: true
+  VersionAdded: '5.8.0'
+  Exclude:
+    - '**/metadata.rb'
+
 ###############################
 # ChefCorrectness: Avoiding potential problems
 ###############################
@@ -208,6 +215,28 @@ ChefCorrectness/IncludingOhaiDefaultRecipe:
   Exclude:
     - '**/metadata.rb'
 
+ChefCorrectness/UnnecessaryNameProperty:
+  Description: There is no need to define a property named :name in a resource as Chef Infra defines that property for all resources out of the box.
+  Enabled: true
+  VersionAdded: '5.8.0'
+  Include:
+    - '**/resources/*.rb'
+    - '**/libraries/*.rb'
+
+ChefCorrectness/EmptyMetadataField:
+  Description: metadata.rb should not include fields with an empty string. Either don't include the field or add a value.
+  Enabled: true
+  VersionAdded: '5.8.0'
+  Include:
+    - '**/metadata.rb'
+
+ChefCorrectness/InvalidVersionMetadata:
+  Description: Cookbook metadata.rb version field should follow X.Y.Z version format.
+  Enabled: true
+  VersionAdded: '5.8.0'
+  Include:
+    - '**/metadata.rb'
+
 ###############################
 # ChefDeprecations: Resolving Deprecations that block upgrading Chef Infra Client
 ###############################
@@ -456,6 +485,20 @@ ChefDeprecations/ResourceUsesProviderBaseMethod:
     - '**/libraries/*.rb'
     - '**/resources/*.rb'
 
+ChefDeprecations/ChefSpecCoverageReport:
+  Description: Don't use the deprecated ChefSpec coverage report functionality in your specs.
+  Enabled: true
+  VersionAdded: '5.8.0'
+  Include:
+    - '**/spec/*.rb'
+
+ChefDeprecations/ChefSpecLegacyRunner:
+  Description: Use ChefSpec::SoloRunner or ChefSpec::ServerRunner instead of the deprecated ChefSpec::Runner.
+  Enabled: true
+  VersionAdded: '5.8.0'
+  Include:
+    - '**/spec/*.rb'
+
 ###############################
 # ChefModernize: Cleaning up legacy code and using new built-in resources
 ###############################

data/cookstyle.gemspec

@@ -19,7 +19,5 @@ Gem::Specification.new do |spec|
   spec.executables = %w(cookstyle)
   spec.require_paths = ['lib']
 
-  spec.add_development_dependency 'rake'
-  spec.add_development_dependency 'rspec'
   spec.add_dependency('rubocop', Cookstyle::RUBOCOP_VERSION)
 end

data/lib/cookstyle/version.rb

@@ -1,4 +1,4 @@
 module Cookstyle
-  VERSION = "5.7.0".freeze # rubocop: disable Style/StringLiterals
+  VERSION = "5.8.1".freeze # rubocop: disable Style/StringLiterals
   RUBOCOP_VERSION = '0.72.0'.freeze
 end

data/lib/rubocop/cop/chef/correctness/block_guard_clause_string_only.rb

@@ -18,8 +18,7 @@ module RuboCop
   module Cop
     module Chef
       module ChefCorrectness
-        # A resource guard (not_if/only_if) that is a string should not be wrapped in {}.
-        # Wrapping a guard string in {} causes it be executed as Ruby code which will always returns true instead of a shell command that will actually run.
+        # A resource guard (not_if/only_if) that is a string should not be wrapped in {}. Wrapping a guard string in {} causes it be executed as Ruby code which will always returns true instead of a shell command that will actually run.
         #
         # @example
         #

data/lib/rubocop/cop/chef/correctness/default_maintainer_metadata.rb

@@ -19,8 +19,7 @@ module RuboCop
   module Cop
     module Chef
       module ChefCorrectness
-        # Metadata contains default maintainer information from the `chef generate cookbook`
-        # command. This should be updated to reflect that actual maintainer of the cookbook.
+        # Metadata contains default maintainer information from the `chef generate cookbook` command. This should be updated to reflect that actual maintainer of the cookbook.
         #
         # @example
         #

data/lib/rubocop/cop/chef/correctness/empty_metadata_field.rb

@@ -0,0 +1,46 @@
+#
+# Copyright:: 2019, Chef Software Inc.
+# Author:: Tim Smith (<tsmith@chef.io>)
+#
+# Licensed under the Apache License, Version 2.0 (the "License");
+# you may not use this file except in compliance with the License.
+# You may obtain a copy of the License at
+#
+# http://www.apache.org/licenses/LICENSE-2.0
+#
+# Unless required by applicable law or agreed to in writing, software
+# distributed under the License is distributed on an "AS IS" BASIS,
+# WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+# See the License for the specific language governing permissions and
+# limitations under the License.
+#
+
+module RuboCop
+  module Cop
+    module Chef
+      module ChefCorrectness
+        # metadata.rb should not include fields with an empty string. Either don't include the field or add a value.
+        #
+        # @example
+        #
+        #   # bad
+        #   license ''
+        #
+        #   # good
+        #   license 'Apache-2.0'
+        #
+        class EmptyMetadataField < Cop
+          MSG = 'Cookbook metadata.rb contains an field with an empty string.'.freeze
+
+          def_node_matcher :field?, '(send nil? _ $str ...)'
+
+          def on_send(node)
+            field?(node) do |str|
+              add_offense(str, location: :expression, message: MSG, severity: :refactor) if str.value.empty?
+            end
+          end
+        end
+      end
+    end
+  end
+end

data/lib/rubocop/cop/chef/correctness/invalid_license_string.rb

@@ -19,8 +19,7 @@ module RuboCop
   module Cop
     module Chef
       module ChefCorrectness
-        # metadata.rb license field should include a SPDX compliant string
-        # or "all right reserved" (not case sensitive)
+        # metadata.rb license field should include a SPDX compliant string or "all right reserved" (not case sensitive)
         #
         # @example
         #

data/lib/rubocop/cop/chef/correctness/invalid_version_metadata.rb

@@ -0,0 +1,48 @@
+#
+# Copyright:: 2019, Chef Software Inc.
+# Author:: Tim Smith (<tsmith@chef.io>)
+#
+# Licensed under the Apache License, Version 2.0 (the "License");
+# you may not use this file except in compliance with the License.
+# You may obtain a copy of the License at
+#
+# http://www.apache.org/licenses/LICENSE-2.0
+#
+# Unless required by applicable law or agreed to in writing, software
+# distributed under the License is distributed on an "AS IS" BASIS,
+# WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+# See the License for the specific language governing permissions and
+# limitations under the License.
+#
+
+module RuboCop
+  module Cop
+    module Chef
+      module ChefCorrectness
+        # Cookbook metadata.rb version field should follow X.Y.Z version format.
+        #
+        # @example
+        #
+        #   # bad
+        #   version '1.2.3.4'
+        #
+        #   # good
+        #   version '1.2.3'
+        #
+        class InvalidVersionMetadata < Cop
+          MSG = 'Cookbook metadata.rb version field should follow X.Y.Z version format.'.freeze
+
+          def_node_matcher :version?, '(send nil? :version $str ...)'
+
+          def on_send(node)
+            version?(node) do |ver|
+              if ver.value !~ /\A\d+\.\d+(\.\d+)?\z/ # entirely borrowed from Foodcritic.
+                add_offense(ver, location: :expression, message: MSG, severity: :refactor)
+              end
+            end
+          end
+        end
+      end
+    end
+  end
+end

data/lib/rubocop/cop/chef/correctness/metadata_missing_name.rb

@@ -18,7 +18,7 @@
 module RuboCop
   module Cop
     module Chef
-      # metadata.rb needs to include the name method
+      # metadata.rb needs to include the name method or it will fail on Chef Infra Client 12 and later.
       #
       # @example
       #
@@ -29,7 +29,7 @@ module RuboCop
         class MetadataMissingName < Cop
           include RangeHelp
 
-          MSG = 'metadata.rb needs to include the name method'.freeze
+          MSG = 'metadata.rb needs to include the name method or it will fail on Chef Infra Client 12 and later.'.freeze
 
           def investigate(processed_source)
             return if processed_source.blank?

data/lib/rubocop/cop/chef/correctness/unnecessary_name_property.rb

@@ -0,0 +1,53 @@
+#
+# Copyright:: Copyright 2019, Chef Software Inc.
+# Author:: Tim Smith (<tsmith@chef.io>)
+#
+# Licensed under the Apache License, Version 2.0 (the "License");
+# you may not use this file except in compliance with the License.
+# You may obtain a copy of the License at
+#
+# http://www.apache.org/licenses/LICENSE-2.0
+#
+# Unless required by applicable law or agreed to in writing, software
+# distributed under the License is distributed on an "AS IS" BASIS,
+# WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+# See the License for the specific language governing permissions and
+# limitations under the License.
+#
+module RuboCop
+  module Cop
+    module Chef
+      module ChefCorrectness
+        # There is no need to define a property named :name in a resource as Chef Infra defines that property for all resources out of the box.
+        #
+        # @example
+        #
+        #   # bad
+        #   property :name, String
+        #   property :name, String, name_property: true
+        #
+        class UnnecessaryNameProperty < Cop
+          MSG = 'There is no need to define a property named :name in a resource as Chef Infra defines that property for all resources out of the box.'.freeze
+
+          def_node_matcher :name_property?, <<-PATTERN
+            (send nil? :property (sym :name) (const nil? :String) $...)
+          PATTERN
+
+          def on_send(node)
+            name_property?(node) do |hash_vals|
+              if hash_vals.empty? || (hash_vals.first.keys.count == 1 && hash_vals.first.keys.first.source == 'name_property')
+                add_offense(node, location: :expression, message: MSG, severity: :refactor)
+              end
+            end
+          end
+
+          def autocorrect(node)
+            lambda do |corrector|
+              corrector.remove(node.source_range)
+            end
+          end
+        end
+      end
+    end
+  end
+end

data/lib/rubocop/cop/chef/deprecation/attribute_metadata.rb

@@ -31,6 +31,7 @@ module RuboCop
         #              type: 'string',
         #              required: 'optional',
         #              default: '"127.0.0.1:2181"'
+        #
         class AttributeMetadata < Cop
           MSG = "Don't use the deprecated 'attribute' metadata value".freeze
 

data/lib/rubocop/cop/chef/deprecation/chefspec_coverage_report.rb

@@ -0,0 +1,52 @@
+#
+# Copyright:: 2019, Chef Software Inc.
+# Author:: Tim Smith (<tsmith@chef.io>)
+#
+# Licensed under the Apache License, Version 2.0 (the "License");
+# you may not use this file except in compliance with the License.
+# You may obtain a copy of the License at
+#
+# http://www.apache.org/licenses/LICENSE-2.0
+#
+# Unless required by applicable law or agreed to in writing, software
+# distributed under the License is distributed on an "AS IS" BASIS,
+# WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+# See the License for the specific language governing permissions and
+# limitations under the License.
+#
+
+module RuboCop
+  module Cop
+    module Chef
+      module ChefDeprecations
+        # Don't use the deprecated ChefSpec Coverage report functionality in your specs. This feature has been removed as coverage reports encourage cookbook authors to write ineffective specs. Focus on testing your logic instead of achieving 100% code coverage.
+        #
+        # @example
+        #
+        #   # bad
+        #
+        #   at_exit { ChefSpec::Coverage.report! }
+        #
+        class ChefSpecCoverageReport < Cop
+          MSG = "Don't use the deprecated ChefSpec coverage report functionality in your specs.".freeze
+
+          def_node_matcher :coverage_reporter?, <<-PATTERN
+          (block (send nil? :at_exit ) (args) (send (const (const nil? :ChefSpec) :Coverage) :report!))
+          PATTERN
+
+          def on_block(node)
+            coverage_reporter?(node) do
+              add_offense(node, location: :expression, message: MSG, severity: :refactor)
+            end
+          end
+
+          def autocorrect(node)
+            lambda do |corrector|
+              corrector.remove(node.loc.expression)
+            end
+          end
+        end
+      end
+    end
+  end
+end

data/lib/rubocop/cop/chef/deprecation/chefspec_legacy_runner.rb

@@ -0,0 +1,64 @@
+#
+# Copyright:: 2019, Chef Software Inc.
+# Author:: Tim Smith (<tsmith@chef.io>)
+#
+# Licensed under the Apache License, Version 2.0 (the "License");
+# you may not use this file except in compliance with the License.
+# You may obtain a copy of the License at
+#
+# http://www.apache.org/licenses/LICENSE-2.0
+#
+# Unless required by applicable law or agreed to in writing, software
+# distributed under the License is distributed on an "AS IS" BASIS,
+# WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+# See the License for the specific language governing permissions and
+# limitations under the License.
+#
+
+module RuboCop
+  module Cop
+    module Chef
+      module ChefDeprecations
+        # Use ChefSpec::SoloRunner or ChefSpec::ServerRunner instead of the deprecated ChefSpec::Runner. These new runners were introduced in ChefSpec 4.1 (Oct 2014).
+        #
+        # @example
+        #
+        #   # bad
+        #
+        #   describe 'foo::default' do
+        #     subject { ChefSpec::Runner.new.converge(described_recipe) }
+        #
+        #     # some spec code
+        #   end
+        #
+        #   # good
+        #
+        #   describe 'foo::default' do
+        #     subject { ChefSpec::ServerRunner.new.converge(described_recipe) }
+        #
+        #     # some spec code
+        #   end
+        #
+        class ChefSpecLegacyRunner < Cop
+          MSG = 'Use ChefSpec::SoloRunner or ChefSpec::ServerRunner instead of the deprecated ChefSpec::Runner.'.freeze
+
+          def_node_matcher :chefspec_runner?, <<-PATTERN
+          (const (const nil? :ChefSpec) :Runner)
+          PATTERN
+
+          def on_const(node)
+            chefspec_runner?(node) do
+              add_offense(node, location: :expression, message: MSG, severity: :refactor)
+            end
+          end
+
+          def autocorrect(node)
+            lambda do |corrector|
+              corrector.replace(node.loc.expression, 'ChefSpec::ServerRunner')
+            end
+          end
+        end
+      end
+    end
+  end
+end

data/lib/rubocop/cop/chef/deprecation/deprecated_mixins.rb

@@ -32,7 +32,7 @@ module RuboCop
         #   require 'chef/mixin/language'
         #   require 'chef/mixin/language_include_attribute'
         #   require 'chef/mixin/language_include_recipe'
-
+        #
         class UsesDeprecatedMixins < Cop
           MSG = "Don't use deprecated Mixins no longer included in Chef Infra Client 14 and later.".freeze
 

data/lib/rubocop/cop/chef/deprecation/long_description_metadata.rb

@@ -32,14 +32,8 @@ module RuboCop
 
           MSG = 'The long_description metadata.rb method is not used and is unnecessary in cookbooks'.freeze
 
-          def_node_matcher :long_description?, <<-PATTERN
-            (send nil? :long_description ... )
-          PATTERN
-
           def on_send(node)
-            long_description?(node) do
-              add_offense(node, location: :expression, message: MSG, severity: :refactor) if node.method_name == :long_description
-            end
+            add_offense(node, location: :expression, message: MSG, severity: :refactor) if node.method_name == :long_description
           end
 
           def autocorrect(node)

data/lib/rubocop/cop/chef/deprecation/use_inline_resources.rb

@@ -26,6 +26,7 @@ module RuboCop
         #   # bad
         #   use_inline_resources
         #   use_inline_resources if defined?(use_inline_resources)
+        #   use_inline_resources if respond_to?(:use_inline_resources)
         #
         class UseInlineResourcesDefined < Cop
           MSG = 'use_inline_resources is now the default for resources in Chef Infra Client 13+ and does not need to be specified.'.freeze
@@ -37,7 +38,7 @@ module RuboCop
               return if node.parent && node.parent.defined_type?
 
               # catch the full offense if the method is gated like this: use_inline_resources if defined?(use_inline_resources)
-              if node.parent && node.parent.if_type? && node.parent.children.first.method_name == :defined?
+              if node.parent && node.parent.if_type? && %i(defined? respond_to?).include?(node.parent.children.first.method_name)
                 node = node.parent
               end
               add_offense(node, location: :expression, message: MSG, severity: :refactor)

data/lib/rubocop/cop/chef/deprecation/user_supports_property.rb

@@ -46,6 +46,17 @@ module RuboCop
               add_offense(property, location: :expression, message: MSG, severity: :refactor)
             end
           end
+
+          def autocorrect(node)
+            lambda do |corrector|
+              new_text = []
+              node.arguments.first.each_pair do |k, v|
+                new_text << "#{k.source} #{v.source}"
+              end
+
+              corrector.replace(node.loc.expression, new_text.join("\n  "))
+            end
+          end
         end
       end
     end

data/lib/rubocop/cop/chef/modernize/cron_manage_resource.rb

@@ -29,8 +29,6 @@ module RuboCop
         #   cron_access 'mike'
         #
         class CronManageResource < Cop
-          include RuboCop::Chef::CookbookHelpers
-
           MSG = 'The cron_manage resource was renamed to cron_access in the 6.1 release of the cron cookbook and later shipped in Chef Infra Client 14.4. The new resource name should be used.'.freeze
 
           def on_send(node)

data/lib/rubocop/cop/chef/modernize/macos_user_defaults.rb

@@ -36,8 +36,6 @@ module RuboCop
         #   end
         #
         class MacOsXUserdefaults < Cop
-          include RuboCop::Chef::CookbookHelpers
-
           MSG = 'The mac_os_x_userdefaults resource was renamed to macos_userdefaults when it was added to Chef Infra Client 14.0. The new resource name should be used.'.freeze
 
           def on_send(node)

data/lib/rubocop/cop/chef/modernize/openssl_rsa_key_resource.rb

@@ -32,8 +32,6 @@ module RuboCop
         #   end
         #
         class OpensslRsaKeyResource < Cop
-          include RuboCop::Chef::CookbookHelpers
-
           MSG = 'The openssl_rsa_key resource was renamed to openssl_rsa_private_key in Chef Infra Client 14.0. The new resource name should be used.'.freeze
 
           def on_send(node)

data/lib/rubocop/cop/chef/modernize/openssl_x509_resource.rb

@@ -38,8 +38,6 @@ module RuboCop
         #   end
         #
         class OpensslX509Resource < Cop
-          include RuboCop::Chef::CookbookHelpers
-
           MSG = 'The openssl_x509 resource was renamed to openssl_x509_certificate in Chef Infra Client 14.4. The new resource name should be used.'.freeze
 
           def on_send(node)

data/lib/rubocop/cop/chef/modernize/osx_config_profile_resource.rb

@@ -32,8 +32,6 @@ module RuboCop
         #   end
         #
         class OsxConfigProfileResource < Cop
-          include RuboCop::Chef::CookbookHelpers
-
           MSG = 'The osx_config_profile resource was renamed to osx_profile. The new resource name should be used.'.freeze
 
           def on_send(node)

data/lib/rubocop/cop/chef/modernize/resource_with_allowed_actions.rb

@@ -19,9 +19,7 @@ module RuboCop
   module Cop
     module Chef
       module ChefModernize
-        # In HWRPs and LWRPs it was necessary to define the allowed actions within the resource.
-        # In custom resources this is no longer necessary as Chef will determine it based on the
-        # actions defined in the resource.
+        # In Chef Infra Client releases after 12.5 it is no longer necessary to set `actions` or `allowed_actions` as Chef Infra Client determines these automatically from the set of all actions defined in the resource.
         #
         # @example
         #
@@ -29,39 +27,25 @@ module RuboCop
         #   property :something, String
         #
         #   allowed_actions [:create, :remove]
-        #   action :create do
-        #     # some action code because we're in a custom resource
-        #   end
         #
         #   # also bad
         #   property :something, String
         #
         #   actions [:create, :remove]
-        #   action :create do
-        #     # some action code because we're in a custom resource
-        #   end
         #
         #   # good
         #   property :something, String
         #
-        #   action :create do
-        #     # some action code because we're in a custom resource
-        #   end
-        #
         class CustomResourceWithAllowedActions < Cop
-          MSG = "Custom Resources don't need to define the allowed actions with allowed_actions or actions methods".freeze
+          MSG = 'Resources no longer need to define the allowed actions with allowed_actions or actions methods.'.freeze
 
           def_node_matcher :allowed_actions?, <<-PATTERN
             (send nil? {:allowed_actions :actions} ... )
           PATTERN
 
-          def_node_search :resource_actions?, <<-PATTERN
-            (block (send nil? :action ... ) ... )
-          PATTERN
-
           def on_send(node)
             allowed_actions?(node) do
-              add_offense(node, location: :expression, message: MSG, severity: :refactor) if resource_actions?(processed_source.ast)
+              add_offense(node, location: :expression, message: MSG, severity: :refactor)
             end
           end
 

data/lib/rubocop/cop/chef/style/simplify_platform_major_version_check.rb

@@ -0,0 +1,87 @@
+#
+# Copyright:: 2019, Chef Software, Inc.
+# Author:: Tim Smith (<tsmith@chef.io>)
+#
+# Licensed under the Apache License, Version 2.0 (the "License");
+# you may not use this file except in compliance with the License.
+# You may obtain a copy of the License at
+#
+# http://www.apache.org/licenses/LICENSE-2.0
+#
+# Unless required by applicable law or agreed to in writing, software
+# distributed under the License is distributed on an "AS IS" BASIS,
+# WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+# See the License for the specific language governing permissions and
+# limitations under the License.
+#
+module RuboCop
+  module Cop
+    module Chef
+      module ChefStyle
+        # When checking the major version number of a platform you can take the node['platform_version'] attribute and transform it to an integer to strip it down to just the major version number. This simple way of determining the major version number of a platform should be used instead of splitting the platform into multiple fields with '.' as the delimiter.
+        #
+        # @example
+        #
+        #   # bad
+        #   node['platform_version'].split('.').first
+        #   node['platform_version'].split('.')[0]
+        #   node['platform_version'].split('.').first.to_i
+        #   node['platform_version'].split('.')[0].to_i
+        #
+        #   # good
+        #
+        #   # check to see if we're on RHEL 7 on a RHEL 7.6 node where node['platform_version] is 7.6.1810
+        #   if node['platform_version'].to_i == 7
+        #
+        class SimplifyPlatformMajorVersionCheck < Cop
+          MSG = "Use node['platform_version'].to_i instead of node['platform_version'].split('.').first or node['platform_version'].split('.')[0]".freeze
+
+          def_node_matcher :platform_version_check?, <<-PATTERN
+            (send (send (send nil? :node) :[] (str "platform_version") ) :split (str ".") )
+          PATTERN
+
+          def on_send(node)
+            platform_version_check?(node) do
+              if parent_method_equals?(node, :[])
+                node = node.parent
+                if node&.arguments.count == 1 &&
+                   node&.arguments&.first&.int_type? &&
+                   node&.arguments&.first.source == '0'
+                  add_offense_to_i_if_present(node)
+                end
+              elsif parent_method_equals?(node, :first)
+                node = node.parent
+                add_offense_to_i_if_present(node)
+              end
+            end
+          end
+
+          def autocorrect(node)
+            lambda do |corrector|
+              corrector.replace(node.loc.expression, "node['platform_version'].to_i")
+            end
+          end
+
+          private
+
+          # if the parent is .to_i then we want to alert on that
+          def add_offense_to_i_if_present(node)
+            node = node.parent if parent_method_equals?(node, :to_i)
+            add_offense(node, location: :expression, message: MSG, severity: :refactor)
+          end
+
+          # see if the parent is a method and if it equals the passed in name
+          #
+          # @param [Rubocop::AST:Node] node The rubocop ast node to search
+          # @param [Symbol] name The method name
+          #
+          def parent_method_equals?(node, name)
+            return false if node.parent.nil?
+            return false unless node.parent.send_type?
+            name == node.parent.method_name
+          end
+        end
+      end
+    end
+  end
+end

metadata

@@ -1,7 +1,7 @@
 --- !ruby/object:Gem::Specification
 name: cookstyle
 version: !ruby/object:Gem::Version
-  version: 5.7.0
+  version: 5.8.1
 platform: ruby
 authors:
 - Thom May
@@ -9,36 +9,8 @@ authors:
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2019-10-04 00:00:00.000000000 Z
+date: 2019-10-07 00:00:00.000000000 Z
 dependencies:
-- !ruby/object:Gem::Dependency
-  name: rake
-  requirement: !ruby/object:Gem::Requirement
-    requirements:
-    - - ">="
-      - !ruby/object:Gem::Version
-        version: '0'
-  type: :development
-  prerelease: false
-  version_requirements: !ruby/object:Gem::Requirement
-    requirements:
-    - - ">="
-      - !ruby/object:Gem::Version
-        version: '0'
-- !ruby/object:Gem::Dependency
-  name: rspec
-  requirement: !ruby/object:Gem::Requirement
-    requirements:
-    - - ">="
-      - !ruby/object:Gem::Version
-        version: '0'
-  type: :development
-  prerelease: false
-  version_requirements: !ruby/object:Gem::Requirement
-    requirements:
-    - - ">="
-      - !ruby/object:Gem::Version
-        version: '0'
 - !ruby/object:Gem::Dependency
   name: rubocop
   requirement: !ruby/object:Gem::Requirement
@@ -78,9 +50,11 @@ files:
 - lib/rubocop/cop/chef/correctness/block_guard_clause_string_only.rb
 - lib/rubocop/cop/chef/correctness/cb_depends_on_self.rb
 - lib/rubocop/cop/chef/correctness/default_maintainer_metadata.rb
+- lib/rubocop/cop/chef/correctness/empty_metadata_field.rb
 - lib/rubocop/cop/chef/correctness/insecure_cookbook_url.rb
 - lib/rubocop/cop/chef/correctness/invalid_license_string.rb
 - lib/rubocop/cop/chef/correctness/invalid_platform_metadata.rb
+- lib/rubocop/cop/chef/correctness/invalid_version_metadata.rb
 - lib/rubocop/cop/chef/correctness/metadata_missing_name.rb
 - lib/rubocop/cop/chef/correctness/name_property_and_required.rb
 - lib/rubocop/cop/chef/correctness/node_normal.rb
@@ -94,8 +68,11 @@ files:
 - lib/rubocop/cop/chef/correctness/resource_with_none_action.rb
 - lib/rubocop/cop/chef/correctness/service_resource.rb
 - lib/rubocop/cop/chef/correctness/tmp_path.rb
+- lib/rubocop/cop/chef/correctness/unnecessary_name_property.rb
 - lib/rubocop/cop/chef/deprecation/attribute_metadata.rb
 - lib/rubocop/cop/chef/deprecation/chef_rest.rb
+- lib/rubocop/cop/chef/deprecation/chefspec_coverage_report.rb
+- lib/rubocop/cop/chef/deprecation/chefspec_legacy_runner.rb
 - lib/rubocop/cop/chef/deprecation/chocolatey_package_uninstall_action.rb
 - lib/rubocop/cop/chef/deprecation/conflicts_metadata.rb
 - lib/rubocop/cop/chef/deprecation/depends_compat_resource.rb
@@ -167,6 +144,7 @@ files:
 - lib/rubocop/cop/chef/style/comments_copyright_format.rb
 - lib/rubocop/cop/chef/style/comments_format.rb
 - lib/rubocop/cop/chef/style/file_mode.rb
+- lib/rubocop/cop/chef/style/simplify_platform_major_version_check.rb
 - lib/rubocop/cop/chef/style/use_platform_helpers.rb
 homepage: https://github.com/chef/cookstyle
 licenses: