cookstyle 5.4.13 → 5.5.7

metadata

@@ -1,7 +1,7 @@
 --- !ruby/object:Gem::Specification
 name: cookstyle
 version: !ruby/object:Gem::Version
-  version: 5.4.13
+  version: 5.5.7
 platform: ruby
 authors:
 - Thom May
@@ -9,7 +9,7 @@ authors:
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2019-08-29 00:00:00.000000000 Z
+date: 2019-09-06 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: rake
@@ -73,6 +73,7 @@ files:
 - lib/cookstyle.rb
 - lib/cookstyle/version.rb
 - lib/rubocop/chef.rb
+- lib/rubocop/chef/cookbook_helpers.rb
 - lib/rubocop/chef/cookbook_only.rb
 - lib/rubocop/cop/chef/correctness/block_guard_clause_string_only.rb
 - lib/rubocop/cop/chef/correctness/cb_depends_on_self.rb
@@ -84,11 +85,18 @@ files:
 - lib/rubocop/cop/chef/correctness/name_property_and_required.rb
 - lib/rubocop/cop/chef/correctness/node_normal.rb
 - lib/rubocop/cop/chef/correctness/node_normal_unless.rb
+- lib/rubocop/cop/chef/correctness/node_save.rb
+- lib/rubocop/cop/chef/correctness/ohai_default_recipe.rb
 - lib/rubocop/cop/chef/correctness/property_with_default_and_required.rb
 - lib/rubocop/cop/chef/correctness/property_with_name_attribute.rb
+- lib/rubocop/cop/chef/correctness/resource_sets_internal_properties.rb
+- lib/rubocop/cop/chef/correctness/resource_sets_name_property.rb
+- lib/rubocop/cop/chef/correctness/resource_with_none_action.rb
 - lib/rubocop/cop/chef/correctness/service_resource.rb
 - lib/rubocop/cop/chef/correctness/tmp_path.rb
 - lib/rubocop/cop/chef/deprecation/attribute_metadata.rb
+- lib/rubocop/cop/chef/deprecation/chef_rest.rb
+- lib/rubocop/cop/chef/deprecation/chocolatey_package_uninstall_action.rb
 - lib/rubocop/cop/chef/deprecation/conflicts_metadata.rb
 - lib/rubocop/cop/chef/deprecation/depends_compat_resource.rb
 - lib/rubocop/cop/chef/deprecation/depends_partial_search.rb
@@ -97,7 +105,9 @@ files:
 - lib/rubocop/cop/chef/deprecation/easy_install.rb
 - lib/rubocop/cop/chef/deprecation/epic_fail.rb
 - lib/rubocop/cop/chef/deprecation/erl_call.rb
+- lib/rubocop/cop/chef/deprecation/launchd_deprecated_hash_property.rb
 - lib/rubocop/cop/chef/deprecation/legacy_yum_cookbook_recipes.rb
+- lib/rubocop/cop/chef/deprecation/locale_lc_all_property.rb
 - lib/rubocop/cop/chef/deprecation/long_description_metadata.rb
 - lib/rubocop/cop/chef/deprecation/node_methods_not_attributes.rb
 - lib/rubocop/cop/chef/deprecation/node_set.rb
@@ -105,10 +115,12 @@ files:
 - lib/rubocop/cop/chef/deprecation/provides_metadata.rb
 - lib/rubocop/cop/chef/deprecation/replaces_metadata.rb
 - lib/rubocop/cop/chef/deprecation/require_recipe.rb
-- lib/rubocop/cop/chef/deprecation/respond_to_metadata.rb
 - lib/rubocop/cop/chef/deprecation/suggests_metadata.rb
+- lib/rubocop/cop/chef/deprecation/use_inline_resources.rb
+- lib/rubocop/cop/chef/deprecation/user_supports_property.rb
+- lib/rubocop/cop/chef/deprecation/xml_ruby_recipe.rb
+- lib/rubocop/cop/chef/deprecation/yum_dnf_compat_recipe.rb
 - lib/rubocop/cop/chef/effortless/data_bags.rb
-- lib/rubocop/cop/chef/effortless/node_save.rb
 - lib/rubocop/cop/chef/effortless/search_used.rb
 - lib/rubocop/cop/chef/modernize/apt_default_recipe.rb
 - lib/rubocop/cop/chef/modernize/berksfile_source.rb
@@ -117,20 +129,23 @@ files:
 - lib/rubocop/cop/chef/modernize/defines_chefspec_matchers.rb
 - lib/rubocop/cop/chef/modernize/execute_apt_update.rb
 - lib/rubocop/cop/chef/modernize/includes_mixin_shellout.rb
+- lib/rubocop/cop/chef/modernize/libarchive_file.rb
 - lib/rubocop/cop/chef/modernize/minitest_handler_usage.rb
-- lib/rubocop/cop/chef/modernize/ohai_default_recipe.rb
+- lib/rubocop/cop/chef/modernize/powershell_expand_archive.rb
+- lib/rubocop/cop/chef/modernize/powershell_install_package.rb
+- lib/rubocop/cop/chef/modernize/powershell_install_windowsfeature.rb
 - lib/rubocop/cop/chef/modernize/resource_set_or_return.rb
-- lib/rubocop/cop/chef/modernize/resource_with_allowed_action.rb
+- lib/rubocop/cop/chef/modernize/resource_with_allowed_actions.rb
 - lib/rubocop/cop/chef/modernize/resource_with_attributes.rb
+- lib/rubocop/cop/chef/modernize/respond_to_metadata.rb
 - lib/rubocop/cop/chef/modernize/respond_to_provides.rb
 - lib/rubocop/cop/chef/modernize/respond_to_resource_name.rb
-- lib/rubocop/cop/chef/modernize/use_inline_resources.rb
+- lib/rubocop/cop/chef/modernize/seven_zip_archive.rb
+- lib/rubocop/cop/chef/modernize/shellouts_to_chocolatey.rb
 - lib/rubocop/cop/chef/modernize/whyrun_supported_true.rb
 - lib/rubocop/cop/chef/modernize/windows_default_recipe.rb
 - lib/rubocop/cop/chef/modernize/windows_version_helper.rb
 - lib/rubocop/cop/chef/modernize/windows_zipfile.rb
-- lib/rubocop/cop/chef/modernize/xml_ruby_recipe.rb
-- lib/rubocop/cop/chef/modernize/yum_dnf_compat_recipe.rb
 - lib/rubocop/cop/chef/style/attribute_keys.rb
 - lib/rubocop/cop/chef/style/comment_sentence_spacing.rb
 - lib/rubocop/cop/chef/style/comments_copyright_format.rb

data/lib/rubocop/cop/chef/deprecation/respond_to_metadata.rb

@@ -1,53 +0,0 @@
-#
-# Copyright:: 2019, Chef Software, Inc.
-# Author:: Tim Smith (<tsmith@chef.io>)
-#
-# Licensed under the Apache License, Version 2.0 (the "License");
-# you may not use this file except in compliance with the License.
-# You may obtain a copy of the License at
-#
-# http://www.apache.org/licenses/LICENSE-2.0
-#
-# Unless required by applicable law or agreed to in writing, software
-# distributed under the License is distributed on an "AS IS" BASIS,
-# WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
-# See the License for the specific language governing permissions and
-# limitations under the License.
-#
-module RuboCop
-  module Cop
-    module Chef
-      # It is not longer necessary respond_to?(:foo) in metadata. This was used to support new metadata
-      # methods in Chef 11 and early versions of Chef 12.
-      #
-      # @example
-      #
-      #   # bad
-      #   chef_version '>= 13' if respond_to?(:chef_version)
-      #
-      #   # good
-      #   chef_version '>= 13'
-      #
-
-      class RespondToInMetadata < Cop
-        MSG = 'It is no longer necessary to use respond_to? in metadata.rb in Chef 12.15 and later'.freeze
-
-        def on_if(node)
-          if_respond_to?(node) do
-            add_offense(node, location: :expression, message: MSG, severity: :refactor)
-          end
-        end
-
-        def_node_matcher :if_respond_to?, <<~PATTERN
-        (if (send nil? :respond_to? _ ) ... )
-        PATTERN
-
-        def autocorrect(node)
-          lambda do |corrector|
-            corrector.replace(node.loc.expression, node.children[1].source)
-          end
-        end
-      end
-    end
-  end
-end

data/lib/rubocop/cop/chef/modernize/ohai_default_recipe.rb

@@ -1,45 +0,0 @@
-#
-# Copyright:: 2019, Chef Software, Inc.
-# Author:: Tim Smith (<tsmith@chef.io>)
-#
-# Licensed under the Apache License, Version 2.0 (the "License");
-# you may not use this file except in compliance with the License.
-# You may obtain a copy of the License at
-#
-# http://www.apache.org/licenses/LICENSE-2.0
-#
-# Unless required by applicable law or agreed to in writing, software
-# distributed under the License is distributed on an "AS IS" BASIS,
-# WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
-# See the License for the specific language governing permissions and
-# limitations under the License.
-#
-module RuboCop
-  module Cop
-    module Chef
-      # The Ohai default recipe previously allowed a user to ship custom Ohai plugins to a system by including them
-      # in a directory in the Ohai cookbook. This functionality was replaced with the ohai_plugin resource, which
-      # should be used instead as it doesn't require forking the ohai cookbook.
-      #
-      # @example
-      #
-      #   # bad
-      #   include_recipe 'ohai::default'
-      #   include_recipe 'ohai'
-      #
-      class IncludingOhaiDefaultRecipe < Cop
-        MSG = "Use the ohai_plugin resource to ship custom Ohai plugins instead of using the ohai::default recipe. If you're not shipping custom Ohai plugins, then you can remove this recipe entirely".freeze
-
-        def_node_matcher :ohai_recipe_usage?, <<-PATTERN
-          (send nil? :include_recipe (str {"ohai" "ohai::default"}))
-        PATTERN
-
-        def on_send(node)
-          ohai_recipe_usage?(node) do
-            add_offense(node, location: :expression, message: MSG, severity: :refactor)
-          end
-        end
-      end
-    end
-  end
-end

data/lib/rubocop/cop/chef/modernize/resource_with_allowed_action.rb

@@ -1,75 +0,0 @@
-#
-# Copyright:: 2019, Chef Software, Inc.
-# Author:: Tim Smith (<tsmith@chef.io>)
-#
-# Licensed under the Apache License, Version 2.0 (the "License");
-# you may not use this file except in compliance with the License.
-# You may obtain a copy of the License at
-#
-# http://www.apache.org/licenses/LICENSE-2.0
-#
-# Unless required by applicable law or agreed to in writing, software
-# distributed under the License is distributed on an "AS IS" BASIS,
-# WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
-# See the License for the specific language governing permissions and
-# limitations under the License.
-#
-
-module RuboCop
-  module Cop
-    module Chef
-      # In HWRPs and LWRPs it was necessary to define the allowed actions within the resource.
-      # In custom resources this is no longer necessary as Chef will determine it based on the
-      # actions defined in the resource.
-      #
-      # @example
-      #
-      #   # bad
-      #   property :something, String
-      #
-      #   allowed_actions [:create, :remove]
-      #   action :create do
-      #     # some action code because we're in a custom resource
-      #   end
-      #
-      #   # also bad
-      #   property :something, String
-      #
-      #   actions [:create, :remove]
-      #   action :create do
-      #     # some action code because we're in a custom resource
-      #   end
-      #
-      #   # good
-      #   property :something, String
-      #
-      #   action :create do
-      #     # some action code because we're in a custom resource
-      #   end
-      #
-      class CustomResourceWithAllowedActions < Cop
-        MSG = "Custom Resources don't need to define the allowed actions with allowed_actions or actions methods".freeze
-
-        def_node_matcher :allowed_actions?, <<-PATTERN
-          (send nil? {:allowed_actions :actions} ... )
-        PATTERN
-
-        def_node_search :resource_actions?, <<-PATTERN
-          (block (send nil? :action ... ) ... )
-        PATTERN
-
-        def on_send(node)
-          allowed_actions?(node) do
-            add_offense(node, location: :expression, message: MSG, severity: :refactor) if resource_actions?(processed_source.ast)
-          end
-        end
-
-        def autocorrect(node)
-          lambda do |corrector|
-            corrector.remove(node.loc.expression)
-          end
-        end
-      end
-    end
-  end
-end

data/lib/rubocop/cop/chef/modernize/use_inline_resources.rb

@@ -1,54 +0,0 @@
-#
-# Copyright:: 2019, Chef Software Inc.
-# Author:: Tim Smith (<tsmith@chef.io>)
-#
-# Licensed under the Apache License, Version 2.0 (the "License");
-# you may not use this file except in compliance with the License.
-# You may obtain a copy of the License at
-#
-# http://www.apache.org/licenses/LICENSE-2.0
-#
-# Unless required by applicable law or agreed to in writing, software
-# distributed under the License is distributed on an "AS IS" BASIS,
-# WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
-# See the License for the specific language governing permissions and
-# limitations under the License.
-#
-module RuboCop
-  module Cop
-    module Chef
-      # use_inline_resources became the default in Chef Infra Client 13+ and no longer needs
-      # to be called in resources
-      #
-      # @example
-      #
-      #   # bad
-      #   use_inline_resources
-      #   use_inline_resources if defined?(use_inline_resources)
-      #
-      class UseInlineResourcesDefined < Cop
-        MSG = 'use_inline_resources is now the default for resources in Chef Infra Client 13+ and does not need to be specified.'.freeze
-
-        def on_send(node)
-          if node.method_name == :use_inline_resources
-            # don't alert on the use_inline_resources within the defined? check
-            # that would result in 2 alerts on the same line and wouldn't be useful
-            return if node.parent && node.parent.defined_type?
-
-            # catch the full offense if the method is gated like this: use_inline_resources if defined?(use_inline_resources)
-            if node.parent && node.parent.if_type? && node.parent.children.first.method_name == :defined?
-              node = node.parent
-            end
-            add_offense(node, location: :expression, message: MSG, severity: :refactor)
-          end
-        end
-
-        def autocorrect(node)
-          lambda do |corrector|
-            corrector.remove(node.loc.expression)
-          end
-        end
-      end
-    end
-  end
-end

data/lib/rubocop/cop/chef/modernize/xml_ruby_recipe.rb

@@ -1,49 +0,0 @@
-#
-# Copyright:: 2019, Chef Software, Inc.
-# Author:: Tim Smith (<tsmith@chef.io>)
-#
-# Licensed under the Apache License, Version 2.0 (the "License");
-# you may not use this file except in compliance with the License.
-# You may obtain a copy of the License at
-#
-# http://www.apache.org/licenses/LICENSE-2.0
-#
-# Unless required by applicable law or agreed to in writing, software
-# distributed under the License is distributed on an "AS IS" BASIS,
-# WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
-# See the License for the specific language governing permissions and
-# limitations under the License.
-#
-module RuboCop
-  module Cop
-    module Chef
-      # The xml::ruby recipe was used to install nokogiri into the Chef installation. Nokogiri is included
-      # in Chef Infra Client 12 and later so this recipe is no longer necessary.
-      #
-      # @example
-      #
-      #   # bad
-      #   include_recipe 'xml::ruby'
-      #
-      class IncludingXMLRubyRecipe < Cop
-        MSG = 'The xml::ruby recipe installs nokogiri which is included in Chef Infra Client 12 and later.'.freeze
-
-        def_node_matcher :xml_ruby_recipe?, <<-PATTERN
-          (send nil? :include_recipe (str "xml::ruby"))
-        PATTERN
-
-        def on_send(node)
-          xml_ruby_recipe?(node) do
-            add_offense(node, location: :expression, message: MSG, severity: :refactor)
-          end
-        end
-
-        def autocorrect(node)
-          lambda do |corrector|
-            corrector.remove(node.loc.expression)
-          end
-        end
-      end
-    end
-  end
-end

data/lib/rubocop/cop/chef/modernize/yum_dnf_compat_recipe.rb

@@ -1,49 +0,0 @@
-#
-# Copyright:: 2019, Chef Software, Inc.
-# Author:: Tim Smith (<tsmith@chef.io>)
-#
-# Licensed under the Apache License, Version 2.0 (the "License");
-# you may not use this file except in compliance with the License.
-# You may obtain a copy of the License at
-#
-# http://www.apache.org/licenses/LICENSE-2.0
-#
-# Unless required by applicable law or agreed to in writing, software
-# distributed under the License is distributed on an "AS IS" BASIS,
-# WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
-# See the License for the specific language governing permissions and
-# limitations under the License.
-#
-module RuboCop
-  module Cop
-    module Chef
-      # Don't include the yum DNF compatibility recipe, which is no longer necessary
-      # as Chef Infra Client includes DNF package support
-      #
-      # @example
-      #
-      #   # bad
-      #   include_recipe 'yum::dnf_yum_compat'
-      #
-      class IncludingYumDNFCompatRecipe < Cop
-        MSG = 'Do not include the yum::dnf_yum_compat default recipe to install yum on dnf systems. Chef Infra Client now includes built in support for DNF packages.'.freeze
-
-        def_node_matcher :yum_dnf_compat_recipe_usage?, <<-PATTERN
-          (send nil? :include_recipe (str "yum::dnf_yum_compat"))
-        PATTERN
-
-        def on_send(node)
-          yum_dnf_compat_recipe_usage?(node) do
-            add_offense(node, location: :expression, message: MSG, severity: :refactor)
-          end
-        end
-
-        def autocorrect(node)
-          lambda do |corrector|
-            corrector.remove(node.loc.expression)
-          end
-        end
-      end
-    end
-  end
-end