cookstyle 5.14.1 → 5.15.7

data/lib/rubocop/cop/chef/modernize/berksfile_source.rb

@@ -28,6 +28,7 @@ module RuboCop
         #   source 'http://community.opscode.com/api/v3'
         #   source 'https://supermarket.getchef.com'
         #   source 'https://api.berkshelf.com'
+        #   site :opscode
         #
         #   # good
         #   source 'https://supermarket.chef.io'
@@ -35,6 +36,10 @@ module RuboCop
         class LegacyBerksfileSource < Cop
           MSG = 'Do not use legacy Berksfile community sources. Use Chef Supermarket instead.'.freeze
 
+          def_node_matcher :berksfile_site?, <<-PATTERN
+            (send nil? :site (:sym _))
+          PATTERN
+
           def_node_matcher :berksfile_source?, <<-PATTERN
             (send nil? :source (str #old_berkshelf_url?))
           PATTERN
@@ -47,6 +52,10 @@ module RuboCop
             berksfile_source?(node) do
               add_offense(node, location: :expression, message: MSG, severity: :refactor)
             end
+
+            berksfile_site?(node) do
+              add_offense(node, location: :expression, message: MSG, severity: :refactor)
+            end
           end
 
           def autocorrect(node)

data/lib/rubocop/cop/chef/modernize/default_action_initializer.rb

@@ -28,6 +28,12 @@ module RuboCop
         #     @action = :create
         #   end
         #
+        #   # bad
+        #   def initialize(*args)
+        #     super
+        #     @default_action = :create
+        #   end
+        #
         #  # good
         #  default_action :create
 
@@ -41,7 +47,7 @@ module RuboCop
             return if node.body.nil? # nil body is an empty initialize method
 
             node.body.each_node do |x|
-              if x.assignment? && !x.node_parts.empty? && x.node_parts.first == :@action
+              if x.assignment? && !x.node_parts.empty? && %i(@action @default_action).include?(x.node_parts.first)
                 add_offense(x, location: :expression, message: MSG, severity: :refactor)
               end
             end

data/lib/rubocop/cop/chef/{correctness → modernize}/ohai_default_recipe.rb

@@ -17,7 +17,7 @@
 module RuboCop
   module Cop
     module Chef
-      module ChefCorrectness
+      module ChefModernize
         # The Ohai default recipe previously allowed a user to ship custom Ohai plugins to a system by including them
         # in a directory in the Ohai cookbook. This functionality was replaced with the ohai_plugin resource, which
         # should be used instead as it doesn't require forking the ohai cookbook.

data/lib/rubocop/cop/chef/{correctness → modernize}/property_with_name_attribute.rb

@@ -17,9 +17,8 @@
 module RuboCop
   module Cop
     module Chef
-      module ChefCorrectness
-        # When using properties in a custom resource you should use name_property not
-        # the legacy name_attribute from the days of attributes
+      module ChefModernize
+        # When using properties in a custom resource you should use name_property not the legacy name_attribute from the days of attributes
         #
         # @example
         #

data/lib/rubocop/cop/chef/modernize/respond_to_resource_name.rb

@@ -18,9 +18,7 @@ module RuboCop
   module Cop
     module Chef
       module ChefModernize
-        # Chef 12.5 introduced the resource_name method for resources. Many cookbooks used
-        # respond_to?(:resource_name) to provide backwards compatibility with older chef-client
-        # releases. This backwards compatibility is no longer necessary.
+        # Chef Infra Client 12.5 introduced the resource_name method for resources. Many cookbooks used respond_to?(:resource_name) to provide backwards compatibility with older chef-client releases. This backwards compatibility is no longer necessary.
         #
         # @example
         #

data/lib/rubocop/cop/chef/modernize/unnecessary_mixlib_shellout_require.rb

@@ -19,7 +19,7 @@ module RuboCop
   module Cop
     module Chef
       module ChefModernize
-        # Chef Infra Client includes mixlib/shellout automatically in resources and providers.
+        # Chef Infra Client 12.4+ includes mixlib/shellout automatically in resources and providers.
         #
         # @example
         #
@@ -27,7 +27,7 @@ module RuboCop
         #   require 'mixlib/shellout'
         #
         class UnnecessaryMixlibShelloutRequire < Cop
-          MSG = 'Chef Infra Client includes mixlib/shellout automatically in resources and providers.'.freeze
+          MSG = 'Chef Infra Client 12.4+ includes mixlib/shellout automatically in resources and providers.'.freeze
 
           def_node_matcher :require_mixlibshellout?, <<-PATTERN
           (send nil? :require ( str "mixlib/shellout"))

data/lib/rubocop/cop/chef/{deprecation → redundant}/attribute_metadata.rb

@@ -18,8 +18,8 @@
 module RuboCop
   module Cop
     module Chef
-      module ChefDeprecations
-        # Don't use the deprecated 'attribute' metadata value
+      module ChefRedundantCode
+        # The attribute metadata.rb method is not used and is unnecessary in cookbooks.
         #
         # @example
         #
@@ -33,7 +33,7 @@ module RuboCop
         #              default: '"127.0.0.1:2181"'
         #
         class AttributeMetadata < Cop
-          MSG = "Don't use the deprecated 'attribute' metadata value".freeze
+          MSG = 'The attribute metadata.rb method is not used and is unnecessary in cookbooks.'.freeze
 
           def on_send(node)
             add_offense(node, location: :expression, message: MSG, severity: :refactor) if node.method_name == :attribute

data/lib/rubocop/cop/chef/{deprecation → redundant}/conflicts_metadata.rb

@@ -18,8 +18,8 @@
 module RuboCop
   module Cop
     module Chef
-      module ChefDeprecations
-        # Don't use the deprecated 'conflicts' metadata value
+      module ChefRedundantCode
+        # The conflicts metadata.rb method is not used and is unnecessary in cookbooks.
         #
         # @example
         #
@@ -28,7 +28,7 @@ module RuboCop
         #   conflicts "another_cookbook"
         #
         class ConflictsMetadata < Cop
-          MSG = "Don't use the deprecated 'conflicts' metadata value".freeze
+          MSG = 'The conflicts metadata.rb method is not used and is unnecessary in cookbooks.'.freeze
 
           def on_send(node)
             add_offense(node, location: :expression, message: MSG, severity: :refactor) if node.method_name == :conflicts

data/lib/rubocop/cop/chef/{modernize/resource_with_allowed_actions.rb → redundant/custom_resource_with_allowed_actions.rb}

@@ -18,8 +18,8 @@
 module RuboCop
   module Cop
     module Chef
-      module ChefModernize
-        # In Chef Infra Client 12.5 and later it is no longer necessary to set `actions` or `allowed_actions` as Chef Infra Client determines these automatically from the set of all actions defined in the resource.
+      module ChefRedundant
+        # It is not necessary to set `actions` or `allowed_actions` in custom resources as Chef Infra Client determines these automatically from the set of all actions defined in the resource.
         #
         # @example
         #
@@ -29,44 +29,28 @@ module RuboCop
         #   # also bad
         #   actions [:create, :remove]
         #
-        #   # don't do this either
-        #   def initialize(*args)
-        #     super
-        #     @allowed_actions = [:create, :remove]
-        #   end
-        #
         class CustomResourceWithAllowedActions < Cop
           include RangeHelp
 
-          MSG = 'Resources no longer need to define the allowed actions using the allowed_actions / actions helper methods or within an initialize method.'.freeze
+          MSG = 'It is not necessary to set `actions` or `allowed_actions` in custom resources as Chef Infra Client determines these automatically from the set of all actions defined in the resource'.freeze
 
           def_node_matcher :allowed_actions?, <<-PATTERN
             (send nil? {:allowed_actions :actions} ... )
           PATTERN
 
-          def on_send(node)
-            allowed_actions?(node) do
-              add_offense(node, location: :expression, message: MSG, severity: :refactor)
-            end
-          end
-
-          def on_def(node)
-            return unless node.method_name == :initialize
-            return if node.body.nil? # empty initialize methods
+          def_node_search :poise_require, '(send nil? :require (str "poise"))'
 
-            node.body.each_node do |x|
-              if allowed_actions_assignment?(x) || allowed_action_send?(x)
-                add_offense(x, location: :expression, message: MSG, severity: :refactor)
-              end
-            end
-          end
+          def_node_search :resource_actions?, <<-PATTERN
+            (block (send nil? :action ... ) ... )
+          PATTERN
 
-          def allowed_actions_assignment?(node)
-            node.assignment? && node.node_parts.first == :@allowed_actions
-          end
+          def on_send(node)
+            # if the resource requires poise then bail out since we're in a poise resource where @allowed_actions is legit
+            return if poise_require(processed_source.ast).any?
 
-          def allowed_action_send?(node)
-            node.send_type? && node.receiver == s(:ivar, :@allowed_actions)
+            allowed_actions?(node) do
+              add_offense(node, location: :expression, message: MSG, severity: :refactor) if resource_actions?(processed_source.ast)
+            end
           end
 
           def autocorrect(node)

data/lib/rubocop/cop/chef/{deprecation → redundant}/long_description_metadata.rb

@@ -18,8 +18,8 @@
 module RuboCop
   module Cop
     module Chef
-      module ChefDeprecations
-        # The long_description metadata.rb method is not used and is unnecessary in cookbooks
+      module ChefRedundantCode
+        # The long_description metadata.rb method is not used and is unnecessary in cookbooks.
         #
         # @example
         #
@@ -30,7 +30,7 @@ module RuboCop
         class LongDescriptionMetadata < Cop
           include RangeHelp
 
-          MSG = 'The long_description metadata.rb method is not used and is unnecessary in cookbooks'.freeze
+          MSG = 'The long_description metadata.rb method is not used and is unnecessary in cookbooks.'.freeze
 
           def on_send(node)
             add_offense(node, location: :expression, message: MSG, severity: :refactor) if node.method_name == :long_description

data/lib/rubocop/cop/chef/{correctness → redundant}/name_property_and_required.rb

@@ -17,7 +17,7 @@
 module RuboCop
   module Cop
     module Chef
-      module ChefCorrectness
+      module ChefRedundantCode
         # When using properties in a custom resource you shouldn't set a property to
         # be both required and a name_property. Name properties are a way to optionally
         # override the name given to the resource block in cookbook code. In your resource

data/lib/rubocop/cop/chef/{correctness → redundant}/property_with_default_and_required.rb

@@ -17,7 +17,7 @@
 module RuboCop
   module Cop
     module Chef
-      module ChefCorrectness
+      module ChefRedundantCode
         # When using properties in a custom resource you shouldn't set a property to
         # required and then provide a default value. If a property is required the
         # user will always pass in a value and the default will never be used. In Chef

data/lib/rubocop/cop/chef/{deprecation → redundant}/provides_metadata.rb

@@ -18,8 +18,8 @@
 module RuboCop
   module Cop
     module Chef
-      module ChefDeprecations
-        # Don't use the deprecated 'provides' metadata value
+      module ChefRedundantCode
+        # The provides metadata.rb method is not used and is unnecessary in cookbooks.
         #
         # @example
         #
@@ -28,7 +28,7 @@ module RuboCop
         #   provides "some_thing"
         #
         class ProvidesMetadata < Cop
-          MSG = "Don't use the deprecated 'provides' metadata value".freeze
+          MSG = 'The provides metadata.rb method is not used and is unnecessary in cookbooks.'.freeze
 
           def on_send(node)
             add_offense(node, location: :expression, message: MSG, severity: :refactor) if node.method_name == :provides

data/lib/rubocop/cop/chef/{deprecation → redundant}/recipe_metadata.rb

@@ -18,9 +18,8 @@
 module RuboCop
   module Cop
     module Chef
-      module ChefDeprecations
-        # The recipe metadata.rb method is not used and is unnecessary in cookbooks. Recipes should be documented
-        # in the README.md file instead.
+      module ChefRedundantCode
+        # The recipe metadata.rb method is not used and is unnecessary in cookbooks. Recipes should be documented in the cookbook's README.md file instead.
         #
         # @example
         #
@@ -29,7 +28,7 @@ module RuboCop
         #
         #
         class RecipeMetadata < Cop
-          MSG = 'The recipe metadata.rb method is not used and is unnecessary in cookbooks. Recipes should be documented in the README.md file instead.'.freeze
+          MSG = "The recipe metadata.rb method is not used and is unnecessary in cookbooks. Recipes should be documented in the cookbook's README.md file instead.".freeze
 
           def on_send(node)
             add_offense(node, location: :expression, message: MSG, severity: :refactor) if node.method_name == :recipe

data/lib/rubocop/cop/chef/{deprecation → redundant}/replaces_metadata.rb

@@ -18,8 +18,8 @@
 module RuboCop
   module Cop
     module Chef
-      module ChefDeprecations
-        # Don't use the deprecated 'replaces' metadata value
+      module ChefRedundantCode
+        # The replaces metadata.rb method is not used and is unnecessary in cookbooks. Replacements for existing cookbooks should be documented in the cookbook's README.md file instead.
         #
         # @example
         #
@@ -28,7 +28,7 @@ module RuboCop
         #   replaces "another_cookbook"
         #
         class ReplacesMetadata < Cop
-          MSG = "Don't use the deprecated 'replaces' metadata value".freeze
+          MSG = 'The replaces metadata.rb method is not used and is unnecessary in cookbooks.'.freeze
 
           def on_send(node)
             add_offense(node, location: :expression, message: MSG, severity: :refactor) if node.method_name == :replaces

data/lib/rubocop/cop/chef/{correctness → redundant}/resource_with_nothing_action.rb

@@ -17,7 +17,7 @@
 module RuboCop
   module Cop
     module Chef
-      module ChefCorrectness
+      module ChefRedundantCode
         # Chef Infra Client provides the :nothing action by default for every resource. There is no need to define a :nothing action in your resource code.
         #
         # @example

data/lib/rubocop/cop/chef/{deprecation → redundant}/suggests_metadata.rb

@@ -18,8 +18,8 @@
 module RuboCop
   module Cop
     module Chef
-      module ChefDeprecations
-        # Don't use the deprecated 'suggests' metadata value
+      module ChefRedundantCode
+        # The suggests metadata.rb method is not used and is unnecessary in cookbooks.
         #
         # @example
         #
@@ -28,7 +28,7 @@ module RuboCop
         #   suggests "another_cookbook"
         #
         class SuggestsMetadata < Cop
-          MSG = "Don't use the deprecated 'suggests' metadata value".freeze
+          MSG = 'The suggests metadata.rb method is not used and is unnecessary in cookbooks.'.freeze
 
           def on_send(node)
             add_offense(node, location: :expression, message: MSG, severity: :refactor) if node.method_name == :suggests

data/lib/rubocop/cop/chef/{correctness → redundant}/unnecessary_name_property.rb

@@ -17,7 +17,7 @@
 module RuboCop
   module Cop
     module Chef
-      module ChefCorrectness
+      module ChefRedundantCode
         # There is no need to define a property named :name in a resource as Chef Infra defines that property for all resources by default.
         #
         # @example

data/lib/rubocop/cop/chef/{correctness → sharing}/default_maintainer_metadata.rb

@@ -18,7 +18,7 @@
 module RuboCop
   module Cop
     module Chef
-      module ChefCorrectness
+      module ChefSharing
         # Metadata contains default maintainer information from the `chef generate cookbook` command. This should be updated to reflect that actual maintainer of the cookbook.
         #
         # @example

data/lib/rubocop/cop/chef/{correctness → sharing}/empty_metadata_field.rb

@@ -18,7 +18,7 @@
 module RuboCop
   module Cop
     module Chef
-      module ChefCorrectness
+      module ChefSharing
         # metadata.rb should not include fields with an empty string. Either don't include the field or add a value.
         #
         # @example

data/lib/rubocop/cop/chef/{correctness → sharing}/insecure_cookbook_url.rb

@@ -17,7 +17,7 @@
 module RuboCop
   module Cop
     module Chef
-      module ChefCorrectness
+      module ChefSharing
         # Use secure Github and Gitlab URLs for source_url and issues_url
         #
         # @example

data/lib/rubocop/cop/chef/{correctness → sharing}/invalid_license_string.rb

@@ -18,7 +18,7 @@
 module RuboCop
   module Cop
     module Chef
-      module ChefCorrectness
+      module ChefSharing
         # metadata.rb license field should include a SPDX compliant string or "all right reserved" (not case sensitive)
         #
         # @example

metadata

@@ -1,7 +1,7 @@
 --- !ruby/object:Gem::Specification
 name: cookstyle
 version: !ruby/object:Gem::Version
-  version: 5.14.1
+  version: 5.15.7
 platform: ruby
 authors:
 - Thom May
@@ -9,7 +9,7 @@ authors:
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2019-12-06 00:00:00.000000000 Z
+date: 2019-12-11 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: rubocop
@@ -47,32 +47,27 @@ files:
 - lib/rubocop/chef.rb
 - lib/rubocop/chef/cookbook_helpers.rb
 - lib/rubocop/chef/cookbook_only.rb
+- lib/rubocop/chef/platform_helpers.rb
 - lib/rubocop/cop/chef/correctness/block_guard_clause_string_only.rb
 - lib/rubocop/cop/chef/correctness/cb_depends_on_self.rb
-- lib/rubocop/cop/chef/correctness/default_maintainer_metadata.rb
-- lib/rubocop/cop/chef/correctness/empty_metadata_field.rb
 - lib/rubocop/cop/chef/correctness/incorrect_library_injection.rb
-- lib/rubocop/cop/chef/correctness/insecure_cookbook_url.rb
-- lib/rubocop/cop/chef/correctness/invalid_license_string.rb
+- lib/rubocop/cop/chef/correctness/invalid_platform_family_helper.rb
+- lib/rubocop/cop/chef/correctness/invalid_platform_helper.rb
 - lib/rubocop/cop/chef/correctness/invalid_platform_metadata.rb
+- lib/rubocop/cop/chef/correctness/invalid_value_for_platform_family_helper.rb
+- lib/rubocop/cop/chef/correctness/invalid_value_for_platform_helper.rb
 - lib/rubocop/cop/chef/correctness/invalid_version_metadata.rb
 - lib/rubocop/cop/chef/correctness/metadata_missing_name.rb
-- lib/rubocop/cop/chef/correctness/name_property_and_required.rb
 - lib/rubocop/cop/chef/correctness/node_normal.rb
 - lib/rubocop/cop/chef/correctness/node_normal_unless.rb
 - lib/rubocop/cop/chef/correctness/node_save.rb
 - lib/rubocop/cop/chef/correctness/notifies_action_not_symbol.rb
-- lib/rubocop/cop/chef/correctness/ohai_default_recipe.rb
-- lib/rubocop/cop/chef/correctness/property_with_default_and_required.rb
-- lib/rubocop/cop/chef/correctness/property_with_name_attribute.rb
 - lib/rubocop/cop/chef/correctness/resource_sets_internal_properties.rb
 - lib/rubocop/cop/chef/correctness/resource_sets_name_property.rb
 - lib/rubocop/cop/chef/correctness/resource_with_none_action.rb
-- lib/rubocop/cop/chef/correctness/resource_with_nothing_action.rb
+- lib/rubocop/cop/chef/correctness/scoped_file_exist.rb
 - lib/rubocop/cop/chef/correctness/service_resource.rb
 - lib/rubocop/cop/chef/correctness/tmp_path.rb
-- lib/rubocop/cop/chef/correctness/unnecessary_name_property.rb
-- lib/rubocop/cop/chef/deprecation/attribute_metadata.rb
 - lib/rubocop/cop/chef/deprecation/chef_handler_supports.rb
 - lib/rubocop/cop/chef/deprecation/chef_rest.rb
 - lib/rubocop/cop/chef/deprecation/chef_rewind.rb
@@ -80,7 +75,6 @@ files:
 - lib/rubocop/cop/chef/deprecation/chefspec_coverage_report.rb
 - lib/rubocop/cop/chef/deprecation/chefspec_legacy_runner.rb
 - lib/rubocop/cop/chef/deprecation/chocolatey_package_uninstall_action.rb
-- lib/rubocop/cop/chef/deprecation/conflicts_metadata.rb
 - lib/rubocop/cop/chef/deprecation/depends_compat_resource.rb
 - lib/rubocop/cop/chef/deprecation/depends_partial_search.rb
 - lib/rubocop/cop/chef/deprecation/depends_poise.rb
@@ -95,7 +89,6 @@ files:
 - lib/rubocop/cop/chef/deprecation/legacy_notify_syntax.rb
 - lib/rubocop/cop/chef/deprecation/legacy_yum_cookbook_recipes.rb
 - lib/rubocop/cop/chef/deprecation/locale_lc_all_property.rb
-- lib/rubocop/cop/chef/deprecation/long_description_metadata.rb
 - lib/rubocop/cop/chef/deprecation/name_property_and_default.rb
 - lib/rubocop/cop/chef/deprecation/node_deep_fetch.rb
 - lib/rubocop/cop/chef/deprecation/node_methods_not_attributes.rb
@@ -105,9 +98,6 @@ files:
 - lib/rubocop/cop/chef/deprecation/partial_search_class_usage.rb
 - lib/rubocop/cop/chef/deprecation/partial_search_helper_usage.rb
 - lib/rubocop/cop/chef/deprecation/poise_archive.rb
-- lib/rubocop/cop/chef/deprecation/provides_metadata.rb
-- lib/rubocop/cop/chef/deprecation/recipe_metadata.rb
-- lib/rubocop/cop/chef/deprecation/replaces_metadata.rb
 - lib/rubocop/cop/chef/deprecation/require_recipe.rb
 - lib/rubocop/cop/chef/deprecation/resource_overrides_provides_method.rb
 - lib/rubocop/cop/chef/deprecation/resource_uses_dsl_name_method.rb
@@ -115,7 +105,6 @@ files:
 - lib/rubocop/cop/chef/deprecation/resource_uses_updated_method.rb
 - lib/rubocop/cop/chef/deprecation/run_command_helper.rb
 - lib/rubocop/cop/chef/deprecation/search_uses_positional_parameters.rb
-- lib/rubocop/cop/chef/deprecation/suggests_metadata.rb
 - lib/rubocop/cop/chef/deprecation/use_inline_resources.rb
 - lib/rubocop/cop/chef/deprecation/user_supports_property.rb
 - lib/rubocop/cop/chef/deprecation/verify_property_file_expansion.rb
@@ -129,6 +118,7 @@ files:
 - lib/rubocop/cop/chef/effortless/node_roles.rb
 - lib/rubocop/cop/chef/effortless/search_for_environments_or_roles.rb
 - lib/rubocop/cop/chef/effortless/search_used.rb
+- lib/rubocop/cop/chef/modernize/allowed_actions_initializer.rb
 - lib/rubocop/cop/chef/modernize/apt_default_recipe.rb
 - lib/rubocop/cop/chef/modernize/berksfile_source.rb
 - lib/rubocop/cop/chef/modernize/build_essential.rb
@@ -147,6 +137,7 @@ files:
 - lib/rubocop/cop/chef/modernize/libarchive_file.rb
 - lib/rubocop/cop/chef/modernize/macos_user_defaults.rb
 - lib/rubocop/cop/chef/modernize/minitest_handler_usage.rb
+- lib/rubocop/cop/chef/modernize/ohai_default_recipe.rb
 - lib/rubocop/cop/chef/modernize/openssl_rsa_key_resource.rb
 - lib/rubocop/cop/chef/modernize/openssl_x509_resource.rb
 - lib/rubocop/cop/chef/modernize/osx_config_profile_resource.rb
@@ -154,9 +145,9 @@ files:
 - lib/rubocop/cop/chef/modernize/powershell_guard_interpreter.rb
 - lib/rubocop/cop/chef/modernize/powershell_install_package.rb
 - lib/rubocop/cop/chef/modernize/powershell_install_windowsfeature.rb
+- lib/rubocop/cop/chef/modernize/property_with_name_attribute.rb
 - lib/rubocop/cop/chef/modernize/resource_name_initializer.rb
 - lib/rubocop/cop/chef/modernize/resource_set_or_return.rb
-- lib/rubocop/cop/chef/modernize/resource_with_allowed_actions.rb
 - lib/rubocop/cop/chef/modernize/resource_with_attributes.rb
 - lib/rubocop/cop/chef/modernize/respond_to_metadata.rb
 - lib/rubocop/cop/chef/modernize/respond_to_provides.rb
@@ -171,6 +162,22 @@ files:
 - lib/rubocop/cop/chef/modernize/windows_zipfile.rb
 - lib/rubocop/cop/chef/modernize/zipfile_resource.rb
 - lib/rubocop/cop/chef/modernize/zypper_repo.rb
+- lib/rubocop/cop/chef/redundant/attribute_metadata.rb
+- lib/rubocop/cop/chef/redundant/conflicts_metadata.rb
+- lib/rubocop/cop/chef/redundant/custom_resource_with_allowed_actions.rb
+- lib/rubocop/cop/chef/redundant/long_description_metadata.rb
+- lib/rubocop/cop/chef/redundant/name_property_and_required.rb
+- lib/rubocop/cop/chef/redundant/property_with_default_and_required.rb
+- lib/rubocop/cop/chef/redundant/provides_metadata.rb
+- lib/rubocop/cop/chef/redundant/recipe_metadata.rb
+- lib/rubocop/cop/chef/redundant/replaces_metadata.rb
+- lib/rubocop/cop/chef/redundant/resource_with_nothing_action.rb
+- lib/rubocop/cop/chef/redundant/suggests_metadata.rb
+- lib/rubocop/cop/chef/redundant/unnecessary_name_property.rb
+- lib/rubocop/cop/chef/sharing/default_maintainer_metadata.rb
+- lib/rubocop/cop/chef/sharing/empty_metadata_field.rb
+- lib/rubocop/cop/chef/sharing/insecure_cookbook_url.rb
+- lib/rubocop/cop/chef/sharing/invalid_license_string.rb
 - lib/rubocop/cop/chef/style/attribute_keys.rb
 - lib/rubocop/cop/chef/style/comment_sentence_spacing.rb
 - lib/rubocop/cop/chef/style/comments_copyright_format.rb
@@ -181,10 +188,15 @@ files:
 - lib/rubocop/cop/chef/style/use_platform_helpers.rb
 - lib/rubocop/monkey_patches/comment_config.rb
 - lib/rubocop/monkey_patches/json_formatter.rb
-homepage: https://github.com/chef/cookstyle
+homepage: 
 licenses:
 - Apache-2.0
-metadata: {}
+metadata:
+  homepage_uri: https://github.com/chef/cookstyle
+  changelog_uri: https://github.com/chef/cookstyle/blob/master/CHANGELOG.md
+  source_code_uri: https://github.com/chef/cookstyle
+  documentation_uri: https://docs.chef.io/cookstyle.html
+  bug_tracker_uri: https://github.com/chef/cookstyle/issues
 post_install_message: 
 rdoc_options: []
 require_paths: