cookstyle 5.0.0 → 5.0.4

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: 800b435721c1606cb6a2e5dc3dc23b5115e6458d33b926d2fe97814f5380cf3e
-  data.tar.gz: 2f5562bf2a8b921dadde7f99729c3f9f4507bdc6625d564193e6c743b7c72e16
+  metadata.gz: 7cbe0d726d24711da59599a15be6d1a6b9904245cb68ad17aa07f390bbad1537
+  data.tar.gz: ec624080babc3e2f6295ed610c6700e69d5fae4a383696638d0344ee1e5eaf86
 SHA512:
-  metadata.gz: 01d8e5baf238a0591b5561ab6bb944781ab7dcc1fa0b9b1eff85df7128c05cd235abb36a7d9086a37152487841bd838c7724c131d24e04b7cf8559e424bc2292
-  data.tar.gz: f2911a20dc0b941da2ce8491fdf1ffedc816bb71f9a55f84a8a4f6dd16a7579b279f9e0d12c951f86ee507e2966ec54233a1eb27d637041257f3c8fa0924fe8b
+  metadata.gz: 5dac69031554a13e6f8df40ebb38dd816c3f7fd87dc32020d5387af42374066433704ac95db00f692ce1dc1970d2b4b11061fb1ea34a6ec2be459486626c25ec
+  data.tar.gz: 2b6f78c5b4859c6fe62f588725da64b40b12c08184a8ca8ce45bac215c771c744ae3ee5c99171a65e05e10177f1e188d0b457067ef1af5964039b333fddeff9f

data/config/cookstyle.yml

@@ -38,7 +38,7 @@ Chef/FileMode:
   Enabled: true
 
 Chef/ServiceResource:
-  Description: Use a service resource to start and stop services
+  Description: Use a service resource to start and stop services instead of execute resources
   Enabled: true
 
 Chef/CopyrightCommentFormat:
@@ -49,6 +49,14 @@ Chef/CommentFormat:
   Description: Use Chef's unique format for comment headers
   Enabled: true
 
+Chef/NodeSet:
+  Description: Do not use the deprecated node.set method
+  Enabled: true
+
+Chef/TmpPath:
+  Description: Use file_cache_path rather than hard-coding tmp paths
+  Enabled: true
+
 #### The base rubocop 0.37 enabled.yml file we started with ####
 
 Layout/AccessModifierIndentation:

data/lib/cookstyle.rb

@@ -34,9 +34,7 @@ require 'rubocop/chef'
 require 'rubocop/chef/cookbook_only'
 
 # Chef specific cops
-require 'rubocop/cop/chef/attribute_keys'
-require 'rubocop/cop/chef/file_mode'
-require 'rubocop/cop/chef/service_resource'
-require 'rubocop/cop/chef/comments_format'
-require 'rubocop/cop/chef/comments_copyright_format'
-require 'rubocop/cop/chef/tmp_path'
+Dir.glob(File.dirname(__FILE__) + '/rubocop/cop/chef/**/*.rb') do |file|
+  next if File.directory?(file)
+  require_relative file # not actually relative but require_relative is faster
+end

data/lib/cookstyle/version.rb

@@ -1,4 +1,4 @@
 module Cookstyle
-  VERSION = '5.0.0'.freeze
+  VERSION = "5.0.4".freeze # rubocop: disable Style/StringLiterals
   RUBOCOP_VERSION = '0.72.0'.freeze
 end

data/lib/rubocop/cop/chef/file_mode.rb

@@ -32,7 +32,7 @@ module RuboCop
         MSG = 'Use strings for file modes'.freeze
 
         def_node_matcher :resource_mode?, <<-PATTERN
-          (send nil :mode $int)
+          (send nil? :mode $int)
         PATTERN
 
         def on_send(node)

data/lib/rubocop/cop/chef/node_set.rb

@@ -0,0 +1,53 @@
+#
+# Copyright:: Copyright 2019-2019, Chef Software Inc.
+#
+# Licensed under the Apache License, Version 2.0 (the "License");
+# you may not use this file except in compliance with the License.
+# You may obtain a copy of the License at
+#
+# http://www.apache.org/licenses/LICENSE-2.0
+#
+# Unless required by applicable law or agreed to in writing, software
+# distributed under the License is distributed on an "AS IS" BASIS,
+# WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+# See the License for the specific language governing permissions and
+# limitations under the License.
+#
+module RuboCop
+  module Cop
+    module Chef
+      # The node.set method has been removed in Chef-13 and must be replaced by node.normal.
+      #
+      # Note that node.normal keeps the semantics identical, but the use of node.normal is
+      # also discouraged.
+      #
+      # @example
+      #
+      #   # bad
+      #   node.set['foo'] = true
+      #
+      #   # good
+      #   node.normal['foo'] = true
+      #
+      class NodeSet < Cop
+        MSG = 'Do not use node.set. Replace with node.normal to keep identical behavior.'.freeze
+
+        def_node_matcher :node_set?, <<-PATTERN
+          (send (send _ :node) :set)
+        PATTERN
+
+        def on_send(node)
+          node_set?(node) do
+            add_offense(node, location: :expression, message: MSG, severity: :warning)
+          end
+        end
+
+        def autocorrect(node)
+          lambda do |corrector|
+            corrector.replace(node.loc.expression, 'node.normal')
+          end
+        end
+      end
+    end
+  end
+end

data/lib/rubocop/cop/chef/service_resource.rb

@@ -29,7 +29,7 @@ module RuboCop
         MSG = 'Use a service resource to start and stop services'.freeze
 
         def_node_matcher :execute_command?, <<-PATTERN
-          (send nil :command $str)
+          (send nil? :command $str)
         PATTERN
 
         def on_send(node)

data/lib/rubocop/cop/chef/tmp_path.rb

@@ -32,7 +32,7 @@ module RuboCop
         MSG = 'Use file_cache_path rather than hard-coding tmp paths'.freeze
 
         def_node_matcher :remote_file?, <<-PATTERN
-          (send nil :remote_file $str)
+          (send nil? :remote_file $str)
         PATTERN
 
         def on_send(node)

metadata

@@ -1,7 +1,7 @@
 --- !ruby/object:Gem::Specification
 name: cookstyle
 version: !ruby/object:Gem::Version
-  version: 5.0.0
+  version: 5.0.4
 platform: ruby
 authors:
 - Thom May
@@ -9,7 +9,7 @@ authors:
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2019-07-02 00:00:00.000000000 Z
+date: 2019-07-15 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: rake
@@ -78,6 +78,7 @@ files:
 - lib/rubocop/cop/chef/comments_copyright_format.rb
 - lib/rubocop/cop/chef/comments_format.rb
 - lib/rubocop/cop/chef/file_mode.rb
+- lib/rubocop/cop/chef/node_set.rb
 - lib/rubocop/cop/chef/service_resource.rb
 - lib/rubocop/cop/chef/tmp_path.rb
 homepage: https://github.com/chef/cookstyle