cookstyle 4.0.0 → 5.0.0

This diff represents the content of publicly available package versions that have been released to one of the supported registries. The information contained in this diff is provided for informational purposes only and reflects changes between package versions as they appear in their respective public registries.
Files changed (17) hide show
  1. checksums.yaml +4 -4
  2. data/config/cookstyle.yml +49 -55
  3. data/config/disable_all.yml +64 -152
  4. data/config/upstream.yml +310 -728
  5. data/lib/cookstyle.rb +15 -2
  6. data/lib/cookstyle/version.rb +2 -2
  7. data/lib/rubocop/chef.rb +10 -0
  8. data/lib/rubocop/chef/cookbook_only.rb +75 -0
  9. data/lib/rubocop/cop/chef/attribute_keys.rb +92 -0
  10. data/lib/rubocop/cop/chef/comments_copyright_format.rb +99 -0
  11. data/lib/rubocop/cop/chef/comments_format.rb +75 -0
  12. data/lib/rubocop/cop/chef/file_mode.rb +63 -0
  13. data/lib/rubocop/cop/chef/service_resource.rb +53 -0
  14. data/lib/rubocop/cop/chef/tmp_path.rb +58 -0
  15. metadata +13 -8
  16. data/config/disabled.yml +0 -128
  17. data/config/enabled.yml +0 -2068
checksums.yaml CHANGED
@@ -1,7 +1,7 @@
1
1
  ---
2
2
  SHA256:
3
- metadata.gz: 81d2f149595e089024c831b1718b064eea9fde55e06f232379d8a25d8b621dc1
4
- data.tar.gz: 623b3a00164fc4fa19d90633dbb1b0327985c9c61a1b2768fe17deff77b9996d
3
+ metadata.gz: 800b435721c1606cb6a2e5dc3dc23b5115e6458d33b926d2fe97814f5380cf3e
4
+ data.tar.gz: 2f5562bf2a8b921dadde7f99729c3f9f4507bdc6625d564193e6c743b7c72e16
5
5
  SHA512:
6
- metadata.gz: 6ab3d6a69360effc8f8becea1ffb11fa6fd0a9cbf3259a3221501258a1166d881092eaf557a002a461e7962c8344935799cb6f06e41281ffdb48ceb88b61a9a0
7
- data.tar.gz: bdcc8700555d467231d3226148071cdb73a5de2a5247b7810b7f597116909aa01f170dfcb6b314e2b033b5d50301355df8acfcac0467f5e44fc99930ab645948
6
+ metadata.gz: 01d8e5baf238a0591b5561ab6bb944781ab7dcc1fa0b9b1eff85df7128c05cd235abb36a7d9086a37152487841bd838c7724c131d24e04b7cf8559e424bc2292
7
+ data.tar.gz: f2911a20dc0b941da2ce8491fdf1ffedc816bb71f9a55f84a8a4f6dd16a7579b279f9e0d12c951f86ee507e2966ec54233a1eb27d637041257f3c8fa0924fe8b
data/config/cookstyle.yml CHANGED
@@ -3,6 +3,51 @@ AllCops:
3
3
  Exclude:
4
4
  - vendor/**/*
5
5
  - Guardfile
6
+ ChefAttributes:
7
+ Patterns:
8
+ - attributes/.*\.rb
9
+ ChefDefinitions:
10
+ Patterns:
11
+ - definitions/.*\.rb
12
+ ChefLibraries:
13
+ Patterns:
14
+ - libraries/.*\.rb
15
+ ChefMetadata:
16
+ Patterns:
17
+ - metadata\.rb
18
+ ChefProviders:
19
+ Patterns:
20
+ - providers/.*\.rb
21
+ ChefRecipes:
22
+ Patterns:
23
+ - recipes/.*\.rb
24
+ ChefResources:
25
+ Patterns:
26
+ - resources/.*\.rb
27
+
28
+ Chef/AttributeKeys:
29
+ Description: Check which style of keys are used to access node attributes.
30
+ Enabled: true
31
+ EnforcedStyle: strings
32
+ SupportedStyles:
33
+ - strings
34
+ - symbols
35
+
36
+ Chef/FileMode:
37
+ Description: Use strings to represent file modes in Chef resources
38
+ Enabled: true
39
+
40
+ Chef/ServiceResource:
41
+ Description: Use a service resource to start and stop services
42
+ Enabled: true
43
+
44
+ Chef/CopyrightCommentFormat:
45
+ Description: Properly format copyright dates in comment blocks and ensure dates are up to date
46
+ Enabled: false
47
+
48
+ Chef/CommentFormat:
49
+ Description: Use Chef's unique format for comment headers
50
+ Enabled: true
6
51
 
7
52
  #### The base rubocop 0.37 enabled.yml file we started with ####
8
53
 
@@ -96,13 +141,11 @@ Style/EvenOdd:
96
141
  Enabled: true
97
142
  Layout/ExtraSpacing:
98
143
  Enabled: true
99
- Style/FrozenStringLiteralComment:
100
- Enabled: true
101
144
  Layout/InitialIndentation:
102
145
  Enabled: true
103
146
  Layout/FirstParameterIndentation:
104
147
  Enabled: true
105
- Style/FlipFlop:
148
+ Lint/FlipFlop:
106
149
  Enabled: true
107
150
  Style/For:
108
151
  Enabled: true
@@ -110,8 +153,6 @@ Style/FormatString:
110
153
  Enabled: true
111
154
  Style/GlobalVars:
112
155
  Enabled: true
113
- Style/GuardClause:
114
- Enabled: true
115
156
  Style/HashSyntax:
116
157
  Enabled: true
117
158
  Style/IfInsideElse:
@@ -190,8 +231,6 @@ Style/ParallelAssignment:
190
231
  Enabled: true
191
232
  Style/ParenthesesAroundCondition:
192
233
  Enabled: true
193
- Style/PercentLiteralDelimiters:
194
- Enabled: true
195
234
  Style/PercentQLiterals:
196
235
  Enabled: true
197
236
  Style/PerlBackrefs:
@@ -278,8 +317,6 @@ Style/StructInheritance:
278
317
  Enabled: true
279
318
  Style/SymbolLiteral:
280
319
  Enabled: true
281
- Style/SymbolProc:
282
- Enabled: true
283
320
  Layout/Tab:
284
321
  Enabled: true
285
322
  Layout/TrailingBlankLines:
@@ -410,47 +447,6 @@ Lint/UselessSetterCall:
410
447
  Enabled: true
411
448
  Lint/Void:
412
449
  Enabled: true
413
- Performance/Casecmp:
414
- Enabled: true
415
- Performance/CaseWhenSplat:
416
- Enabled: true
417
- Performance/Count:
418
- Enabled: true
419
- Performance/Detect:
420
- Enabled: true
421
- Performance/DoubleStartEndWith:
422
- Enabled: true
423
- Performance/EndWith:
424
- Enabled: true
425
- Performance/FixedSize:
426
- Enabled: true
427
- Performance/FlatMap:
428
- Enabled: true
429
- EnabledForFlattenWithoutParams: false
430
- Performance/LstripRstrip:
431
- Enabled: true
432
- Performance/RangeInclude:
433
- Enabled: true
434
- Performance/RedundantBlockCall:
435
- Enabled: true
436
- Performance/RedundantMatch:
437
- Enabled: true
438
- Performance/RedundantMerge:
439
- Enabled: true
440
- Performance/RedundantSortBy:
441
- Enabled: true
442
- Performance/ReverseEach:
443
- Enabled: true
444
- Performance/Sample:
445
- Enabled: true
446
- Performance/Size:
447
- Enabled: true
448
- Performance/StartWith:
449
- Enabled: true
450
- Performance/StringReplacement:
451
- Enabled: true
452
- Performance/TimesMap:
453
- Enabled: true
454
450
 
455
451
  ##### Additional rules we enable/disable over the rubocop 0.37 rules ago #####
456
452
 
@@ -574,7 +570,8 @@ Style/FrozenStringLiteralComment:
574
570
 
575
571
  # maintain the previous array behavior in previous cookstyle releases
576
572
  Style/PercentLiteralDelimiters:
577
- PreferredDelimiters:
573
+ Enabled: true
574
+ PreferredDelimiters:
578
575
  '%': ()
579
576
  '%i': ()
580
577
  '%I': ()
@@ -673,11 +670,8 @@ Lint/UnneededCopEnableDirective:
673
670
  Style/UnpackFirst:
674
671
  Enabled: true
675
672
 
676
- # simplify how you get the min or max of an array
677
- Performance/UnneededSort:
678
- Enable: true
679
-
680
673
  Style/SymbolProc:
674
+ Enabled: true
681
675
  # A list of method names to be ignored by the check.
682
676
  # The names should be fairly unique, otherwise you'll end up ignoring lots of code.
683
677
  IgnoredMethods:
data/config/disable_all.yml CHANGED
@@ -1,6 +1,8 @@
1
1
  ---
2
2
  Bundler/DuplicatedGem:
3
3
  Enabled: false
4
+ Bundler/GemComment:
5
+ Enabled: false
4
6
  Bundler/InsecureProtocolSource:
5
7
  Enabled: false
6
8
  Bundler/OrderedGems:
@@ -11,8 +13,12 @@ Gemspec/OrderedDependencies:
11
13
  Enabled: false
12
14
  Gemspec/RequiredRubyVersion:
13
15
  Enabled: false
16
+ Gemspec/RubyVersionGlobalsUsage:
17
+ Enabled: false
14
18
  Layout/AccessModifierIndentation:
15
19
  Enabled: false
20
+ Layout/AlignArguments:
21
+ Enabled: false
16
22
  Layout/AlignArray:
17
23
  Enabled: false
18
24
  Layout/AlignHash:
@@ -27,6 +33,8 @@ Layout/CaseIndentation:
27
33
  Enabled: false
28
34
  Layout/ClassStructure:
29
35
  Enabled: false
36
+ Layout/ClosingHeredocIndentation:
37
+ Enabled: false
30
38
  Layout/ClosingParenthesisIndentation:
31
39
  Enabled: false
32
40
  Layout/CommentIndentation:
@@ -41,6 +49,8 @@ Layout/ElseAlignment:
41
49
  Enabled: false
42
50
  Layout/EmptyComment:
43
51
  Enabled: false
52
+ Layout/EmptyLineAfterGuardClause:
53
+ Enabled: false
44
54
  Layout/EmptyLineAfterMagicComment:
45
55
  Enabled: false
46
56
  Layout/EmptyLineBetweenDefs:
@@ -77,9 +87,7 @@ Layout/FirstMethodArgumentLineBreak:
77
87
  Enabled: false
78
88
  Layout/FirstMethodParameterLineBreak:
79
89
  Enabled: false
80
- Layout/FirstParameterIndentation:
81
- Enabled: false
82
- Layout/IndentArray:
90
+ Layout/HeredocArgumentClosingParenthesis:
83
91
  Enabled: false
84
92
  Layout/IndentAssignment:
85
93
  Enabled: false
@@ -87,22 +95,36 @@ Layout/IndentationConsistency:
87
95
  Enabled: false
88
96
  Layout/IndentationWidth:
89
97
  Enabled: false
90
- Layout/IndentHash:
98
+ Layout/IndentFirstArgument:
99
+ Enabled: false
100
+ Layout/IndentFirstArrayElement:
101
+ Enabled: false
102
+ Layout/IndentFirstHashElement:
103
+ Enabled: false
104
+ Layout/IndentFirstParameter:
91
105
  Enabled: false
92
106
  Layout/IndentHeredoc:
93
107
  Enabled: false
94
108
  Layout/InitialIndentation:
95
109
  Enabled: false
110
+ Layout/LeadingBlankLines:
111
+ Enabled: false
96
112
  Layout/LeadingCommentSpace:
97
113
  Enabled: false
98
114
  Layout/MultilineArrayBraceLayout:
99
115
  Enabled: false
116
+ Layout/MultilineArrayLineBreaks:
117
+ Enabled: false
100
118
  Layout/MultilineAssignmentLayout:
101
119
  Enabled: false
102
120
  Layout/MultilineBlockLayout:
103
121
  Enabled: false
104
122
  Layout/MultilineHashBraceLayout:
105
123
  Enabled: false
124
+ Layout/MultilineHashKeyLineBreaks:
125
+ Enabled: false
126
+ Layout/MultilineMethodArgumentLineBreaks:
127
+ Enabled: false
106
128
  Layout/MultilineMethodCallBraceLayout:
107
129
  Enabled: false
108
130
  Layout/MultilineMethodCallIndentation:
@@ -185,6 +207,8 @@ Lint/Debugger:
185
207
  Enabled: false
186
208
  Lint/DeprecatedClassMethods:
187
209
  Enabled: false
210
+ Lint/DisjunctiveAssignmentInConstructor:
211
+ Enabled: false
188
212
  Lint/DuplicateCaseCondition:
189
213
  Enabled: false
190
214
  Lint/DuplicateMethods:
@@ -207,12 +231,18 @@ Lint/EndInMethod:
207
231
  Enabled: false
208
232
  Lint/EnsureReturn:
209
233
  Enabled: false
234
+ Lint/ErbNewArguments:
235
+ Enabled: false
236
+ Lint/FlipFlop:
237
+ Enabled: false
210
238
  Lint/FloatOutOfRange:
211
239
  Enabled: false
212
240
  Lint/FormatParameterMismatch:
213
241
  Enabled: false
214
242
  Lint/HandleExceptions:
215
243
  Enabled: false
244
+ Lint/HeredocMethodCallPosition:
245
+ Enabled: false
216
246
  Lint/ImplicitStringConcatenation:
217
247
  Enabled: false
218
248
  Lint/InheritException:
@@ -269,6 +299,8 @@ Lint/SafeNavigationConsistency:
269
299
  Enabled: false
270
300
  Lint/SafeNavigationChain:
271
301
  Enabled: false
302
+ Lint/SafeNavigationWithEmpty:
303
+ Enabled: false
272
304
  Lint/ScriptPermission:
273
305
  Enabled: false
274
306
  Lint/ShadowedArgument:
@@ -281,6 +313,8 @@ Lint/StringConversionInInterpolation:
281
313
  Enabled: false
282
314
  Lint/Syntax:
283
315
  Enabled: false
316
+ Lint/ToJSON:
317
+ Enabled: false
284
318
  Lint/UnderscorePrefixedVariableName:
285
319
  Enabled: false
286
320
  Lint/UnifiedInteger:
@@ -357,6 +391,8 @@ Naming/BinaryOperatorParameterName:
357
391
  Enabled: false
358
392
  Naming/PredicateName:
359
393
  Enabled: false
394
+ Naming/RescuedExceptionsVariableName:
395
+ Enabled: false
360
396
  Naming/UncommunicativeBlockParamName:
361
397
  Enabled: false
362
398
  Naming/UncommunicativeMethodParamName:
@@ -365,57 +401,7 @@ Naming/VariableName:
365
401
  Enabled: false
366
402
  Naming/VariableNumber:
367
403
  Enabled: false
368
- Performance/Caller:
369
- Enabled: false
370
- Performance/CaseWhenSplat:
371
- Enabled: false
372
- Performance/Casecmp:
373
- Enabled: false
374
- Performance/Count:
375
- Enabled: false
376
- Performance/Detect:
377
- Enabled: false
378
- Performance/DoubleStartEndWith:
379
- Enabled: false
380
- Performance/EndWith:
381
- Enabled: false
382
- Performance/FixedSize:
383
- Enabled: false
384
- Performance/FlatMap:
385
- Enabled: false
386
- Performance/LstripRstrip:
387
- Enabled: false
388
- Performance/RangeInclude:
389
- Enabled: false
390
- Performance/RedundantBlockCall:
391
- Enabled: false
392
- Performance/RedundantMatch:
393
- Enabled: false
394
- Performance/RedundantMerge:
395
- Enabled: false
396
- Performance/RedundantSortBy:
397
- Enabled: false
398
- Performance/RegexpMatch:
399
- Enabled: false
400
- Performance/ReverseEach:
401
- Enabled: false
402
- Performance/Sample:
403
- Enabled: false
404
- Performance/Size:
405
- Enabled: false
406
- Performance/CompareWithBlock:
407
- Enabled: false
408
- Performance/StartWith:
409
- Enabled: false
410
- Performance/StringReplacement:
411
- Enabled: false
412
- Performance/TimesMap:
413
- Enabled: false
414
- Performance/UnfreezeString:
415
- Enabled: false
416
- Performance/UnneededSort:
417
- Enabled: false
418
- Performance/UriDefaultParser:
404
+ Style/AccessModifierDeclarations:
419
405
  Enabled: false
420
406
  Style/Alias:
421
407
  Enabled: false
@@ -465,6 +451,8 @@ Style/CommentedKeyword:
465
451
  Enabled: false
466
452
  Style/ConditionalAssignment:
467
453
  Enabled: false
454
+ Style/ConstantVisibility:
455
+ Enabled: false
468
456
  Style/Copyright:
469
457
  Enabled: false
470
458
  Style/DateTime:
@@ -491,8 +479,6 @@ Style/EmptyElse:
491
479
  Enabled: false
492
480
  Style/EmptyLambdaParameter:
493
481
  Enabled: false
494
- Layout/EmptyLineAfterGuardClause:
495
- Enabled: false
496
482
  Style/EmptyLiteral:
497
483
  Enabled: false
498
484
  Style/EmptyMethod:
@@ -507,7 +493,7 @@ Style/EvenOdd:
507
493
  Enabled: false
508
494
  Style/ExpandPathArguments:
509
495
  Enabled: false
510
- Style/FlipFlop:
496
+ Style/FloatDivision:
511
497
  Enabled: false
512
498
  Style/For:
513
499
  Enabled: false
@@ -541,6 +527,8 @@ Style/InverseMethods:
541
527
  Enabled: false
542
528
  Style/InlineComment:
543
529
  Enabled: false
530
+ Style/IpAddresses:
531
+ Enabled: false
544
532
  Style/Lambda:
545
533
  Enabled: false
546
534
  Style/LambdaCall:
@@ -555,12 +543,14 @@ Style/MethodCalledOnDoEndBlock:
555
543
  Enabled: false
556
544
  Style/MethodDefParentheses:
557
545
  Enabled: false
558
- Style/MethodMissing:
546
+ Style/MethodMissingSuper:
559
547
  Enabled: false
560
548
  Style/MinMax:
561
549
  Enabled: false
562
550
  Style/MissingElse:
563
551
  Enabled: false
552
+ Style/MissingRespondToMissing:
553
+ Enabled: false
564
554
  Style/MixinGrouping:
565
555
  Enabled: false
566
556
  Style/MixinUsage:
@@ -573,6 +563,8 @@ Style/MultilineIfThen:
573
563
  Enabled: false
574
564
  Style/MultilineIfModifier:
575
565
  Enabled: false
566
+ Style/MultilineMethodSignature:
567
+ Enabled: false
576
568
  Style/MultilineMemoization:
577
569
  Enabled: false
578
570
  Style/MultilineTernaryOperator:
@@ -583,6 +575,8 @@ Style/MutableConstant:
583
575
  Enabled: false
584
576
  Style/NegatedIf:
585
577
  Enabled: false
578
+ Style/NegatedUnless:
579
+ Enabled: false
586
580
  Style/NegatedWhile:
587
581
  Enabled: false
588
582
  Style/NestedModifier:
@@ -633,6 +627,8 @@ Style/RandomWithOffset:
633
627
  Enabled: false
634
628
  Style/RedundantBegin:
635
629
  Enabled: false
630
+ Style/RedundantConditional:
631
+ Enabled: false
636
632
  Style/RedundantException:
637
633
  Enabled: false
638
634
  Style/RedundantFreeze:
@@ -643,7 +639,7 @@ Style/RedundantReturn:
643
639
  Enabled: false
644
640
  Style/RedundantSelf:
645
641
  Enabled: false
646
- Style/RedundantConditional:
642
+ Style/RedundantSortBy:
647
643
  Enabled: false
648
644
  Style/RegexpLiteral:
649
645
  Enabled: false
@@ -655,6 +651,8 @@ Style/ReturnNil:
655
651
  Enabled: false
656
652
  Style/SafeNavigation:
657
653
  Enabled: false
654
+ Style/Sample:
655
+ Enabled: false
658
656
  Style/SelfAssignment:
659
657
  Enabled: false
660
658
  Style/Semicolon:
@@ -681,6 +679,8 @@ Style/StringLiteralsInInterpolation:
681
679
  Enabled: false
682
680
  Style/StringMethods:
683
681
  Enabled: false
682
+ Style/Strip:
683
+ Enabled: false
684
684
  Style/StructInheritance:
685
685
  Enabled: false
686
686
  Style/SymbolArray:
@@ -713,10 +713,14 @@ Style/UnlessElse:
713
713
  Enabled: false
714
714
  Style/UnneededCapitalW:
715
715
  Enabled: false
716
+ Style/UnneededCondition:
717
+ Enabled: false
716
718
  Style/UnneededInterpolation:
717
719
  Enabled: false
718
720
  Style/UnneededPercentQ:
719
721
  Enabled: false
722
+ Style/UnneededSort:
723
+ Enabled: false
720
724
  Style/UnpackFirst:
721
725
  Enabled: false
722
726
  Style/VariableInterpolation:
@@ -733,98 +737,6 @@ Style/YodaCondition:
733
737
  Enabled: false
734
738
  Style/ZeroLengthPredicate:
735
739
  Enabled: false
736
- Rails/ActionFilter:
737
- Enabled: false
738
- Rails/ActiveRecordAliases:
739
- Enabled: false
740
- Rails/ActiveSupportAliases:
741
- Enabled: false
742
- Rails/ApplicationJob:
743
- Enabled: false
744
- Rails/ApplicationRecord:
745
- Enabled: false
746
- Rails/AssertNot:
747
- Enabled: false
748
- Rails/Blank:
749
- Enabled: false
750
- Rails/BulkChangeTable:
751
- Enabled: false
752
- Rails/CreateTableWithTimestamps:
753
- Enabled: false
754
- Rails/Date:
755
- Enabled: false
756
- Rails/DynamicFindBy:
757
- Enabled: false
758
- Rails/Delegate:
759
- Enabled: false
760
- Rails/DelegateAllowBlank:
761
- Enabled: false
762
- Rails/EnumUniqueness:
763
- Enabled: false
764
- Rails/EnvironmentComparison:
765
- Enabled: false
766
- Rails/Exit:
767
- Enabled: false
768
- Rails/FilePath:
769
- Enabled: false
770
- Rails/FindBy:
771
- Enabled: false
772
- Rails/FindEach:
773
- Enabled: false
774
- Rails/HasAndBelongsToMany:
775
- Enabled: false
776
- Rails/HasManyOrHasOneDependent:
777
- Enabled: false
778
- Rails/HttpPositionalArguments:
779
- Enabled: false
780
- Rails/HttpStatus:
781
- Enabled: false
782
- Rails/InverseOf:
783
- Enabled: false
784
- Rails/LexicallyScopedActionFilter:
785
- Enabled: false
786
- Rails/LinkToBlank:
787
- Enabled: false
788
- Rails/NotNullColumn:
789
- Enabled: false
790
- Rails/OutputSafety:
791
- Enabled: false
792
- Rails/Output:
793
- Enabled: false
794
- Rails/PluralizationGrammar:
795
- Enabled: false
796
- Rails/Presence:
797
- Enabled: false
798
- Rails/Present:
799
- Enabled: false
800
- Rails/ReadWriteAttribute:
801
- Enabled: false
802
- Rails/RedundantReceiverInWithOptions:
803
- Enabled: false
804
- Rails/RefuteMethods:
805
- Enabled: false
806
- Rails/RequestReferer:
807
- Enabled: false
808
- Rails/ReversibleMigration:
809
- Enabled: false
810
- Rails/RelativeDateConstant:
811
- Enabled: false
812
- Rails/SafeNavigation:
813
- Enabled: false
814
- Rails/SaveBang:
815
- Enabled: false
816
- Rails/ScopeArgs:
817
- Enabled: false
818
- Rails/SkipsModelValidations:
819
- Enabled: false
820
- Rails/TimeZone:
821
- Enabled: false
822
- Rails/UniqBeforePluck:
823
- Enabled: false
824
- Rails/UnknownEnv:
825
- Enabled: false
826
- Rails/Validation:
827
- Enabled: false
828
740
  Security/Eval:
829
741
  Enabled: false
830
742
  Security/JSONLoad: