cookbook-omnifetch 0.2.3 → 0.4.0

data/lib/cookbook-omnifetch/integration.rb

@@ -1,4 +1,4 @@
-require 'cookbook-omnifetch/exceptions'
+require "cookbook-omnifetch/exceptions"
 
 module CookbookOmnifetch
 
@@ -28,7 +28,6 @@ module CookbookOmnifetch
           value
         end
       end
-
     end
 
     configurable :cache_path

data/lib/cookbook-omnifetch/path.rb

@@ -1,4 +1,4 @@
-require 'cookbook-omnifetch/base'
+require "cookbook-omnifetch/base"
 
 module CookbookOmnifetch
   class PathLocation < BaseLocation
@@ -65,8 +65,8 @@ module CookbookOmnifetch
 
     def ==(other)
       other.is_a?(PathLocation) &&
-      other.metadata? == metadata? &&
-      other.relative_path == relative_path
+        other.metadata? == metadata? &&
+        other.relative_path == relative_path
     end
 
     def lock_data

data/lib/cookbook-omnifetch/version.rb

@@ -1,3 +1,3 @@
 module CookbookOmnifetch
-  VERSION = "0.2.3"
+  VERSION = "0.4.0"
 end

data/spec/fixtures/cookbooks/example_cookbook-0.5.0/metadata.rb

@@ -1,3 +1,3 @@
-name       'example_cookbook'
-maintainer 'Berkshelf Core'
-version    '0.5.0'
+name       "example_cookbook"
+maintainer "Berkshelf Core"
+version    "0.5.0"

data/spec/fixtures/cookbooks/example_cookbook/metadata.rb

@@ -1,3 +1,3 @@
-name       'example_cookbook'
-maintainer 'Berkshelf Core'
-version    '0.5.0'
+name       "example_cookbook"
+maintainer "Berkshelf Core"
+version    "0.5.0"

data/spec/spec_helper.rb

@@ -1,9 +1,9 @@
-require 'cookbook-omnifetch'
+require "cookbook-omnifetch"
 
 module Fixtures
 
   def fixtures_path
-    spec_root.join('fixtures')
+    spec_root.join("fixtures")
   end
 
   def spec_root
@@ -34,11 +34,10 @@ RSpec.configure do |config|
 
   config.before(:suite) do
     CookbookOmnifetch.configure do |c|
-      c.cache_path = File.expand_path('~/.berkshelf')
-      c.storage_path = Pathname.new(File.expand_path('~/.berkshelf/cookbooks'))
+      c.cache_path = File.expand_path("~/.berkshelf")
+      c.storage_path = Pathname.new(File.expand_path("~/.berkshelf/cookbooks"))
       c.shell_out_class = MockShellOut
       c.cached_cookbook_class = MockCachedCookbook
     end
   end
 end
-

data/spec/unit/artifactserver_spec.rb

@@ -1,5 +1,7 @@
-require 'spec_helper'
-require 'cookbook-omnifetch/artifactserver'
+require "spec_helper"
+require "cookbook-omnifetch/artifactserver"
+require "zlib"
+require "archive/tar/minitar"
 
 module CookbookOmnifetch
   describe ArtifactserverLocation do
@@ -14,7 +16,7 @@ module CookbookOmnifetch
 
     let(:url) { "https://supermarket.getchef.com/api/v1/cookbooks/nginx/versions/1.5.23/download" }
 
-    let(:options) { {artifactserver: url, version: cookbook_version } }
+    let(:options) { { artifactserver: url, version: cookbook_version } }
 
     subject(:public_repo_location) { described_class.new(dependency, options) }
 
@@ -35,7 +37,7 @@ module CookbookOmnifetch
     end
 
     it "sets the install location as the cache path plus cache key" do
-      expected_install_path = Pathname.new('~/.berkshelf/cookbooks').expand_path.join("nginx-1.5.23-supermarket.getchef.com")
+      expected_install_path = Pathname.new("~/.berkshelf/cookbooks").expand_path.join("nginx-1.5.23-supermarket.getchef.com")
       expect(public_repo_location.install_path).to eq(expected_install_path)
     end
 
@@ -52,7 +54,7 @@ module CookbookOmnifetch
     it "provides lock data as a Hash" do
       expected_data = {
         "artifactserver" => url,
-        "version" => "1.5.23"
+        "version" => "1.5.23",
       }
       expect(public_repo_location.lock_data).to eq(expected_data)
     end
@@ -67,14 +69,14 @@ module CookbookOmnifetch
 
       let(:cache_path) { File.join(test_root, "cache") }
 
-      let(:cookbook_fixtures_path) { fixtures_path.join('cookbooks') }
+      let(:cookbook_fixtures_path) { fixtures_path.join("cookbooks") }
 
       let(:cookbook_name) { "example_cookbook" }
 
       let(:cookbook_version) { "0.5.0" }
 
       let(:cookbook_tarball_handle) do
-        gz_file_name = File.join(test_root, 'input.gz')
+        gz_file_name = File.join(test_root, "input.gz")
         Zlib::GzipWriter.open(gz_file_name) do |gz|
           # Minitar writes the full paths provided and doesn't seem to have a way to
           # remove prefixes.  So we chdir like barbarians.
@@ -85,7 +87,7 @@ module CookbookOmnifetch
         File.open(gz_file_name)
       end
 
-      let(:cookbook_files) { %w". .. .gitignore .kitchen.yml Berksfile Berksfile.lock metadata.rb README.md recipes" }
+      let(:cookbook_files) { %w{. .. .gitignore .kitchen.yml Berksfile Berksfile.lock metadata.rb README.md recipes} }
 
       before do
         allow(CookbookOmnifetch).to receive(:storage_path).and_return(Pathname.new(storage_path))
@@ -112,4 +114,3 @@ module CookbookOmnifetch
     end
   end
 end
-

data/spec/unit/base_spec.rb

@@ -1,59 +1,59 @@
-require 'spec_helper'
-require 'cookbook-omnifetch/base'
+require "spec_helper"
+require "cookbook-omnifetch/base"
 
 module CookbookOmnifetch
   describe BaseLocation do
-    let(:constraint) { double('constraint') }
-    let(:dependency) { double('dependency', name: 'cookbook', version_constraint: constraint) }
+    let(:constraint) { double("constraint") }
+    let(:dependency) { double("dependency", name: "cookbook", version_constraint: constraint) }
 
     subject { described_class.new(dependency) }
 
-    describe '#installed?' do
-      it 'is an abstract function' do
+    describe "#installed?" do
+      it "is an abstract function" do
         expect { subject.installed? }.to raise_error(AbstractFunction)
       end
     end
 
-    describe '#install' do
-      it 'is an abstract function' do
+    describe "#install" do
+      it "is an abstract function" do
         expect { subject.install }.to raise_error(AbstractFunction)
       end
     end
 
-    describe '#cached_cookbook' do
-      it 'is an abstract function' do
+    describe "#cached_cookbook" do
+      it "is an abstract function" do
         expect { subject.cached_cookbook }.to raise_error(AbstractFunction)
       end
     end
 
-    describe '#to_lock' do
-      it 'is an abstract function' do
+    describe "#to_lock" do
+      it "is an abstract function" do
         expect { subject.to_lock }.to raise_error(AbstractFunction)
       end
     end
 
-    describe '#lock_data' do
-      it 'is an abstract function' do
+    describe "#lock_data" do
+      it "is an abstract function" do
         expect { subject.lock_data }.to raise_error(AbstractFunction)
       end
     end
 
-    describe '#validate_cached!' do
-      context 'when the path is not a cookbook' do
+    describe "#validate_cached!" do
+      context "when the path is not a cookbook" do
         before { CookbookOmnifetch.stub(:cookbook?).and_return(false) }
 
-        it 'raises an error' do
-          expect {
-            subject.validate_cached!('/foo/bar')
-          }.to raise_error(NotACookbook)
+        it "raises an error" do
+          expect do
+            subject.validate_cached!("/foo/bar")
+          end.to raise_error(NotACookbook)
         end
       end
 
-      context 'when the path is a cookbook' do
+      context "when the path is a cookbook" do
         let(:cookbook) do
-          double('cookbook',
-            cookbook_name: 'cookbook',
-            version: '0.1.0',
+          double("cookbook",
+            cookbook_name: "cookbook",
+            version: "0.1.0"
           )
         end
 
@@ -62,23 +62,23 @@ module CookbookOmnifetch
           MockCachedCookbook.stub(:from_path).and_return(cookbook)
         end
 
-        it 'raises an error if the constraint does not satisfy' do
-          constraint.stub(:satisfies?).with('0.1.0').and_return(false)
-          expect {
+        it "raises an error if the constraint does not satisfy" do
+          constraint.stub(:satisfies?).with("0.1.0").and_return(false)
+          expect do
             subject.validate_cached!(cookbook)
-          }.to raise_error(CookbookValidationFailure)
+          end.to raise_error(CookbookValidationFailure)
         end
 
-        it 'raises an error if the names do not match' do
-          constraint.stub(:satisfies?).with('0.1.0').and_return(true)
-          cookbook.stub(:cookbook_name).and_return('different_name')
-          expect {
+        it "raises an error if the names do not match" do
+          constraint.stub(:satisfies?).with("0.1.0").and_return(true)
+          cookbook.stub(:cookbook_name).and_return("different_name")
+          expect do
             subject.validate_cached!(cookbook)
-          }.to raise_error(MismatchedCookbookName)
+          end.to raise_error(MismatchedCookbookName)
         end
 
-        it 'returns true when the validation succeeds' do
-          constraint.stub(:satisfies?).with('0.1.0').and_return(true)
+        it "returns true when the validation succeeds" do
+          constraint.stub(:satisfies?).with("0.1.0").and_return(true)
           expect(subject.validate_cached!(cookbook)).to be true
         end
       end

data/spec/unit/chef_server_spec.rb

@@ -0,0 +1,75 @@
+require "spec_helper"
+require "cookbook-omnifetch/chef_server.rb"
+
+module CookbookOmnifetch
+  METADATA = {
+    "recipes" => [
+      { "name" => "default.rb", "path" => "recipes/default.rb", "checksum" => "a6be794cdd2eb44d38fdf17f792a0d0d", "specificity" => "default", "url" => "https://example.com/recipes/default.rb" },
+    ],
+    "root_files" => [
+      { "name" => "metadata.rb", "path" => "metadata.rb", "checksum" => "5b346119e5e41ab99500608decac8dca", "specificity" => "default", "url" => "https://example.com/metadata.rb" },
+    ],
+  }
+
+  describe CookbookMetadata do
+    let(:cb_metadata) { CookbookMetadata.new(METADATA) }
+
+    it "yields a set of paths and urls" do
+      expect { |b| cb_metadata.files(&b) }.to yield_successive_args(["https://example.com/recipes/default.rb", "recipes/default.rb"], ["https://example.com/metadata.rb", "metadata.rb"])
+    end
+  end
+
+  describe ChefserverLocation do
+
+    let(:http_client) { double("Http Client") }
+
+    let(:cb_metadata) { CookbookMetadata.new(METADATA) }
+
+    let(:test_root) { Dir.mktmpdir(nil) }
+
+    let(:storage_path) { File.join(test_root, "storage") }
+
+    let(:cache_path) { File.join(test_root, "cache") }
+
+    let(:constraint) { double("Constraint") }
+
+    let(:dependency) { double("Dependency", name: cookbook_name, constraint: constraint) }
+
+    let(:cookbook_name) { "example" }
+    let(:cookbook_version) { "0.5.0" }
+
+    let(:cookbook_fixture_path) { fixtures_path.join("cookbooks/example_cookbook") }
+
+    let(:remote_path) { File.join(test_root, "remote") }
+    let(:options) { { version: cookbook_version, http_client: http_client } }
+
+    let(:cookbook_files) { %w{. ..  metadata.rb recipes} }
+    subject(:chef_server_location) { described_class.new(dependency, options) }
+
+    before do
+      allow(CookbookOmnifetch).to receive(:storage_path).and_return(Pathname.new(storage_path))
+      allow(CookbookOmnifetch).to receive(:cache_path).and_return(cache_path)
+      allow_any_instance_of(File).to receive(:close).and_return(true)
+      FileUtils.cp_r(cookbook_fixture_path, remote_path)
+      FileUtils.mkdir_p(storage_path)
+    end
+
+    after do
+      FileUtils.rm_r(test_root)
+    end
+
+    it "installs the cookbook to the desired install path" do
+      expect(http_client).to receive(:get).with("/cookbooks/example/0.5.0").and_return(METADATA)
+      expect(http_client).to receive(:streaming_request).twice do |url, &block|
+        path = url.split("/", 4)[3]
+        path = File.join(remote_path, path)
+        block.call(File.open(path))
+      end
+
+      chef_server_location.install
+
+      expect(Dir).to exist(chef_server_location.install_path)
+      expect(Dir.entries(chef_server_location.install_path)).to match_array(cookbook_files)
+    end
+  end
+end

data/spec/unit/exceptions_spec.rb

@@ -1,5 +1,5 @@
-require 'spec_helper'
-require 'cookbook-omnifetch/exceptions'
+require "spec_helper"
+require "cookbook-omnifetch/exceptions"
 
 module CookbookOmnifetch
   describe "Exceptions" do

data/spec/unit/git_spec.rb

@@ -1,77 +1,77 @@
-require 'spec_helper'
-require 'cookbook-omnifetch/git'
+require "spec_helper"
+require "cookbook-omnifetch/git"
 
 module CookbookOmnifetch
   describe GitLocation do
-    let(:dependency) { double(name: 'bacon') }
+    let(:dependency) { double(name: "bacon") }
 
     subject do
-      described_class.new(dependency, git: 'https://repo.com', branch: 'ham',
-        tag: 'v1.2.3', ref: 'abc123', revision: 'defjkl123456', rel: 'hi')
+      described_class.new(dependency, git: "https://repo.com", branch: "ham",
+                                      tag: "v1.2.3", ref: "abc123", revision: "defjkl123456", rel: "hi")
     end
 
-    describe '.initialize' do
-      it 'sets the uri' do
-        instance = described_class.new(dependency, git: 'https://repo.com')
-        expect(instance.uri).to eq('https://repo.com')
+    describe ".initialize" do
+      it "sets the uri" do
+        instance = described_class.new(dependency, git: "https://repo.com")
+        expect(instance.uri).to eq("https://repo.com")
       end
 
-      it 'sets the branch' do
+      it "sets the branch" do
         instance = described_class.new(dependency,
-          git: 'https://repo.com', branch: 'magic_new_feature')
-        expect(instance.branch).to eq('magic_new_feature')
+          git: "https://repo.com", branch: "magic_new_feature")
+        expect(instance.branch).to eq("magic_new_feature")
       end
 
-      it 'sets the tag' do
+      it "sets the tag" do
         instance = described_class.new(dependency,
-          git: 'https://repo.com', tag: 'v1.2.3')
-        expect(instance.tag).to eq('v1.2.3')
+          git: "https://repo.com", tag: "v1.2.3")
+        expect(instance.tag).to eq("v1.2.3")
       end
 
-      it 'adds the ref' do
+      it "adds the ref" do
         instance = described_class.new(dependency,
-          git: 'https://repo.com', ref: 'abc123')
-        expect(instance.ref).to eq('abc123')
+          git: "https://repo.com", ref: "abc123")
+        expect(instance.ref).to eq("abc123")
       end
 
-      it 'sets the revision' do
+      it "sets the revision" do
         instance = described_class.new(dependency,
-          git: 'https://repo.com', revision: 'abcde12345')
-        expect(instance.revision).to eq('abcde12345')
+          git: "https://repo.com", revision: "abcde12345")
+        expect(instance.revision).to eq("abcde12345")
       end
 
-      it 'sets the rel' do
+      it "sets the rel" do
         instance = described_class.new(dependency,
-          git: 'https://repo.com', rel: 'internal/path')
-        expect(instance.rel).to eq('internal/path')
+          git: "https://repo.com", rel: "internal/path")
+        expect(instance.rel).to eq("internal/path")
       end
 
-      context 'rev_parse' do
+      context "rev_parse" do
         def rev_parse(instance)
           instance.instance_variable_get(:@rev_parse)
         end
 
-        it 'uses the :ref option with priority' do
+        it "uses the :ref option with priority" do
           instance = described_class.new(dependency,
-            git: 'https://repo.com', ref: 'abc123', branch: 'magic_new_feature')
-          expect(rev_parse(instance)).to eq('abc123')
+            git: "https://repo.com", ref: "abc123", branch: "magic_new_feature")
+          expect(rev_parse(instance)).to eq("abc123")
         end
 
-        it 'uses the :branch option with priority' do
+        it "uses the :branch option with priority" do
           instance = described_class.new(dependency,
-            git: 'https://repo.com', branch: 'magic_new_feature', tag: 'v1.2.3')
-          expect(rev_parse(instance)).to eq('magic_new_feature')
+            git: "https://repo.com", branch: "magic_new_feature", tag: "v1.2.3")
+          expect(rev_parse(instance)).to eq("magic_new_feature")
         end
 
-        it 'uses the :tag option' do
+        it "uses the :tag option" do
           instance = described_class.new(dependency,
-            git: 'https://repo.com', tag: 'v1.2.3')
-          expect(rev_parse(instance)).to eq('v1.2.3')
+            git: "https://repo.com", tag: "v1.2.3")
+          expect(rev_parse(instance)).to eq("v1.2.3")
         end
 
         it 'uses "master" when none is given' do
-          instance = described_class.new(dependency, git: 'https://repo.com')
-          expect(rev_parse(instance)).to eq('master')
+          instance = described_class.new(dependency, git: "https://repo.com")
+          expect(rev_parse(instance)).to eq("master")
         end
       end
     end
@@ -84,26 +84,26 @@ module CookbookOmnifetch
       end
     end
 
-    describe '#installed?' do
-      it 'returns false when there is no revision' do
+    describe "#installed?" do
+      it "returns false when there is no revision" do
         subject.stub(:revision).and_return(nil)
         expect(subject.installed?).to be false
       end
 
-      it 'returns false when the install_path does not exist' do
-        subject.stub(:revision).and_return('abcd1234')
+      it "returns false when the install_path does not exist" do
+        subject.stub(:revision).and_return("abcd1234")
         subject.stub(:install_path).and_return(double(exist?: false))
         expect(subject.installed?).to be false
       end
 
-      it 'returns true when the location is installed' do
-        subject.stub(:revision).and_return('abcd1234')
+      it "returns true when the location is installed" do
+        subject.stub(:revision).and_return("abcd1234")
         subject.stub(:install_path).and_return(double(exist?: true))
         expect(subject.installed?).to be true
       end
     end
 
-    describe '#install' do
+    describe "#install" do
       before do
         File.stub(:chmod)
         FileUtils.stub(:cp_r)
@@ -111,8 +111,8 @@ module CookbookOmnifetch
         subject.stub(:git)
       end
 
-      context 'when the repository is cached' do
-        it 'pulls a new version' do
+      context "when the repository is cached" do
+        it "pulls a new version" do
           Dir.stub(:chdir) { |args, &b| b.call } # Force eval the chdir block
 
           subject.stub(:cached?).and_return(true)
@@ -123,27 +123,27 @@ module CookbookOmnifetch
         end
       end
 
-      context 'when the revision is not cached' do
-        it 'clones the repository' do
+      context "when the revision is not cached" do
+        it "clones the repository" do
           Dir.stub(:chdir) { |args, &b| b.call } # Force eval the chdir block
 
           cache_path = subject.send(:cache_path)
           subject.stub(:cached?).and_return(false)
           expect(subject).to receive(:git).with(
-            %|clone https://repo.com "#{cache_path}" --bare --no-hardlinks|
+            %{clone https://repo.com "#{cache_path}" --bare --no-hardlinks}
           )
           subject.install
         end
       end
     end
 
-    describe '#cached_cookbook' do
-      it 'returns nil if the cookbook is not installed' do
+    describe "#cached_cookbook" do
+      it "returns nil if the cookbook is not installed" do
         subject.stub(:installed?).and_return(false)
         expect(subject.cached_cookbook).to be_nil
       end
 
-      it 'returns the cookbook at the install_path' do
+      it "returns the cookbook at the install_path" do
         subject.stub(:installed?).and_return(true)
         MockCachedCookbook.stub(:from_path)
 
@@ -152,69 +152,69 @@ module CookbookOmnifetch
       end
     end
 
-    describe '#==' do
+    describe "#==" do
       let(:other) { subject.dup }
 
-      it 'returns true when everything matches' do
+      it "returns true when everything matches" do
         expect(subject).to eq(other)
       end
 
-      it 'returns false when the other location is not an GitLocation' do
+      it "returns false when the other location is not an GitLocation" do
         other.stub(:is_a?).and_return(false)
         expect(subject).to_not eq(other)
       end
 
-      it 'returns false when the uri is different' do
-        other.stub(:uri).and_return('different')
+      it "returns false when the uri is different" do
+        other.stub(:uri).and_return("different")
         expect(subject).to_not eq(other)
       end
 
-      it 'returns false when the branch is different' do
-        other.stub(:branch).and_return('different')
+      it "returns false when the branch is different" do
+        other.stub(:branch).and_return("different")
         expect(subject).to_not eq(other)
       end
 
-      it 'returns false when the tag is different' do
-        other.stub(:tag).and_return('different')
+      it "returns false when the tag is different" do
+        other.stub(:tag).and_return("different")
         expect(subject).to_not eq(other)
       end
 
-      it 'returns false when the ref is different' do
-        other.stub(:ref).and_return('different')
+      it "returns false when the ref is different" do
+        other.stub(:ref).and_return("different")
         expect(subject).to_not eq(other)
       end
 
-      it 'returns false when the rel is different' do
-        other.stub(:rel).and_return('different')
+      it "returns false when the rel is different" do
+        other.stub(:rel).and_return("different")
         expect(subject).to_not eq(other)
       end
     end
 
-    describe '#to_s' do
-      it 'prefers the tag' do
-        expect(subject.to_s).to eq('https://repo.com (at v1.2.3/hi)')
+    describe "#to_s" do
+      it "prefers the tag" do
+        expect(subject.to_s).to eq("https://repo.com (at v1.2.3/hi)")
       end
 
-      it 'prefers the branch' do
+      it "prefers the branch" do
         subject.stub(:tag).and_return(nil)
-        expect(subject.to_s).to eq('https://repo.com (at ham/hi)')
+        expect(subject.to_s).to eq("https://repo.com (at ham/hi)")
       end
 
-      it 'falls back to the ref' do
+      it "falls back to the ref" do
         subject.stub(:tag).and_return(nil)
         subject.stub(:branch).and_return(nil)
-        expect(subject.to_s).to eq('https://repo.com (at abc123/hi)')
+        expect(subject.to_s).to eq("https://repo.com (at abc123/hi)")
       end
 
-      it 'does not use the rel if missing' do
+      it "does not use the rel if missing" do
         subject.stub(:rel).and_return(nil)
-        expect(subject.to_s).to eq('https://repo.com (at v1.2.3)')
+        expect(subject.to_s).to eq("https://repo.com (at v1.2.3)")
       end
     end
 
-    describe '#to_lock' do
-      it 'includes all the information' do
-        expect(subject.to_lock).to eq <<-EOH.gsub(/^ {8}/, '')
+    describe "#to_lock" do
+      it "includes all the information" do
+        expect(subject.to_lock).to eq <<-EOH.gsub(/^ {8}/, "")
             git: https://repo.com
             revision: defjkl123456
             ref: abc123
@@ -224,23 +224,23 @@ module CookbookOmnifetch
         EOH
       end
 
-      it 'does not include the branch if missing' do
+      it "does not include the branch if missing" do
         subject.stub(:branch).and_return(nil)
-        expect(subject.to_lock).to_not include('branch')
+        expect(subject.to_lock).to_not include("branch")
       end
 
-      it 'does not include the tag if missing' do
+      it "does not include the tag if missing" do
         subject.stub(:tag).and_return(nil)
-        expect(subject.to_lock).to_not include('tag')
+        expect(subject.to_lock).to_not include("tag")
       end
 
-      it 'does not include the rel if missing' do
+      it "does not include the rel if missing" do
         subject.stub(:rel).and_return(nil)
-        expect(subject.to_lock).to_not include('rel')
+        expect(subject.to_lock).to_not include("rel")
       end
     end
 
-    describe '#lock_data' do
+    describe "#lock_data" do
       let(:full_lock_data) do
         {
           "git" => "https://repo.com",
@@ -248,43 +248,42 @@ module CookbookOmnifetch
           "ref" => "abc123",
           "branch" => "ham",
           "tag" => "v1.2.3",
-          "rel" => "hi"
+          "rel" => "hi",
         }
       end
 
-      it 'includes all the information' do
+      it "includes all the information" do
         expect(subject.lock_data).to eq(full_lock_data)
       end
 
-      it 'does not include the branch if missing' do
+      it "does not include the branch if missing" do
         subject.stub(:branch).and_return(nil)
-        expect(subject.lock_data).to_not have_key('branch')
+        expect(subject.lock_data).to_not have_key("branch")
       end
 
-      it 'does not include the tag if missing' do
+      it "does not include the tag if missing" do
         subject.stub(:tag).and_return(nil)
-        expect(subject.lock_data).to_not have_key('tag')
+        expect(subject.lock_data).to_not have_key("tag")
       end
 
-      it 'does not include the rel if missing' do
+      it "does not include the rel if missing" do
         subject.stub(:rel).and_return(nil)
-        expect(subject.lock_data).to_not have_key('rel')
+        expect(subject.lock_data).to_not have_key("rel")
       end
     end
 
-
-    describe '#git' do
+    describe "#git" do
       before { described_class.send(:public, :git) }
 
-      it 'raises an error if Git is not installed' do
+      it "raises an error if Git is not installed" do
         CookbookOmnifetch.stub(:which).and_return(false)
-        expect { subject.git('foo') }.to raise_error(GitNotInstalled)
+        expect { subject.git("foo") }.to raise_error(GitNotInstalled)
       end
 
-      it 'raises an error if the command fails' do
-        shell_out = double('shell_out', success?: false, stderr: nil)
+      it "raises an error if the command fails" do
+        shell_out = double("shell_out", success?: false, stderr: nil)
         MockShellOut.stub(:shell_out).and_return(shell_out)
-        expect { subject.git('foo') }.to raise_error(GitCommandError)
+        expect { subject.git("foo") }.to raise_error(GitCommandError)
       end
     end
   end