cookbook-omnifetch 0.2.1 → 0.2.2

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA1:
-  metadata.gz: e7d091088a8d8bc3534633afc049408ec4b1ae98
-  data.tar.gz: c41001a64b00582c791a9161d9b65989897aea44
+  metadata.gz: 58ddaa973a683bc785d88b14aba77ec925a88593
+  data.tar.gz: 6bc3e9c9b10d358670d3e7e10a6f355ff84bef3d
 SHA512:
-  metadata.gz: 206300e6648ef964968ab77535acbfd494df3f20ab36d4155ae9a2ddb7224b16d23cc95192aa6a7a02799c5c5c47fb386aa161f6e3ec3d022d9c45789d173899
-  data.tar.gz: 44b5ba6fdde4ff019d481e2709a8b5b592012193b0cdfb46d741719dafe7f4a5e70dec776175d7fc91120b287e57aba5154babd81f6aa430a556b24ebb24894d
+  metadata.gz: 2ad898b79aabc3caa8cc7dd492079f8e7c62dd0f3ab04dc9677b15dc48c18e5853b787dc8d7bccebe11a0d44fcfa23a68df4ccd7bf731f5b2569fe48d50de62d
+  data.tar.gz: 6197fdedffcd7df2e40de298d42a4f2b8ff512ccc09302d91e076ddf9ae57d81e072d9a9317342fbef54343a5a82a42cfac2070a7006f227b76d264c2a085675

data/lib/cookbook-omnifetch/exceptions.rb

@@ -50,6 +50,7 @@ module CookbookOmnifetch
     #   the path to the thing that is not a cookbook
     def initialize(path)
       @path = File.expand_path(path) rescue path
+      super(to_s)
     end
 
     def to_s
@@ -68,6 +69,7 @@ module CookbookOmnifetch
     def initialize(dependency, cached_cookbook)
       @dependency      = dependency
       @cached_cookbook = cached_cookbook
+      super(to_s)
     end
 
     def to_s
@@ -85,6 +87,7 @@ module CookbookOmnifetch
     def initialize(dependency, cached_cookbook)
       @dependency      = dependency
       @cached_cookbook = cached_cookbook
+      super(to_s)
     end
 
     def to_s
@@ -98,7 +101,7 @@ module CookbookOmnifetch
       out << "\n"
       out << "NOTE: If you do not explicitly set the 'name' attribute in the "
       out << "metadata, the name of the directory will be used instead. This "
-      out << "is often a cause of confusion for dependency solving."
+      out << "is often a cause of confusion for dependency solving.\n"
       out
     end
   end

data/lib/cookbook-omnifetch/version.rb

@@ -1,3 +1,3 @@
 module CookbookOmnifetch
-  VERSION = "0.2.1"
+  VERSION = "0.2.2"
 end

data/spec/unit/exceptions_spec.rb

@@ -0,0 +1,87 @@
+require 'spec_helper'
+require 'cookbook-omnifetch/exceptions'
+
+module CookbookOmnifetch
+  describe "Exceptions" do
+
+    describe NotACookbook do
+
+      subject(:exception) do
+        described_class.new("/path/to/cookbook")
+      end
+
+      let(:message) do
+        "The resource at '/path/to/cookbook' does not appear to be a valid cookbook. Does it have a metadata.rb?"
+      end
+
+      it "creates an informative error in #message" do
+        expect(exception.message).to eq(message)
+      end
+
+      it "creates an informative error in #to_s" do
+        expect(exception.to_s).to eq(message)
+      end
+
+    end
+
+    describe CookbookValidationFailure do
+
+      let(:dependency) { instance_double("ChefDK::Policyfile::CookbookLocationSpecification", to_s: "apt ~> 1.2.3") }
+
+      # The exception class itself doesn't use this
+      let(:cached_cookbook) { Object.new }
+
+      subject(:exception) do
+        described_class.new(dependency, cached_cookbook)
+      end
+
+      let(:message) do
+        "The cookbook downloaded for apt ~> 1.2.3 did not satisfy the constraint."
+      end
+
+      it "creates an informative error in #message" do
+        expect(exception.message).to eq(message)
+      end
+
+      it "creates an informative error in #to_s" do
+        expect(exception.to_s).to eq(message)
+      end
+
+    end
+
+    describe MismatchedCookbookName do
+
+      let(:dependency) { instance_double("ChefDK::Policyfile::CookbookLocationSpecification", name: "apt") }
+
+      let(:cached_cookbook) { instance_double("Chef::Cookbook", cookbook_name: "apt") }
+
+      subject(:exception) do
+        described_class.new(dependency, cached_cookbook)
+      end
+
+      let(:message) do
+        <<-EOM
+In your Berksfile, you have:
+
+  cookbook 'apt'
+
+But that cookbook is actually named 'apt'
+
+This can cause potentially unwanted side-effects in the future.
+
+NOTE: If you do not explicitly set the 'name' attribute in the metadata, the name of the directory will be used instead. This is often a cause of confusion for dependency solving.
+EOM
+      end
+
+      it "creates an informative error in #message" do
+        expect(exception.message).to eq(message)
+      end
+
+      it "creates an informative error in #to_s" do
+        expect(exception.to_s).to eq(message)
+      end
+
+    end
+
+  end
+end

metadata

@@ -1,7 +1,7 @@
 --- !ruby/object:Gem::Specification
 name: cookbook-omnifetch
 version: !ruby/object:Gem::Version
-  version: 0.2.1
+  version: 0.2.2
 platform: ruby
 authors:
 - Jamie Winsor
@@ -13,7 +13,7 @@ authors:
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2015-03-26 00:00:00.000000000 Z
+date: 2015-10-13 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: minitar
@@ -98,6 +98,7 @@ files:
 - spec/spec_helper.rb
 - spec/unit/artifactserver_spec.rb
 - spec/unit/base_spec.rb
+- spec/unit/exceptions_spec.rb
 - spec/unit/git_spec.rb
 - spec/unit/path_spec.rb
 homepage: http://www.getchef.com/
@@ -120,7 +121,7 @@ required_rubygems_version: !ruby/object:Gem::Requirement
       version: '0'
 requirements: []
 rubyforge_project: 
-rubygems_version: 2.2.2
+rubygems_version: 2.4.8
 signing_key: 
 specification_version: 4
 summary: Library code to fetch Chef cookbooks from a variety of sources to a local
@@ -139,6 +140,7 @@ test_files:
 - spec/spec_helper.rb
 - spec/unit/artifactserver_spec.rb
 - spec/unit/base_spec.rb
+- spec/unit/exceptions_spec.rb
 - spec/unit/git_spec.rb
 - spec/unit/path_spec.rb
 has_rdoc: