convolver 0.4.0 → 1.0.0

data/lib/convolver.rb

@@ -1,100 +1,109 @@
 # frozen_string_literal: true
 
-require 'narray'
+require 'numo/narray/alt'
+require 'numo/pocketfft'
 require 'convolver/convolver'
 require 'convolver/version'
-require 'fftw3'
 
-# Convolution operations for NArray values.
+# Valid cross-correlation operations for Numo::NArray values.
 module Convolver
-  # Chooses and calls likely fastest method from #convolve_basic and #convolve_fftw3.
-  # The two parameters must have the same rank. The output has same rank, its size in each
-  # dimension d is given by
-  #  signal.shape[d] - kernel.shape[d] + 1
-  # If you always perform convolutions of the same size, you may be better off benchmarking your
-  # own code using either #convolve_basic or #convolve_fftw3, and have your code use the fastest.
-  # @param [NArray] signal must be same size or larger than kernel in each dimension
-  # @param [NArray] kernel must be same size or smaller than signal in each dimension
-  # @return [NArray] result of convolving signal with kernel
-  def self.convolve(signal, kernel)
-    # For small signals or kernels, just go straight to basic
-    return convolve_basic(signal, kernel) if signal.size < 1000 || kernel.size < 100
-
-    # If predicted time is less than a millisecond, just do a basic convolve
-    basic_time_predicted = predict_convolve_basic_time(signal, kernel)
-    return convolve_basic(signal, kernel) if basic_time_predicted < 0.1
-
-    # Factor of two to allow for large uncertainty in predictions for FFTW3
-    fft_time_predicted = predict_convolve_fft_time(signal, kernel)
-    return convolve_fftw3(signal, kernel) if fft_time_predicted < 2 * basic_time_predicted
-
-    convolve_basic(signal, kernel)
-  end
+  # Maximum number of dimensions supported by the direct native implementation.
+  MAX_RANK = 16
 
-  # Uses FFTW3 library to calculate convolution of an array of floats representing a signal,
-  # with a second array representing a kernel. The two parameters must have the same rank.
-  # The output has same rank, its size in each dimension d is given by
-  #  signal.shape[d] - kernel.shape[d] + 1
-  # @param [NArray] signal must be same size or larger than kernel in each dimension
-  # @param [NArray] kernel must be same size or smaller than signal in each dimension
-  # @return [NArray] result of convolving signal with kernel
-  def self.convolve_fftw3(signal, kernel)
-    combined_shape, shift_by, ranges = fft_offsets(signal.shape, kernel.shape)
-    mod_a, mod_b = fft_inputs(signal, kernel, combined_shape, shift_by)
-    cfreqs = FFTW3.fft(mod_a) * FFTW3.fft(mod_b)
-
-    (FFTW3.ifft(cfreqs).real * (1.0 / mod_a.size))[*ranges]
-  end
+  class << self
+    # Chooses the likely fastest implementation for a valid cross-correlation.
+    #
+    # The inputs must have the same rank, and the kernel must not be larger than
+    # the signal in any dimension. The result shape is:
+    #
+    #   signal.shape.zip(kernel.shape).map { |signal_size, kernel_size| signal_size - kernel_size + 1 }
+    #
+    # @param signal [Numo::NArray] input values
+    # @param kernel [Numo::NArray] correlation kernel
+    # @return [Numo::SFloat] valid cross-correlation result
+    # @raise [ArgumentError] if the inputs have incompatible ranks or shapes
+    def convolve(signal, kernel)
+      validate_inputs!(signal, kernel)
+      return convolve_basic(signal, kernel) if signal.size < 1000 || kernel.size < 100
 
-  # A rough estimate of time that #convolve_fftw3 will take, based on complexity
-  # of its operations, and some rough benchmarking. A value of 1.0 corresponds to results
-  # varying between 1 and 12 milliseconds on the test computer.
-  # @param [NArray] signal must be same size or larger than kernel in each dimension
-  # @param [NArray] kernel must be same size or smaller than signal in each dimension
-  # @return [Float] rough estimate of time for convolution compared to baseline
-  def self.predict_convolve_fft_time(signal, kernel)
-    16 * 4.55e-08 * result_shape(signal.shape, kernel.shape).inject(1) { |t, x| t * x * Math.log(x) }
-  end
+      basic_time_predicted = predict_convolve_basic_time(signal, kernel)
+      return convolve_basic(signal, kernel) if basic_time_predicted < 0.1
 
-  # A rough estimate of time that #convolve will take, based on complexity
-  # of its operations, and some rough benchmarking. A value of 1.0 corresponds to results
-  # varying bewteen 2 and 8 milliseconds on the test computer.
-  # @param [NArray] signal must be same size or larger than kernel in each dimension
-  # @param [NArray] kernel must be same size or smaller than signal in each dimension
-  # @return [Float] rough estimate of time for convolution compared to baseline
-  def self.predict_convolve_basic_time(signal, kernel)
-    outputs = shape_to_size(result_shape(signal.shape, kernel.shape))
-    4.54e-12 * (outputs * shape_to_size(signal.shape) * shape_to_size(kernel.shape))
-  end
+      fft_time_predicted = predict_convolve_fft_time(signal, kernel)
+      return convolve_fft(signal, kernel) if fft_time_predicted < 2 * basic_time_predicted
 
-  def self.shape_to_size(shape)
-    shape.inject(1) { |t, x| t * x }
-  end
+      convolve_basic(signal, kernel)
+    end
 
-  def self.result_shape(signal_shape, kernel_shape)
-    result_shape = []
-    signal_shape.each_with_index do |signal_size, i|
-      kernel_size = kernel_shape[i]
-      result_shape[i] = signal_size - kernel_size + 1
+    # Uses PocketFFT to calculate a valid cross-correlation.
+    #
+    # @param signal [Numo::NArray] input values
+    # @param kernel [Numo::NArray] correlation kernel
+    # @return [Numo::SFloat] valid cross-correlation result
+    # @raise [ArgumentError] if the inputs have incompatible ranks or shapes
+    def convolve_fft(signal, kernel)
+      validate_inputs!(signal, kernel)
+      ranges = kernel.shape.zip(signal.shape).map { |kernel_size, signal_size| (kernel_size - 1)...signal_size }
+      full_convolution = Numo::Pocketfft.fftconvolve(signal, kernel.reverse)
+
+      Numo::SFloat.cast(full_convolution[*ranges])
     end
-    result_shape
-  end
 
-  def self.fft_offsets(signal_shape, kernel_shape)
-    signal_shape.zip(kernel_shape).map { |sizes| fft_offset(*sizes) }.transpose
-  end
+    # Compatibility alias for the former FFTW3-backed implementation.
+    #
+    # @deprecated Use {.convolve_fft}; Convolver no longer uses FFTW3.
+    # @return [Numo::SFloat] valid cross-correlation result
+    def convolve_fftw3(signal, kernel)
+      warn 'Convolver.convolve_fftw3 is deprecated; use .convolve_fft instead', uplevel: 1
+      convolve_fft(signal, kernel)
+    end
 
-  def self.fft_inputs(signal, kernel, combined_shape, shift_by)
-    signal_input = NArray.sfloat(*combined_shape)
-    signal_input[*shift_by] = signal
-    kernel_input = NArray.sfloat(*combined_shape)
-    fit_kernel_backwards(kernel_input, kernel)
-    [signal_input, kernel_input]
-  end
+    # Estimates the relative cost of {.convolve_fft}.
+    #
+    # @param signal [Numo::NArray] input values
+    # @param kernel [Numo::NArray] correlation kernel
+    # @return [Float] machine-specific relative cost estimate
+    def predict_convolve_fft_time(signal, kernel)
+      validate_inputs!(signal, kernel)
+      output_size = result_shape(signal.shape, kernel.shape).inject(:*)
+      16 * 4.55e-08 * output_size * Math.log(output_size)
+    end
 
-  def self.fft_offset(signal_size, kernel_size)
-    output_offset = kernel_size - 1
-    output_size = signal_size - kernel_size + 1
-    [signal_size + kernel_size - 1, kernel_size / 2, output_offset...(output_offset + output_size)]
+    # Estimates the relative cost of {.convolve_basic}.
+    #
+    # @param signal [Numo::NArray] input values
+    # @param kernel [Numo::NArray] correlation kernel
+    # @return [Float] machine-specific relative cost estimate
+    def predict_convolve_basic_time(signal, kernel)
+      validate_inputs!(signal, kernel)
+      outputs = result_shape(signal.shape, kernel.shape).inject(:*)
+      4.54e-12 * (outputs * signal.size * kernel.size)
+    end
+
+    private
+
+    def result_shape(signal_shape, kernel_shape)
+      signal_shape.zip(kernel_shape).map { |signal_size, kernel_size| signal_size - kernel_size + 1 }
+    end
+
+    def validate_inputs!(signal, kernel)
+      validate_types!(signal, kernel)
+      validate_shapes!(signal, kernel)
+    end
+
+    def validate_types!(signal, kernel)
+      unless signal.is_a?(Numo::NArray) && kernel.is_a?(Numo::NArray)
+        raise ArgumentError, 'signal and kernel must be Numo::NArray values'
+      end
+      raise ArgumentError, 'signal and kernel must not be empty' if signal.empty? || kernel.empty?
+    end
+
+    def validate_shapes!(signal, kernel)
+      raise ArgumentError, 'signal and kernel must have equal rank' unless signal.ndim == kernel.ndim
+      raise ArgumentError, "maximum supported rank is #{MAX_RANK}" if signal.ndim > MAX_RANK
+      return if signal.shape.zip(kernel.shape).all? { |signal_size, kernel_size| signal_size >= kernel_size }
+
+      raise ArgumentError, 'kernel must not be larger than signal in any dimension'
+    end
   end
 end

metadata

@@ -1,7 +1,7 @@
 --- !ruby/object:Gem::Specification
 name: convolver
 version: !ruby/object:Gem::Version
-  version: 0.4.0
+  version: 1.0.0
 platform: ruby
 authors:
 - Neil Slater
@@ -10,34 +10,47 @@ cert_chain: []
 date: 1980-01-02 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
-  name: fftw3
+  name: numo-narray-alt
   requirement: !ruby/object:Gem::Requirement
     requirements:
     - - ">="
       - !ruby/object:Gem::Version
-        version: '0.3'
+        version: 0.9.9
+    - - "<"
+      - !ruby/object:Gem::Version
+        version: '0.11'
   type: :runtime
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
     - - ">="
       - !ruby/object:Gem::Version
-        version: '0.3'
+        version: 0.9.9
+    - - "<"
+      - !ruby/object:Gem::Version
+        version: '0.11'
 - !ruby/object:Gem::Dependency
-  name: narray
+  name: numo-pocketfft
   requirement: !ruby/object:Gem::Requirement
     requirements:
     - - ">="
       - !ruby/object:Gem::Version
-        version: 0.6.0.8
+        version: '0.6'
+    - - "<"
+      - !ruby/object:Gem::Version
+        version: '0.8'
   type: :runtime
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
     - - ">="
       - !ruby/object:Gem::Version
-        version: 0.6.0.8
-description: Convolution for NArray
+        version: '0.6'
+    - - "<"
+      - !ruby/object:Gem::Version
+        version: '0.8'
+description: Fast valid cross-correlation for multidimensional Numo::NArray values,
+  with native and FFT implementations.
 email:
 - slobo777@gmail.com
 executables: []
@@ -45,31 +58,21 @@ extensions:
 - ext/convolver/extconf.rb
 extra_rdoc_files: []
 files:
-- ".github/workflows/ci.yml"
-- ".gitignore"
-- ".rubocop.yml"
-- Gemfile
+- CHANGELOG.md
 - LICENSE.txt
 - README.md
-- Rakefile
-- convolver.gemspec
 - ext/convolver/convolve_raw.c
 - ext/convolver/convolve_raw.h
 - ext/convolver/convolver.c
 - ext/convolver/extconf.rb
-- ext/convolver/narray_shared.c
-- ext/convolver/narray_shared.h
 - lib/convolver.rb
 - lib/convolver/version.rb
-- spec/convolver_basic_spec.rb
-- spec/convolver_fftw3_spec.rb
-- spec/convolver_spec.rb
-- spec/helpers.rb
-homepage: http://github.com/neilslater/convolver
+homepage: https://github.com/neilslater/convolver
 licenses:
 - MIT
 metadata:
   rubygems_mfa_required: 'true'
+  source_code_uri: https://github.com/neilslater/convolver
 rdoc_options: []
 require_paths:
 - lib
@@ -84,7 +87,7 @@ required_rubygems_version: !ruby/object:Gem::Requirement
     - !ruby/object:Gem::Version
       version: '0'
 requirements: []
-rubygems_version: 4.0.1
+rubygems_version: 4.0.16
 specification_version: 4
-summary: Convolution for NArray
+summary: Fast cross-correlation for Numo::NArray
 test_files: []

data/.github/workflows/ci.yml

@@ -1,40 +0,0 @@
-name: CI
-
-on:
-  pull_request:
-
-permissions:
-  contents: read
-
-jobs:
-  test:
-    name: Ruby ${{ matrix.ruby }}
-    runs-on: ubuntu-latest
-    timeout-minutes: 10
-
-    strategy:
-      fail-fast: false
-      matrix:
-        ruby:
-          - '3.3'
-          - '3.4'
-
-    steps:
-      - name: Check out repository
-        uses: actions/checkout@v4
-
-      - name: Install FFTW
-        run: sudo apt-get update && sudo apt-get install --yes libfftw3-dev
-
-      - name: Set up Ruby
-        uses: ruby/setup-ruby@v1
-        with:
-          ruby-version: ${{ matrix.ruby }}
-          bundler: latest
-          bundler-cache: true
-
-      - name: Compile extension and run specs
-        run: bundle exec rake compile test
-
-      - name: Run RuboCop
-        run: bundle exec rubocop

data/.gitignore

@@ -1,19 +0,0 @@
-*.gem
-*.rbc
-.bundle
-lib/convolver/*.bundle
-.config
-.yardoc
-Gemfile.lock
-InstalledFiles
-_yardoc
-coverage
-doc/
-lib/bundler/man
-pkg
-rdoc
-spec/reports
-test/tmp
-test/version_tmp
-tmp
-benchmarks

data/.rubocop.yml

@@ -1,16 +0,0 @@
-plugins:
-  - rubocop-rake
-  - rubocop-rspec
-
-AllCops:
-  NewCops: enable
-
-Style/GlobalVars:
-  Exclude:
-    - ext/convolver/extconf.rb
-
-RSpec/ExampleLength:
-  Max: 30
-
-RSpec/MultipleExpectations:
-  Max: 7

data/Gemfile

@@ -1,15 +0,0 @@
-# frozen_string_literal: true
-
-source 'https://rubygems.org'
-
-# Specify your gem's dependencies in convolver.gemspec
-gemspec
-
-gem 'rake', '>= 1.9.1'
-gem 'rake-compiler', '>= 0.8.3'
-gem 'rspec', '>= 2.13.0'
-gem 'rubocop', '~> 1.85'
-gem 'rubocop-rake', '~> 0.7'
-gem 'rubocop-rspec', '~> 3.9'
-gem 'simplecov', '>= 0.22'
-gem 'yard', '>= 0.8.7.2'

data/Rakefile

@@ -1,22 +0,0 @@
-# frozen_string_literal: true
-
-require 'bundler/gem_tasks'
-require 'rspec/core/rake_task'
-require 'rake/extensiontask'
-
-desc 'Convolver unit tests'
-RSpec::Core::RakeTask.new(:test) do |t|
-  t.pattern = 'spec/*_spec.rb'
-  t.verbose = true
-end
-
-gemspec = Gem::Specification.load('convolver.gemspec')
-Rake::ExtensionTask.new do |ext|
-  ext.name = 'convolver'
-  ext.source_pattern = '*.{c,h}'
-  ext.ext_dir = 'ext/convolver'
-  ext.lib_dir = 'lib/convolver'
-  ext.gem_spec = gemspec
-end
-
-task default: %i[compile test]

data/convolver.gemspec

@@ -1,27 +0,0 @@
-# frozen_string_literal: true
-
-require 'English'
-lib = File.expand_path('lib', __dir__)
-$LOAD_PATH.unshift(lib) unless $LOAD_PATH.include?(lib)
-require 'convolver/version'
-
-Gem::Specification.new do |spec|
-  spec.name          = 'convolver'
-  spec.version       = Convolver::VERSION
-  spec.authors       = ['Neil Slater']
-  spec.email         = ['slobo777@gmail.com']
-  spec.description   = 'Convolution for NArray'
-  spec.summary       = 'Convolution for NArray'
-  spec.homepage      = 'http://github.com/neilslater/convolver'
-  spec.license       = 'MIT'
-  spec.required_ruby_version = '>= 3.2'
-
-  spec.add_dependency 'fftw3', '>= 0.3'
-  spec.add_dependency 'narray', '>= 0.6.0.8'
-
-  spec.files         = `git ls-files`.split($INPUT_RECORD_SEPARATOR)
-  spec.executables   = spec.files.grep(%r{^bin/}) { |f| File.basename(f) }
-  spec.extensions    = spec.files.grep(%r{/extconf\.rb$})
-  spec.require_paths = ['lib']
-  spec.metadata['rubygems_mfa_required'] = 'true'
-end

data/ext/convolver/narray_shared.c

@@ -1,61 +0,0 @@
-// ext/convolver/narray_shared.c
-
-#include "narray_shared.h"
-
-// This is copied from na_array.c, with safety checks and temp vars removed
-int na_quick_idxs_to_pos( int rank, int *shape, int *idxs ) {
-  int i, pos = 0;
-  for ( i = rank - 1; i >= 0; i-- ) {
-    pos = pos * shape[i] + idxs[i];
-  }
-  return pos;
-}
-
-// This is inverse of above
-void na_quick_pos_to_idxs( int rank, int *shape, int pos, int *idxs ) {
-  int i;
-  for ( i = 0; i < rank; i++ ) {
-    idxs[ i ] = pos % shape[i];
-    pos /= shape[i];
-  }
-  return;
-}
-
-// This is copied from na_array.c, with safety checks and temp vars removed
-inline int na_inline_idxs_to_pos( int rank, int *shape, int *idxs ) {
-  int i, pos = 0;
-  for ( i = rank - 1; i >= 0; i-- ) {
-    pos = pos * shape[i] + idxs[i];
-  }
-  return pos;
-}
-
-// This is inverse of above
-inline void na_inline_pos_to_idxs( int rank, int *shape, int pos, int *idxs ) {
-  int i;
-  for ( i = 0; i < rank; i++ ) {
-    idxs[ i ] = pos % shape[i];
-    pos /= shape[i];
-  }
-  return;
-}
-
-// used to place kernel data into array for FFTW3 processing
-void fit_backwards_raw( int rank, int *dst_shape, float *dst, int *src_shape, float *src, int *shift_shape ) {
-  int i, j, size, x;
-  int k_idx[16], dst_idx[16];
-
-  size = 1;
-  for ( j = 0; j < rank; j++ ) { size *= src_shape[j]; }
-
-  for ( i = 0; i < size; i++ ) {
-    na_inline_pos_to_idxs( rank, src_shape, i, k_idx );
-    for ( j = 0; j < rank; j++ ) {
-      x =  src_shape[j] - shift_shape[j] - k_idx[j] - 1;
-      if ( x < 0 ) x = x + dst_shape[j];
-      dst_idx[j] = x;
-    }
-    dst[ na_inline_idxs_to_pos( rank, dst_shape, dst_idx ) ] = src[i];
-  }
-  return;
-}

data/ext/convolver/narray_shared.h

@@ -1,22 +0,0 @@
-// ext/convolver/narray_shared.h
-
-////////////////////////////////////////////////////////////////////////////////////////////////
-//
-// Declarations of narray helper functions
-//
-
-#ifndef CONVOLVER_NARRAY_SHARED_H
-#define CONVOLVER_NARRAY_SHARED_H
-
-#include <ruby.h>
-#include "narray.h"
-
-// This is copied from na_array.c, with safety checks and temp vars removed
-int na_quick_idxs_to_pos( int rank, int *shape, int *idxs );
-
-// This is inverse of above
-void na_quick_pos_to_idxs( int rank, int *shape, int pos, int *idxs );
-
-void fit_backwards_raw( int rank, int *dst_shape, float *dst, int *src_shape, float *src, int *shift_shape );
-
-#endif

data/spec/convolver_basic_spec.rb

@@ -1,89 +0,0 @@
-# frozen_string_literal: true
-
-require 'helpers'
-
-describe Convolver do
-  describe '#convolve_basic' do
-    it 'works like the example in the README' do
-      a = NArray[0.3, 0.4, 0.5]
-      b = NArray[1.3, -0.5]
-      c = described_class.convolve_basic(a, b)
-      expect(c).to be_narray_like NArray[0.19, 0.27]
-    end
-
-    it 'calculates a 2D convolution' do
-      a = NArray[[0.3, 0.4, 0.5], [0.6, 0.8, 0.2], [0.9, 1.0, 0.1]]
-      b = NArray[[1.2, -0.5], [0.5, -1.3]]
-      c = described_class.convolve_basic(a, b)
-      expect(c).to be_narray_like NArray[[-0.58, 0.37], [-0.53, 1.23]]
-    end
-
-    it 'calculates a 2D convolution with rectangular arrays' do
-      a = NArray[ [0.3, 0.4, 0.5, 0.3, 0.4], [0.6, 0.8, 0.2, 0.8, 0.2],
-                  [0.9, 1.0, 0.1, 0.9, 1.0], [0.5, 0.9, 0.3, 0.2, 0.8], [0.7, 0.1, 0.3, 0.0, 0.1],
-                  [0.4, 0.5, 0.6, 0.7, 0.8], [0.5, 0.4, 0.3, 0.2, 0.1] ]
-      b = NArray[[1.2, -0.5, 0.2], [1.8, 0.5, -1.3]]
-      c = described_class.convolve_basic(a, b)
-      expect(c).to be_narray_like NArray[ [1.48, 0.79, 1.03], [2.35, 1.7, -0.79], [1.56, 2.84, -0.53],
-                                          [1.13, 1.3, 0.83], [1.04, 0.26, 0.77], [1.06, 1.05, 1.04] ]
-    end
-
-    it 'calculates a 3D convolution' do
-      # 5x4x3
-      a = NArray[
-        [[1.0, 0.6, 1.1, 0.2, 0.9], [1.0, 0.7, 0.8, 1.0, 1.0], [0.2, 0.6, 0.1, 0.2, 0.5],
-         [0.5, 0.9, 0.2, 0.1, 0.6]],
-        [[0.4, 0.9, 0.4, 0.0, 0.6], [0.2, 1.1, 0.2, 0.4, 0.1], [0.4, 0.2, 0.5, 0.8, 0.7],
-         [0.1, 0.9, 0.7, 0.1, 0.3]],
-        [[0.8, 0.6, 1.0, 0.1, 0.4], [0.3, 0.8, 0.6, 0.7, 1.1], [0.9, 1.0, 0.3, 0.4, 0.6],
-         [0.2, 0.5, 0.4, 0.7, 0.2]]
-      ]
-
-      # 3x3x3
-      b = NArray[
-        [[-0.9, 1.2, 0.8], [0.9, 0.1, -0.5], [1.1, 0.1, -1.1]],
-        [[-0.2, -1.0, 1.4], [-1.4, 0.0, 1.3], [0.3, 1.0, -0.5]],
-        [[0.6, 0.0, 0.7],   [-0.7, 1.1, 1.2], [1.3, 0.7, 0.0]]
-      ]
-
-      # Should be 3x2x1
-      c = described_class.convolve_basic(a, b)
-      expect(c).to be_narray_like NArray[[[5.51, 3.04, 4.3], [3.04, 6.31, 3.87]]]
-    end
-
-    it 'calculates a 4D convolution' do
-      # 3x4x5x3
-      a = NArray[
-        [[[0.5, 0.4, 0.9], [0.1, 0.9, 0.8], [0.4, 0.0, 0.1], [0.8, 0.3, 0.4]],
-         [[0.0, 0.4, 0.0], [0.2, 0.3, 0.8], [0.6, 0.3, 0.2], [0.7, 0.4, 0.3]],
-         [[0.3, 0.3, 0.1], [0.6, 0.9, 0.4], [0.4, 0.0, 0.1], [0.8, 0.3, 0.4]],
-         [[0.0, 0.4, 0.0], [0.2, 0.3, 0.8], [0.6, 0.3, 0.2], [0.7, 0.4, 0.3]],
-         [[0.3, 0.3, 0.1], [0.6, 0.9, 0.4], [0.4, 0.0, 0.1], [0.8, 0.3, 0.4]]],
-        [[[0.5, 0.4, 0.9], [0.1, 0.9, 0.8], [0.4, 0.0, 0.1], [0.8, 0.3, 0.4]],
-         [[0.0, 0.4, 0.0], [0.2, 0.3, 0.8], [0.6, 0.3, 0.2], [0.7, 0.4, 0.3]],
-         [[0.3, 0.3, 0.1], [0.6, 0.9, 0.4], [0.4, 0.0, 0.1], [0.8, 0.3, 0.4]],
-         [[0.0, 0.4, 0.0], [0.2, 0.3, 0.8], [0.6, 0.3, 0.2], [0.7, 0.4, 0.3]],
-         [[0.3, 0.3, 0.1], [0.6, 0.9, 0.4], [0.4, 0.0, 0.1], [0.8, 0.3, 0.4]]],
-        [[[0.5, 0.4, 0.9], [0.1, 0.9, 0.8], [0.4, 0.0, 0.1], [0.8, 0.3, 0.4]],
-         [[0.0, 0.4, 0.0], [0.2, 0.3, 0.8], [0.6, 0.3, 0.2], [0.7, 0.4, 0.3]],
-         [[0.3, 0.3, 0.1], [0.6, 0.9, 0.4], [0.4, 0.0, 0.1], [0.8, 0.3, 0.4]],
-         [[0.0, 0.4, 0.0], [0.2, 0.3, 0.8], [0.6, 0.3, 0.2], [0.7, 0.4, 0.3]],
-         [[0.3, 0.3, 0.1], [0.6, 0.9, 0.4], [0.4, 0.0, 0.1], [0.8, 0.3, 0.4]]] ]
-
-      # 2x3x3x2
-      b = NArray[ [
-        [[1.1, 0.6], [1.2, 0.6], [0.8, 0.1]], [[-0.4, 0.8], [0.5, 0.4], [1.2, 0.2]],
-        [[0.8, 0.2], [0.5, 0.0], [1.4, 1.3]]
-      ],
-                  [[[1.1, 0.6], [1.2, 0.6], [0.8, 0.1]], [[-0.4, 0.8], [0.5, 0.4], [1.2, 0.2]],
-                   [[0.8, 0.2], [0.5, 0.0], [1.4, 1.3]]] ]
-
-      # Should be 2x2x3x2
-      c = described_class.convolve_basic(a, b)
-      expect(c).to be_narray_like NArray[
-        [[[8.5, 8.2], [11.34, 9.68]], [[7.68, 6.56], [11.24, 7.16]], [[9.14, 6.54], [12.44, 9.2]]],
-        [[[8.5, 8.2], [11.34, 9.68]], [[7.68, 6.56], [11.24, 7.16]], [[9.14, 6.54], [12.44, 9.2]]]
-      ]
-    end
-  end
-end