convertator 0.1.1 → 0.2.0

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA1:
-  metadata.gz: fec0ef4b0e1409a1223912e8b22f0ec8094822ff
-  data.tar.gz: 6f8abbd25071d4e7ed68628b6f15f3a8a58f1b45
+  metadata.gz: bc7a6facbe3c191895e300323d3edef1ade43fb6
+  data.tar.gz: eaa33fe8665055b55049f7cef821f3402bb06432
 SHA512:
-  metadata.gz: '01595668a682cc1b476657e4ad0a6402b2370c9c2fcdf7d2fa4140033a7cdf18542dee4a5735dab70d3879cbca3fa29343e49b9ab1b4b07fb85fd3a03db01e61'
-  data.tar.gz: f37171f28f4eda3a988b307d5e964720896d51cb51fa2dfda46bbebdc647fb9ae2e3814d48077d0e3c0cc752b5e35bdf8e5a216487840674a6ed78fbf453bf69
+  metadata.gz: eaa2be165648f8ecd29ff4e29e62409a2021e6a8fc81d10bb6c608827de6f767554537fc02ec4a6891a8cc6f108211084edf8c66f9b5ae2aa16ccff69d4fa4da
+  data.tar.gz: 727eb42164a427c3ab1c6bde3ba300c93adcc0f3259617cfce71637dd859f036e57de32ffe80786fd6d8c777d0a97a9d8f522096c0950a0bc9755a8cc022e7e0

data/.rubocop.yml

@@ -0,0 +1,4 @@
+Style/Documentation:
+  Enabled: false
+Metrics/BlockLength:
+  Enabled: false

data/README.md

@@ -1,11 +1,14 @@
 # Convertator
 
-A simple rate exchange converter.
+A simple currency converter which can use different sources to fetch rates and provides a rack-like middleware feature.
 
 [![Gem Version](https://badge.fury.io/rb/convertator.svg)](https://badge.fury.io/rb/convertator)
 
 ## Usage
 
+
+**Simple example**
+
 ```ruby
 require 'convertator/converter'
 
@@ -16,6 +19,21 @@ converter.convert_digits(100, :RUB, :USD)
 => "5500.0"
 ```
 
+
+**Multi convertion**
+
+```ruby
+Convertator::Converter.new.convert_multi_s(100, :GBP, [:AMD, :RUB, :GBP])
+=> ["15.7142857144", "1.4285714286", "100.0"]
+```
+
+
+**Define accuracy and handler**
+
+```ruby
+Convertator::Converter.new(:static, 7)
+```
+
 ## Installation
 
 Add this line to your application's Gemfile:

data/Rakefile

@@ -1,6 +1,6 @@
-require "bundler/gem_tasks"
-require "rspec/core/rake_task"
+require 'bundler/gem_tasks'
+require 'rspec/core/rake_task'
 
 RSpec::Core::RakeTask.new(:spec)
 
-task :default => :spec
+task default: :spec

data/bin/console

@@ -1,7 +1,7 @@
 #!/usr/bin/env ruby
 
-require "bundler/setup"
-require "convertator"
+require 'bundler/setup'
+require 'convertator'
 
 # You can add fixtures and/or initialization code here to make experimenting
 # with your gem easier. You can also use a different console, if you like.
@@ -10,5 +10,5 @@ require "convertator"
 # require "pry"
 # Pry.start
 
-require "irb"
+require 'irb'
 IRB.start(__FILE__)

data/convertator.gemspec

@@ -1,4 +1,5 @@
 # coding: utf-8
+
 lib = File.expand_path('../lib', __FILE__)
 $LOAD_PATH.unshift(lib) unless $LOAD_PATH.include?(lib)
 require 'convertator/version'
@@ -9,8 +10,8 @@ Gem::Specification.new do |spec|
   spec.authors       = ['Ivan Zinovyev']
   spec.email         = ['vanyazin@gmail.com']
 
-  spec.summary       = %q{Rate exchange converter}
-  spec.homepage      = "https://github.com/zinovyev/convertator"
+  spec.summary       = 'Simple currency converter'
+  spec.homepage      = 'https://github.com/zinovyev/convertator'
   spec.license       = 'MIT'
 
   spec.files         = `git ls-files -z`.split("\x0").reject do |f|
@@ -23,5 +24,6 @@ Gem::Specification.new do |spec|
   spec.add_development_dependency 'bundler', '~> 1.14'
   spec.add_development_dependency 'rake', '~> 10.0'
   spec.add_development_dependency 'rspec', '~> 3.0'
+  spec.add_development_dependency 'rubocop', '~> 0.48.1'
   spec.add_development_dependency 'pry', '~> 0.10.3'
 end

data/lib/convertator/base_provider.rb

@@ -2,7 +2,7 @@ module Convertator
   class BaseProvider
     def new_rates
       raise ::NotImplementedError,
-        "Method new_rates should be implemented by every rates provider"
+            'Method new_rates should be implemented by every rates provider'
     end
   end
 end

data/lib/convertator/converter.rb

@@ -13,29 +13,49 @@ module Convertator
     end
 
     def rates
-      rates ||= @provider.new_rates
+      @provider.new_rates
     end
 
     def rate(currency)
       currency = normalize_currency(currency)
-      raise UnknownCurrencyError unless rates[currency]
-      BigDecimal.new(rates[currency], @accuracy)
+      rate = rates[currency]
+      raise UnknownCurrencyError, "Unknown currency #{currency}" unless rate
+      round(BigDecimal.new(rate, @accuracy))
     end
 
     def ratio(currency_from, currency_to)
-      rate(currency_from) / rate(currency_to)
+      round(rate(currency_from) / rate(currency_to))
     end
 
     def convert(amount, currency_from, currency_to)
-      amount / ratio(currency_from, currency_to)
+      round(amount / ratio(currency_from, currency_to))
     end
 
-    def convert_digits(amount, currency_from, currency_to)
-      convert(amount, currency_from, currency_to).to_digits
+    def convert_s(amount, currency_from, currency_to)
+      round(convert(amount, currency_from, currency_to)).to_digits
+    end
+
+    def convert_multi(amount, currency_from, currencies_to)
+      currencies_to.map do |currency_to|
+        convert(amount, currency_from, currency_to)
+      end
+    end
+
+    def convert_multi_s(amount, currency_from, currencies_to)
+      currencies_to.map do |currency_to|
+        convert_s(amount, currency_from, currency_to)
+      end
     end
 
     private
 
+    def round(value)
+      BigDecimal.save_rounding_mode do
+        BigDecimal.mode(BigDecimal::ROUND_MODE, :half_up)
+        value.round(@accuracy)
+      end
+    end
+
     def load_provider(name)
       try_require(name)
       klass = Object.const_get(

data/lib/convertator/providers/cbr_provider.rb

@@ -4,9 +4,9 @@ require 'rexml/document'
 module Convertator
   module Providers
     class CbrProvider
-      SERVICE_URI = 'http://www.cbr.ru/scripts/xml_daily.asp'
+      SERVICE_URI = 'http://www.cbr.ru/scripts/xml_daily.asp'.freeze
 
-      def new_rates 
+      def new_rates
         default_rates.merge parse(fetch)
       end
 
@@ -14,7 +14,7 @@ module Convertator
 
       def default_rates
         {
-          RUB: "1",
+          RUB: '1'
         }
       end
 
@@ -31,7 +31,7 @@ module Convertator
 
       def fetch
         uri = URI(SERVICE_URI)
-        ::Net::HTTP.get(uri) 
+        ::Net::HTTP.get(uri)
       end
     end
   end

data/lib/convertator/version.rb

@@ -1,3 +1,3 @@
 module Convertator
-  VERSION = "0.1.1"
+  VERSION = '0.2.0'.freeze
 end

data/lib/convertator.rb

@@ -1,4 +1,4 @@
-require "convertator/version"
+require 'convertator/version'
 
 module Convertator
   # Your code goes here...

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: convertator
 version: !ruby/object:Gem::Version
-  version: 0.1.1
+  version: 0.2.0
 platform: ruby
 authors:
 - Ivan Zinovyev
 autorequire: 
 bindir: exe
 cert_chain: []
-date: 2017-04-05 00:00:00.000000000 Z
+date: 2017-04-06 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: bundler
@@ -52,6 +52,20 @@ dependencies:
     - - "~>"
       - !ruby/object:Gem::Version
         version: '3.0'
+- !ruby/object:Gem::Dependency
+  name: rubocop
+  requirement: !ruby/object:Gem::Requirement
+    requirements:
+    - - "~>"
+      - !ruby/object:Gem::Version
+        version: 0.48.1
+  type: :development
+  prerelease: false
+  version_requirements: !ruby/object:Gem::Requirement
+    requirements:
+    - - "~>"
+      - !ruby/object:Gem::Version
+        version: 0.48.1
 - !ruby/object:Gem::Dependency
   name: pry
   requirement: !ruby/object:Gem::Requirement
@@ -75,6 +89,7 @@ extra_rdoc_files: []
 files:
 - ".gitignore"
 - ".rspec"
+- ".rubocop.yml"
 - ".travis.yml"
 - CODE_OF_CONDUCT.md
 - Gemfile
@@ -113,5 +128,5 @@ rubyforge_project:
 rubygems_version: 2.6.8
 signing_key: 
 specification_version: 4
-summary: Rate exchange converter
+summary: Simple currency converter
 test_files: []