conversant 1.0.18 → 1.0.20

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: b40e1ec2641cec2c860a7de9bb7a5bb9ff8a85bde847cf9520139f288c9883c3
-  data.tar.gz: 9c15c4e3153aad9d60782fe748e3e4324ba573307b6ba91f357be9d78cfab3d1
+  metadata.gz: 428022316d577c54962bff0866371094de01192f3ffd3bdb4bf163dabd7eb55f
+  data.tar.gz: 146d4c61baedbc413f96bbd86262ec893263526956ea659d2d2489cb0e44e8b8
 SHA512:
-  metadata.gz: ea35d31fc8722f9955e620fb285fe8376fa57a72d18da0a1de12f44de82cff8ad71f76a0c0ce30b50a63faab4cccccdf095867df19ecf4f841762d7f64da07bc
-  data.tar.gz: 04f3fed5093b6388c9e66b7991542fe459cbd2b59dec0d50ad21b7de5e358f7f25445cd9617c748236d1b2ced8cc71aea03a7083b05ea4fccf4a75bf6cc87223
+  metadata.gz: 8cec1bf543d749082ce25aaf7a36b9c58083168d4e360b26d559571f85a7110d2572fe261d6743bd505ae2ba90facfd0a1e629e7829a0a7cb78b62ed7f47f8ec
+  data.tar.gz: 246e1ef85cb4705d8dd61e64ae125b49cbb1caf2f93aeffe9d5d0b41c5bc1ae77bfaee393ce9a8bbe46653c29494719d657534447d274ab06104a9c9f460a4ac

data/.gitignore

@@ -49,4 +49,8 @@ Gemfile.lock
 
 # Test artifacts
 /spec/cassettes/
-/spec/fixtures/vcr_cassettes/
+/spec/fixtures/vcr_cassettes/
+/.claude/
+/.repomixignore
+/CLAUDE.md
+/release-manifest.json

data/.gitlab-ci.yml

@@ -7,6 +7,16 @@ stages:
 
 variables:
   BUNDLE_PATH: vendor/bundle
+  GIT_STRATEGY: clone
+  GIT_DEPTH: "20"
+
+# Wipe runner build dir before clone — prevents stale ref conflicts
+# (e.g. "couldn't set 'refs/remotes/origin/rebases/ci'" when
+# a sibling ref like 'rebases' exists from earlier jobs).
+default:
+  hooks:
+    pre_get_sources_script:
+      - rm -rf "$CI_PROJECT_DIR/.git" || true
 
 # Cache dependencies
 cache:
@@ -19,8 +29,9 @@ cache:
 .ruby_template: &ruby_template
   image: ruby:3.0
   before_script:
-    - gem install bundler -v 2.4.0
+    - gem install bundler -v 2.4.22
     - bundle config set --local path 'vendor/bundle'
+    - mkdir -p vendor/bundle
     - bundle install --jobs $(nproc)
 
 # Run tests on multiple Ruby versions

data/.rubocop.yml

@@ -1,16 +1,53 @@
+AllCops:
+  TargetRubyVersion: 2.7
+  NewCops: disable
+  SuggestExtensions: false
+  Exclude:
+    - 'vendor/**/*'
+    - 'tmp/**/*'
+    - 'examples/**/*'   # demo scripts, not production
+    - 'spec/**/*'
+    - 'bin/**/*'
+    - 'exe/**/*'
+
+# --- Layout ---
 Layout/EndOfLine:
-  Enabled: False
+  Enabled: false
+Layout/LineLength:
+  Max: 150          # vendor API URLs / long YARD comments
+
+# --- Metrics — service classes wrap vendor APIs, tend to be long ---
 Metrics/MethodLength:
-  Max: 50
+  Max: 60
 Metrics/AbcSize:
-  Max: 50
+  Max: 70
   CountRepeatedAttributes: false
 Metrics/CyclomaticComplexity:
-  Max: 10
+  Max: 25
+Metrics/PerceivedComplexity:
+  Max: 25
 Metrics/ClassLength:
   Max: 500
+Metrics/ModuleLength:
+  Max: 300
+Metrics/BlockLength:
+  Max: 50
 Metrics/ParameterLists:
   Max: 5
   MaxOptionalParameters: 5
-Metrics/PerceivedComplexity:
-  Max: 10
+
+# --- Style — only disable cops that conflict with codebase reality ---
+Style/Documentation:
+  Enabled: false              # too many classes, low ROI
+Style/GlobalVars:
+  Enabled: false              # $redis is Rails convention
+Style/StringLiterals:
+  EnforcedStyle: single_quotes
+  ConsistentQuotesInMultiline: false
+
+# --- Naming — vendor API forces non-conformant names ---
+Naming/VariableNumber:
+  Enabled: false              # mDataProp_0, bSortable_1 are vendor API params
+Naming/AccessorMethodName:
+  Exclude:
+    - '**/lms/dashboard.rb'   # parses HTML tables, get_X reads better

data/CHANGELOG.md

@@ -5,6 +5,26 @@ All notable changes to this project will be documented in this file.
 The format is based on [Keep a Changelog](https://keepachangelog.com/en/1.0.0/),
 and this project adheres to [Semantic Versioning](https://semver.org/spec/v2.0.0.html).
 
+## [1.0.20] - 2026-07-04
+
+### Fixed
+- **SSO Login URL hardcoded to dead domain**: `V3::HttpClient` used a hardcoded `LOGIN_URL = 'https://console.swiftfederation.com/'` constant, ignoring configuration. After the domain migration to `flashcone.com`, SSO login failed with `Connection refused`, producing `Missing SESSION for CDN` and empty usages responses.
+  - Removed the `LOGIN_URL` constant; added private `#login_url` resolving from `configuration.portal_endpoint` (ENV-driven: `PRIVATE_PORTAL_ENDPOINT` / `PORTAL_ROOT_HOSTNAME`), normalized with a single trailing slash
+  - Login page URL is now fully config/ENV-driven — no base domain hardcoded
+
+### Changed
+- **Default portal/SSO hostnames** in `Configuration` updated from the retired `*.swiftfederation.com` to `console.flashcone.com` / `sso2.flashcone.com` (only used when ENV is unset)
+- Updated RBS in `sig/conversant/v3.rbs`: removed `LOGIN_URL` constant, added `login_url` method signature
+
+## [1.0.19] - 2026-02-06
+
+### Fixed
+- **LMS Job RBS Type Signatures**: Updated RBS signatures in `sig/conversant/v3/services/lms.rbs` to match actual implementation
+  - Fixed `where` return type from `Array[Hash[String, untyped]]` to `Array[Hash[Symbol, untyped]]?` (nilable, symbol keys)
+  - Fixed `parse_status` parameter type from `Integer | String | nil` to `Integer` (value is always `.to_i`)
+  - Fixed `build_manifest_url` signature to `(String? play_domain, Hash item, String? output_type)` matching actual parameters
+  - Removed non-existent `build_profile_url` method signature
+
 ## [1.0.18] - 2025-10-08
 
 ### Fixed

data/Gemfile

@@ -9,4 +9,4 @@ gemspec
 group :development, :test do
   gem 'pry-byebug'
   gem 'simplecov', require: false
-end
+end

data/README.md

@@ -472,9 +472,9 @@ jobs = lms.job.where(
 )
 
 jobs.each do |job|
-  puts "Job #{job['id']}: #{job['name']}"
-  puts "  Status: #{job['status']}"
-  puts "  Created: #{job['created_at']}"
+  puts "Job #{job[:id]}: #{job[:name]}"
+  puts "  Status: #{job[:status]}"
+  puts "  Created: #{job[:created_at]}"
 end
 
 # Domain Management
@@ -834,20 +834,13 @@ end
 
 ## Version Notes
 
-### Latest Release: 1.0.10 (2025-09-30)
+### Latest Release: 1.0.19 (2026-02-06)
 
-**Documentation Update**: Enhanced documentation for v1.0.9 critical fixes
+**RBS Type Signature Fix**: Updated LMS Job RBS signatures to match actual implementation
 
-### Version 1.0.9 - Critical Bug Fix
-
-**Fixed authentication issues with LMS and VMS services:**
-
-- ✅ Fixed JSESSIONID authentication for LMS service (resolves "Missing JSESSIONID" error)
-- ✅ Fixed JSESSIONID authentication for VMS service
-- ✅ Improved RestClient cookie handling (switched from manual `'Cookie'` header to `:cookies` option)
-- ✅ Fixed method visibility issues in Authorization module
-
-**Upgrade recommended** if you're using LMS or VMS services. CDN and Portal services are unaffected.
+- Fixed `where` return type to `Array[Hash[Symbol, untyped]]?`
+- Fixed `build_manifest_url` parameter signature
+- Removed non-existent `build_profile_url` method signature
 
 See [CHANGELOG.md](CHANGELOG.md) for complete version history.
 

data/Rakefile

@@ -18,4 +18,4 @@ task :console do
   require 'conversant'
   require 'pry'
   Pry.start
-end
+end

data/conversant.gemspec

@@ -9,7 +9,12 @@ Gem::Specification.new do |spec|
   spec.email         = ['tho.nguyen@vnetwork.vn']
 
   spec.summary       = 'Ruby client for Conversant CDN API (V3)'
-  spec.description   = 'A Ruby gem providing a clean interface to interact with Conversant/SwiftFederation CDN services including Portal, CDN, and LMS APIs with V3 authentication support. Features zero-configuration setup, automatic ENV detection, and seamless integration with existing Conversant implementations.'
+  spec.description   = <<~DESC
+    A Ruby gem providing a clean interface to interact with Conversant/SwiftFederation
+    CDN services including Portal, CDN, and LMS APIs with V3 authentication support.
+    Features zero-configuration setup, automatic ENV detection, and seamless integration
+    with existing Conversant implementations.
+  DESC
   spec.homepage      = 'https://gitlab.vnetwork.dev/gems/conversant'
   spec.license       = 'MIT'
   spec.required_ruby_version = '>= 2.7.0'
@@ -39,7 +44,7 @@ Gem::Specification.new do |spec|
 
   # Development dependencies
   spec.add_development_dependency 'bundler', '~> 2.0'
-  spec.add_development_dependency 'pry', '~> 0.14'
+  spec.add_development_dependency 'pry', '~> 0.14.0'
   spec.add_development_dependency 'rake', '~> 13.0'
   spec.add_development_dependency 'rspec', '~> 3.12'
   spec.add_development_dependency 'rubocop', '~> 1.50'

data/examples/inheritance_integration.rb

@@ -193,10 +193,7 @@ module Utils
 
         private
 
-        def configuration
-          ::Conversant.configuration
-        end
-
+        # `configuration` is already provided by the Authentication mixin (private).
         def logger
           configuration.logger
         end

data/lib/conversant/configuration.rb

@@ -26,8 +26,8 @@ module Conversant
       # Users only need to override if they want different values
 
       # Portal configuration - defaults from ENV
-      @portal_root_hostname = ENV['PORTAL_ROOT_HOSTNAME'] || 'console.swiftfederation.com'
-      @portal_sso_hostname = ENV['PORTAL_SSO_HOSTNAME'] || 'sso.swiftfederation.com'
+      @portal_root_hostname = ENV['PORTAL_ROOT_HOSTNAME'] || 'console.flashcone.com'
+      @portal_sso_hostname = ENV['PORTAL_SSO_HOSTNAME'] || 'sso2.flashcone.com'
 
       # API Endpoints - defaults from ENV (matching existing CONVERSANT setup)
       @private_cdn_endpoint = ENV['PRIVATE_CDN_ENDPOINT']
@@ -56,14 +56,12 @@ module Conversant
 
       # Redis - auto-detect from global $redis or ENV
       @redis = if defined?($redis) && $redis
-        $redis
-      elsif defined?(::Redis) && ENV['REDIS_URL']
-        ::Redis.new(url: ENV['REDIS_URL'])
-      elsif defined?(::Redis)
-        ::Redis.new
-      else
-        nil
-      end
+                 $redis
+               elsif defined?(::Redis) && ENV['REDIS_URL']
+                 ::Redis.new(url: ENV['REDIS_URL'])
+               elsif defined?(::Redis)
+                 ::Redis.new
+               end
     end
 
     def portal_endpoint
@@ -79,18 +77,18 @@ module Conversant
 
       # Only require credentials if not auto-configured
       unless auto_configured?
-        required_fields += [
-          :swiftserve_identifier_id,
-          :swiftserve_identifier_hash
+        required_fields += %i[
+          swiftserve_identifier_id
+          swiftserve_identifier_hash
         ]
       end
 
       # Always require endpoints
-      required_fields += [
-        :private_cdn_endpoint,
-        :private_lms_endpoint,
-        :private_vms_endpoint,
-        :redis
+      required_fields += %i[
+        private_cdn_endpoint
+        private_lms_endpoint
+        private_vms_endpoint
+        redis
       ]
 
       missing_fields = required_fields.select { |field| send(field).nil? || send(field).to_s.empty? }
@@ -129,4 +127,4 @@ module Conversant
       config
     end
   end
-end
+end

data/lib/conversant/v3/base.rb

@@ -44,4 +44,4 @@ module Conversant
       end
     end
   end
-end
+end

data/lib/conversant/v3/http_client.rb

@@ -20,9 +20,6 @@ module Conversant
     #
     # @since 1.0.0
     module HttpClient
-      # Default login URL for SSO authentication
-      LOGIN_URL = 'https://console.swiftfederation.com/'
-
       # Redis key for storing portal SESSION cookie
       PORTAL_SESSION_REDIS_KEY = 'CONVERSANT.V3.PORTAL.SESSION'
 
@@ -115,8 +112,8 @@ module Conversant
           self.cookie_jar = {}
 
           # Step 1: Get login page and extract form action
-          debug_log "[SSO Login - Step 1] Fetching login page: #{LOGIN_URL}"
-          login_page_response = http_get(LOGIN_URL)
+          debug_log "[SSO Login - Step 1] Fetching login page: #{login_url}"
+          login_page_response = http_get(login_url)
           return nil unless login_page_response
 
           debug_log "Login page loaded, status: #{login_page_response[:status]}"
@@ -139,8 +136,8 @@ module Conversant
 
           debug_log '[SSO Login - Step 3] Submitting login form...'
           login_response = http_post(form_action, form_data, {
-            'Content-Type' => 'application/x-www-form-urlencoded'
-          })
+                                       'Content-Type' => 'application/x-www-form-urlencoded'
+                                     })
 
           return nil unless login_response
 
@@ -165,7 +162,6 @@ module Conversant
 
           debug_log 'New SSO login failed - no valid sessions obtained'
           nil
-
         rescue StandardError => e
           configuration.logger.error "Conversant::V3 - SSO login error: #{e.message}"
           nil
@@ -191,13 +187,11 @@ module Conversant
       def authenticate
         result = sso_login
 
-        if result && result[:session]
-          redis.set(PORTAL_SESSION_REDIS_KEY, result[:session], ex: configuration.cache_ttl)
-          redis.set(SSO_GW_SESSION2_REDIS_KEY, result[:sso_gw_session2], ex: configuration.cache_ttl) if result[:sso_gw_session2]
-          result
-        else
-          nil
-        end
+        return unless result && result[:session]
+
+        redis.set(PORTAL_SESSION_REDIS_KEY, result[:session], ex: configuration.cache_ttl)
+        redis.set(SSO_GW_SESSION2_REDIS_KEY, result[:sso_gw_session2], ex: configuration.cache_ttl) if result[:sso_gw_session2]
+        result
       end
 
       # Makes an authenticated HTTP request
@@ -224,9 +218,7 @@ module Conversant
         debug_log "[Request] Headers: #{headers.inspect}" if configuration.debug_mode
 
         # Check Content-Type using string key (headers are now plain hash with string keys)
-        if headers&.[]('Content-Type') == configuration.default_content_type
-          payload = payload&.to_json
-        end
+        payload = payload&.to_json if headers&.[]('Content-Type') == configuration.default_content_type
 
         request = RestClient::Request.new(
           method: method,
@@ -270,7 +262,7 @@ module Conversant
           headers: headers,
           verify_ssl: configuration.verify_ssl,
           max_redirects: 10
-        ) do |resp, request, result|
+        ) do |resp, _request, _result|
           update_cookie_jar(resp)
 
           case resp.code
@@ -319,7 +311,7 @@ module Conversant
           headers: headers,
           verify_ssl: configuration.verify_ssl,
           max_redirects: 10
-        ) do |resp, request, result|
+        ) do |resp, _request, _result|
           update_cookie_jar(resp)
 
           case resp.code
@@ -387,10 +379,10 @@ module Conversant
           end
         end
 
-        if response.respond_to?(:cookies) && response.cookies.is_a?(Hash)
-          response.cookies.each do |name, value|
-            cookie_jar[name.to_s] = value.to_s
-          end
+        return unless response.respond_to?(:cookies) && response.cookies.is_a?(Hash)
+
+        response.cookies.each do |name, value|
+          cookie_jar[name.to_s] = value.to_s
         end
       end
 
@@ -425,19 +417,25 @@ module Conversant
 
         # Parse HTML to find form action URL
         match = html_body.match(/form[^>]*id=["']kc-form-login["'][^>]*action=["']([^"']*)["']/)
-        if match
-          return CGI.unescapeHTML(match[1])
-        end
+        return CGI.unescapeHTML(match[1]) if match
 
         # Fallback: look for any form with action
         match = html_body.match(/form[^>]*action=["']([^"']*)["']/)
-        if match
-          return CGI.unescapeHTML(match[1])
-        end
+        return CGI.unescapeHTML(match[1]) if match
 
         nil
       end
 
+      # Returns the SSO login page URL (portal console root)
+      #
+      # Resolved from configuration (ENV-driven) so the base domain is never
+      # hardcoded. Always normalized with a single trailing slash.
+      #
+      # @return [String] Login page URL, e.g. "https://console.flashcone.com/"
+      def login_url
+        "#{configuration.portal_endpoint.chomp('/')}/"
+      end
+
       # Returns the global Conversant configuration
       #
       # @return [Conversant::Configuration] Configuration instance
@@ -453,4 +451,4 @@ module Conversant
       end
     end
   end
-end
+end

data/lib/conversant/v3/mixins/authentication.rb

@@ -218,4 +218,4 @@ module Conversant
       end
     end
   end
-end
+end

data/lib/conversant/v3/services/cdn/analytics.rb

@@ -75,7 +75,7 @@ module Conversant
             if response&.[]('bandwidth')
               {
                 averageThroughput: response&.[]('averageThroughput'),
-                data: response&.[]('bandwidth'),
+                data: response&.[]('bandwidth')
               }
             end
           rescue StandardError => e
@@ -170,7 +170,7 @@ module Conversant
                 avgQuantity: response['avgQuantity'],
                 httpTotalQuantity: response['httpTotalQuantity'],
                 httpsTotalQuantity: response['httpsTotalQuantity'],
-                data: response['datas'],
+                data: response['datas']
               }
             end
           rescue StandardError => e
@@ -312,8 +312,7 @@ module Conversant
           # @since 1.0.8
           def request_hit_rate(params)
             query_string = URI.encode_www_form(params)
-            response = JSON.parse(@parent.send(:call, 'GET', "/api/hit_rate_chart_data?#{query_string}", nil))
-            response
+            JSON.parse(@parent.send(:call, 'GET', "/api/hit_rate_chart_data?#{query_string}", nil))
           rescue StandardError => e
             @parent.send(:logger).error "#{@parent.send(:identifier)}.METHOD:#{__method__}.EXCEPTION:#{e.message}"
             nil
@@ -326,8 +325,7 @@ module Conversant
           # @since 1.0.8
           def byte_hit_rate(params)
             query_string = URI.encode_www_form(params)
-            response = JSON.parse(@parent.send(:call, 'GET', "/api/byte_rate_chart_data?#{query_string}", nil))
-            response
+            JSON.parse(@parent.send(:call, 'GET', "/api/byte_rate_chart_data?#{query_string}", nil))
           rescue StandardError => e
             @parent.send(:logger).error "#{@parent.send(:identifier)}.METHOD:#{__method__}.EXCEPTION:#{e.message}"
             nil
@@ -379,8 +377,7 @@ module Conversant
           # @return [Hash, nil] total referrer data, or nil on error
           # @since 1.0.8
           def referrer_total_by_domain(payload)
-            response = JSON.parse(@parent.send(:call, 'POST', '/api/report/getReferrerTotalByDomain', payload))
-            response
+            JSON.parse(@parent.send(:call, 'POST', '/api/report/getReferrerTotalByDomain', payload))
           rescue StandardError => e
             @parent.send(:logger).error "#{@parent.send(:identifier)}.METHOD:#{__method__}.EXCEPTION:#{e.message}"
             nil
@@ -392,8 +389,7 @@ module Conversant
           # @return [String, nil] CSV data, or nil on error
           # @since 1.0.8
           def referrer_csv_by_domain(payload)
-            response = @parent.send(:call, 'POST', '/api/report/getReferrerCsvByDomain', payload)
-            response
+            @parent.send(:call, 'POST', '/api/report/getReferrerCsvByDomain', payload)
           rescue StandardError => e
             @parent.send(:logger).error "#{@parent.send(:identifier)}.METHOD:#{__method__}.EXCEPTION:#{e.message}"
             nil
@@ -405,8 +401,7 @@ module Conversant
           # @return [Hash, nil] total URL data, or nil on error
           # @since 1.0.8
           def popular_content_url_total_by_domain(payload)
-            response = JSON.parse(@parent.send(:call, 'POST', '/api/report/getUrlTotalByDomain', payload))
-            response
+            JSON.parse(@parent.send(:call, 'POST', '/api/report/getUrlTotalByDomain', payload))
           rescue StandardError => e
             @parent.send(:logger).error "#{@parent.send(:identifier)}.METHOD:#{__method__}.EXCEPTION:#{e.message}"
             nil
@@ -418,8 +413,7 @@ module Conversant
           # @return [String, nil] CSV data, or nil on error
           # @since 1.0.8
           def popular_content_url_csv_by_domain(payload)
-            response = @parent.send(:call, 'POST', '/api/report/getUrlCsvByDomain', payload)
-            response
+            @parent.send(:call, 'POST', '/api/report/getUrlCsvByDomain', payload)
           rescue StandardError => e
             @parent.send(:logger).error "#{@parent.send(:identifier)}.METHOD:#{__method__}.EXCEPTION:#{e.message}"
             nil
@@ -431,8 +425,7 @@ module Conversant
           # @return [Hash, nil] request/visit statistics, or nil on error
           # @since 1.0.8
           def request_visit_number(payload)
-            response = JSON.parse(@parent.send(:call, 'POST', '/api/report/request_visit_number', payload))
-            response
+            JSON.parse(@parent.send(:call, 'POST', '/api/report/request_visit_number', payload))
           rescue StandardError => e
             @parent.send(:logger).error "#{@parent.send(:identifier)}.METHOD:#{__method__}.EXCEPTION:#{e.message}"
             nil
@@ -470,8 +463,7 @@ module Conversant
           # @return [String, nil] CSV data, or nil on error
           # @since 1.0.8
           def user_agent_csv(payload)
-            response = @parent.send(:call, 'POST', '/api/report/domain/userAgentCsv', payload)
-            response
+            @parent.send(:call, 'POST', '/api/report/domain/userAgentCsv', payload)
           rescue StandardError => e
             @parent.send(:logger).error "#{@parent.send(:identifier)}.METHOD:#{__method__}.EXCEPTION:#{e.message}"
             nil
@@ -480,4 +472,4 @@ module Conversant
       end
     end
   end
-end
+end

data/lib/conversant/v3/services/cdn/audit.rb

@@ -68,4 +68,4 @@ module Conversant
       end
     end
   end
-end
+end

data/lib/conversant/v3/services/cdn/certificate.rb

@@ -177,4 +177,4 @@ module Conversant
       end
     end
   end
-end
+end

data/lib/conversant/v3/services/cdn/dashboard.rb

@@ -106,4 +106,4 @@ module Conversant
       end
     end
   end
-end
+end

data/lib/conversant/v3/services/cdn/domain.rb

@@ -64,12 +64,11 @@ module Conversant
               return [] if response.nil?
 
               response = JSON.parse(response)
-              if response&.[]('list')
-                domains = response['list'].to_json
-                redis.set(key, domains, ex: 600)
-              else
-                return []
-              end
+              return [] unless response&.[]('list')
+
+              domains = response['list'].to_json
+              redis.set(key, domains, ex: 600)
+
             end
 
             JSON.parse(domains).map do |item|
@@ -220,4 +219,4 @@ module Conversant
       end
     end
   end
-end
+end

data/lib/conversant/v3/services/cdn/monitoring.rb

@@ -62,4 +62,4 @@ module Conversant
       end
     end
   end
-end
+end

data/lib/conversant/v3/services/cdn/partner/analytics.rb

@@ -230,4 +230,4 @@ module Conversant
       end
     end
   end
-end
+end

data/lib/conversant/v3/services/cdn/partner.rb

@@ -57,4 +57,4 @@ module Conversant
 end
 
 # Load nested analytics class after Partner is defined
-require_relative 'partner/analytics'
+require_relative 'partner/analytics'

data/lib/conversant/v3/services/lms/dashboard.rb

@@ -56,9 +56,9 @@ module Conversant
             table = doc.at('table')
             return [] if table.nil?
 
-            jobs = table.search('tr').map do |row|
+            table.search('tr').map do |row|
               cells = row.search('td')
-              next [] if cells.length.zero?
+              next [] if cells.empty?
 
               app_name, stream_name, type, created, started, recording, status = cells
 
@@ -72,8 +72,6 @@ module Conversant
                 status: status&.text&.strip
               }
             end.flatten.compact
-
-            jobs
           rescue StandardError => e
             logger.error "#{@parent.send(:identifier)}.METHOD:#{__method__}.EXCEPTION:#{e.message}"
             []
@@ -96,4 +94,4 @@ module Conversant
       end
     end
   end
-end
+end

data/lib/conversant/v3/services/lms/domain.rb

@@ -105,4 +105,4 @@ module Conversant
       end
     end
   end
-end
+end