convergence 1.0.6 → 1.2.0

data/spec/postgres_integrations/command_dryrun.rb

@@ -0,0 +1,101 @@
+require 'spec_helper'
+require 'convergence/command/dryrun'
+
+describe 'PostgreSQL Command::Dryrun#execute' do
+  def execute(dsl_path, extra_options = {})
+    parse_option = {
+      input: File.expand_path("#{File.dirname(__FILE__)}/../fixtures/postgres/#{dsl_path}")
+    }.merge(extra_options)
+    Convergence::Command::Dryrun.new(parse_option, config: postgres_settings).execute
+  end
+
+  describe 'change table options' do
+    let(:exec_dsl) { 'change_table_comment_to_paper.schema' }
+
+    it 'should be output alter table query' do
+      result = execute(exec_dsl)
+      expect(result).to be_include(%(# COMMENT ON TABLE "authors" IS 'Author Table';))
+    end
+  end
+
+  describe 'add table' do
+    let(:exec_dsl) { 'add_table.schema' }
+
+    it 'should be output create table query' do
+      result = execute(exec_dsl)
+      expect(result).to be_include(%(#   "id" integer NOT NULL GENERATED BY DEFAULT AS IDENTITY,))
+      expect(result).to be_include(%(# COMMENT ON TABLE "dummies" IS 'Dummy Table';))
+      expect(result).to be_include(%(# COMMENT ON COLUMN "dummies"."id" IS 'Hello Convergence';))
+    end
+  end
+
+  describe 'drop table' do
+    let(:exec_dsl) { 'drop_table.schema' }
+
+    it 'should be output drop table query' do
+      result = execute(exec_dsl)
+      expect(result).to be_include('DROP TABLE "paper_authors";')
+    end
+  end
+
+  describe 'add columns' do
+    let(:exec_dsl) { 'add_columns_to_paper.schema' }
+
+    it 'should be output alter add column query' do
+      result = execute(exec_dsl)
+      expect(result).to be_include(%(# ALTER TABLE "papers" ADD COLUMN "subtitle" varchar DEFAULT NULL;))
+    end
+  end
+
+  describe 'remove columns' do
+    let(:exec_dsl) { 'remove_columns_to_paper.schema' }
+
+    it 'should be output alter drop column query' do
+      result = execute(exec_dsl)
+      expect(result).to be_include(%(# ALTER TABLE "papers" DROP COLUMN "description";))
+    end
+  end
+
+  describe 'change columns' do
+    describe 'change comment' do
+      let(:exec_dsl) { 'change_comment_columns_to_paper.schema' }
+
+      it 'should be output alter table column query' do
+        result = execute(exec_dsl)
+        expect(result).to be_include(%(# COMMENT ON COLUMN "authors"."created_at" IS 'Created At';))
+      end
+    end
+  end
+
+  describe 'rename column' do
+    let(:exec_dsl) { 'rename_column_on_paper.schema' }
+
+    it 'should be output rename column query, not drop+add' do
+      result = execute(exec_dsl)
+      expect(result).to be_include(%(# ALTER TABLE "papers" RENAME COLUMN "description" TO "notes";))
+      expect(result).not_to be_include('DROP COLUMN "description"')
+      expect(result).not_to be_include('ADD COLUMN "notes"')
+    end
+  end
+
+  describe 'rename table' do
+    let(:exec_dsl) { 'rename_table.schema' }
+
+    it 'should be output rename table query, not drop+add' do
+      result = execute(exec_dsl)
+      expect(result).to be_include(%(# ALTER TABLE "paper_authors" RENAME TO "paper_author_links";))
+      expect(result).not_to be_include('DROP TABLE "paper_authors"')
+      expect(result).not_to be_include('CREATE TABLE "paper_author_links"')
+    end
+  end
+
+  describe 'drop foreign key' do
+    let(:exec_dsl) { 'drop_foreign_key.schema' }
+
+    it 'should be output drop foreign key query' do
+      result = execute(exec_dsl)
+      expect(result).to be_include(%(# ALTER TABLE "paper_authors" DROP CONSTRAINT "paper_authors_author_id_fk";))
+      expect(result).to be_include(%(# ALTER TABLE "paper_authors" DROP CONSTRAINT "paper_authors_paper_id_fk";))
+    end
+  end
+end

data/spec/spec_helper.rb

@@ -5,6 +5,8 @@ require 'pry'
 require 'convergence'
 require 'convergence/database_connector'
 Dir["#{File.dirname(__FILE__)}/integrations/**/*.rb"].each { |f| require f }
+Dir["#{File.dirname(__FILE__)}/postgres_integrations/**/*.rb"].each { |f| require f }
+Dir["#{File.dirname(__FILE__)}/sqlite_integrations/**/*.rb"].each { |f| require f }
 
 $default_output = File.open('/dev/null', 'w')
 
@@ -13,6 +15,17 @@ def mysql_settings
   Convergence::Config.new(Hash[mysql_settings.map { |k, v| [k.to_sym, v] }])
 end
 
+def postgres_settings
+  postgres_settings = YAML.load_file("#{File.dirname(__FILE__)}/config/spec_database.yml")['postgresql']
+  Convergence::Config.new(Hash[postgres_settings.map { |k, v| [k.to_sym, v] }])
+end
+
+def sqlite_settings
+  sqlite_settings = YAML.load_file("#{File.dirname(__FILE__)}/config/spec_database.yml")['sqlite3']
+  database_path = File.expand_path("#{File.dirname(__FILE__)}/fixtures/#{sqlite_settings['database']}")
+  Convergence::Config.new(adapter: sqlite_settings['adapter'], database: database_path)
+end
+
 def rollback
   # FIXME But I have no idea to rollback create/drop/alter table of mysql
   sqls = File.open("#{File.dirname(__FILE__)}/fixtures/test_db.sql")

data/spec/sqlite_integrations/command_dryrun.rb

@@ -0,0 +1,92 @@
+require 'spec_helper'
+require 'convergence/command/dryrun'
+
+describe 'SQLite Command::Dryrun#execute' do
+  def execute(dsl_path, extra_options = {})
+    parse_option = {
+      input: File.expand_path("#{File.dirname(__FILE__)}/../fixtures/sqlite/#{dsl_path}")
+    }.merge(extra_options)
+    Convergence::Command::Dryrun.new(parse_option, config: sqlite_settings).execute
+  end
+
+  describe 'add table' do
+    let(:exec_dsl) { 'add_table.schema' }
+
+    it 'should be output create table query' do
+      result = execute(exec_dsl)
+      expect(result).to be_include(%(# CREATE TABLE "dummies" (\n#   "id" INTEGER PRIMARY KEY AUTOINCREMENT\n# );))
+    end
+  end
+
+  describe 'drop table' do
+    let(:exec_dsl) { 'drop_table.schema' }
+
+    it 'should be output drop table query' do
+      result = execute(exec_dsl)
+      expect(result).to be_include('DROP TABLE "paper_authors";')
+    end
+
+    context 'when safe_migration is enabled' do
+      it 'should not output drop table query' do
+        result = execute(exec_dsl, safe_migration: true)
+        expect(result).not_to be_include('DROP TABLE "paper_authors";')
+      end
+    end
+  end
+
+  describe 'add columns' do
+    let(:exec_dsl) { 'add_columns_to_paper.schema' }
+
+    it 'should be output alter add column query' do
+      result = execute(exec_dsl)
+      expect(result).to be_include(%(# ALTER TABLE "papers" ADD COLUMN "subtitle" varchar;))
+    end
+  end
+
+  describe 'remove columns' do
+    let(:exec_dsl) { 'remove_columns_to_paper.schema' }
+
+    it 'should be output alter drop column query' do
+      result = execute(exec_dsl)
+      expect(result).to be_include(%(# ALTER TABLE "papers" DROP COLUMN "description";))
+    end
+  end
+
+  describe 'change columns' do
+    let(:exec_dsl) { 'change_columns_to_paper.schema' }
+
+    it 'should raise NotImplementedError since SQLite cannot ALTER a column in place' do
+      expect { execute(exec_dsl) }.to raise_error(NotImplementedError, /does not support changing column/)
+    end
+  end
+
+  describe 'rename column' do
+    let(:exec_dsl) { 'rename_column_on_paper.schema' }
+
+    it 'should be output rename column query, not drop+add' do
+      result = execute(exec_dsl)
+      expect(result).to be_include(%(# ALTER TABLE "papers" RENAME COLUMN "description" TO "notes";))
+      expect(result).not_to be_include('DROP COLUMN "description"')
+      expect(result).not_to be_include('ADD COLUMN "notes"')
+    end
+  end
+
+  describe 'rename table' do
+    let(:exec_dsl) { 'rename_table.schema' }
+
+    it 'should be output rename table query, not drop+add' do
+      result = execute(exec_dsl)
+      expect(result).to be_include(%(# ALTER TABLE "paper_authors" RENAME TO "paper_author_links";))
+      expect(result).not_to be_include('DROP TABLE "paper_authors"')
+      expect(result).not_to be_include('CREATE TABLE "paper_author_links"')
+    end
+  end
+
+  describe 'drop foreign key' do
+    let(:exec_dsl) { 'drop_foreign_key.schema' }
+
+    it 'should raise NotImplementedError since SQLite cannot drop a foreign key in place' do
+      expect { execute(exec_dsl) }.to raise_error(NotImplementedError, /does not support removing a foreign key/)
+    end
+  end
+end

metadata

@@ -1,14 +1,13 @@
 --- !ruby/object:Gem::Specification
 name: convergence
 version: !ruby/object:Gem::Version
-  version: 1.0.6
+  version: 1.2.0
 platform: ruby
 authors:
 - Shinsuke Nishio
-autorequire:
 bindir: bin
 cert_chain: []
-date: 2022-04-28 00:00:00.000000000 Z
+date: 1980-01-02 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: mysql2
@@ -24,6 +23,34 @@ dependencies:
     - - ">="
       - !ruby/object:Gem::Version
         version: '0'
+- !ruby/object:Gem::Dependency
+  name: pg
+  requirement: !ruby/object:Gem::Requirement
+    requirements:
+    - - ">="
+      - !ruby/object:Gem::Version
+        version: '0'
+  type: :runtime
+  prerelease: false
+  version_requirements: !ruby/object:Gem::Requirement
+    requirements:
+    - - ">="
+      - !ruby/object:Gem::Version
+        version: '0'
+- !ruby/object:Gem::Dependency
+  name: sqlite3
+  requirement: !ruby/object:Gem::Requirement
+    requirements:
+    - - ">="
+      - !ruby/object:Gem::Version
+        version: '0'
+  type: :runtime
+  prerelease: false
+  version_requirements: !ruby/object:Gem::Requirement
+    requirements:
+    - - ">="
+      - !ruby/object:Gem::Version
+        version: '0'
 - !ruby/object:Gem::Dependency
   name: diff-lcs
   requirement: !ruby/object:Gem::Requirement
@@ -40,6 +67,20 @@ dependencies:
         version: '0'
 - !ruby/object:Gem::Dependency
   name: diffy
+  requirement: !ruby/object:Gem::Requirement
+    requirements:
+    - - ">="
+      - !ruby/object:Gem::Version
+        version: 3.4.2
+  type: :runtime
+  prerelease: false
+  version_requirements: !ruby/object:Gem::Requirement
+    requirements:
+    - - ">="
+      - !ruby/object:Gem::Version
+        version: 3.4.2
+- !ruby/object:Gem::Dependency
+  name: thor
   requirement: !ruby/object:Gem::Requirement
     requirements:
     - - ">="
@@ -53,7 +94,21 @@ dependencies:
       - !ruby/object:Gem::Version
         version: '0'
 - !ruby/object:Gem::Dependency
-  name: thor
+  name: logger
+  requirement: !ruby/object:Gem::Requirement
+    requirements:
+    - - ">="
+      - !ruby/object:Gem::Version
+        version: '0'
+  type: :runtime
+  prerelease: false
+  version_requirements: !ruby/object:Gem::Requirement
+    requirements:
+    - - ">="
+      - !ruby/object:Gem::Version
+        version: '0'
+- !ruby/object:Gem::Dependency
+  name: benchmark
   requirement: !ruby/object:Gem::Requirement
     requirements:
     - - ">="
@@ -163,6 +218,7 @@ files:
 - ".rspec"
 - ".rubocop.yml"
 - CHANGELOG.md
+- CONTRIBUTING.md
 - Gemfile
 - Gemfile.lock
 - Guardfile
@@ -184,12 +240,18 @@ files:
 - lib/convergence/config.rb
 - lib/convergence/database_connector.rb
 - lib/convergence/database_connector/mysql_connector.rb
+- lib/convergence/database_connector/postgres_connector.rb
+- lib/convergence/database_connector/sqlite_connector.rb
 - lib/convergence/default_parameter.rb
 - lib/convergence/default_parameter/mysql_default_parameter.rb
+- lib/convergence/default_parameter/postgres_default_parameter.rb
+- lib/convergence/default_parameter/sqlite_default_parameter.rb
 - lib/convergence/diff.rb
 - lib/convergence/dsl.rb
 - lib/convergence/dumper.rb
 - lib/convergence/dumper/mysql_schema_dumper.rb
+- lib/convergence/dumper/postgres_schema_dumper.rb
+- lib/convergence/dumper/sqlite_schema_dumper.rb
 - lib/convergence/foreign_key.rb
 - lib/convergence/index.rb
 - lib/convergence/logger.rb
@@ -197,31 +259,65 @@ files:
 - lib/convergence/pretty_diff.rb
 - lib/convergence/sql_generator.rb
 - lib/convergence/sql_generator/mysql_generator.rb
+- lib/convergence/sql_generator/postgres_generator.rb
+- lib/convergence/sql_generator/sqlite_generator.rb
 - lib/convergence/table.rb
 - lib/convergence/version.rb
 - spec/config/spec_database.yml
+- spec/convergence/config_spec.rb
 - spec/convergence/diff_spec.rb
 - spec/convergence/dsl_spec.rb
 - spec/convergence/dumper/mysql_schema_dumper_spec.rb
+- spec/convergence/dumper/postgres_schema_dumper_spec.rb
+- spec/convergence/dumper/sqlite_schema_dumper_spec.rb
 - spec/convergence/dumper_spec.rb
+- spec/convergence/foreign_key_spec.rb
+- spec/convergence/index_spec.rb
+- spec/convergence/pretty_diff_spec.rb
 - spec/convergence/table_spec.rb
 - spec/fixtures/add_columns_to_paper.schema
 - spec/fixtures/add_table.schema
+- spec/fixtures/add_table_with_enum_set.schema
 - spec/fixtures/change_comment_columns_to_paper.schema
 - spec/fixtures/change_foreign_key.schema
 - spec/fixtures/change_table_comment_to_paper.schema
 - spec/fixtures/drop_foreign_key.schema
 - spec/fixtures/drop_table.schema
+- spec/fixtures/execute_raw_sql.schema
+- spec/fixtures/postgres/add_columns_to_paper.schema
+- spec/fixtures/postgres/add_table.schema
+- spec/fixtures/postgres/change_comment_columns_to_paper.schema
+- spec/fixtures/postgres/change_table_comment_to_paper.schema
+- spec/fixtures/postgres/drop_foreign_key.schema
+- spec/fixtures/postgres/drop_table.schema
+- spec/fixtures/postgres/remove_columns_to_paper.schema
+- spec/fixtures/postgres/rename_column_on_paper.schema
+- spec/fixtures/postgres/rename_table.schema
+- spec/fixtures/postgres_test_db.sql
 - spec/fixtures/remove_columns_to_paper.schema
+- spec/fixtures/rename_column_to_author.schema
+- spec/fixtures/rename_table.schema
+- spec/fixtures/sqlite/add_columns_to_paper.schema
+- spec/fixtures/sqlite/add_table.schema
+- spec/fixtures/sqlite/change_columns_to_paper.schema
+- spec/fixtures/sqlite/drop_foreign_key.schema
+- spec/fixtures/sqlite/drop_table.schema
+- spec/fixtures/sqlite/remove_columns_to_paper.schema
+- spec/fixtures/sqlite/rename_column_on_paper.schema
+- spec/fixtures/sqlite/rename_table.schema
+- spec/fixtures/sqlite_test_db.sql
 - spec/fixtures/test_db.sql
+- spec/integrations/command_diff.rb
 - spec/integrations/command_dryrun.rb
+- spec/integrations/command_export.rb
 - spec/integrations/drop_foreign_key.rb
+- spec/postgres_integrations/command_dryrun.rb
 - spec/spec_helper.rb
+- spec/sqlite_integrations/command_dryrun.rb
 homepage: https://github.com/nishio-dens/convergence
 licenses:
 - MIT
 metadata: {}
-post_install_message:
 rdoc_options: []
 require_paths:
 - lib
@@ -236,26 +332,58 @@ required_rubygems_version: !ruby/object:Gem::Requirement
     - !ruby/object:Gem::Version
       version: '0'
 requirements: []
-rubygems_version: 3.2.32
-signing_key:
+rubygems_version: 4.0.3
 specification_version: 4
 summary: DB Schema management tool
 test_files:
 - spec/config/spec_database.yml
+- spec/convergence/config_spec.rb
 - spec/convergence/diff_spec.rb
 - spec/convergence/dsl_spec.rb
 - spec/convergence/dumper/mysql_schema_dumper_spec.rb
+- spec/convergence/dumper/postgres_schema_dumper_spec.rb
+- spec/convergence/dumper/sqlite_schema_dumper_spec.rb
 - spec/convergence/dumper_spec.rb
+- spec/convergence/foreign_key_spec.rb
+- spec/convergence/index_spec.rb
+- spec/convergence/pretty_diff_spec.rb
 - spec/convergence/table_spec.rb
 - spec/fixtures/add_columns_to_paper.schema
 - spec/fixtures/add_table.schema
+- spec/fixtures/add_table_with_enum_set.schema
 - spec/fixtures/change_comment_columns_to_paper.schema
 - spec/fixtures/change_foreign_key.schema
 - spec/fixtures/change_table_comment_to_paper.schema
 - spec/fixtures/drop_foreign_key.schema
 - spec/fixtures/drop_table.schema
+- spec/fixtures/execute_raw_sql.schema
+- spec/fixtures/postgres/add_columns_to_paper.schema
+- spec/fixtures/postgres/add_table.schema
+- spec/fixtures/postgres/change_comment_columns_to_paper.schema
+- spec/fixtures/postgres/change_table_comment_to_paper.schema
+- spec/fixtures/postgres/drop_foreign_key.schema
+- spec/fixtures/postgres/drop_table.schema
+- spec/fixtures/postgres/remove_columns_to_paper.schema
+- spec/fixtures/postgres/rename_column_on_paper.schema
+- spec/fixtures/postgres/rename_table.schema
+- spec/fixtures/postgres_test_db.sql
 - spec/fixtures/remove_columns_to_paper.schema
+- spec/fixtures/rename_column_to_author.schema
+- spec/fixtures/rename_table.schema
+- spec/fixtures/sqlite/add_columns_to_paper.schema
+- spec/fixtures/sqlite/add_table.schema
+- spec/fixtures/sqlite/change_columns_to_paper.schema
+- spec/fixtures/sqlite/drop_foreign_key.schema
+- spec/fixtures/sqlite/drop_table.schema
+- spec/fixtures/sqlite/remove_columns_to_paper.schema
+- spec/fixtures/sqlite/rename_column_on_paper.schema
+- spec/fixtures/sqlite/rename_table.schema
+- spec/fixtures/sqlite_test_db.sql
 - spec/fixtures/test_db.sql
+- spec/integrations/command_diff.rb
 - spec/integrations/command_dryrun.rb
+- spec/integrations/command_export.rb
 - spec/integrations/drop_foreign_key.rb
+- spec/postgres_integrations/command_dryrun.rb
 - spec/spec_helper.rb
+- spec/sqlite_integrations/command_dryrun.rb