convenient_service 0.17.0 → 0.19.0

data/lib/convenient_service/service/configs/standard/v1.rb

@@ -20,7 +20,7 @@ module ConvenientService
           #
           # rubocop:disable Lint/ConstantDefinitionInBlock
           included do
-            include Configs::Minimal
+            include Configs::Essential
 
             concerns do
               use ConvenientService::Plugins::Common::CachesConstructorArguments::Concern
@@ -33,6 +33,15 @@ module ConvenientService
               use ConvenientService::Plugins::Common::HasAroundCallbacks::Concern
 
               use ConvenientService::Plugins::Service::HasMermaidFlowchart::Concern
+
+              delete ConvenientService::Plugins::Service::HasNegatedResult::Concern
+              delete ConvenientService::Plugins::Service::HasNegatedJSendResult::Concern
+
+              replace \
+                ConvenientService::Plugins::Service::CanHaveConnectedSteps::Concern,
+                ConvenientService::Plugins::Service::CanHaveSequentialSteps::Concern
+
+              delete ConvenientService::Plugins::Service::CanHaveFallbacks::Concern
             end
 
             middlewares :initialize do
@@ -41,9 +50,7 @@ module ConvenientService
             end
 
             middlewares :result do
-              insert_after \
-                ConvenientService::Plugins::Common::NormalizesEnv::Middleware,
-                ConvenientService::Plugins::Service::CollectsServicesInException::Middleware
+              unshift ConvenientService::Plugins::Service::CollectsServicesInException::Middleware
 
               insert_before \
                 ConvenientService::Plugins::Service::RaisesOnNotResultReturnValue::Middleware,
@@ -61,6 +68,10 @@ module ConvenientService
               insert_before \
                 ConvenientService::Plugins::Service::RaisesOnNotResultReturnValue::Middleware,
                 ConvenientService::Plugins::Service::SetsParentToForeignResult::Middleware
+
+              replace \
+                ConvenientService::Plugins::Service::CanHaveConnectedSteps::Middleware,
+                ConvenientService::Plugins::Service::CanHaveSequentialSteps::Middleware
             end
 
             middlewares :step do
@@ -85,46 +96,52 @@ module ConvenientService
                 use ConvenientService::Plugins::Common::HasJSendResultDuckShortSyntax::Concern
                 use ConvenientService::Plugins::Result::CanRecalculateResult::Concern
 
-                use ConvenientService::Plugins::Result::CanHaveStep::Concern
+                use ConvenientService::Plugins::Result::CanBeFromException::Concern
                 use ConvenientService::Plugins::Result::CanBeOwnResult::Concern
                 use ConvenientService::Plugins::Result::CanHaveParentResult::Concern
                 use ConvenientService::Plugins::Result::CanHaveCheckedStatus::Concern
               end
 
-              middlewares :success? do
-                use ConvenientService::Plugins::Result::CanHaveCheckedStatus::Middleware
+              middlewares :data do
+                use ConvenientService::Plugins::Result::RaisesOnNotCheckedResultStatus::Middleware
               end
 
-              middlewares :failure? do
-                use ConvenientService::Plugins::Result::CanHaveCheckedStatus::Middleware
+              middlewares :message do
+                use ConvenientService::Plugins::Result::RaisesOnNotCheckedResultStatus::Middleware
               end
 
-              middlewares :error? do
-                use ConvenientService::Plugins::Result::CanHaveCheckedStatus::Middleware
+              middlewares :code do
+                use ConvenientService::Plugins::Result::RaisesOnNotCheckedResultStatus::Middleware
               end
 
-              middlewares :not_success? do
-                use ConvenientService::Plugins::Result::CanHaveCheckedStatus::Middleware
-              end
+              class self::Status
+                concerns do
+                  use ConvenientService::Plugins::Status::CanBeChecked::Concern
+                end
 
-              middlewares :not_failure? do
-                use ConvenientService::Plugins::Result::CanHaveCheckedStatus::Middleware
-              end
+                middlewares :success? do
+                  use ConvenientService::Plugins::Status::CanBeChecked::Middleware
+                end
 
-              middlewares :not_error? do
-                use ConvenientService::Plugins::Result::CanHaveCheckedStatus::Middleware
-              end
+                middlewares :failure? do
+                  use ConvenientService::Plugins::Status::CanBeChecked::Middleware
+                end
 
-              middlewares :data do
-                use ConvenientService::Plugins::Result::RaisesOnNotCheckedResultStatus::Middleware
-              end
+                middlewares :error? do
+                  use ConvenientService::Plugins::Status::CanBeChecked::Middleware
+                end
 
-              middlewares :message do
-                use ConvenientService::Plugins::Result::RaisesOnNotCheckedResultStatus::Middleware
-              end
+                middlewares :not_success? do
+                  use ConvenientService::Plugins::Status::CanBeChecked::Middleware
+                end
 
-              middlewares :code do
-                use ConvenientService::Plugins::Result::RaisesOnNotCheckedResultStatus::Middleware
+                middlewares :not_failure? do
+                  use ConvenientService::Plugins::Status::CanBeChecked::Middleware
+                end
+
+                middlewares :not_error? do
+                  use ConvenientService::Plugins::Status::CanBeChecked::Middleware
+                end
               end
             end
 
@@ -144,9 +161,7 @@ module ConvenientService
               end
 
               middlewares :result do
-                insert_after \
-                  ConvenientService::Plugins::Common::NormalizesEnv::Middleware,
-                  ConvenientService::Plugins::Service::CanHaveStubbedResults::Middleware
+                unshift ConvenientService::Plugins::Service::CanHaveStubbedResults::Middleware
 
                 insert_before \
                   ConvenientService::Plugins::Service::CanHaveStubbedResults::Middleware,
@@ -154,9 +169,7 @@ module ConvenientService
               end
 
               middlewares :result, scope: :class do
-                insert_after \
-                  ConvenientService::Plugins::Common::NormalizesEnv::Middleware,
-                  ConvenientService::Plugins::Service::CanHaveStubbedResults::Middleware
+                unshift ConvenientService::Plugins::Service::CanHaveStubbedResults::Middleware
 
                 insert_before \
                   ConvenientService::Plugins::Service::CanHaveStubbedResults::Middleware,

data/lib/convenient_service/service/configs/standard.rb

@@ -22,7 +22,7 @@ module ConvenientService
         #
         # rubocop:disable Lint/ConstantDefinitionInBlock
         included do
-          include Configs::Minimal
+          include Configs::Essential
 
           concerns do
             use ConvenientService::Plugins::Common::CachesConstructorArguments::Concern
@@ -34,7 +34,6 @@ module ConvenientService
             use ConvenientService::Plugins::Common::HasCallbacks::Concern
             use ConvenientService::Plugins::Common::HasAroundCallbacks::Concern
 
-            use ConvenientService::Plugins::Service::CanHaveFallbacks::Concern
             use ConvenientService::Plugins::Service::HasMermaidFlowchart::Concern
           end
 
@@ -44,9 +43,7 @@ module ConvenientService
           end
 
           middlewares :result do
-            insert_after \
-              ConvenientService::Plugins::Common::NormalizesEnv::Middleware,
-              ConvenientService::Plugins::Service::CollectsServicesInException::Middleware
+            unshift ConvenientService::Plugins::Service::CollectsServicesInException::Middleware
 
             insert_before \
               ConvenientService::Plugins::Service::RaisesOnNotResultReturnValue::Middleware,
@@ -66,12 +63,7 @@ module ConvenientService
               ConvenientService::Plugins::Service::SetsParentToForeignResult::Middleware
           end
 
-          ##
-          # @internal
-          #   NOTE: Check `Minimal` docs to understand why `use ConvenientService::Plugins::Common::NormalizesEnv::Middleware` for `:fallback_failure_result` is used in `Standard`, not in `Minimal` config.
-          #
           middlewares :fallback_failure_result do
-            use ConvenientService::Plugins::Common::NormalizesEnv::Middleware
             use ConvenientService::Plugins::Service::CollectsServicesInException::Middleware
             use ConvenientService::Plugins::Common::CachesReturnValue::Middleware
 
@@ -79,12 +71,7 @@ module ConvenientService
             use ConvenientService::Plugins::Service::CanHaveFallbacks::Middleware.with(status: :failure)
           end
 
-          ##
-          # @internal
-          #   NOTE: Check `Minimal` docs to understand why `use ConvenientService::Plugins::Common::NormalizesEnv::Middleware` for `:fallback_error_result` is used in `Standard`, not in `Minimal` config.
-          #
           middlewares :fallback_error_result do
-            use ConvenientService::Plugins::Common::NormalizesEnv::Middleware
             use ConvenientService::Plugins::Service::CollectsServicesInException::Middleware
             use ConvenientService::Plugins::Common::CachesReturnValue::Middleware
 
@@ -92,6 +79,31 @@ module ConvenientService
             use ConvenientService::Plugins::Service::CanHaveFallbacks::Middleware.with(status: :error)
           end
 
+          middlewares :fallback_result do
+            use ConvenientService::Plugins::Service::CollectsServicesInException::Middleware
+            use ConvenientService::Plugins::Common::CachesReturnValue::Middleware
+
+            use ConvenientService::Plugins::Service::RaisesOnNotResultReturnValue::Middleware
+            use ConvenientService::Plugins::Service::CanHaveFallbacks::Middleware.with(status: nil)
+          end
+
+          middlewares :negated_result do
+            use ConvenientService::Plugins::Service::CollectsServicesInException::Middleware
+            use ConvenientService::Plugins::Common::CachesReturnValue::Middleware
+
+            use ConvenientService::Plugins::Common::EnsuresNegatedJSendResult::Middleware
+          end
+
+          ##
+          # TODO:
+          #   `after :step do |step|` is executed after step result is calculated.
+          #    This completely makes sence and is useful for debugging for example.
+          #
+          #   But `before :step do` is also executed after step result is calculated.
+          #   That confuses the end-users a lot.
+          #   Probably a dedicated plugin is needed?
+          #   Or to forbid `before :step do`?
+          #
           middlewares :step do
             use ConvenientService::Plugins::Common::HasCallbacks::Middleware
             use ConvenientService::Plugins::Common::HasAroundCallbacks::Middleware
@@ -114,47 +126,58 @@ module ConvenientService
               use ConvenientService::Plugins::Common::HasJSendResultDuckShortSyntax::Concern
               use ConvenientService::Plugins::Result::CanRecalculateResult::Concern
 
-              use ConvenientService::Plugins::Result::CanHaveStep::Concern
+              use ConvenientService::Plugins::Result::HasNegatedResult::Concern
+              use ConvenientService::Plugins::Result::CanBeFromException::Concern
               use ConvenientService::Plugins::Result::CanBeOwnResult::Concern
               use ConvenientService::Plugins::Result::CanHaveFallbacks::Concern
               use ConvenientService::Plugins::Result::CanHaveParentResult::Concern
               use ConvenientService::Plugins::Result::CanHaveCheckedStatus::Concern
             end
 
-            middlewares :success? do
-              use ConvenientService::Plugins::Result::CanHaveCheckedStatus::Middleware
+            middlewares :data do
+              use ConvenientService::Plugins::Result::RaisesOnNotCheckedResultStatus::Middleware
             end
 
-            middlewares :failure? do
-              use ConvenientService::Plugins::Result::CanHaveCheckedStatus::Middleware
+            middlewares :message do
+              use ConvenientService::Plugins::Result::RaisesOnNotCheckedResultStatus::Middleware
             end
 
-            middlewares :error? do
-              use ConvenientService::Plugins::Result::CanHaveCheckedStatus::Middleware
+            middlewares :code do
+              use ConvenientService::Plugins::Result::RaisesOnNotCheckedResultStatus::Middleware
             end
 
-            middlewares :not_success? do
-              use ConvenientService::Plugins::Result::CanHaveCheckedStatus::Middleware
+            middlewares :negated_result do
+              use ConvenientService::Plugins::Common::EnsuresNegatedJSendResult::Middleware
             end
 
-            middlewares :not_failure? do
-              use ConvenientService::Plugins::Result::CanHaveCheckedStatus::Middleware
-            end
+            class self::Status
+              concerns do
+                use ConvenientService::Plugins::Status::CanBeChecked::Concern
+              end
 
-            middlewares :not_error? do
-              use ConvenientService::Plugins::Result::CanHaveCheckedStatus::Middleware
-            end
+              middlewares :success? do
+                use ConvenientService::Plugins::Status::CanBeChecked::Middleware
+              end
 
-            middlewares :data do
-              use ConvenientService::Plugins::Result::RaisesOnNotCheckedResultStatus::Middleware
-            end
+              middlewares :failure? do
+                use ConvenientService::Plugins::Status::CanBeChecked::Middleware
+              end
 
-            middlewares :message do
-              use ConvenientService::Plugins::Result::RaisesOnNotCheckedResultStatus::Middleware
-            end
+              middlewares :error? do
+                use ConvenientService::Plugins::Status::CanBeChecked::Middleware
+              end
 
-            middlewares :code do
-              use ConvenientService::Plugins::Result::RaisesOnNotCheckedResultStatus::Middleware
+              middlewares :not_success? do
+                use ConvenientService::Plugins::Status::CanBeChecked::Middleware
+              end
+
+              middlewares :not_failure? do
+                use ConvenientService::Plugins::Status::CanBeChecked::Middleware
+              end
+
+              middlewares :not_error? do
+                use ConvenientService::Plugins::Status::CanBeChecked::Middleware
+              end
             end
           end
 
@@ -165,42 +188,23 @@ module ConvenientService
             end
 
             middlewares :result do
-              use ConvenientService::Plugins::Step::CanHaveFallbacks::Middleware.with(fallback_true_status: :failure)
-              use ConvenientService::Plugins::Step::CanHaveParentResult::Middleware
-            end
-
-            middlewares :service_fallback_failure_result do
-              use ConvenientService::Plugins::Common::NormalizesEnv::Middleware
-              use ConvenientService::Plugins::Common::CachesReturnValue::Middleware
-              use ConvenientService::Plugins::Step::RaisesOnNotResultReturnValue::Middleware
-            end
-
-            middlewares :fallback_failure_result do
-              use ConvenientService::Plugins::Common::NormalizesEnv::Middleware
-              use ConvenientService::Plugins::Common::CachesReturnValue::Middleware
-            end
-
-            middlewares :service_fallback_error_result do
-              use ConvenientService::Plugins::Common::NormalizesEnv::Middleware
-              use ConvenientService::Plugins::Common::CachesReturnValue::Middleware
-              use ConvenientService::Plugins::Step::RaisesOnNotResultReturnValue::Middleware
-            end
+              insert_after \
+                ConvenientService::Plugins::Step::HasResult::Middleware,
+                ConvenientService::Plugins::Step::CanHaveParentResult::Middleware
 
-            middlewares :fallback_error_result do
-              use ConvenientService::Plugins::Common::NormalizesEnv::Middleware
-              use ConvenientService::Plugins::Common::CachesReturnValue::Middleware
+              insert_after \
+                ConvenientService::Plugins::Step::HasResult::Middleware,
+                ConvenientService::Plugins::Step::CanHaveFallbacks::Middleware.with(fallback_true_status: :failure)
             end
           end
 
           if Dependencies.rspec.loaded?
             concerns do
-              insert_before 0, ConvenientService::Plugins::Service::CanHaveStubbedResults::Concern
+              unshift ConvenientService::Plugins::Service::CanHaveStubbedResults::Concern
             end
 
             middlewares :result do
-              insert_after \
-                ConvenientService::Plugins::Common::NormalizesEnv::Middleware,
-                ConvenientService::Plugins::Service::CanHaveStubbedResults::Middleware
+              unshift ConvenientService::Plugins::Service::CanHaveStubbedResults::Middleware
 
               insert_before \
                 ConvenientService::Plugins::Service::CanHaveStubbedResults::Middleware,
@@ -208,9 +212,7 @@ module ConvenientService
             end
 
             middlewares :result, scope: :class do
-              insert_after \
-                ConvenientService::Plugins::Common::NormalizesEnv::Middleware,
-                ConvenientService::Plugins::Service::CanHaveStubbedResults::Middleware
+              unshift ConvenientService::Plugins::Service::CanHaveStubbedResults::Middleware
 
               insert_before \
                 ConvenientService::Plugins::Service::CanHaveStubbedResults::Middleware,

data/lib/convenient_service/service/configs.rb

@@ -1,6 +1,6 @@
 # frozen_string_literal: true
 
-require_relative "configs/minimal"
+require_relative "configs/essential"
 require_relative "configs/standard"
 
 require_relative "configs/aliases"