controller_filter_logging 0.0.7 → 0.0.8

data/lib/controller_filter_logging.rb

@@ -7,7 +7,7 @@ module AbstractController::Callbacks::ClassMethods
   alias_method_chain :before_filter, :logging
 
   def skip_before_filter_with_logging(filter_name, *args)
-    skip_before_filter_without_logging("#{filter_name}_with_logging".to_sym, *args)
+    skip_before_filter_without_logging(filter_name_to_logging_filter_name(filter_name).to_sym, *args)
   end
   alias_method_chain :skip_before_filter, :logging
 
@@ -29,7 +29,7 @@ module AbstractController::Callbacks::ClassMethods
   end
 
   def create_logging_filter(filter_name)
-    name = "#{filter_name.to_s.gsub(%r{[?!]}, '')}_with_logging"
+    name = filter_name_to_logging_filter_name(filter_name)
     define_method(name) do
       Rails.logger.debug("Entering before_filter: #{filter_name}")
       start_time = Time.now
@@ -45,4 +45,9 @@ module AbstractController::Callbacks::ClassMethods
     name.to_sym
   end
 
+  protected
+    def filter_name_to_logging_filter_name(filter_name)
+      "#{filter_name.to_s.gsub(%r{[?!]}, '')}_with_logging"
+    end
+
 end

data/lib/controller_filter_logging/version.rb

@@ -1,3 +1,3 @@
 module ControllerFilterLogging
-  VERSION = "0.0.7"
+  VERSION = "0.0.8"
 end

data/spec/lib/controller_filter_logging_spec.rb

@@ -25,7 +25,7 @@ describe 'controller_filter_logging' do
         result = 12345
 
         Rails.logger.expects(:debug).with("Entering before_filter: test")
-        Rails.logger.expects(:debug).with(" result: #{result}")
+        Rails.logger.expects(:debug).with(" result (0.00001): #{result}")
 
         controller = Class.new(ActionController::Base) do
           attr_reader :called
@@ -44,5 +44,28 @@ describe 'controller_filter_logging' do
       end
     end
   end
+
+  describe "#skip_before_filter_with_logging" do
+    it "should skip a filter with a ! in it" do
+      controller = Class.new(ActionController::Base) do
+        attr_accessor :called
+        def test_filter!
+          @called = true
+        end
+
+        before_filter :test_filter!
+
+      end.new
+
+      controller.run_callbacks(:process_action)
+      controller.called.should == true
+
+      controller.called = nil
+      controller.class_eval { skip_before_filter :test_filter! }
+
+      controller.run_callbacks(:process_action)
+      controller.called.should == nil
+    end
+  end
 end
 

metadata

@@ -1,34 +1,23 @@
---- !ruby/object:Gem::Specification 
+--- !ruby/object:Gem::Specification
 name: controller_filter_logging
-version: !ruby/object:Gem::Version 
-  hash: 17
-  prerelease: false
-  segments: 
-  - 0
-  - 0
-  - 7
-  version: 0.0.7
+version: !ruby/object:Gem::Version
+  version: 0.0.8
+  prerelease: 
 platform: ruby
-authors: 
+authors:
 - Jon Moses
 autorequire: 
 bindir: bin
 cert_chain: []
-
-date: 2011-06-24 00:00:00 -04:00
-default_executable: 
+date: 2011-12-01 00:00:00.000000000Z
 dependencies: []
-
 description: Gem to log execution and results of before_filter's for Rails 3
-email: 
+email:
 - jon@burningbush.us
 executables: []
-
 extensions: []
-
 extra_rdoc_files: []
-
-files: 
+files:
 - .gitignore
 - Gemfile
 - README
@@ -39,40 +28,30 @@ files:
 - lib/controller_filter_logging/version.rb
 - spec/lib/controller_filter_logging_spec.rb
 - spec/spec_helper.rb
-has_rdoc: true
-homepage: ""
+homepage: ''
 licenses: []
-
 post_install_message: 
 rdoc_options: []
-
-require_paths: 
+require_paths:
 - lib
-required_ruby_version: !ruby/object:Gem::Requirement 
+required_ruby_version: !ruby/object:Gem::Requirement
   none: false
-  requirements: 
-  - - ">="
-    - !ruby/object:Gem::Version 
-      hash: 3
-      segments: 
-      - 0
-      version: "0"
-required_rubygems_version: !ruby/object:Gem::Requirement 
+  requirements:
+  - - ! '>='
+    - !ruby/object:Gem::Version
+      version: '0'
+required_rubygems_version: !ruby/object:Gem::Requirement
   none: false
-  requirements: 
-  - - ">="
-    - !ruby/object:Gem::Version 
-      hash: 3
-      segments: 
-      - 0
-      version: "0"
+  requirements:
+  - - ! '>='
+    - !ruby/object:Gem::Version
+      version: '0'
 requirements: []
-
 rubyforge_project: controller_filter_logging
-rubygems_version: 1.3.7
+rubygems_version: 1.8.10
 signing_key: 
 specification_version: 3
 summary: Bring back controller filter logging to rails 3
-test_files: 
+test_files:
 - spec/lib/controller_filter_logging_spec.rb
 - spec/spec_helper.rb