control_spec_helper 0.0.2 → 0.0.3.pre

data/spec/tasks/spec_prep_spec.rb

@@ -0,0 +1,69 @@
+require 'spec_helper'
+
+describe :spec_prep do
+  include_context 'rake'
+
+  before(:all) do
+    @original_dir = Dir.pwd
+    Dir.chdir('fixtures/puppet-control')
+  end
+
+  after(:all) do
+    Dir.chdir(@original_dir)
+  end
+
+  context 'when run on CentOS 7' do
+    # rubocop:disable Lint/UselessAssignment
+    cached_env_debug = ''
+    # rubocop:enable Lint/UselessAssignment
+    original_stderr = $stderr
+    original_stdout = $stdout
+
+    before(:each) do
+      conf = ssh_config
+      @connection = Net::SSH.start(
+        conf['HostName'],
+        conf['User'],
+        port: conf['Port'],
+        password: 'vagrant'
+      )
+      ssh_exec!(@connection, 'cp /vagrant/fixtures/bashrc ~/.bashrc')
+      $stderr = File.open(File::NULL, 'w')
+      $stdout = File.open(File::NULL, 'w')
+      @prep_return = ssh_exec!(@connection,
+                               'cd /vagrant ; bundle exec rake spec_prep')
+    end
+
+    after(:each) do
+      $stderr = original_stderr
+      $stdout = original_stdout
+    end
+
+    it 'should return success' do
+      expect(@prep_return[2]).to eq(0)
+    end
+
+    it 'should run r10k' do
+      r10k_success = ssh_exec!(@connection,
+                               'ls /vagrant/modules/vcsrepo')
+      expect(r10k_success[2]).to eq(0)
+    end
+    it 'should create the fixtures/modules directory' do
+      dir_success = ssh_exec!(@connection,
+                              'ls /vagrant/site/profile/spec/fixtures/modules')
+      expect(dir_success[2]).to eq(0)
+    end
+    it 'should link the profile path to its link directory' do
+      path_link_success = ssh_exec!(@connection,
+                                    'file /vagrant/site/profile/spec/fixtures/'\
+                                    'modules/profile')
+      expect(path_link_success[0]).to match(/(?!broken) symbolic link/)
+    end
+    it 'should link each module into the link directory' do
+      path_link_success = ssh_exec!(@connection,
+                                    'file /vagrant/site/profile/spec/fixtures/'\
+                                    'modules/vcsrepo')
+      expect(path_link_success[0]).to match(/(?!broken) symbolic link/)
+    end
+  end
+end

data/spec/tasks/unit_spec.rb

@@ -0,0 +1,70 @@
+require 'spec_helper'
+
+describe :unit do
+  include_context 'rake'
+
+  before(:all) do
+    @original_dir = Dir.pwd
+    Dir.chdir('fixtures/puppet-control')
+  end
+
+  after(:all) do
+    Dir.chdir(@original_dir)
+  end
+
+  context 'when run on CentOS 7' do
+    # rubocop:disable Lint/UselessAssignment
+    cached_env_debug = ''
+    # rubocop:enable Lint/UselessAssignment
+    original_stderr = $stderr
+    original_stdout = $stdout
+
+    before(:each) do
+      @connection = build_vagrant_connection(vagrant_ssh_config)
+      ssh_exec!(@connection, 'cp /vagrant/fixtures/bashrc ~/.bashrc')
+      $stderr = File.open(File::NULL, 'w')
+      $stdout = File.open(File::NULL, 'w')
+    end
+
+    after(:each) do
+      $stderr = original_stderr
+      $stdout = original_stdout
+    end
+
+    repo = "#{File.dirname(__FILE__)}/../../fixtures/puppet-control"
+
+    context 'when all tests pass' do
+      before(:each) do
+        Git.open(repo).checkout('unit_pass')
+      end
+
+      after(:each) do
+        Git.open(repo).checkout('fixture')
+      end
+
+      it 'should run rspec and return successfully' do
+        cmd = 'cd /vagrant ; bundle exec rake unit'
+        _, _, exit_code, = ssh_exec!(@connection, cmd)
+        expect(exit_code).to eq(0)
+      end
+    end
+
+    context 'when at least one test fails' do
+      before(:context) do
+        Git.open(repo).checkout('unit_fail')
+      end
+
+      after(:context) do
+        Git.open(repo).checkout('fixture')
+      end
+
+      it 'should run rspec and return an error code & message' do
+        cmd = 'cd /vagrant ; bundle exec rake unit'
+        msg, _, exit_code, = ssh_exec!(@connection, cmd)
+        expect(exit_code).to_not eq(0)
+        expect(msg).to match(/Failed examples:/)
+      end
+    end
+  end
+end
+

data/spec/tasks/vplugins_spec.rb

@@ -18,13 +18,22 @@ describe :vplugins do
   end
 
   context 'when run on CentOS 7' do
+    # rubocop:disable Lint/UselessAssignment
     cached_env_debug = ''
+    # rubocop:enable Lint/UselessAssignment
     original_stderr = $stderr
     original_stdout = $stdout
 
     let(:conf) { ssh_config }
 
     before(:each) do
+      conf = ssh_config
+      @connection = Net::SSH.start(
+        conf['HostName'],
+        conf['User'],
+        port: conf['Port'],
+        password: 'vagrant'
+      )
       $stderr = File.open(File::NULL, 'w')
       $stdout = File.open(File::NULL, 'w')
     end
@@ -32,40 +41,24 @@ describe :vplugins do
     after(:each) do
       $stderr = original_stderr
       $stdout = original_stdout
+      @connection.close
     end
 
     it 'should install successfully' do
-      expect(Net::SSH.start(
-        conf['HostName'],
-        conf['User'],
-        port: conf['Port'],
-        password: 'vagrant'
-      ) do |ssh|
-        ssh_exec!(ssh,
-                  'cd /vagrant && unset RUBYLIB ; bundle exec rake vplugins')
-      end[2]).to eq(0)
+      response = ssh_exec!(@connection,
+                           'cd /vagrant ; bundle exec rake vplugins')
+      expect(response[2]).to eq(0)
     end
 
     it 'should install the vagrant-auto_network plugin' do
-      expect(Net::SSH.start(
-        conf['HostName'],
-        conf['User'],
-        port: conf['Port'],
-        password: 'vagrant'
-      ) do |ssh|
-        ssh_exec!(ssh, 'unset RUBYLIB ; vagrant plugin list')
-      end[0].split("\n")).to include(/vagrant-auto_network/)
+      response = ssh_exec!(@connection, 'unset RUBYLIB ; vagrant plugin list')
+      puts response
+      expect(response[0].split("\n")).to include(/vagrant-auto_network/)
     end
 
     it 'should install the vagrant-hosts plugin' do
-      expect(Net::SSH.start(
-        conf['HostName'],
-        conf['User'],
-        port: conf['Port'],
-        password: 'vagrant'
-      ) do |ssh|
-        ssh_exec!(ssh, 'unset RUBYLIB ; vagrant plugin list')
-      end[0].split("\n")).to include(/vagrant-hosts/)
+      response = ssh_exec!(@connection, 'unset RUBYLIB ; vagrant plugin list')
+      expect(response[0].split("\n")).to include(/vagrant-hosts/)
     end
   end
 end

data/spec/unit/control_spec_helper_spec.rb

@@ -31,7 +31,7 @@ describe 'control_spec_helper' do
     it 'should print properly-formatted debugging messages' do
       cached_env_debug = ENV['debug']
       ENV['debug'] = 'true'
-      expect { @dummy_class.debug('spec') }.to output("DEBUG: spec\n").to_stderr
+      expect { debug('spec') }.to output("DEBUG: spec\n").to_stderr
       ENV['debug'] = cached_env_debug
     end
   end
@@ -40,14 +40,14 @@ describe 'control_spec_helper' do
     it 'should suppress debugging messages' do
       cached_env_debug = ENV['debug']
       ENV.delete('debug')
-      expect { @dummy_class.debug('spec') }.to_not output('DEBUG: spec')
+      expect { debug('spec') }.to_not output('DEBUG: spec')
         .to_stderr
       ENV['debug'] = cached_env_debug
     end
   end
 
   it 'should print the puppet command' do
-    cmd = "puppet apply manifests/site.pp \\\n      --modulepath " \
+    cmd = "sudo puppet apply manifests/site.pp \\\n      --modulepath " \
           '$(echo `pwd`/modules:`pwd`/site) --hiera_config hiera.yaml'
     expect(@dummy_class.puppet_cmd).to eq(cmd)
   end

data/spec/unit/debug_spec.rb

@@ -13,7 +13,7 @@ describe 'control_spec_helper' do
     it 'should print properly-formatted debugging messages' do
       cached_env_debug = ENV['debug']
       ENV['debug'] = 'true'
-      expect { @dummy_class.debug('spec') }.to output("DEBUG: spec\n").to_stderr
+      expect { debug('spec') }.to output("DEBUG: spec\n").to_stderr
       ENV['debug'] = cached_env_debug
     end
   end
@@ -22,7 +22,7 @@ describe 'control_spec_helper' do
     it 'should suppress debugging messages' do
       cached_env_debug = ENV['debug']
       ENV.delete('debug')
-      expect { @dummy_class.debug('spec') }.to_not output('DEBUG: spec')
+      expect { debug('spec') }.to_not output('DEBUG: spec')
         .to_stderr
       ENV['debug'] = cached_env_debug
     end

data/spec/unit/profile_fixtures_spec.rb

@@ -5,177 +5,163 @@ class DummyClass
 end
 
 describe 'control_spec_helper' do
-  before do
+  before(:each) do
     @dummy_class = DummyClass.new
+    @cached_env_debug = ''
+    @original_stderr = $stderr
+    @original_stdout = $stdout
+    $stderr = File.open(File::NULL, 'w')
+    $stdout = File.open(File::NULL, 'w')
+    allow(@dummy_class)
+      .to receive(:profile_path)
+      .and_return("#{Dir.pwd}/fixtures/puppet-control/site/profile")
+    FileUtils.rm_rf("#{Dir.pwd}/fixtures/puppet-control/site/profile/spec/"\
+                    'fixtures/modules/profile')
+  end
+  after(:each) do
+    $stderr = @original_stderr
+    $stdout = @original_stdout
   end
 
   describe 'when profile_fixtures is called' do
     describe 'when debug environmental variable is set' do
-      cached_env_debug = ''
-
       before(:each) do
-        allow(@dummy_class).to receive(:profile_path).and_return('/')
-        allow(File).to receive(:symlink)
-          .with('/', '/tmp/spec/fixtures/modules/profile')
+        @cached_env_debug = ENV['debug']
+        ENV['debug'] = 'true'
+        allow(Dir)
+          .to receive(:glob)
+          .with("#{Dir.pwd}/fixtures/puppet-control/site/profile/../../modules"\
+                '/*')
+          .and_return(["#{Dir.pwd}/fixtures/puppet-control/site/profile/../../"\
+                       'modules/concat',
+                       "#{Dir.pwd}/fixtures/puppet-control/site/profile/../../"\
+                       'modules/epel'])
+      end
+
+      after(:each) do
+        ENV['debug'] = @cached_env_debug
       end
 
       context 'if a profile link already exists' do
         it 'should not try to symlink the profile path' do
-          allow(Dir).to receive(:glob).with('/tmp/../../modules/*')
-            .and_return([])
-          allow(File).to receive(:exists?)
-            .with('/tmp/spec/fixtures/modules/profile').and_return(true)
+          allow(File).to receive(:exist?)
+            .with("#{Dir.pwd}/fixtures/puppet-control/site/profile/"\
+                  'spec/fixtures/modules/profile')
+            .and_return(true)
           expect(File).to_not receive(:symlink)
-            .with('/', '/tmp/spec/fixtures/modules/profile')
-          allow(FileUtils).to receive(:mkpath)
-            .with('/tmp/spec/fixtures/modules/')
-          expect { @dummy_class.profile_fixtures }
+            .with("#{Dir.pwd}/fixtures/puppet-control/site/profile",
+                  "#{Dir.pwd}/fixtures/puppet-control/site/profile/spec/"\
+                  'fixtures/modules/profile')
+          @dummy_class.profile_fixtures
         end
       end
 
       context 'if a profile link does not already exist' do
         it 'should symlink the profile path' do
-          allow(Dir).to receive(:glob).with('/tmp/../../modules/*')
-            .and_return([])
-          allow(File).to receive(:exists?)
-            .with('/tmp/spec/fixtures/modules/profile').and_return(false)
-          allow(@dummy_class).to receive(:file_name).and_return('/tmp/foo.rb')
+          allow(File).to receive(:exist?)
+            .with("#{Dir.pwd}/fixtures/puppet-control/site/profile/"\
+                  'spec/fixtures/modules/profile')
+            .and_return(false)
           expect(File).to receive(:symlink)
-            .with('/', '/tmp/spec/fixtures/modules/profile')
-          allow(FileUtils).to receive(:mkpath)
-            .with('/tmp/spec/fixtures/modules/')
+            .with("#{Dir.pwd}/fixtures/puppet-control/site/profile",
+                  "#{Dir.pwd}/fixtures/puppet-control/site/profile/"\
+                  'spec/fixtures/modules/profile')
           @dummy_class.profile_fixtures
         end
       end
 
       context 'when iterating through available modules' do
         before(:each) do
-          allow(Dir).to receive(:glob).with('/tmp/../../modules/*')
-            .and_return(%w(foo bar))
-          allow(File).to receive(:exists?)
-            .with('/tmp/spec/fixtures/modules/profile').and_return(true)
+          allow(Dir).to receive(:glob)
+            .with("#{Dir.pwd}/fixtures/puppet-control/site/profile/../"\
+                  '../modules/*')
+            .and_return([
+                          "#{Dir.pwd}/fixtures/puppet-control/site/"\
+                          'profile/../../modules/concat',
+                          "#{Dir.pwd}/fixtures/puppet-control/site/"\
+                          'profile/../../modules/epel'
+                        ])
         end
-
         context 'if discovered file is not a directory' do
-          it 'should not try to perform module operations on that file' do
+          before(:each) do
             allow(File).to receive(:directory?)
-              .with('/tmp/spec/fixtures/modules').and_return(true)
-            allow(File).to receive(:directory?).with('foo').and_return(false)
-            allow(File).to receive(:directory?).with('bar').and_return(false)
-            allow(@dummy_class).to receive(:file_name).and_return('/tmp/foo.rb')
-            expect(File).to_not receive(:symlink)
-              .with('/tmp/foo', '/tmp/spec/fixtures/modules/foo')
-            expect(File).to_not receive(:symlink)
-              .with('/tmp/bar', '/tmp/spec/fixtures/modules/bar')
-            @dummy_class.profile_fixtures
+              .with("#{Dir.pwd}/fixtures/puppet-control/modules/concat")
+              .and_return(false)
+            allow(File).to receive(:directory?)
+              .with("#{Dir.pwd}/fixtures/puppet-control/modules/epel")
+          end
+          it 'should not try to perform module operations on that file' do
+            expect(File).to_not receive(:symlink?)
+              .with("#{Dir.pwd}/fixtures/puppet-control/site/profile"\
+                    '/../../modules/concat')
           end
         end
 
         context 'if discovered file is a directory' do
+          before(:each) do
+            allow(FileUtils)
+              .to receive(:mkpath)
+              .with("#{Dir.pwd}/fixtures/puppet-control/site/profile/spec/"\
+                    'fixtures/modules/')
+              .and_return(true)
+            allow(File).to receive(:directory?)
+              .with("#{Dir.pwd}/fixtures/puppet-control/site/profile"\
+                    '/../../modules/concat')
+              .and_return(true)
+            allow(File).to receive(:directory?)
+              .with("#{Dir.pwd}/fixtures/puppet-control/site/profile"\
+                    '/../../modules/epel')
+          end
           context 'if modules directories already are symlinks' do
-            it 'should not try to symlink the module path' do
-              allow(File).to receive(:directory?)
-                .with('/tmp/spec/fixtures/modules').and_return(true)
-              allow(File).to receive(:directory?).with('foo').and_return(true)
-              allow(File).to receive(:directory?).with('bar').and_return(true)
-              allow(@dummy_class).to receive(:file_name)
-                .and_return('/tmp/foo.rb')
-              allow(File).to receive(:symlink?)
-                .with('/tmp/spec/fixtures/modules/foo').and_return(true)
+            before(:each) do
               allow(File).to receive(:symlink?)
-                .with('/tmp/spec/fixtures/modules/bar').and_return(true)
+                .with("#{Dir.pwd}/fixtures/puppet-control/site/"\
+                      'profile/../../modules/concat')
+                .and_return(true)
+              allow(File).to receive(:symlink?).at_least(2).times
+            end
+            it 'should not try to symlink the module path' do
+              expect(File).to_not receive(:symlink)
+                .with("#{Dir.pwd}/fixtures/puppet-control/site/"\
+                      'profile/../../modules/concat',
+                      "#{Dir.pwd}/spec/fixtures/modules/concat")
               @dummy_class.profile_fixtures
             end
           end
 
           context 'if modules directories do not already have symlinks' do
-            it 'should symlink the module path' do
-              allow(@dummy_class).to receive(:file_name)
-                .and_return('/tmp/control_spec_helper.rb')
-              allow(File).to receive(:directory?)
-                .with('/tmp/spec/fixtures/modules').and_return(true)
+            before(:each) do
+              allow(File).to receive(:symlink?)
+                .with("#{Dir.pwd}/fixtures/puppet-control/site/"\
+                      'profile/spec/fixtures/modules/concat')
+                .and_return(false)
               allow(File).to receive(:directory?)
-                .with('foo').and_return(true)
+                .with("#{Dir.pwd}/fixtures/puppet-control/site/"\
+                      'profile/../../modules/concat')
+                .and_return(true)
               allow(File).to receive(:directory?)
-                .with('bar').and_return(true)
-              allow(File).to receive(:symlink?)
-                .with('/tmp/spec/fixtures/modules/foo').and_return(false)
-              allow(File).to receive(:symlink?)
-                .with('/tmp/spec/fixtures/modules/bar').and_return(false)
+                .with("#{Dir.pwd}/fixtures/puppet-control/site/profile/"\
+                      '../../modules/epel')
+            end
+            it 'should symlink the module path' do
               expect(File).to receive(:symlink)
-                .with('/tmp/foo', '/tmp/spec/fixtures/modules/foo')
+                .with("#{Dir.pwd}/fixtures/puppet-control/site/profile",
+                      "#{Dir.pwd}/fixtures/puppet-control/site/"\
+                      'profile/spec/fixtures/modules/profile')
               expect(File).to receive(:symlink)
-                .with('/tmp/bar', '/tmp/spec/fixtures/modules/bar')
+                .with("#{Dir.pwd}/fixtures/puppet-control/site/"\
+                      'profile/../../modules/concat',
+                      "#{Dir.pwd}/fixtures/puppet-control/site/"\
+                      'profile/spec/fixtures/modules/concat')
               @dummy_class.profile_fixtures
             end
           end
 
-          describe 'when debug environmental variable is set' do
-            before(:each) do
-              allow(@dummy_class).to receive(:profile_path).and_return('/')
-              allow(@dummy_class).to receive(:file_name)
-                .and_return('/tmp/foo.rb')
-              allow(Dir).to receive(:glob).with('/tmp/../../modules/*')
-                .and_return([])
-              allow(Dir).to receive(:pwd).and_return('/foo')
-              allow(File).to receive(:exists?)
-                .with('/tmp/spec/fixtures/modules/profile').and_return(true)
-              allow(FileUtils).to receive(:mkpath)
-                .with('/tmp/spec/fixtures/modules/')
-              cached_env_debug = ENV['debug']
-              ENV['debug'] = 'true'
-            end
-
-            after(:each) do
-              ENV['debug'] = cached_env_debug
-            end
-
-            it 'should print its current profile_path directory' do
-              expect { @dummy_class.profile_fixtures }
-                .to output(%r{DEBUG: cd to /}).to_stderr
-            end
-
-            it 'should print its actual working directory' do
-              expect { @dummy_class.profile_fixtures }
-                .to output(%r{DEBUG: cd to /foo}).to_stderr
-            end
-          end
-
-          context 'when debug environmental variable is not set' do
-            before(:each) do
-              allow(@dummy_class).to receive(:profile_path).and_return('/')
-              allow(@dummy_class).to receive(:file_name)
-                .and_return('/tmp/foo.rb')
-              allow(Dir).to receive(:glob).with('/tmp/../../modules/*')
-                .and_return([])
-              allow(Dir).to receive(:pwd).and_return('/foo')
-              allow(File).to receive(:exists?)
-                .with('/tmp/spec/fixtures/modules/profile').and_return(true)
-              allow(FileUtils).to receive(:mkpath)
-                .with('/tmp/spec/fixtures/modules/')
-            end
-
-            it 'should not print its current profile_path directory' do
-              cached_env_debug = ENV['debug']
-              ENV.delete('debug')
-              expect { @dummy_class.profile_fixtures }
-                .to_not output(%r{DEBUG: cd to /}).to_stderr
-              ENV['debug'] = cached_env_debug
-            end
-
-            it 'should not print its actual working directory' do
-              cached_env_debug = ENV['debug']
-              ENV.delete('debug')
-              expect { @dummy_class.profile_fixtures }
-                .to_not output(%r{DEBUG: cd to /foo}).to_stderr
-              ENV['debug'] = cached_env_debug
-            end
-          end
-
           it 'should create a modules directory inside fixtures' do
-            allow(@dummy_class).to receive(:file_name).and_return('/tmp/foo.rb')
-            expect(FileUtils).to receive(:mkpath)
-              .with('/tmp/spec/fixtures/modules/')
+            expect(FileUtils)
+              .to receive(:mkpath)
+              .with("#{Dir.pwd}/fixtures/puppet-control/site/profile/spec/"\
+                    'fixtures/modules/')
             @dummy_class.profile_fixtures
           end
         end

data/spec/unit/r10k_spec.rb

@@ -1,4 +1,5 @@
 require 'spec_helper'
+require 'git'
 
 class DummyClass
   include ControlSpecHelper
@@ -53,6 +54,12 @@ describe 'control_spec_helper' do
         allow(Dir).to receive(:pwd).and_return('/tmp')
         expect { @dummy_class.r10k }.to output(%r{cd to /tmp}).to_stderr
       end
+
+      context 'when Puppetfile is valid' do
+        it 'should return a success code' do
+          expect(@dummy_class.r10k[2]).to eq(0)
+        end
+      end
     end
   end
 end