contrek 1.2.4 → 1.2.6

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: 0df584b1fe92f70cb27f479a6d7705545f662b8758a4843bf966fe92d90c4c9d
-  data.tar.gz: 2dfe6f8b0cc96298858f5055158ba439644d24a9921166c572e91cd5df17780b
+  metadata.gz: ca0c4f7e37692b2d2e5b17556ed67bee4b624511ddf1dc3865ecf910e8f46aeb
+  data.tar.gz: 66b9af71020dc6a86da1abace1d0467807b9212e207b71a7f6337b2257a34192
 SHA512:
-  metadata.gz: d97742b1bc4f3688a8d083d25873da8db709b69c42c8068d02cfe6fe3569acac159f3d1a37c31128a7809b0e9851ba5e9da15c801f18c514189e53f4bc39440a
-  data.tar.gz: ee34393dc9713f62de0560b5d6538e7e9ffd6ff38358429f14f7ab7efb3cde201f2461d4ec209ed906a0a0e1e6aa0eb013040dddf290856400f632131e4c3622
+  metadata.gz: 63ba135c86c7849fda12e542af23a2746681f8aade888daa9269438c1601e8184215b3fe5081ee9caabce923e7dfafd8bcc3613fb06cf2ec9997193ff831e5c7
+  data.tar.gz: dd691e542a8722be9532d3c0f206d4b2a2499874f0be52786c99822036d3e0e463ffb6d301bceae44e8f487f434eeff98c9a931cffe27eab3ed5d249daf060e5

data/CHANGELOG.md

@@ -95,7 +95,20 @@ All notable changes to this project will be documented in this file.
 
 ## [1.2.3] - 2026-05-23
 ### Changed
-### Changed
 * **SVG Conversion:** Added utility methods to convert point coordinates directly into SVG paths.
 * **Contrek API & RAII Architecture:** Refactored the Contrek API to utilize an RAII (Resource Acquisition Is Initialization) pattern, safely wrapping both the trace engine and the processing results within a unified context lifecycle shell.
 * **ProcessResult Memory Management:** Updated `ProcessResult` to properly manage resource deallocation during cloning operations, ensuring deep-copied or moved internal points are automatically and safely freed when the context scope ends.
+
+## [1.2.4] - 2026-05-26
+### Changed
+* Fixed an issue in connectivity8 tracing mode that, under specific rare conditions, disrupted the topological continuity of external contours in favor of internal ones.
+
+## [1.2.5] - 2026-05-27
+### Changed
+- **Refactored `ProcessResult.clone()`:** Switched from fragmented dynamic allocation to a contiguous `std::vector` with explicit `.reserve()`. Eliminates heap fragmentation during high-res streaming.
+
+## [1.2.6] - 2026-05-31
+### Changed
+- **Refactored `spng.c` function `rgb8_row_to_rgba8`:** Extended a loop counter to `size_t` (previously limited to `uint32_t`), which was causing segmentation faults when reading massive images (e.g., 81920x81920).
+- **Refactored `RawBitmap.define` function:** Updated area and size calculations to use full 64-bit integers.
+- **Refactored `PolygonFinder.to_svg_stream()` function:** Optimized performance to efficiently handle massive SVG streams of 2 GB and beyond.

data/Gemfile.lock

@@ -1,7 +1,7 @@
 PATH
   remote: .
   specs:
-    contrek (1.2.4)
+    contrek (1.2.6)
       chunky_png (~> 1.4)
       concurrent-ruby (~> 1.3.5)
       rice (= 4.5.0)

data/ext/cpp_polygon_finder/PolygonFinder/src/Tests.cpp

@@ -8,6 +8,7 @@
  */
 
 #include "Tests.h"
+#include <sys/resource.h>
 #include <string.h>
 #include <iostream>
 #include <list>
@@ -17,6 +18,7 @@
 #include <cstring>
 #include <algorithm>
 #include <cstdio>
+
 #include "polygon/finder/PolygonFinder.h"
 #include "polygon/finder/concurrent/ClippedPolygonFinder.h"
 #include "polygon/bitmaps/Bitmap.h"
@@ -260,6 +262,16 @@ void Tests::test_h()
   delete right_result;
 }
 
+double get_peak_rss() {
+  struct rusage r_usage;
+  getrusage(RUSAGE_SELF, &r_usage);
+#ifdef __APPLE__
+  return r_usage.ru_maxrss / (1024.0 * 1024.0);
+#else
+  return r_usage.ru_maxrss / 1024.0;
+#endif
+}
+
 /* In this example, PNG data is read by streaming into a user-defined buffer height.
   Contrek scans each stripe and extracts the polygons. Finally, it merges all
   polygons from every stripe as if they had been read from a single image and saves
@@ -267,7 +279,7 @@ void Tests::test_h()
   This approach allows for processing large PNG files on systems where memory
   would otherwise be insufficient.
 */
-void stream_png_image(const std::string& filepath, uint32_t stripe_height) {
+void stream_png_image(const std::string& filepath, uint32_t stripe_height, bool generate_svg = false, bool generate_png = false) {
     std::vector<ProcessResult*> result_clones;
     std::vector<std::string> varguments = {};
     VerticalMerger vmerger(0, &varguments);
@@ -293,6 +305,7 @@ void stream_png_image(const std::string& filepath, uint32_t stripe_height) {
 
     // allocates stripe buffer
     RawBitmap stripe_bitmap;
+    std::cout << total_width << " " << stripe_height << std::endl;
     stripe_bitmap.define(total_width, stripe_height, 4, true);
     RGBNotMatcher not_matcher(-1);
 
@@ -303,7 +316,8 @@ void stream_png_image(const std::string& filepath, uint32_t stripe_height) {
     }
 
     size_t row_size = static_cast<size_t>(total_width) * 4;
-    // main strpes loop
+    int stripe_count = 0;
+    // main stripes loop
     for (uint32_t current_y_offset = 0; current_y_offset < total_height; current_y_offset += stripe_height) {
       int uncovered_height = total_height - current_y_offset;
 
@@ -332,12 +346,13 @@ void stream_png_image(const std::string& filepath, uint32_t stripe_height) {
       PolygonFinder polygon_finder(&stripe_bitmap, &not_matcher, nullptr, &finder_arguments);
       ProcessResult *result = polygon_finder.process_info();
       if (result) {
-        std::cout << "Founds polygons: " << result->groups << std::endl;
+        std::cout << "stripe " << stripe_count << ": found polygons " << result->groups << std::endl;
         ProcessResult* safe_result = result->clone();
         result_clones.push_back(safe_result);
         vmerger.add_tile(*safe_result);
         delete result;
       }
+      stripe_count++;
     }
 
     std::cout << "Merging polygons ..." << std::endl;
@@ -345,15 +360,20 @@ void stream_png_image(const std::string& filepath, uint32_t stripe_height) {
 
     if (merged_result) {
       std::cout << "Founds total polygons: " << merged_result->groups << std::endl;
-      /*RawBitmap full_bitmap;
-      full_bitmap.define(total_width, total_height, 4, true);
-      full_bitmap.fill(255, 255, 255);
-      merged_result->draw_on_bitmap(full_bitmap);
-      std::cout << "Saving whole png ..." << std::endl;
-      if (full_bitmap.save_to_png("whole.png")) {
-        std::cout << "Png saved!" << std::endl;
-      }*/
-      merged_result->save_svg("whole.svg");
+      if (generate_png) {
+        RawBitmap full_bitmap;
+        full_bitmap.define(total_width, total_height, 4, true);
+        full_bitmap.fill(255, 255, 255);
+        merged_result->draw_on_bitmap(full_bitmap);
+        std::cout << "Saving whole png ..." << std::endl;
+        if (full_bitmap.save_to_png("whole.png")) {
+          std::cout << "Png saved!" << std::endl;
+        }
+      }
+      if (generate_svg) {
+        merged_result->save_svg("whole.svg");
+        std::cout << "Svg saved!" << std::endl;
+      }
     }
     delete merged_result;
     // frees memory
@@ -366,4 +386,5 @@ void stream_png_image(const std::string& filepath, uint32_t stripe_height) {
 
 void Tests::test_i() {
   stream_png_image("../images/graphs_1024x1024.png", 300);
+  std::cout << "Memory usage peak: " << get_peak_rss() << " MB" << std::endl;
 }

data/ext/cpp_polygon_finder/PolygonFinder/src/polygon/bitmaps/RawBitmap.cpp

@@ -56,16 +56,16 @@ void RawBitmap::draw_pixel(int x, int y, unsigned char r, unsigned char g, unsig
   if (bpp > 3) p[3] = a;
 }
 
-uint32_t RawBitmap::define(uint width, uint height, int bytes_per_pixel, bool clear)
-{ this->width = width;
+size_t RawBitmap::define(uint width, uint height, int bytes_per_pixel, bool clear)
+{ this->width  = width;
   this->height = height;
   this->bpp = bytes_per_pixel;
-  uint32_t dimension = (static_cast<uint32_t>(width) * static_cast<uint32_t>(height)) * bytes_per_pixel;
+  size_t dimension = static_cast<size_t>(width) * static_cast<size_t>(height) * static_cast<size_t>(bytes_per_pixel);
   this->image = std::make_unique<unsigned char[]>(dimension);
   if (clear) {
     std::fill(image.get(), image.get() + dimension, 0);
   }
-  return dimension;
+  return static_cast<uint32_t>(dimension);
 }
 
 void RawBitmap::fill(unsigned char r, unsigned char g, unsigned char b, unsigned char a) {

data/ext/cpp_polygon_finder/PolygonFinder/src/polygon/bitmaps/RawBitmap.h

@@ -25,7 +25,7 @@ class RawBitmap : public Bitmap {
   unsigned int rgb_value_at(int x, int y);
   const unsigned char* get_row_ptr(int y) const;
   int get_bytes_per_pixel() const;
-  uint32_t define(uint width, uint height, int bytes_per_pixel, bool clear = false);
+  size_t define(uint width, uint height, int bytes_per_pixel, bool clear = false);
   void draw_pixel(int x, int y, unsigned char r, unsigned char g, unsigned char b, unsigned char a = 255);
   bool save_to_png(const std::string& filename);
   void fill(unsigned char r, unsigned char g, unsigned char b, unsigned char a = 255);

data/ext/cpp_polygon_finder/PolygonFinder/src/polygon/bitmaps/spng.c

@@ -534,7 +534,7 @@ static void u16_row_to_bigendian(void *row, size_t size)
         write_u16(&px[i], px[i]);
     }
 }
-
+/*
 static void rgb8_row_to_rgba8(const unsigned char *row, unsigned char *out, uint32_t n)
 {
     uint32_t i;
@@ -543,6 +543,22 @@ static void rgb8_row_to_rgba8(const unsigned char *row, unsigned char *out, uint
         memcpy(out + i * 4, row + i * 3, 3);
         out[i*4+3] = 255;
     }
+}*/
+
+/* Fix overflow Gigapixel images */
+static void rgb8_row_to_rgba8(const unsigned char *row, unsigned char *out, uint32_t n)
+{
+    size_t i;
+    for(i=0; i < n; i++)
+    {
+        out[0] = row[0];
+        out[1] = row[1];
+        out[2] = row[2];
+        out[3] = 255;
+
+        out += 4;
+        row += 3;
+    }
 }
 
 static unsigned num_channels(const struct spng_ihdr *ihdr)

data/ext/cpp_polygon_finder/PolygonFinder/src/polygon/finder/Node.h

@@ -62,6 +62,7 @@ struct Point {
     return x == other.x && y == other.y;
   }
   Point(int x_, int y_) : x(x_), y(y_) {}
+  Point() : x(0), y(0) {}
 };
 
 class Node : public  Listable {

data/ext/cpp_polygon_finder/PolygonFinder/src/polygon/finder/PolygonFinder.cpp

@@ -103,7 +103,6 @@ void PolygonFinder::scan() {
 ProcessResult* PolygonFinder::process_info() {
   ProcessResult *pr = new ProcessResult();
   pr->groups = this->node_cluster->sequences.size();
-  pr->polygons = std::move(this->node_cluster->polygons);
   pr->benchmarks = std::move(this->reports);
   pr->treemap = this->node_cluster->treemap;
   pr->width = this->source_bitmap->w();
@@ -124,6 +123,7 @@ ProcessResult* PolygonFinder::process_info() {
     pr->named_sequence = sequence;
   }
   else pr->named_sequence = "";
+  pr->polygons = std::move(this->node_cluster->polygons);
   return(pr);
 }
 

data/ext/cpp_polygon_finder/PolygonFinder/src/polygon/finder/PolygonFinder.h

@@ -63,7 +63,7 @@ struct ProcessResult {
   std::list<Polygon> polygons;
   std::string named_sequence;
   std::vector<std::pair<int, int>> treemap;
-  std::vector<std::unique_ptr<Point>> cloned_points_storage;
+  std::vector<Point> cloned_points_storage;
 
   void draw_on_bitmap(RawBitmap& canvas) const;
 
@@ -119,22 +119,25 @@ struct ProcessResult {
 
     for (const auto& poly : this->polygons) {
       Polygon new_poly;
-      // bounds
       new_poly.bounds = poly.bounds;
+      new_poly.outer.reserve(poly.outer.size());
       // outer
       for (const Point* p : poly.outer) {
         if (p) {
-          new_res->cloned_points_storage.push_back(std::make_unique<Point>(p->x, p->y));
-          new_poly.outer.push_back(new_res->cloned_points_storage.back().get());
+          new_res->cloned_points_storage.push_back(Point(p->x, p->y));
+          size_t idx = new_res->cloned_points_storage.size() - 1;
+          new_poly.outer.push_back(&new_res->cloned_points_storage[idx]);
         }
       }
       // inner
       for (const auto& seq : poly.inner) {
         std::vector<Point*> new_seq;
+        new_seq.reserve(seq.size());
         for (const Point* p : seq) {
           if (p) {
-            new_res->cloned_points_storage.push_back(std::make_unique<Point>(p->x, p->y));
-            new_seq.push_back(new_res->cloned_points_storage.back().get());
+            new_res->cloned_points_storage.push_back(Point(p->x, p->y));
+            size_t idx = new_res->cloned_points_storage.size() - 1;
+            new_seq.push_back(&new_res->cloned_points_storage[idx]);
           }
         }
         new_poly.inner.push_back(new_seq);
@@ -144,50 +147,37 @@ struct ProcessResult {
     return new_res;
   }
 
-  std::string to_svg() const {
-    std::vector<std::string> lines;
-    lines.push_back(
-      "<svg xmlns=\"http://www.w3.org/2000/svg\" "
-      "width=\"" + std::to_string(width) +
-      "\" height=\"" + std::to_string(height) + "\">");
+  void to_svg_stream(std::ostream& os) const {
+    os << "<svg xmlns=\"http://www.w3.org/2000/svg\" "
+       << "width=\"" << width << "\" height=\"" << height << "\">\n";
     for (const auto& poly : polygons) {
-      { // outer
-        std::ostringstream pts;
+      // --- OUTER (Red) ---
+      if (!poly.outer.empty()) {
+        os << "<polygon points=\"";
         bool first = true;
         for (const Point* p : poly.outer) {
           if (!p) continue;
-          if (!first)
-              pts << " ";
+          if (!first) os << " ";
           first = false;
-          pts << p->x << "," << p->y;
+          os << p->x << "," << p->y;
         }
-        lines.push_back(
-          "<polygon points=\"" + pts.str() +
-          "\" fill=\"none\" stroke=\"red\" stroke-width=\"1\"/>");
+        os << "\" fill=\"none\" stroke=\"red\" stroke-width=\"1\"/>\n";
       }
-      // inner
+      // --- INNER (Green) ---
       for (const auto& sequence : poly.inner) {
         if (sequence.empty()) continue;
-        std::ostringstream pts;
+        os << "<polygon points=\"";
         bool first = true;
         for (const Point* p : sequence) {
           if (!p) continue;
-          if (!first) pts << " ";
+          if (!first) os << " ";
           first = false;
-          pts << p->x << "," << p->y;
+          os << p->x << "," << p->y;
         }
-        lines.push_back(
-          "<polygon points=\"" + pts.str() +
-          "\" fill=\"none\" stroke=\"green\" stroke-width=\"1\"/>");
+        os << "\" fill=\"none\" stroke=\"green\" stroke-width=\"1\"/>\n";
       }
     }
-    lines.push_back("</svg>");
-    std::ostringstream result;
-    for (size_t i = 0; i < lines.size(); ++i) {
-      result << lines[i];
-      if (i + 1 < lines.size()) result << "\n";
-    }
-    return result.str();
+    os << "</svg>";
   }
 
   void save_svg(const std::string& filename) const {
@@ -195,7 +185,7 @@ struct ProcessResult {
     if (!file.is_open()) {
       throw std::runtime_error("Unable to open SVG file: " + filename);
     }
-    file << to_svg();
+    to_svg_stream(file);
     file.close();
   }
 };

data/lib/contrek/version.rb

@@ -1,3 +1,3 @@
 module Contrek
-  VERSION = "1.2.4"
+  VERSION = "1.2.6"
 end

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: contrek
 version: !ruby/object:Gem::Version
-  version: 1.2.4
+  version: 1.2.6
 platform: ruby
 authors:
 - Emanuele Cesaroni
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2026-05-26 00:00:00.000000000 Z
+date: 2026-05-31 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: rspec