context_validations 0.0.2 → 0.0.3

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA1:
-  metadata.gz: 67d37cb351ac12e521c94e794876897740f49f9e
-  data.tar.gz: f3bbd51b2e4571c43653baafcc3bda40e48fed21
+  metadata.gz: d11c171439aaf9f2e7e22d2dea1e148f061f0daa
+  data.tar.gz: 4d430fc4aac414999a209f76411c10962bf1bd88
 SHA512:
-  metadata.gz: 9bf2e6d88e94472acc2ca903744096520615f40a1231186b92a0f8834dd80421249b7d1f686cce59a4d7510374f3c3007ddb807b40f3d6fd764fd510019d522b
-  data.tar.gz: ab7b9e658d84b0f075c81c54c2946c5d9fd3f70914daf39728e26aa86d7999863acd7d53005e27a356e658e2854d0d411f9d83b84ca7785ed3ad38a5ec333288
+  metadata.gz: 6586b690a8e4e97cae04a5e8a77636245ee0b875b870daadb0c86263483e5f70500b7b3196fcbc2f0ae8fcd4d50c795f4680b6ad3767762208a0e9a6a5b507fa
+  data.tar.gz: 42563e3c5c1a493f09493e837f01a4e3ffe8aa920864c1b2a0f09a249b6ef5c538c336ec49f1328791a511f649aa57e307c26cea7e4ba08255e5a09a7bb63abf

data/CONTRIBUTING.md

@@ -0,0 +1,25 @@
+# Contribution Guidelines #
+
+## Submitting a new issue ##
+
+If you want to ensure that your issue gets fixed *fast* you should
+attempt to reproduce the issue in an isolated example application that
+you can share.
+
+## Making a pull request ##
+
+If you'd like to submit a pull request please adhere to the following:
+
+1. Your code *must* be tested. Please TDD your code!
+2. No single-character variables
+3. Two-spaces instead of tabs
+4. Single-quotes instead of double-quotes unless you are using string
+   interpolation or escapes.
+5. General Rails/Ruby naming conventions for files and classes
+6. *Do not* use Ruby 1.9 stubby proc syntax
+
+Please note that you must adhere to each of the above mentioned rules.
+Failure to do so will result in an immediate closing of the pull
+request. If you update and rebase the pull request to follow the
+guidelines your pull request will be re-opened and considered for
+inclusion.

data/README.md

@@ -4,17 +4,51 @@
 [![Dependency Status](https://gemnasium.com/dockyard/context_validations.png?travis)](https://gemnasium.com/dockyard/context_validations)
 [![Code Climate](https://codeclimate.com/github/dockyard/context_validations.png)](https://codeclimate.com/github/dockyard/context_validations)
 
-Rails exceptions automatically opened as issues on GitHub
+Context based validations for model instances.
 
 ## Looking for help? ##
 
 If it is a bug [please open an issue on GitHub](https://github.com/dockyard/context_validations/issues).
 
-## About ##
+## Installation ##
 
-Context based validations for model instances.
+In your `Gemfile`
 
-## Example ##
+```ruby
+gem 'context_validations'
+```
+
+You can either mixin the moduels on a case-by-case basis or make the
+changes global:
+
+### Case-by-case ###
+
+```ruby
+# model
+class User < ActiveModel::Base
+  include ContextValidations::Model
+end
+
+# controller
+class UsersController < ApplicationController
+  include ContextValidations::Controller
+end
+```
+
+### Global ###
+Create an initializer: `config/initializers/context_validations.rb`
+
+```ruby
+class ActiveRecord::Base
+  include ContextValidations::Model
+end
+
+class ActionController::Base
+  include ContextValidations::Controller
+end
+```
+
+## Usage ##
 
 ```ruby
 class UserController < ApplicationController
@@ -85,7 +119,7 @@ end
 ```
 
 ### Models ###
-When the `ContextValidations::Model` module is mixed into the module all
+When the `ContextValidations::Model` module is mixed into the model all
 of the validation callbacks are removed from that model.
 
 Because we are setting the validations on the instance you should not
@@ -116,3 +150,4 @@ on how to properly submit issues and pull requests.
 [@dockyard](http://twitter.com/dockyard)
 
 [Licensed under the MIT license](http://www.opensource.org/licenses/mit-license.php)
+

data/lib/context_validations/controller.rb

@@ -34,7 +34,8 @@ module ContextValidations::Controller
     end
     @validations = []
     base_validations
-    if respond_to?("#{context}_validations")
+    if respond_to?("#{context}_validations") || private_methods.include?("#{context}_validations".to_sym) ||
+      protected_methods.include?("#{context}_validations".to_sym)
       send("#{context}_validations")
     end
     @validations

data/lib/context_validations/version.rb

@@ -1,3 +1,3 @@
 module ContextValidations
-  VERSION = '0.0.2'
+  VERSION = '0.0.3'
 end

data/test/controller_test.rb

@@ -24,22 +24,81 @@ class UsersController
   end
 end
 
+class ProtectedController
+  include ContextValidations::Controller
+
+  def create
+    validations(:create)
+  end
+
+  protected
+
+  def base_validations
+    validates :first_name, :presence => true
+  end
+
+  def create_validations
+    validates :password, :presence => true
+  end
+end
+
+class PrivateController
+  include ContextValidations::Controller
+
+  def create
+    validations(:create)
+  end
+
+  private
+
+  def base_validations
+    validates :first_name, :presence => true
+  end
+
+  def create_validations
+    validates :password, :presence => true
+  end
+end
+
+
 describe 'Controller' do
-  before do
-    @controller = UsersController.new
+  context 'Public validations' do
+    before do
+      @controller = UsersController.new
+    end
+
+    if RUBY_VERSION >= '2'
+      it 'combines base and create validations for create action, context is implied' do
+        @controller.create.length.must_equal 2
+      end
+    end
+
+    it 'combines base and create validations for other create action, context is forced' do
+      @controller.other_create.length.must_equal 2
+    end
+
+    it 'uses base validations when context validations are not set for update action' do
+      @controller.update.length.must_equal 1
+    end
   end
 
-  if RUBY_VERSION >= '2'
-    it 'combines base and create validations for create action, context is implied' do
+  context 'Protected validations' do
+    before do
+      @controller = ProtectedController.new
+    end
+
+    it 'combines base and create validations for other create action, context is forced' do
       @controller.create.length.must_equal 2
     end
   end
 
-  it 'combines base and create validations for other create action, context is forced' do
-    @controller.other_create.length.must_equal 2
-  end
+  context 'Private validations' do
+    before do
+      @controller = PrivateController.new
+    end
 
-  it 'uses base validations when context validations are not set for update action' do
-    @controller.update.length.must_equal 1
+    it 'combines base and create validations for other create action, context is forced' do
+      @controller.create.length.must_equal 2
+    end
   end
 end

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: context_validations
 version: !ruby/object:Gem::Version
-  version: 0.0.2
+  version: 0.0.3
 platform: ruby
 authors:
 - Brian Cardarella
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2013-05-09 00:00:00.000000000 Z
+date: 2013-06-04 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: activesupport
@@ -103,6 +103,7 @@ extra_rdoc_files: []
 files:
 - .gitignore
 - .travis.yml
+- CONTRIBUTING.md
 - Gemfile
 - README.md
 - Rakefile