contentful 2.2.0 → 2.2.1

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA1:
-  metadata.gz: 8f52c84276b1d01accb5b4dbe02c03a449cbbe92
-  data.tar.gz: 440fd92382ceff3a1e16f1041579aa580274fb19
+  metadata.gz: cf53c3d3eb32e5999d0fc830ffcc1daa8da44fb4
+  data.tar.gz: 3f00e06364877e4766d0bb301d18b0d3ffc54ac4
 SHA512:
-  metadata.gz: 75accb9770e199513b8446503374dae316fb71064732ad24e4798488fac14991e8aeed7ff0b28d3889e6e9bc36755cacf8fe233d547f0bc9947cc7da6047025c
-  data.tar.gz: 077226c6102ecf514383b9a83ef71ebbd94b6080354c99d5f222e7a8ebd47cad011a86ac55d7cb7cc618596b5af45335efa76be668092ae4618d45cd8c2303f1
+  metadata.gz: 474232cb4a42d12d9bff8d1a8673abf810b9856734e20d370e0599acdc5b448a44e8f4bfbdaff86d5fd5183ab0580f3137811ec2a5e4cd13c5a911ad2377d917
+  data.tar.gz: 11997a27a1fdcb606fadb94875136a7d88d32157cc3656cfa9a3ee10212d2be30fdbefb16f1aa64e95ee7a01d0c4ce5f44d8fbab95a79abe68b3b9e12fa51c94

data/CHANGELOG.md

@@ -2,6 +2,10 @@
 
 ## Unreleased
 
+## 2.2.1
+### Fixed
+* Fixed an edge case of 404 error having details as a string.
+
 ## 2.2.0
 ### Added
 * Added `:use_camel_case` option to client. [#142](https://github.com/contentful/contentful.rb/issues/142)

data/lib/contentful/error.rb

@@ -120,6 +120,8 @@ module Contentful
     end
 
     def handle_details(details)
+      return details if details.is_a?(String)
+
       message = "The requested #{details['type']} could not be found."
 
       resource_id = details.fetch('id', nil)

data/lib/contentful/version.rb

@@ -1,5 +1,5 @@
 # Contentful Namespace
 module Contentful
   # Gem Version
-  VERSION = '2.2.0'
+  VERSION = '2.2.1'
 end

data/spec/error_class_spec.rb

@@ -154,6 +154,17 @@ describe Contentful::Error do
         end
 
         describe '404' do
+          it 'details is a string' do
+            response = Contentful::Response.new raw_fixture('404_details_string', 404)
+            error = Contentful::Error[response.raw.status].new(response)
+
+            message = "HTTP status code: 404\n"\
+                      "Message: The requested resource or endpoint could not be found.\n"\
+                      "Details: The resource could not be found\n"\
+                      "Request ID: 85f-351076632"
+            expect(error.message).to eq message
+          end
+
           it 'has a type' do
             response = Contentful::Response.new raw_fixture('404_type', 404)
             error = Contentful::Error[response.raw.status].new(response)

data/spec/fixtures/json_responses/404_details_string.json

@@ -0,0 +1,8 @@
+{
+  "sys": {
+    "type": "Error",
+    "id": "NotFound"
+  },
+  "details": "The resource could not be found",
+  "requestId": "85f-351076632"
+}

metadata

@@ -1,7 +1,7 @@
 --- !ruby/object:Gem::Specification
 name: contentful
 version: !ruby/object:Gem::Version
-  version: 2.2.0
+  version: 2.2.1
 platform: ruby
 authors:
 - Contentful GmbH (Jan Lelis)
@@ -10,7 +10,7 @@ authors:
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2017-10-24 00:00:00.000000000 Z
+date: 2017-10-25 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: http
@@ -408,6 +408,7 @@ files:
 - spec/fixtures/json_responses/400_details_errors_string.json
 - spec/fixtures/json_responses/400_details_string.json
 - spec/fixtures/json_responses/403_reasons.json
+- spec/fixtures/json_responses/404_details_string.json
 - spec/fixtures/json_responses/404_id.json
 - spec/fixtures/json_responses/404_type.json
 - spec/fixtures/json_responses/content_type.json
@@ -539,6 +540,7 @@ test_files:
 - spec/fixtures/json_responses/400_details_errors_string.json
 - spec/fixtures/json_responses/400_details_string.json
 - spec/fixtures/json_responses/403_reasons.json
+- spec/fixtures/json_responses/404_details_string.json
 - spec/fixtures/json_responses/404_id.json
 - spec/fixtures/json_responses/404_type.json
 - spec/fixtures/json_responses/content_type.json