contentful-management 0.3.1 → 0.4.0

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA1:
-  metadata.gz: 049eb488576c16400cff6e5ccda07a6d49730cf2
-  data.tar.gz: f8e3875a69f5a41827fade93d588b105e2ebea0b
+  metadata.gz: 078f6456feff75c1b9b229796ce894c38fb75f67
+  data.tar.gz: 1d2374e3fb60e05ad5a12f9d2dcaabfde8a2453b
 SHA512:
-  metadata.gz: c945200f9958c740a37f5712d0579b9c37b951d1450cd27a9677505aa2a95b68245ed0b929d1570651bd6b3997ec5a490c25f6e3f9dcfdd752eafc93d9569224
-  data.tar.gz: b606b3c542b8c0bb64976e34916f2a3004b3c03c15b7dfd806792dd58da8b81d5846ae568a6895a8d9b4b27b0dbca6da0e537190ec68041bd012589bf1218dd4
+  metadata.gz: f3df2feede3f7a11508ebc6d284e01e0696f3111263bfc3eb3efa137ba5e847bc061137a4ebb077edca5bdebf7bd20e982b46daa5c9a40461cc26c83e357619b
+  data.tar.gz: bf49926589bd2e50a5ddfe5218a19e3eb12b167f569bca930cc446daa094702938cc33bc5825b1414d50b84e83ee6dea23f90aae86948d16c3bf3b8bb43388c1

data/CHANGELOG.md

@@ -1,9 +1,11 @@
 # Change Log
-## Unreleased
+## 0.4.0
 ### Fixed
 * Return Keep attribute if it's already a hash [#33](https://github.com/contentful/contentful-management.rb/pull/33)
 * Typo in header [#34](https://github.com/contentful/contentful-management.rb/pull/34)
 * Items are nil when creating an array field for a content type [#35](https://github.com/contentful/contentful-management.rb/issues/35)
+### Added
+* `raise_errors` can be enabled, disabled by default [#38](https://github.com/contentful/contentful-management.rb/pull/38)
 
 ## 0.3.1
 ### Added

data/README.md

@@ -542,6 +542,14 @@ Logger.new('logfile.log')
 
 The default severity is set to INFO and logs only the request attributes (headers, parameters and url). Setting it to DEBUG will also log the raw JSON response.
 
+## Raise Errors
+
+If ```:raise_errors``` is set to true, an Exception will be raised in case of an error. The default is false, in this case a ```Contentful::Management::Error``` object will be returned.
+
+```ruby
+client = Contentful::Management::Client.new('access_token', raise_errors: true)
+```
+
 ## Contributing
 
 1. Fork it ( https://github.com/[my-github-username]/contentful-management/fork )

data/lib/contentful/management/client.rb

@@ -25,7 +25,8 @@ module Contentful
           default_locale: 'en-US',
           gzip_encoded: false,
           logger: false,
-          log_level: Logger::INFO
+          log_level: Logger::INFO,
+          raise_errors: false
       }
 
       def initialize(access_token = nil, configuration = {})
@@ -83,11 +84,13 @@ module Contentful
       def execute_request(request)
         request_url = request.url
         url = request.absolute? ? request_url : base_url + request_url
-        logger.info(request: {url: url, query: request.query ,header: request_headers}) if logger
+        logger.info(request: {url: url, query: request.query, header: request_headers}) if logger
         raw_response = yield(url)
         logger.debug(response: raw_response) if logger
         clear_headers
-        Response.new(raw_response, request)
+        result = Response.new(raw_response, request)
+        fail result.object if result.object.is_a?(Error) && configuration[:raise_errors]
+        result
       end
 
       def clear_headers

data/lib/contentful/management/version.rb

@@ -1,5 +1,5 @@
 module Contentful
   module Management
-    VERSION = '0.3.1'
+    VERSION = '0.4.0'
   end
 end

data/spec/lib/contentful/management/client_spec.rb

@@ -74,6 +74,15 @@ module Contentful
         end
       end
 
+      describe '.raise_error' do
+        it 'raise error set to true' do
+          expect(subject.configuration[:raise_errors]).to be_falsey
+        end
+        it 'raise error set to false' do
+          client = Client.new('token', raise_errors: true)
+          expect(client.configuration[:raise_errors]).to be_truthy
+        end
+      end
     end
   end
 end

data/spec/lib/contentful/management/entry_spec.rb

@@ -55,6 +55,14 @@ module Contentful
             expect(result).to be_kind_of Contentful::Management::NotFound
           end
         end
+        context 'raise_error when space not found' do
+          let!(:client) { Client.new(token, raise_errors: true) }
+          it 'returns an error when entry does not exists' do
+            expect_vcr('entry/find_not_found') do
+              subject.find(space_id, 'not_exist')
+            end.to raise_error Contentful::Management::NotFound
+          end
+        end
 
         it 'returns an error when service is unavailable' do
           vcr('entry/service_unavailable') do
@@ -268,9 +276,9 @@ module Contentful
           vcr('entry/create_with_entries') do
             entry_att = Entry.find(space_id, '1d1QDYzeiyWmgqQYysae8u')
             new_entry = subject.create(content_type,
-                                    name: 'EntryWithEntries',
-                                    age: 20,
-                                    entries: [entry_att, entry_att, entry_att])
+                                       name: 'EntryWithEntries',
+                                       age: 20,
+                                       entries: [entry_att, entry_att, entry_att])
             expect(new_entry.name).to eq 'EntryWithEntries'
             expect(new_entry.age).to eq 20
           end
@@ -572,18 +580,18 @@ module Contentful
           # entry_att = Entry.find('ene4qtp2sh7u', '60zYC7nY9GcKGiCYwAs4wm')
 
           attributes = {
-            name: 'Test name',
-            number: 30,
-            float1: 1.1,
-            boolean: true, date: '2000-07-12T11:11:00+02:00',
-            time: '2000-07-12T11:11:00+02:00',
-            location: location,
-            image: Asset.new,
-            images: [Asset.new, Asset.new],
-            array: %w(PL USD XX),
-            entry: Entry.new,
-            entries: [Entry.new, Entry.new],
-            object_json: {'test' => {'@type' => 'Codequest'}}
+              name: 'Test name',
+              number: 30,
+              float1: 1.1,
+              boolean: true, date: '2000-07-12T11:11:00+02:00',
+              time: '2000-07-12T11:11:00+02:00',
+              location: location,
+              image: Asset.new,
+              images: [Asset.new, Asset.new],
+              array: %w(PL USD XX),
+              entry: Entry.new,
+              entries: [Entry.new, Entry.new],
+              object_json: {'test' => {'@type' => 'Codequest'}}
           }
 
           parsed_attributes = Entry.new.fields_from_attributes(attributes)
@@ -606,7 +614,7 @@ module Contentful
 
         it 'keepd hashes in attributes' do
           attributes = {
-            entries: [{sys: {type: 'Link', linkType: 'Entry', id: nil}}, {sys: {type: 'Link', linkType: 'Entry', id: nil}}]
+              entries: [{sys: {type: 'Link', linkType: 'Entry', id: nil}}, {sys: {type: 'Link', linkType: 'Entry', id: nil}}]
           }
 
           parsed_attributes = Entry.new.fields_from_attributes(attributes)

metadata

@@ -1,7 +1,7 @@
 --- !ruby/object:Gem::Specification
 name: contentful-management
 version: !ruby/object:Gem::Version
-  version: 0.3.1
+  version: 0.4.0
 platform: ruby
 authors:
 - Piotr Protas
@@ -10,7 +10,7 @@ authors:
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2014-10-31 00:00:00.000000000 Z
+date: 2014-11-07 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: http