contact-list 0.2.0 → 0.2.1

data/README.md

@@ -0,0 +1,27 @@
+# Contact List
+
+A small gem for fetching a user's contacts from various social providers. Now with 100% less ActiveSupport!
+
+## Usage
+
+Instantiate a provider with your API key and the OAuth token for the user:
+
+    provider = Contacts[:linkedin].new(consumer_key: 'foo', consumer_secret: 'bar', token: 'moo', secret: 'oink')
+
+Fetch the contacts:
+
+    provider.contacts.first.name
+    # => "Joe Bloggs"
+
+## Todo
+
+Improve the API. Seriously. It's awful.
+
+## Contribootin'
+
+* Fork the project.
+* Make your feature addition or bug fix.
+* Add specs for it. This is important so I don't break it in a future version unintentionally.
+* Commit, do not mess with rakefile, version, or history
+  (if you want to have your own version, that is fine but bump version in a commit by itself I can ignore when I pull)
+* Send me a pull request. Bonus points for topic branches.

data/lib/contact_list.rb

@@ -1,13 +1,3 @@
 require 'rubygems'
 
-require 'active_support/core_ext/hash/slice'
-require 'active_support/core_ext/class/inheritable_attributes'
-require 'active_support/core_ext/module/delegation'
-require 'active_support/core_ext/object/blank'
-require 'active_support/inflector'
-
-class Hash
-  alias_method :only,  :slice
-  alias_method :only!, :slice!
-end
 require File.expand_path('../contacts', __FILE__)

data/lib/contacts/contact/google.rb

@@ -3,7 +3,7 @@ class Contacts::Contact::Google < Struct.new(:email, :name)
   def self.parse xml
     name = xml.css("title").text
     email_node = xml.xpath("gd:email").first
-    return nil unless email_node.present?
+    return nil if email_node.nil?
     email = email_node['address'] 
     new(email, name)
   end

data/lib/contacts/contact/yahoo.rb

@@ -11,7 +11,7 @@ class Contacts::Contact::Yahoo < Struct.new(:email, :name)
       end
     end
     name ||= email
-    new(email, name) unless email.blank?
+    new(email, name) unless email.nil? or email.empty?
   end
   
 end

data/lib/contacts/provider/base.rb

@@ -1,32 +1,36 @@
 module Contacts
   module Provider
     class Base
-      
-      class_inheritable_accessor :site_url
-      self.site_url = nil
-      delegate :site_url, :to => "self.class"
 
-      class_inheritable_accessor :valid_attributes
-      self.valid_attributes = []          
-      delegate :import_type, :valid_attributes, :to => "self.class"
+      class << self
+        attr_accessor :site_url
 
-      def self.set_site_url url
-        self.site_url = url
-      end
+        def valid_attributes= attrs
+          @valid_attributes = attrs.map!(&:to_sym)
+          attr_accessor *attrs
+        end
 
-      def self.set_valid_attributes *attrs
-        self.valid_attributes = attrs.map!(&:to_sym)
-        attr_accessor *attrs
+        def valid_attributes
+          @valid_attributes ||= []
+        end
+
+        def provider_id
+          self.name.gsub(/^.*::/, '').downcase
+        end
+        
+        def all attrs={}
+          new(attrs).contacts
+        end
       end
 
-      def self.provider_id
-        self.name.demodulize.underscore
+      def site_url
+        self.class.site_url
       end
-      
-      def self.all attrs={}
-        new(attrs).contacts
+
+      def valid_attributes
+        self.class.valid_attributes
       end
-      
+
       def initialize attrs={}
         parse_attributes attrs
       end
@@ -56,7 +60,7 @@ module Contacts
       end
 
       def parse_attributes attrs = {}
-        self.attributes = attrs.only(*valid_attributes)   
+        self.attributes = attrs.reject { |k,v| !self.class.valid_attributes.include?(k.to_sym) }
       end
 
       def attributes= attrs = {}
@@ -66,7 +70,7 @@ module Contacts
       end
 
       def attributes
-        valid_attributes.inject({}) {|result, attr| result.merge attr => send(attr) }
+        self.class.valid_attributes.inject({}) {|result, attr| result.merge attr => send(attr) }
       end
     end
   end      

data/lib/contacts/provider/facebook.rb

@@ -1,6 +1,6 @@
 require 'multi_json'
 class Contacts::Provider::Facebook < Contacts::Provider::OAuth2
-  set_site_url 'https://graph.facebook.com'
+  self.site_url = 'https://graph.facebook.com'
   
   def retrieve_contacts!
     @contacts_response = connection.get("/me/friends")

data/lib/contacts/provider/google.rb

@@ -1,7 +1,7 @@
 require 'nokogiri'
 
 class Contacts::Provider::Google < Contacts::Provider::OAuth
-  set_site_url 'https://www.google.com'
+  self.site_url = 'https://www.google.com'
   
   def retrieve_contacts!
     @contacts_response = connection.get("/m8/feeds/contacts/#{uid||'default'}/full?max-results=999")

data/lib/contacts/provider/linkedin.rb

@@ -1,6 +1,6 @@
 require 'multi_json'
 class Contacts::Provider::Linkedin < Contacts::Provider::OAuth
-  set_site_url 'http://api.linkedin.com'
+  self.site_url = 'http://api.linkedin.com'
   
   def retrieve_contacts!
     @connections_response = connection.get("/v1/people/~/connections:(first-name,last-name,id,headline,picture-url)")

data/lib/contacts/provider/oauth.rb

@@ -3,10 +3,14 @@ require 'oauth'
 module Contacts
   module Provider
     class OAuth < Contacts::Provider::Base
-      set_valid_attributes :token, :secret, :consumer_key, :consumer_secret, :uid
+      def self.inherited klass
+        klass.valid_attributes = self.valid_attributes
+      end
+      
+      self.valid_attributes = [:token, :secret, :consumer_key, :consumer_secret, :uid]
       
       def consumer
-        @consumer ||= ::OAuth::Consumer.new(consumer_key, consumer_secret, :site => site_url)
+        @consumer ||= ::OAuth::Consumer.new(consumer_key, consumer_secret, :site => self.site_url)
       end
       
       def connect!

data/lib/contacts/provider/oauth2.rb

@@ -3,7 +3,11 @@ require 'oauth2'
 module Contacts
   module Provider
     class OAuth2 < Contacts::Provider::Base
-      set_valid_attributes :token, :consumer_key, :consumer_secret
+      def self.inherited klass
+        klass.valid_attributes = self.valid_attributes
+      end
+      
+      self.valid_attributes = [:token, :consumer_key, :consumer_secret]
       
       def client
         @client ||= ::OAuth2::Client.new(consumer_key, consumer_secret, :site => site_url)

data/lib/contacts/provider/twitter.rb

@@ -1,6 +1,6 @@
 require 'multi_json'
 class Contacts::Provider::Twitter < Contacts::Provider::OAuth
-  set_site_url 'http://api.twitter.com'
+  self.site_url = 'http://api.twitter.com'
   
   def retrieve_contacts!
     {:followers_response => followers_response, :following_response => following_response}

data/lib/contacts/provider/yahoo.rb

@@ -1,6 +1,6 @@
 require 'multi_json'
 class Contacts::Provider::Yahoo < Contacts::Provider::OAuth
-  set_site_url 'http://social.yahooapis.com'
+  self.site_url = 'http://social.yahooapis.com'
   
   def retrieve_contacts!
     @contacts_response = connection.get("/v1/user/me/contacts?format=json")

metadata

@@ -1,7 +1,7 @@
 --- !ruby/object:Gem::Specification
 name: contact-list
 version: !ruby/object:Gem::Version
-  version: 0.2.0
+  version: 0.2.1
   prerelease: 
 platform: ruby
 authors:
@@ -11,11 +11,11 @@ authors:
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2012-02-14 00:00:00.000000000 Z
+date: 2012-02-20 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: contact-list
-  requirement: &70198657387760 !ruby/object:Gem::Requirement
+  requirement: &70180995875800 !ruby/object:Gem::Requirement
     none: false
     requirements:
     - - ! '>='
@@ -23,10 +23,10 @@ dependencies:
         version: '0'
   type: :runtime
   prerelease: false
-  version_requirements: *70198657387760
+  version_requirements: *70180995875800
 - !ruby/object:Gem::Dependency
   name: rspec
-  requirement: &70198657387140 !ruby/object:Gem::Requirement
+  requirement: &70180995873440 !ruby/object:Gem::Requirement
     none: false
     requirements:
     - - ~>
@@ -34,10 +34,10 @@ dependencies:
         version: '2.0'
   type: :development
   prerelease: false
-  version_requirements: *70198657387140
+  version_requirements: *70180995873440
 - !ruby/object:Gem::Dependency
   name: rspec
-  requirement: &70198657386660 !ruby/object:Gem::Requirement
+  requirement: &70180995872540 !ruby/object:Gem::Requirement
     none: false
     requirements:
     - - ~>
@@ -45,10 +45,10 @@ dependencies:
         version: '2.0'
   type: :development
   prerelease: false
-  version_requirements: *70198657386660
+  version_requirements: *70180995872540
 - !ruby/object:Gem::Dependency
   name: rspec
-  requirement: &70198657386040 !ruby/object:Gem::Requirement
+  requirement: &70180995871580 !ruby/object:Gem::Requirement
     none: false
     requirements:
     - - ~>
@@ -56,10 +56,10 @@ dependencies:
         version: '2.0'
   type: :development
   prerelease: false
-  version_requirements: *70198657386040
+  version_requirements: *70180995871580
 - !ruby/object:Gem::Dependency
   name: rspec
-  requirement: &70198657385400 !ruby/object:Gem::Requirement
+  requirement: &70180995870620 !ruby/object:Gem::Requirement
     none: false
     requirements:
     - - ~>
@@ -67,21 +67,32 @@ dependencies:
         version: '2.0'
   type: :development
   prerelease: false
-  version_requirements: *70198657385400
+  version_requirements: *70180995870620
 - !ruby/object:Gem::Dependency
-  name: activesupport
-  requirement: &70198657384880 !ruby/object:Gem::Requirement
+  name: rspec
+  requirement: &70180995869160 !ruby/object:Gem::Requirement
     none: false
     requirements:
-    - - ! '>='
+    - - ~>
       - !ruby/object:Gem::Version
-        version: 2.1.0
-  type: :runtime
+        version: '2.0'
+  type: :development
+  prerelease: false
+  version_requirements: *70180995869160
+- !ruby/object:Gem::Dependency
+  name: rspec
+  requirement: &70180995867120 !ruby/object:Gem::Requirement
+    none: false
+    requirements:
+    - - ~>
+      - !ruby/object:Gem::Version
+        version: '2.0'
+  type: :development
   prerelease: false
-  version_requirements: *70198657384880
+  version_requirements: *70180995867120
 - !ruby/object:Gem::Dependency
   name: multi_json
-  requirement: &70198657384340 !ruby/object:Gem::Requirement
+  requirement: &70180995865060 !ruby/object:Gem::Requirement
     none: false
     requirements:
     - - ~>
@@ -89,10 +100,10 @@ dependencies:
         version: 1.0.4
   type: :runtime
   prerelease: false
-  version_requirements: *70198657384340
+  version_requirements: *70180995865060
 - !ruby/object:Gem::Dependency
   name: nokogiri
-  requirement: &70198657383640 !ruby/object:Gem::Requirement
+  requirement: &70180995863960 !ruby/object:Gem::Requirement
     none: false
     requirements:
     - - ~>
@@ -100,10 +111,10 @@ dependencies:
         version: 1.5.0
   type: :runtime
   prerelease: false
-  version_requirements: *70198657383640
+  version_requirements: *70180995863960
 - !ruby/object:Gem::Dependency
   name: oauth
-  requirement: &70198657383040 !ruby/object:Gem::Requirement
+  requirement: &70180995861800 !ruby/object:Gem::Requirement
     none: false
     requirements:
     - - ~>
@@ -111,10 +122,10 @@ dependencies:
         version: 0.4.5
   type: :runtime
   prerelease: false
-  version_requirements: *70198657383040
+  version_requirements: *70180995861800
 - !ruby/object:Gem::Dependency
   name: oauth2
-  requirement: &70198657382440 !ruby/object:Gem::Requirement
+  requirement: &70180995848320 !ruby/object:Gem::Requirement
     none: false
     requirements:
     - - ~>
@@ -122,10 +133,10 @@ dependencies:
         version: 0.5.2
   type: :runtime
   prerelease: false
-  version_requirements: *70198657382440
+  version_requirements: *70180995848320
 - !ruby/object:Gem::Dependency
   name: rspec
-  requirement: &70198657381900 !ruby/object:Gem::Requirement
+  requirement: &70180995847540 !ruby/object:Gem::Requirement
     none: false
     requirements:
     - - ~>
@@ -133,7 +144,7 @@ dependencies:
         version: '2.0'
   type: :development
   prerelease: false
-  version_requirements: *70198657381900
+  version_requirements: *70180995847540
 description: Find contacts from multiple providers
 email:
 - alex@rawnet.com
@@ -142,7 +153,7 @@ email:
 executables: []
 extensions: []
 extra_rdoc_files:
-- README
+- README.md
 files:
 - lib/contact_list.rb
 - lib/contacts.rb
@@ -161,8 +172,8 @@ files:
 - lib/contacts/provider/oauth2.rb
 - lib/contacts/provider/twitter.rb
 - lib/contacts/provider/yahoo.rb
-- README
-homepage: 
+- README.md
+homepage: http://github.com/boffbowsh/contact-list
 licenses: []
 post_install_message: 
 rdoc_options: []