contact-data 0.2.2 → 0.2.3

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA1:
-  metadata.gz: 64b030ebd50147457d027469443614dee8f0b61d
-  data.tar.gz: b5be157f0fdde8b6d1897b38683996008132e400
+  metadata.gz: f710aaded7b29a23aeeaba066b6ab44a3dccf35e
+  data.tar.gz: 92d0d640a4b6dea1c394a459b51e1cef687b2415
 SHA512:
-  metadata.gz: 73495ac9ccae0a573c42a70fb4345adc918b5c907246627152d9f15037b6e228dab6670d0f7a7b5d95de7ab434a6878b3a9af62d7374cc9b117100d7717b66fc
-  data.tar.gz: 37c9ceb5f36e55b9b15dfe1baa1cc9a66ad57593c34b3ccd0c6e501af8d0db692365f514eec472c9775ed60283ed56c46d2149ef5f1badf0be9dd26bbd36d9b2
+  metadata.gz: ee1f83d6fc779a5c811ed36115c66104b8ac1d9578325883ae0413c7529926bf8552645457d0a98708f4033f0ad2ad4a6acbebc3c616ea185d30c97cd98b6d63
+  data.tar.gz: 1cac72dde7c016f3936d0d6d9491c037890f447c2b3050964a8b6fa94a97da8a9cbfccb909a7893c31d3631ac972344fa041fcfac2f011b39a473a2037160918

data/.gitignore

@@ -1,3 +1,6 @@
+* Gem project, so don't check in:
+Gemfile.lock
+
 *.gem
 *.rbc
 /.config

data/.hound.yml

@@ -3,6 +3,10 @@ LineLength:
   Max: 120
   Enabled: true
 
+StringLiterals:
+  EnforcedStyle: single_quotes
+  Enabled: true
+
 FileName:
   Description: 'Use snake_case for source file names.'
   Enabled: false

data/.ruby-version

@@ -1 +1 @@
-2.1.2
+2.1.5

data/contact-data.gemspec

@@ -24,7 +24,7 @@ Gem::Specification.new do |spec|
   spec.add_development_dependency 'rake', '~> 10'
   spec.add_development_dependency 'rspec', '~> 2'
   spec.add_development_dependency 'gem-release', '~> 0'
-  spec.add_development_dependency 'simplecov', '~> 0.7', '>= 0.7.1' # https://github.com/colszowka/simplecov/issues/281
+  spec.add_development_dependency 'simplecov', '~> 0.9'
   spec.add_development_dependency 'coveralls', '~> 0'
   spec.add_development_dependency 'vcr', '~> 2'
   spec.add_development_dependency 'webmock', '~> 1'

data/lib/contact-data/contact.rb

@@ -9,6 +9,12 @@ module ContactData
         options[:params] = { name: name }
         Fetcher.get(:search, options)
       end
+
+      def from(source, slug, options = {})
+        options[:base] = BASE
+        options[:params] = { source: source, slug: slug }
+        Fetcher.get(:from, options)
+      end
     end
   end
 end

data/lib/contact-data/fetcher.rb

@@ -50,7 +50,18 @@ module ContactData
       end
 
       def fetch(url, method = :get, options = {})
+        args = args_from url, method, options
         logger.info { "Using #{method.to_s.upcase} for #{url}" }
+        logger.info { "Args: #{args}" }
+
+        begin
+          RestClient::Request.new(args).execute
+        rescue RestClient::Exception => e
+          raise ContactData::FetchError, "#{e.message} when trying to #{method.to_s.upcase} url: #{url}", e.backtrace
+        end
+      end
+
+      def args_from(url, method, options)
         args = { url: url, method: method }
         args[:headers] = { params: options[:params] } if options.key? :params
 
@@ -62,11 +73,7 @@ module ContactData
           :ssl_verify_callback_warnings, :ssl_version, :ssl_ciphers
         ].each { |key| args[key] = options[key] if options.key? key }
 
-        begin
-          RestClient::Request.new(args).execute
-        rescue RestClient::Exception => e
-          raise ContactData::FetchError, "#{e.message} when trying to #{method.to_s.upcase} url: #{url}", e.backtrace
-        end
+        args
       end
 
       def parse(json)

data/lib/contact-data/version.rb

@@ -1,4 +1,4 @@
 # Gem version
 module ContactData
-  VERSION = '0.2.2'
+  VERSION = '0.2.3'
 end

data/spec/contact-data_contact_spec.rb

@@ -3,7 +3,9 @@ require 'spec_helper'
 require 'contact-data'
 
 describe ContactData::Contact do
-  let(:name) { 'Derek Jones III' }
+  let(:name)    { 'Derek Jones III' }
+  let(:source)  { 'angel_list' }
+  let(:slug)    { 'derek-jones' }
 
   it 'searches for a contact by name' do
     VCR.use_cassette('name_search') do
@@ -13,4 +15,13 @@ describe ContactData::Contact do
       expect(result[:identities].count).to eq(15)
     end
   end
+
+  it 'retrieves a contact from a source' do
+    VCR.use_cassette('source_slug') do
+      result = ContactData::Contact.from(source, slug, verbose: true)
+      expect(result).to be_a(Hash)
+      expect(result[:slug]).to eq(slug)
+      expect(result[:data].first[:source_identities].count).to eq(5)
+    end
+  end
 end

data/spec/fetcher_spec.rb

@@ -1,10 +1,10 @@
 # encoding: utf-8
 require 'spec_helper'
 require 'contact-data'
-require 'byebug'
 
 describe ContactData::Fetcher do
   let(:method) { 'method' }
+  let(:url) { ContactData::Fetcher::URL }
 
   it 'adds diagnostic information to a RestClient exception' do
     RestClient::Request.any_instance.stub(:execute).and_raise RestClient::InternalServerError.new(nil, 500)
@@ -15,4 +15,19 @@ describe ContactData::Fetcher do
       expect(e.message).to eq(message)
     }
   end
+
+  it 'forms the expected URL' do
+    [
+      { method: method, options: {}, url: "#{url}/method.json" },
+      { method: :method, options: {}, url: "#{url}/api/v2/method.json" },
+      { method: :method, options: { base: 'base' }, url: "#{url}/api/v2/base/method.json" }
+    ].each do |url_data|
+      puts "#{url_data[:method].class}\t#{url_data[:options]}"
+      expect(
+        ContactData::Fetcher.__send__(
+          :get_url_from, url_data[:method], url_data[:options]
+        )
+      ).to eq(url_data[:url])
+    end
+  end
 end

data/spec/support/cassettes/name_search.yml

@@ -53,6 +53,6 @@ http_interactions:
         Jones","identity_slug":"dxj00029","service":"fsa","url":"http://www.fsa.gov.uk/register//indivbasicdetails.do?sid=282759"},{"contact_type":"person","description":"Derek
         Jones","identity_slug":"dxj01164","service":"fsa","url":"http://www.fsa.gov.uk/register//indivbasicdetails.do?sid=490042"},{"contact_type":"person","description":"Derek
         Jones","identity_slug":"dxj01321","service":"fsa","url":"http://www.fsa.gov.uk/register//indivbasicdetails.do?sid=729794"},{"contact_type":"person","description":null,"identity_slug":"pub/derek-jones/15/b2/55b","service":"linked_in","url":"http://www.linkedin.com/pub/derek-jones/15/b2/55b"},{"contact_type":"person","description":null,"identity_slug":"http://www.dereknakano.com","service":"url","url":"http://www.dereknakano.com"}],"relationships":[],"links":[]}'
-    http_version: 
+    http_version:
   recorded_at: Tue, 11 Nov 2014 16:28:14 GMT
 recorded_with: VCR 2.9.3

data/spec/support/cassettes/source_slug.yml

@@ -0,0 +1,49 @@
+---
+http_interactions:
+- request:
+    method: get
+    uri: http://public.xenapto.com/api/v2/contacts/from.json?slug=derek-jones&source=angel_list
+    body:
+      encoding: US-ASCII
+      string: ''
+    headers:
+      Accept:
+      - "*/*; q=0.5, application/xml"
+      Accept-Encoding:
+      - gzip, deflate
+      User-Agent:
+      - Ruby
+  response:
+    status:
+      code: 200
+      message: OK
+    headers:
+      Date:
+      - Fri, 06 Feb 2015 17:38:54 GMT
+      Status:
+      - 200 OK
+      Connection:
+      - close
+      Content-Type:
+      - application/json; charset=utf-8
+      Content-Length:
+      - '1184'
+      X-Ua-Compatible:
+      - IE=Edge,chrome=1
+      Etag:
+      - '"f242c0a293365c9aaaa79c1754b8d7ea"'
+      Cache-Control:
+      - max-age=0, private, must-revalidate
+      X-Request-Id:
+      - 8b6f60e98e1bd645ee159f7a3a2ad056
+      X-Runtime:
+      - '0.232381'
+      X-Rack-Cache:
+      - miss
+    body:
+      encoding: UTF-8
+      string: '{"version":"v2","source":"angel_list","slug":"derek-jones","data":[{"api_link":"/users/165075","canonical_slug":"derek-jones","contact_type":"person","description":null,"last_fetched":"2015-01-30T20:05:46Z","name":"Derek
+        Thomas Edward Jones","page_link":"/derek-jones","source_created_at":null,"source_id":165075,"source_namespace":"users","source_slug":"derek-jones","source_updated_at":null,"website":null,"source_links":[],"source_funding_rounds":[],"source_relationships":[],"source_identities":[{"description":null,"service":"angel_list","slug":"derek-jones","url":"https://angel.co/derek-jones"},{"description":null,"service":"avatar","slug":"https://d1qb2nb5cznatu.cloudfront.net/users/165075-medium_jpg?1405505118","url":"https://d1qb2nb5cznatu.cloudfront.net/users/165075-medium_jpg?1405505118"},{"description":null,"service":"linked_in","slug":"pub/derek-jones/15/b2/55b","url":"http://www.linkedin.com/pub/derek-jones/15/b2/55b"},{"description":null,"service":"domain","slug":"dereknakano.com","url":"http://www.dereknakano.com"},{"description":null,"service":"url","slug":"http://www.dereknakano.com","url":"http://www.dereknakano.com"}],"counterparty_relationships":[]}]}'
+    http_version: 
+  recorded_at: Fri, 06 Feb 2015 17:38:54 GMT
+recorded_with: VCR 2.9.3

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: contact-data
 version: !ruby/object:Gem::Version
-  version: 0.2.2
+  version: 0.2.3
 platform: ruby
 authors:
 - Xenapto
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2014-11-11 00:00:00.000000000 Z
+date: 2015-02-06 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: rest-client
@@ -100,20 +100,14 @@ dependencies:
     requirements:
     - - "~>"
       - !ruby/object:Gem::Version
-        version: '0.7'
-    - - ">="
-      - !ruby/object:Gem::Version
-        version: 0.7.1
+        version: '0.9'
   type: :development
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
     - - "~>"
       - !ruby/object:Gem::Version
-        version: '0.7'
-    - - ">="
-      - !ruby/object:Gem::Version
-        version: 0.7.1
+        version: '0.9'
 - !ruby/object:Gem::Dependency
   name: coveralls
   requirement: !ruby/object:Gem::Requirement
@@ -184,7 +178,6 @@ files:
 - ".ruby-gemset"
 - ".ruby-version"
 - Gemfile
-- Gemfile.lock
 - LICENSE
 - README.md
 - Rakefile
@@ -207,6 +200,7 @@ files:
 - spec/support/cassettes/links_info_search.yml
 - spec/support/cassettes/links_latest.yml
 - spec/support/cassettes/name_search.yml
+- spec/support/cassettes/source_slug.yml
 - spec/support/vcr_setup.rb
 homepage: https://github.com/Xenapto/contact-data
 licenses:
@@ -228,7 +222,7 @@ required_rubygems_version: !ruby/object:Gem::Requirement
       version: '0'
 requirements: []
 rubyforge_project: 
-rubygems_version: 2.2.2
+rubygems_version: 2.4.4
 signing_key: 
 specification_version: 4
 summary: 'Example: ContactData.search(''John Smith III'')'
@@ -244,4 +238,5 @@ test_files:
 - spec/support/cassettes/links_info_search.yml
 - spec/support/cassettes/links_latest.yml
 - spec/support/cassettes/name_search.yml
+- spec/support/cassettes/source_slug.yml
 - spec/support/vcr_setup.rb

data/Gemfile.lock

@@ -1,73 +0,0 @@
-PATH
-  remote: .
-  specs:
-    contact-data (0.2.1)
-      addressable (~> 2.3)
-      rest-client (~> 1)
-
-GEM
-  remote: https://rubygems.org/
-  specs:
-    addressable (2.3.6)
-    byebug (3.5.1)
-      columnize (~> 0.8)
-      debugger-linecache (~> 1.2)
-      slop (~> 3.6)
-    columnize (0.8.9)
-    coveralls (0.7.1)
-      multi_json (~> 1.3)
-      rest-client
-      simplecov (>= 0.7)
-      term-ansicolor
-      thor
-    crack (0.4.2)
-      safe_yaml (~> 1.0.0)
-    debugger-linecache (1.2.0)
-    diff-lcs (1.2.5)
-    docile (1.1.5)
-    gem-release (0.7.3)
-    mime-types (2.4.3)
-    multi_json (1.10.1)
-    netrc (0.8.0)
-    rake (10.3.2)
-    rest-client (1.7.2)
-      mime-types (>= 1.16, < 3.0)
-      netrc (~> 0.7)
-    rspec (2.99.0)
-      rspec-core (~> 2.99.0)
-      rspec-expectations (~> 2.99.0)
-      rspec-mocks (~> 2.99.0)
-    rspec-core (2.99.2)
-    rspec-expectations (2.99.2)
-      diff-lcs (>= 1.1.3, < 2.0)
-    rspec-mocks (2.99.2)
-    safe_yaml (1.0.4)
-    simplecov (0.9.1)
-      docile (~> 1.1.0)
-      multi_json (~> 1.0)
-      simplecov-html (~> 0.8.0)
-    simplecov-html (0.8.0)
-    slop (3.6.0)
-    term-ansicolor (1.3.0)
-      tins (~> 1.0)
-    thor (0.19.1)
-    tins (1.3.3)
-    vcr (2.9.3)
-    webmock (1.20.4)
-      addressable (>= 2.3.6)
-      crack (>= 0.3.2)
-
-PLATFORMS
-  ruby
-
-DEPENDENCIES
-  bundler (~> 1)
-  byebug (~> 3)
-  contact-data!
-  coveralls (~> 0)
-  gem-release (~> 0)
-  rake (~> 10)
-  rspec (~> 2)
-  simplecov (~> 0.7, >= 0.7.1)
-  vcr (~> 2)
-  webmock (~> 1)