consyncful-tree 1.0.0 → 1.0.1

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: 8f9dfd640ea20ac184288e3af655a3def80755429ca2d0880d3d05af4848bd3f
-  data.tar.gz: e523aa66dcc6f005f661eb4bba23644f52b83b0a48d6fb0b6774ec631b760fc9
+  metadata.gz: de96606e91d4b2f832cb42429df45f2794cb07526ece0a98e7766384bfabb430
+  data.tar.gz: 32b4749935b9c503e1b6171f09a6b7fe92d1afaec510db1402dc7c377812be8c
 SHA512:
-  metadata.gz: 3f68b3fef751d66d2e3ae02d4a21819fda521a1bbd3ae49bbc5a5c78eb81826ed37d5bc83a11c094ce232995d465443000fdca03585303be7dfcf6a7d40735ce
-  data.tar.gz: 98a49750eb6a42057da56e97e92b36cce1ac9fb9d8618428b62fcc95232b3f4f52150cca265fde4bbf5376f88f8f0bffb4f58ca28ae829b6001faf43c010e3b6
+  metadata.gz: 4a8e3e4db80d8b746872e2809715e549def805ab0737bbb3e6d0989e3ea29f0a32428f11e2ddb984055d14d7a2d787eeef966383d8ecebd3a0a2df706f44aebf
+  data.tar.gz: 270dd99f798052d23b6372dc9602c395fe343ee00e9a2aee904a5ec09b731e86d97556d6ac23e179cb0c1651f57a012b2c143cca4d8fac962c34ff12e1c1420b

data/.rubocop.yml

@@ -15,3 +15,8 @@ Layout/LineLength:
 
 Style/Documentation:
   Enabled: false
+
+Metrics/BlockLength:
+  Exclude:
+    - 'spec/**/*'
+    - 'consyncful-tree.gemspec'

data/CHANGELOG.md

@@ -3,3 +3,7 @@
 ## [1.0.0] - 2022-06-14
 
 - Initial release
+
+## [1.0.1] - 2022-06-20
+
+- Fixed a bug in the break condition which caused infinite loops

data/Gemfile.lock

@@ -1,7 +1,7 @@
 PATH
   remote: .
   specs:
-    consyncful-tree (1.0.0)
+    consyncful-tree (1.0.1)
       consyncful (~> 0.7.0)
 
 GEM

data/lib/consyncful/tree/concerns/parent.rb

@@ -24,19 +24,20 @@ module Consyncful
 
           next if key == "child_models" || child_ids.empty?
 
-          child_ids + lookup_child_objects(child_ids)
+          child_objects = child_ids.map { |id| Consyncful::Base.where(id: id).first }
+
+          child_ids + lookup_child_model_ids_for_list(child_objects)
         end.flatten.compact
       end
 
-      def lookup_child_objects(child_ids)
-        return [] if child_ids.empty?
-
-        child_ids.map do |id|
-          obj = Consyncful::Base.where(id: id).first
+      def lookup_child_model_ids_for_list(child_objects)
+        return [] if child_objects.empty?
 
+        child_objects.map do |obj|
           next if obj.nil?
 
-          lookup_child_model_ids(context: obj) if classes_with_parent_concern.exclude?(obj.class.to_s)
+          obj_is_parent = classes_with_parent_concern.include?(obj.class)
+          lookup_child_model_ids(context: obj) unless obj_is_parent
         end.flatten.compact
       end
 
@@ -52,6 +53,16 @@ module Consyncful
 
       private
 
+      # NOTE: I think this break condition is a bit odd.
+      # It works if we think about a "Parent" being a unit that's fields and dependencies will display on
+      # one page; if it isn't content we are going to display with the parent, then we don't care.
+      # It protects us from some kinds of cyclic depencencies.
+      #
+      # However, if we changed our recursive method to instead pass down the children that had been found so far and
+      # only check its children's children if they aren't in the list yet, then we'd be protected from all
+      # cyclic dependencies.
+      # I ran out of time to make that change.
+
       def classes_with_parent_concern
         # ObjectSpace lets you interact with garbage collection and traverse alive objects.
         # This will iterate through all the classes for objects that are alive.

data/lib/consyncful/tree/version.rb

@@ -2,6 +2,6 @@
 
 module Consyncful
   module Tree
-    VERSION = "1.0.0"
+    VERSION = "1.0.1"
   end
 end

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: consyncful-tree
 version: !ruby/object:Gem::Version
-  version: 1.0.0
+  version: 1.0.1
 platform: ruby
 authors:
 - DigitalNZ
 autorequire:
 bindir: exe
 cert_chain: []
-date: 2022-06-14 00:00:00.000000000 Z
+date: 2022-06-19 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: bundler