constructor-pages 0.3.2 → 0.3.3

data/app/controllers/constructor_pages/pages_controller.rb

@@ -53,8 +53,8 @@ module ConstructorPages
 
       instance_variable_set('@'+@page.template.code_name.to_s, @page)
 
-      @children_of_current_root = Page.children_of(@page.root)
-      @children_of_current_page = Page.children_of(@page)
+      @children_of_current_root = @page.root.children
+      @children_of_current_page = @page.children
 
       respond_to do |format|
         format.html { render :template => "html_templates/#{@page.template.code_name}" }
@@ -107,8 +107,8 @@ module ConstructorPages
 
       instance_variable_set('@'+template.code_name.pluralize, @pages)
 
-      @children_of_current_root = Page.children_of(@page.root)
-      @children_of_current_page = Page.children_of(@page)
+      @children_of_current_root = @page.root.children
+      @children_of_current_page = @page.children
 
       render :template => "templates/#{template.code_name}_search"
     end

data/app/models/constructor_pages/field.rb

@@ -2,29 +2,27 @@
 
 module ConstructorPages
   class Field < ActiveRecord::Base
-    attr_accessible :name, :code_name, :type_value, :template_id
+    attr_accessible :name, :code_name, :type_value, :template_id, :template
     validates_presence_of :name
-
-    validate :method_uniqueness
-
     validates_uniqueness_of :code_name, :scope => :template_id
+    validate :method_uniqueness
 
     after_create :create_page_fields
     after_destroy :destroy_page_fields
 
     belongs_to :template
 
-    has_one :string_type, :class_name => "Types::StringType"
-    has_one :integer_type, :class_name => "Types::IntegerType"
-    has_one :float_type, :class_name => "Types::FloatType"
-    has_one :boolean_type, :class_name => "Types::BooleanType"
-    has_one :text_type, :class_name => "Types::TextType"
-    has_one :date_type, :class_name => "Types::DateType"
-    has_one :html_type, :class_name => "Types::HtmlType"
-    has_one :image_type, :class_name => "Types::ImageType"
+    has_one :string_type,   class_name: 'Types::StringType'
+    has_one :integer_type,  class_name: 'Types::IntegerType'
+    has_one :float_type,    class_name: 'Types::FloatType'
+    has_one :boolean_type,  class_name: 'Types::BooleanType'
+    has_one :text_type,     class_name: 'Types::TextType'
+    has_one :date_type,     class_name: 'Types::DateType'
+    has_one :html_type,     class_name: 'Types::HtmlType'
+    has_one :image_type,    class_name: 'Types::ImageType'
 
-    acts_as_list :scope => :template_id
-    default_scope :order => :position
+    acts_as_list  scope: :template_id
+    default_scope order: :position
 
     private
 
@@ -33,28 +31,22 @@ module ConstructorPages
       or Page.first.respond_to?(code_name.pluralize) \
       or Page.first.respond_to?(code_name.singularize) \
       or template.self_and_ancestors.map{|t| t.code_name unless t.code_name == code_name}.include?(code_name.pluralize) \
-      or template.self_and_ancestors.map{|t| t.code_name t.code_name == code_name}.include?(code_name.singularize) \
-      or template.descendants.map{|t| t.code_name t.code_name == code_name}.include?(code_name.pluralize) \
-      or template.descendants.map{|t| t.code_name t.code_name == code_name}.include?(code_name.singularize)
-        errors.add(:base, "Такой метод уже используется")
+      or template.self_and_ancestors.map{|t| t.code_name unless t.code_name == code_name}.include?(code_name.singularize) \
+      or template.descendants.map{|t| t.code_name unless t.code_name == code_name}.include?(code_name.pluralize) \
+      or template.descendants.map{|t| t.code_name unless t.code_name == code_name}.include?(code_name.singularize)
+        errors.add(:base, 'Такой метод уже используется')
       end
     end
 
     def create_page_fields
       self.template.pages.each do |page|
-        "constructor_pages/types/#{type_value}_type".classify.constantize.create(
-          :page_id => page.id,
-          :field_id => id
-        )
+        "constructor_pages/types/#{type_value}_type".classify.constantize.create page_id: page.id, field_id: id
       end
     end
 
     def destroy_page_fields
       self.template.pages.each do |page|
-        "constructor_pages/types/#{type_value}_type".classify.constantize.destroy_all(
-            :page_id => page.id,
-            :field_id => id
-        )
+        "constructor_pages/types/#{type_value}_type".classify.constantize.destroy_all page_id: page.id, field_id: id
       end
     end
   end

data/app/models/constructor_pages/page.rb

@@ -4,45 +4,59 @@ module ConstructorPages
   class Page < ActiveRecord::Base
     attr_accessible :name, :title, :keywords, :description,
                     :url, :full_url, :active, :auto_url,
-                    :parent_id, :link, :in_menu, :in_map,
-                    :in_nav, :template_id
-
-    has_many :string_types,:dependent => :destroy, :class_name => "Types::StringType"
-    has_many :float_types, :dependent => :destroy, :class_name => "Types::FloatType"
-    has_many :boolean_types, :dependent => :destroy, :class_name => "Types::BooleanType"
-    has_many :integer_types, :dependent => :destroy, :class_name => "Types::IntegerType"
-    has_many :text_types, :dependent => :destroy, :class_name => "Types::TextType"
-    has_many :date_types, :dependent => :destroy, :class_name => "Types::DateType"
-    has_many :html_types, :dependent => :destroy, :class_name => "Types::HtmlType"
-    has_many :image_types, :dependent => :destroy, :class_name => "Types::ImageType"
+                    :parent, :parent_id, :link, :in_menu, :in_map,
+                    :in_nav, :template_id, :template
+
+    has_many :string_types,   dependent: :destroy, class_name: 'Types::StringType'
+    has_many :float_types,    dependent: :destroy, class_name: 'Types::FloatType'
+    has_many :boolean_types,  dependent: :destroy, class_name: 'Types::BooleanType'
+    has_many :integer_types,  dependent: :destroy, class_name: 'Types::IntegerType'
+    has_many :text_types,     dependent: :destroy, class_name: 'Types::TextType'
+    has_many :date_types,     dependent: :destroy, class_name: 'Types::DateType'
+    has_many :html_types,     dependent: :destroy, class_name: 'Types::HtmlType'
+    has_many :image_types,    dependent: :destroy, class_name: 'Types::ImageType'
 
     belongs_to :template
 
-    default_scope order(:lft)
+    default_scope order :lft
 
-    before_save :url_prepare, :content_filter
-    after_update :full_url_descendants_change
-
-    before_update :full_url_change
-    before_create :full_url_create
+    validate :template_check
 
+    before_save :friendly_url, :template_assign, :full_url_update
+    after_update :descendants_update
     after_create :create_fields
-    
+
     acts_as_nested_set
-    
-    def self.children_of(page)
-      Page.where(:parent_id => page)
+
+    # generate full_url from parent page and url
+    def self.full_url_generate(parent_id, url = '')
+      Page.find(parent_id).self_and_ancestors.map {|c| c.url}.append(url).join('/')
     end
 
-    def field(code_name, meth = "value")
-      field = ConstructorPages::Field.where(:code_name => code_name, :template_id => self.template_id).first
+    def field(code_name, meth = 'value')
+      field = Field.where(code_name: code_name, template_id: self.template_id).first
 
       if field
-        f = "constructor_pages/types/#{field.type_value}_type".classify.constantize.where(:field_id => field.id, :page_id => self.id).first
+        f = "constructor_pages/types/#{field.type_value}_type".classify.constantize.where(field_id: field.id, page_id: self.id).first
         f.send(meth) if f
       end
     end
 
+    def as_json(options = {})
+      options =  {
+        :name => self.name,
+        :title => self.title
+      }.merge options
+
+      self.template.fields.each do |field|
+        unless self.send(field.code_name)
+          options = {field.code_name => self.send(field.code_name)}.merge options
+        end
+      end
+
+      options
+    end
+
     def method_missing(name, *args, &block)
       name = name.to_s
 
@@ -61,56 +75,32 @@ module ConstructorPages
       end
     end
 
-    def as_json(options = {})
-      options =  {
-        :name => self.name,
-        :title => self.title
-      }.merge options
-
-      self.template.fields.each do |field|
-        unless self.send(field.code_name)
-          options = {field.code_name => self.send(field.code_name)}.merge options
-        end
-      end
-
-      options
-    end
-
     private
 
-    def full_url_change
-      if parent_id
-        self.full_url = '/' + Page.find(parent_id).self_and_ancestors.map {|c| c.url}.append(self.url).join('/')
-      else
-        self.full_url = '/' + self.url
-      end
+    # if url has been changed by manually or url is empty
+    def friendly_url
+      self.url = ((auto_url || url.empty?) ? name : url).parameterize
     end
 
-    def full_url_create
-      if self.parent.nil?
-        self.full_url = '/' + self.url
-      else
-        self.full_url = self.parent.full_url + '/' + self.url
-      end
+    # page is not valid if there is no template
+    def template_check
+      errors.add_on_empty(:template_id) if Template.count == 0
     end
 
-    def full_url_descendants_change
-      self.descendants.each { |c| c.save }
+    # if template_id is nil then get first template
+    def template_assign
+      self.template_id = Template.first.id unless template_id
     end
 
-    def url_prepare
-      if self.auto_url or self.url.empty?
-        self.url = self.name.parameterize
-      else
-        self.url = self.url.parameterize
-      end
+    def full_url_update
+      self.full_url = '/' + (parent_id ? Page.full_url_generate(parent_id, url) : url)
     end
 
+    def descendants_update; descendants.map(&:save) end
+
     def create_fields
       template.fields.each do |field|
-        "constructor_pages/types/#{field.type_value}_type".classify.constantize.create(
-            :page_id => id,
-            :field_id => field.id)
+        "constructor_pages/types/#{field.type_value}_type".classify.constantize.create page_id: id, field: field
       end
     end
   end

data/app/models/constructor_pages/template.rb

@@ -3,7 +3,8 @@
 module ConstructorPages
   class Template < ActiveRecord::Base
     attr_accessible :name, :code_name, :child_id, :parent_id
-    validates_presence_of :name
+
+    validates_presence_of :name, :code_name
     validates_uniqueness_of :code_name
 
     validate :method_uniqueness

data/app/models/constructor_pages/types/boolean_type.rb

@@ -3,7 +3,7 @@
 module ConstructorPages
   module Types
     class BooleanType < ActiveRecord::Base
-      attr_accessible :value, :field_id, :page_id
+      attr_accessible :value, :field_id, :field, :page_id, :page
 
       belongs_to :field
       belongs_to :page

data/app/models/constructor_pages/types/date_type.rb

@@ -3,7 +3,7 @@
 module ConstructorPages
   module Types
     class DateType < ActiveRecord::Base
-      attr_accessible :value, :field_id, :page_id
+      attr_accessible :value, :field_id, :field, :page_id, :page
 
       belongs_to :field
       belongs_to :page

data/app/models/constructor_pages/types/float_type.rb

@@ -3,7 +3,7 @@
 module ConstructorPages
   module Types
     class FloatType < ActiveRecord::Base
-      attr_accessible :value, :field_id, :page_id
+      attr_accessible :value, :field_id, :field, :page_id, :page
 
       belongs_to :field
       belongs_to :page

data/app/models/constructor_pages/types/html_type.rb

@@ -3,7 +3,7 @@
 module ConstructorPages
   module Types
     class HtmlType < ActiveRecord::Base
-      attr_accessible :value, :field_id, :page_id
+      attr_accessible :value, :field_id, :field, :page_id, :page
 
       belongs_to :field
       belongs_to :page

data/app/models/constructor_pages/types/image_type.rb

@@ -3,7 +3,7 @@
 module ConstructorPages
   module Types
     class ImageType < ActiveRecord::Base
-      attr_accessible :value, :field_id, :page_id
+      attr_accessible :value, :field_id, :field, :page_id, :page
 
       belongs_to :field
       belongs_to :page

data/app/models/constructor_pages/types/integer_type.rb

@@ -3,7 +3,7 @@
 module ConstructorPages
   module Types
     class IntegerType < ActiveRecord::Base
-      attr_accessible :value, :field_id, :page_id
+      attr_accessible :value, :field_id, :field, :page_id, :page
 
       belongs_to :field
       belongs_to :page

data/app/models/constructor_pages/types/string_type.rb

@@ -3,7 +3,7 @@
 module ConstructorPages
   module Types
     class StringType < ActiveRecord::Base
-      attr_accessible :value, :field_id, :page_id
+      attr_accessible :value, :field_id, :field, :page_id, :page
 
       belongs_to :field
       belongs_to :page

data/app/models/constructor_pages/types/text_type.rb

@@ -3,7 +3,7 @@
 module ConstructorPages
   module Types
     class TextType < ActiveRecord::Base
-      attr_accessible :value, :field_id, :page_id
+      attr_accessible :value, :field_id, :field, :page_id, :page
 
       belongs_to :field
       belongs_to :page

data/constructor-pages.gemspec

@@ -1,22 +1,32 @@
 # encoding: utf-8
 
+require File.expand_path('../../core/lib/constructor_core/version', __FILE__)
+
 Gem::Specification.new do |s|
   s.platform          = Gem::Platform::RUBY
   s.name              = %q{constructor-pages}
-  s.version           = '0.3.2'
-  s.summary           = %q{Pages for ConstructorCms}
+  s.version           = ConstructorCore::VERSION
+  s.summary           = %q{Pages for Constructor CMS}
   s.authors           = ['Ivan Zotov']
   s.require_paths     = %w(lib)
+  s.homepage          = 'http://ivanzotov.github.com/constructor'
+  s.description       = 'Pages for Constructor CMS'
+  s.email             = 'ivanzotov@gmail.com'
   
   s.files             = `git ls-files`.split("\n")
   s.test_files        = `git ls-files -- spec/*`.split("\n")
   s.executables       = `git ls-files -- bin/*`.split("\n").map { |f| File.basename(f) }
-    
+
+  s.add_dependency 'constructor-core', ConstructorCore::VERSION
+
   s.add_dependency 'dragonfly'
   s.add_dependency 'rack-cache'
   s.add_dependency 'awesome_nested_set', '~> 2.0'
   s.add_dependency 'haml-rails'
   s.add_dependency 'aws-s3'
   s.add_dependency 'russian', '~> 0.6.0'
-  s.add_dependency 'RedCloth'  
+  s.add_dependency 'RedCloth'
+  s.add_dependency 'acts_as_list'
+
+  s.add_development_dependency 'rspec-rails'
 end

data/spec/models/constructor_pages/field_model_spec.rb

@@ -0,0 +1,6 @@
+# encoding: utf-8
+
+require 'spec_helper'
+
+module ConstructorPages
+end

data/spec/models/constructor_pages/page_model_spec.rb

@@ -0,0 +1,148 @@
+# encoding: utf-8
+
+require 'spec_helper'
+
+module ConstructorPages
+  describe Page do
+    before :all do
+      Template.delete_all
+      Template.create name: 'Page', code_name: 'page'
+
+
+      Field.delete_all
+      Types::TextType.delete_all
+    end
+
+    it 'should be valid' do
+      page = Page.create
+      page.valid?.should be_true
+    end
+
+    describe '.field' do
+      it 'should get value from type_field' do
+        template = Template.create name: 'Page template', code_name: 'page_template'
+        page = Page.create name: 'Home page', template: template
+        field = Field.create name: 'Content', code_name: 'desc', template: template, type_value: 'text'
+        page.field('desc').should == field.text_type.value
+      end
+    end
+
+    describe '.full_url_generate' do
+      it 'should generate full_url from parent_id and url' do
+      end
+    end
+
+    describe '#as_json' do
+      it 'should return page as json format with fields'
+    end
+
+    describe '#auto_url' do
+      it 'should be true by default' do
+        page = Page.create
+        page.auto_url.should be_true
+      end
+    end
+
+    describe '#template' do
+      context 'if there is no template' do
+        it 'should not be valid' do
+          Template.delete_all
+          page = Page.create
+          page.valid?.should_not be_true
+          Template.create name: 'Page', code_name: 'page'
+        end
+      end
+
+      context 'if template_id is nil' do
+        it 'should be first template' do
+          page = Page.create
+          page.template.should == Template.first
+        end
+      end
+    end
+
+    describe '#url' do
+      context 'if url is empty or if auto_url is true' do
+        it 'should be generated from name' do
+          page = Page.create name: 'Hello world'
+          page.url.should == 'hello-world'
+        end
+      end
+
+      context 'else' do
+        it 'should get url field value' do
+          page = Page.create name: 'Hello', auto_url: true
+          page.url.should == 'hello'
+
+          page.auto_url = false
+          page.url = 'world'
+          page.save
+          page.url.should == 'world'
+
+          page.auto_url = true
+          page.name = 'Another world'
+          page.url = 'world-two'
+          page.save
+          page.url.should == 'another-world'
+        end
+      end
+    end
+
+    describe '#full_url' do
+      it 'should be generated from url and ancestors' do
+        page = Page.create name: 'Hello'
+        page.full_url.should == '/hello'
+
+        page_two = Page.create name: 'World', parent: page
+        page_two.full_url.should == '/hello/world'
+      end
+
+      context 'if parent or url has been changed' do
+        it 'should update full_url' do
+          page = Page.create name: 'Change url', url: 'change-url', auto_url: false
+          page.full_url.should == '/change-url'
+
+          page.url = 'another-change-url'
+          page.save
+          page.full_url.should == '/another-change-url'
+        end
+      end
+
+      context 'if parent is root or nil' do
+        it 'should be as /self.url' do
+          page = Page.create name: 'Page', url: 'page', auto_url: false, parent_id: nil
+          page.full_url.should == '/page'
+
+          parent = Page.create name: 'Parent'
+          page.parent = parent
+          page.save
+
+          page.full_url.should == '/parent/page'
+
+          page.parent = nil
+          page.save
+          page.full_url.should == '/page'
+        end
+      end
+    end
+
+    describe 'descendants_update' do
+      it 'should update descendants full_url' do
+        page = Page.create name: 'Update descendants', url: 'update-descendants', auto_url: false
+        page_two = Page.create name: 'Child', url: 'child', parent: page
+        page_two.full_url.should == '/update-descendants/child'
+
+        page = Page.find(page.id)
+        page.url = 'another-update-descendants'
+        page.save
+
+        page_two = Page.find(page_two.id)
+        page_two.full_url.should == '/another-update-descendants/child'
+      end
+    end
+
+    describe 'create_fields' do
+      it 'should create type_fields after update page'
+    end
+  end
+end

data/spec/models/constructor_pages/template_model_spec.rb

@@ -0,0 +1,18 @@
+# encoding: utf-8
+
+require 'spec_helper'
+
+module ConstructorPages
+  describe Template do
+    it 'should be valid' do
+      template = Template.create name: 'Page template', code_name: 'page_template'
+      template.valid?.should be_true
+    end
+
+    describe '#code_name' do
+      context 'validation' do
+        it 'should be uniqueness'
+      end
+    end
+  end
+end

metadata

@@ -1,7 +1,7 @@
 --- !ruby/object:Gem::Specification
 name: constructor-pages
 version: !ruby/object:Gem::Version
-  version: 0.3.2
+  version: 0.3.3
   prerelease: 
 platform: ruby
 authors:
@@ -9,8 +9,24 @@ authors:
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2013-06-06 00:00:00.000000000 Z
+date: 2013-06-11 00:00:00.000000000 Z
 dependencies:
+- !ruby/object:Gem::Dependency
+  name: constructor-core
+  requirement: !ruby/object:Gem::Requirement
+    none: false
+    requirements:
+    - - '='
+      - !ruby/object:Gem::Version
+        version: 0.3.3
+  type: :runtime
+  prerelease: false
+  version_requirements: !ruby/object:Gem::Requirement
+    none: false
+    requirements:
+    - - '='
+      - !ruby/object:Gem::Version
+        version: 0.3.3
 - !ruby/object:Gem::Dependency
   name: dragonfly
   requirement: !ruby/object:Gem::Requirement
@@ -123,8 +139,40 @@ dependencies:
     - - ! '>='
       - !ruby/object:Gem::Version
         version: '0'
-description: 
-email: 
+- !ruby/object:Gem::Dependency
+  name: acts_as_list
+  requirement: !ruby/object:Gem::Requirement
+    none: false
+    requirements:
+    - - ! '>='
+      - !ruby/object:Gem::Version
+        version: '0'
+  type: :runtime
+  prerelease: false
+  version_requirements: !ruby/object:Gem::Requirement
+    none: false
+    requirements:
+    - - ! '>='
+      - !ruby/object:Gem::Version
+        version: '0'
+- !ruby/object:Gem::Dependency
+  name: rspec-rails
+  requirement: !ruby/object:Gem::Requirement
+    none: false
+    requirements:
+    - - ! '>='
+      - !ruby/object:Gem::Version
+        version: '0'
+  type: :development
+  prerelease: false
+  version_requirements: !ruby/object:Gem::Requirement
+    none: false
+    requirements:
+    - - ! '>='
+      - !ruby/object:Gem::Version
+        version: '0'
+description: Pages for Constructor CMS
+email: ivanzotov@gmail.com
 executables: []
 extensions: []
 extra_rdoc_files: []
@@ -196,9 +244,10 @@ files:
 - lib/constructor-pages.rb
 - lib/constructor_pages/engine.rb
 - public/hello.txt
-- spec/factories.rb
-- spec/models/page_model_spec.rb
-homepage: 
+- spec/models/constructor_pages/field_model_spec.rb
+- spec/models/constructor_pages/page_model_spec.rb
+- spec/models/constructor_pages/template_model_spec.rb
+homepage: http://ivanzotov.github.com/constructor
 licenses: []
 post_install_message: 
 rdoc_options: []
@@ -221,7 +270,8 @@ rubyforge_project:
 rubygems_version: 1.8.25
 signing_key: 
 specification_version: 3
-summary: Pages for ConstructorCms
+summary: Pages for Constructor CMS
 test_files:
-- spec/factories.rb
-- spec/models/page_model_spec.rb
+- spec/models/constructor_pages/field_model_spec.rb
+- spec/models/constructor_pages/page_model_spec.rb
+- spec/models/constructor_pages/template_model_spec.rb

data/spec/factories.rb

@@ -1,7 +0,0 @@
-FactoryGirl.define do
-  factory :page do
-    sequence(:title) {|n| "Page title #{n}" }
-    sequence(:url) {|n| "/page-#{n}" }
-    content ""
-  end
-end

data/spec/models/page_model_spec.rb

@@ -1,113 +0,0 @@
-# encoding: utf-8
-
-require './../spec/spec_helper'
-
-describe Page do
-  describe "Title and Url" do
-    before :each do
-      Factory(:page, :title => "Hello", :url => '/hello')
-    end
-
-    it "should be unique" do
-      page = Factory.build(:page, :title => "Hello", :url => '/hello')
-      page.should_not be_valid
-      page.url = '/hello@#$%^&'
-      page.should_not be_valid    
-      page.should have(1).error_on(:base)
-  
-      page.url = "/world"
-      page.should be_valid
-    end
-
-    it "should be unique even before save" do
-      page = Factory.build(:page, :title => "Hello", :url => "")
-  
-      page.should_not be_valid
-      page.should have(1).error_on(:base)
-    end
-  end
-  
-  describe "Title" do
-    it "should not be empty" do
-      page = Factory.build(:page, :title => '  ')
-      page.should_not be_valid
-      page.should have(1).error_on(:title)
-      page.errors[:title].should == ['не может быть пустым']
-    
-      page.title = "Title"
-      page.should be_valid  
-    end
-  end
-
-  describe "In nav, in menu, in map" do
-    it "should be true by default" do
-      page = Page.new
-      page.in_nav.should be_true
-      page.in_menu.should be_true
-      page.in_map.should be_true
-    end
-  
-    it "should change when given in new method" do
-      page = Page.new(:in_nav => false, :in_menu => false, :in_map => false)
-      page.in_nav.should be_false
-      page.in_menu.should be_false
-      page.in_map.should be_false
-    end
-  end
-
-  describe "Parent" do
-    it "should not be same as self" do
-      page = Factory(:page)
-      page.parent_id = page.id
-    
-      page.save
-      page.should have(1).errors
-    end
-  end
-
-  describe "Url" do
-    context "Fix mistakes if remote" do
-      it "should fix http// and http:/" do
-        page = Factory(:page, :url => 'http:/myurl.com/')
-        page.url.should == 'http://myurl.com/'
-      
-        page = Factory(:page, :url => 'http//myurl.com/')
-        page.url.should == 'http://myurl.com/'
-      end
-    end
-  
-    context "If empty or nil" do
-      it "should be generated from title" do
-        page = Factory(:page, :title => "  //Hello!@#$\%^&*() my     WORLD /// привет//    ", :url => '  ')
-        page.url.should == "\/hello-my-world\/privet"
-      end
-    
-      it "should add parent url before if parent selected" do
-        page_parent = Factory(:page, :id => 1, :url => '/hello')
-        page = Factory(:page, :parent_id => page_parent, :title => 'World', :url => ' ')
-        page.url.should == '/hello/world'
-      
-        # if parent not selected
-        page.parent_id = nil
-        page.url = ' '
-        page.save
-        page.url.should == '/world'
-      end
-    
-      it "should be empty when page not valid" do
-        Factory(:page, :title => "Hello", :url => "/hello")
-        page = Factory.build(:page, :title => "Hello", :url => "")
-      
-        page.should_not be_valid
-        page.url.should == ""
-      end
-    end
-  
-    context "Finish cleanup" do
-      it "should cleanup url: remove spaces, fix backslashes, unknown chars etc." do
-        page = Factory(:page, :url => "  //Hello!@#$\%^&*() my     WORLD /// привет//    ")
-        page.url.should == "\/hello-my-world\/privet"
-      end
-    end
-  end
-end