constructable 0.2.1 → 0.2.2

data/VERSION

@@ -1 +1 @@
-0.2.1
+0.2.2

data/constructable.gemspec

@@ -5,7 +5,7 @@
 
 Gem::Specification.new do |s|
   s.name = %q{constructable}
-  s.version = "0.2.1"
+  s.version = "0.2.2"
 
   s.required_rubygems_version = Gem::Requirement.new(">= 0") if s.respond_to? :required_rubygems_version=
   s.authors = ["Manuel Korfmann"]

data/lib/constructable/attribute.rb

@@ -7,7 +7,7 @@ module Constructable
     REQUIRED_REQUIREMENT = {
       name: :required,
       message: proc {":#{self.name} is a required attribute"},
-      check: ->(hash) { hash.has_key?(self.name) }
+      check: ->(hash) { hash[self.name] }
     }
 
     REQUIREMENTS = [
@@ -30,10 +30,6 @@ module Constructable
       end
     end
 
-    def defined?
-      @defined
-    end
-
     def accessible=(boolean)
       if boolean
         self.readable = true
@@ -55,16 +51,14 @@ module Constructable
     private :check_for_requirement
 
     def process(constructor_hash)
-      if constructor_hash.has_key?(self.name)
+      if constructor_hash[self.name]
         REQUIREMENTS.each do |requirement|
           check_for_requirement(requirement, constructor_hash)
         end
         value = constructor_hash[self.name]
-        @defined = true
         self.converter ? converter.(value) : value
       else
         check_for_requirement(REQUIRED_REQUIREMENT, constructor_hash)
-        @defined = false
         self.default
       end.tap { |value| @value = value }
     end

data/lib/constructable/constructor.rb

@@ -21,19 +21,11 @@ module Constructable
       attributes = @attributes
       attributes.each do |attribute|
         @klass.class_eval do
-
           attr_reader attribute.name if attribute.readable
 
           define_method(:"#{attribute.name}=") do |value|
             instance_variable_set attribute.ivar_symbol, attribute.process({ attribute.name => value})
           end if attribute.writable
-
-          define_method(attribute.group) do
-            attributes.group_by(&:group)[attribute.group].inject({}) do |hash, attribute|
-              hash[attribute.name] = attribute.value if attribute.defined?
-              hash
-            end
-          end if attribute.group && !method_defined?(attribute.group)
         end
       end
     end
@@ -46,17 +38,9 @@ module Constructable
     end
 
     def generate_attributes(attributes)
-      attributes.map do |dynamic_args|
-        if Hash === dynamic_args
-          dynamic_args.map do |name, attributes|
-            attributes.map do |attribute|
-              Attribute.new(*attribute).tap { |a| a.group = dynamic_args.keys.first }
-            end
-          end
-        else
-          Attribute.new(*dynamic_args)
-        end
-      end.flatten
+      attributes.map do |attribute|
+        Attribute.new(*attribute)
+      end
     end
   end
 end

data/test/constructable/test_constructor.rb

@@ -14,32 +14,6 @@ describe 'Constructor' do
     end
   end
 
-  describe 'Attribute#group' do
-    it 'returns attributes included in the group along with their values' do
-      @klass.constructable [:foo, group: :foobar], [:bar, group: :foobar]
-      instance = @klass.new(foo: 1, bar: 2)
-      assert_equal({foo: 1, bar: 2}, instance.foobar)
-    end
-
-    it 'ONLY returns attributes included in that group' do
-      @klass.constructable [:foo, group: :foobar], [:bar]
-      instance = @klass.new(foo: 1, bar: 2)
-      assert_equal({foo: 1}, instance.foobar)
-    end
-
-    it 'has a nice syntax' do
-      @klass.constructable foobar: [:foo, :bar]
-      instance = @klass.new(foo: 1, bar: 2)
-      assert_equal({foo: 1, bar: 2}, instance.foobar)
-    end
-
-    it 'ONLY returns attributes acutally provided' do
-      @klass.constructable foobar: [:foo, :bar]
-      instance = @klass.new(foo: 1)
-      assert_equal false, instance.foobar.has_key?(:bar)
-    end
-  end
-
   describe 'permission' do
     it 'should allow writable attributes' do
       @klass.constructable [:writable_attribute, writable: true]

metadata

@@ -2,7 +2,7 @@
 name: constructable
 version: !ruby/object:Gem::Version 
   prerelease: 
-  version: 0.2.1
+  version: 0.2.2
 platform: ruby
 authors: 
 - Manuel Korfmann
@@ -104,7 +104,7 @@ required_ruby_version: !ruby/object:Gem::Requirement
   requirements: 
   - - ">="
     - !ruby/object:Gem::Version 
-      hash: -1729575163689007260
+      hash: 1216029924814922555
       segments: 
       - 0
       version: "0"