constant_table_saver 4.1.1 → 4.2.0

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA1:
-  metadata.gz: e456bebaba7c8e29e66feb2b63b5626c2bcdaa5f
-  data.tar.gz: 28bd116590a6d334b5d337e94623b23583d48b34
+  metadata.gz: e2578ce8faa60c69b0c71cac907a097168fefcda
+  data.tar.gz: 8b53a074ed7d5f9d919de2b0de4e8d1a8cbb8140
 SHA512:
-  metadata.gz: a73041f3bf0d46a7dae0ec0f091045ea6abfb84f9c7650dd6ebde9449a8783823e0af1b6b576cbd06e356f07dc26f4abdbab743d62d728bde95ecbc08604930c
-  data.tar.gz: c863ae2ff77fa78c8e9f68259d54d5b30798e7e12d6385187be42ebd459fcb0b1afde9bcda4badddc7fab303930b513bb15587d3d4e328216da6427c587d8a14
+  metadata.gz: ce00c64f33fe8a7aee4291579ecddd24d5d18f0aadaeafbaf4d7cd3b7074f11c8a32e97c154d9e6a769fb7b664e18bb08343bfe72c0dd642b5c1419dfea247ec
+  data.tar.gz: bd8e42cdf8dc69619c13b195799fe886c0d41873ed061229c95b37c3ec30fda113ed9964871d5781bf829e0ff3504158a481525253673332bf649774406f7d39

data/README

@@ -11,8 +11,10 @@ named after the name field you specify.
 Compatibility
 =============
 
-Currently tested against Rails 3.2.13, on Ruby 1.8.7 and 2.0.0p0.
-Was also tested compatible with 2.3.14, 3.0.17, and 3.1.8.
+Currently tested against Rails 4.2 (up to 4.2.3), 4.1 (up to 4.1.12), 4.0 (up to 4.0.13), and 3.2 (3.2.18), on Ruby 2.1.5.
+
+Was also previously tested compatible with 2.3.14, 3.0.17, and 3.1.8 on Ruby 2.0.0
+or 1.8.7 as appropriate, and may still work for them.
 
 
 Example

data/constant_table_saver.gemspec

@@ -16,19 +16,22 @@ named after the name field you specify.
 Compatibility
 =============
 
-Currently tested against Rails 3.2.19, 4.0.8, and 4.1.1, on Ruby 2.0.0.
-Previous versions were also tested compatible with 3.0.17 and 3.1.8 and it may still be but they're not supported.
+Currently tested against Rails 4.2 (up to 4.2.3), 4.1 (up to 4.1.12), 4.0 (up to 4.0.13), and 3.2 (3.2.18), on Ruby 2.1.5.
+
+Was also previously tested compatible with 2.3.14, 3.0.17, and 3.1.8 on Ruby 2.0.0
+or 1.8.7 as appropriate, and may still work for them.
 EOF
   gem.has_rdoc     = false
   gem.author       = "Will Bryant"
   gem.email        = "will.bryant@gmail.com"
   gem.homepage     = "http://github.com/willbryant/constant_table_saver"
-  
+  gem.license      = "MIT"
+
   gem.executables  = `git ls-files -- bin/*`.split("\n").map{ |f| File.basename(f) }
   gem.files        = `git ls-files`.split("\n")
   gem.test_files   = `git ls-files -- {test,spec,features}/*`.split("\n")
   gem.require_path = "lib"
-  
+
   gem.add_dependency "activerecord"
   gem.add_development_dependency "rake"
   gem.add_development_dependency "sqlite3"

data/lib/constant_table_saver/version.rb

@@ -1,3 +1,3 @@
 module ConstantTableSaver
-  VERSION = '4.1.1'
+  VERSION = '4.2.0'
 end

data/lib/constant_table_saver.rb

@@ -53,7 +53,9 @@ module ConstantTableSaver
     def find_by_sql(sql, binds = [])
       @find_by_sql ||= {
         :all   => all.to_sql,
-        :id    => relation.where(relation.table[primary_key].eq(connection.substitute_at(columns_hash[primary_key], 1))).limit(1),
+        :id    => relation.where(relation.table[primary_key].eq(connection.substitute_at(columns_hash[primary_key], 0))).limit(1).
+                    tap {|r| r.bind_values += [[columns_hash[primary_key], :undefined]]}. # work around AR 4.1.9-4.1.x (but not 4.2.x) calling nil.first if there's no bind_values
+                    arel,
         :first => relation.order(relation.table[primary_key].asc).limit(1).to_sql,
         :last  => relation.order(relation.table[primary_key].desc).limit(1).to_sql,
       }

data/test/constant_table_saver_test.rb

@@ -45,9 +45,9 @@ class ConstantTableSaverTest < ActiveSupport::TestCase
 
   def assert_queries(num = 1)
     ::SQLCounter.clear_log
-    yield
-  ensure
+    result = yield
     assert_equal num, ::SQLCounter.log.size, "#{::SQLCounter.log.size} instead of #{num} queries were executed.#{::SQLCounter.log.size == 0 ? '' : "\nQueries:\n#{::SQLCounter.log.join("\n")}"}"
+    result
   end
 
   def assert_no_queries(&block)
@@ -78,11 +78,14 @@ class ConstantTableSaverTest < ActiveSupport::TestCase
 
   test "it caches find(id) results" do
     @pie = StandardPie.find(1)
+    @other_pie = StandardPie.find(2)
     assert_queries(1) do
       assert_equal @pie.attributes, ConstantPie.find(1).attributes
+      assert_equal @other_pie.attributes, ConstantPie.find(2).attributes
     end
     assert_no_queries do
       assert_equal @pie.attributes, ConstantPie.find(1).attributes
+      assert_equal @other_pie.attributes, ConstantPie.find(2).attributes
     end
   end
 

data/test/test_helper.rb

@@ -1,5 +1,7 @@
 require 'rubygems'
 
+puts "Rails: #{ENV['RAILS_VERSION'] || 'default'}"
+puts "Env: #{ENV['RAILS_ENV'] || 'not set'}"
 gem 'minitest', (ENV['RAILS_VERSION'] =~ /^(3\.|4\.0)/ ? '~> 4.0' : nil)
 gem 'activesupport', ENV['RAILS_VERSION']
 gem 'activerecord',  ENV['RAILS_VERSION']

data/test_all.rb

@@ -0,0 +1,13 @@
+#!/usr/bin/env ruby
+
+require 'yaml'
+
+rails_versions = ["4.2.0".."4.2.3", "4.1.07".."4.1.12", "4.0.13", "3.2.18"].flat_map {|spec| Array(spec).collect {|v| v.gsub /.0(\d)/, '.\\1'}}
+rails_envs = YAML.load(File.read("test/database.yml")).keys
+
+rails_envs.each do |env|
+  rails_versions.each do |version|
+    puts "*"*40
+    system "RAILS_ENV=#{env} RAILS_VERSION=#{version} rake" or exit(1)
+  end
+end

metadata

@@ -1,55 +1,55 @@
 --- !ruby/object:Gem::Specification
 name: constant_table_saver
 version: !ruby/object:Gem::Version
-  version: 4.1.1
+  version: 4.2.0
 platform: ruby
 authors:
 - Will Bryant
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2014-08-18 00:00:00.000000000 Z
+date: 2015-07-06 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: activerecord
   requirement: !ruby/object:Gem::Requirement
     requirements:
-    - - '>='
+    - - ">="
       - !ruby/object:Gem::Version
         version: '0'
   type: :runtime
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
-    - - '>='
+    - - ">="
       - !ruby/object:Gem::Version
         version: '0'
 - !ruby/object:Gem::Dependency
   name: rake
   requirement: !ruby/object:Gem::Requirement
     requirements:
-    - - '>='
+    - - ">="
       - !ruby/object:Gem::Version
         version: '0'
   type: :development
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
-    - - '>='
+    - - ">="
       - !ruby/object:Gem::Version
         version: '0'
 - !ruby/object:Gem::Dependency
   name: sqlite3
   requirement: !ruby/object:Gem::Requirement
     requirements:
-    - - '>='
+    - - ">="
       - !ruby/object:Gem::Version
         version: '0'
   type: :development
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
-    - - '>='
+    - - ">="
       - !ruby/object:Gem::Version
         version: '0'
 description: |
@@ -63,14 +63,16 @@ description: |
   Compatibility
   =============
 
-  Currently tested against Rails 3.2.19, 4.0.8, and 4.1.1, on Ruby 2.0.0.
-  Previous versions were also tested compatible with 3.0.17 and 3.1.8 and it may still be but they're not supported.
+  Currently tested against Rails 4.2 (up to 4.2.3), 4.1 (up to 4.1.12), 4.0 (up to 4.0.13), and 3.2 (3.2.18), on Ruby 2.1.5.
+
+  Was also previously tested compatible with 2.3.14, 3.0.17, and 3.1.8 on Ruby 2.0.0
+  or 1.8.7 as appropriate, and may still work for them.
 email: will.bryant@gmail.com
 executables: []
 extensions: []
 extra_rdoc_files: []
 files:
-- .gitignore
+- ".gitignore"
 - Gemfile
 - MIT-LICENSE
 - README
@@ -86,8 +88,10 @@ files:
 - test/fixtures/pies.yml
 - test/schema.rb
 - test/test_helper.rb
+- test_all.rb
 homepage: http://github.com/willbryant/constant_table_saver
-licenses: []
+licenses:
+- MIT
 metadata: {}
 post_install_message: 
 rdoc_options: []
@@ -95,12 +99,12 @@ require_paths:
 - lib
 required_ruby_version: !ruby/object:Gem::Requirement
   requirements:
-  - - '>='
+  - - ">="
     - !ruby/object:Gem::Version
       version: '0'
 required_rubygems_version: !ruby/object:Gem::Requirement
   requirements:
-  - - '>='
+  - - ">="
     - !ruby/object:Gem::Version
       version: '0'
 requirements: []