console1984 0.2.3 → 0.2.4

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: 3bcb1c5436456f551d695a6b3ffdf284959846303adf6afaaee8fe0ff66ecb6e
-  data.tar.gz: 317f00e5e0c25b8f2e18876782872cc7288df2038c25139538c98c1e77dbeb85
+  metadata.gz: 62a1a63354e44bfc19ab3ca033e14a44505c55832aa150ae1fc11b77b8d01919
+  data.tar.gz: beef047a7ec407f4fac7d08601a7522689d2cb0365d186447a4f4bbf0f06ebfe
 SHA512:
-  metadata.gz: 0a9fc5c6bb7c6c36580dfae29f4cfaadbc18930d11061a77609bbec85c9a3b44131e873bc347e04f7db2b8ce7dc2d239c9d18a74cedcde14dcb28858697e7c86
-  data.tar.gz: fb53e1d21f930e80b4d05a77a2e3b2eeed5eb7af22fd242874452cce10b141e65e4f4b7eda3a22a2d52335d7aeed923d22c6732905587f0890d1cfcb630cd78d
+  metadata.gz: 925ef9d2ec34d823fe1ed7714164ca6ef7842e91f952c8746fdc60d53d8e5e7a9870a0b0883c702f5d5f7f26f653251f09325814bac8b504a8d40de2eab2b67a
+  data.tar.gz: a362cb02f0499406b7aea4e9e415265ceabefe9aaeb4661fe6097789252c746a4fd52d8faad4aaed56b7c5b48abefc1045cc539cf605077327300ec9d1b94483

data/lib/console1984/command_validator/.command_parser.rb

@@ -56,7 +56,7 @@ class Console1984::CommandValidator::CommandParser < ::Parser::AST::Processor
 
   def on_casgn(node)
     super
-    scope_node, name, value_node = *node
+    _, _, value_node = *node
     @constant_assignments.push(*extract_constants(value_node))
   end
 

data/lib/console1984/engine.rb

@@ -24,5 +24,9 @@ module Console1984
         Console1984.supervisor.start
       end
     end
+
+    initializer "console1984.query_auditor" do
+      Console1984::QueryAuditor.install
+    end
   end
 end

data/lib/console1984/ext/active_record/protected_auditable_tables.rb

@@ -5,7 +5,7 @@ module Console1984::Ext::ActiveRecord::ProtectedAuditableTables
   %i[ execute exec_query exec_insert exec_delete exec_update exec_insert_all ].each do |method|
     define_method method do |*args, **kwargs|
       sql = args.first
-      if Console1984.command_executor.executing_user_command? && sql.b =~ auditable_tables_regexp
+      if Console1984.command_executor.executing_user_command? && auditable_sql(sql) =~ auditable_tables_regexp
         raise Console1984::Errors::ForbiddenCommandAttempted, "#{sql}"
       else
         super(*args, **kwargs)
@@ -14,6 +14,14 @@ module Console1984::Ext::ActiveRecord::ProtectedAuditableTables
   end
 
   private
+    # exec_insert_all receives an ActiveRecord::InsertAll, not a SQL string, so
+    # #b is undefined on it. Check its target table name instead, so insert_all
+    # and upsert_all don't blow up when run from the console.
+    def auditable_sql(sql)
+      string = sql.is_a?(String) ? sql : (sql.try(:model)&.table_name || sql.to_s)
+      string.b
+    end
+
     def auditable_tables_regexp
       @auditable_tables_regexp ||= Regexp.new("#{auditable_tables.join("|")}")
     end

data/lib/console1984/query_auditor.rb

@@ -0,0 +1,40 @@
+class Console1984::QueryAuditor
+  mattr_accessor :known_agents, default: {
+    "CLAUDECODE"      => "Claude Code",
+    "CODEX_THREAD_ID" => "Codex"
+  }
+
+  def self.install
+    ActiveSupport::Notifications.subscribe("query.rails", new)
+  end
+
+  def start(name, id, payload)
+    return unless Console1984.running_protected_environment?
+
+    Console1984.session_logger.start_session(resolved_username, session_reason)
+    Console1984.session_logger.before_executing([ payload[:expression].to_s ])
+  end
+
+  def finish(name, id, payload)
+    return unless Console1984.running_protected_environment?
+
+    Console1984.session_logger.finish_session
+  end
+
+  private
+    def resolved_username
+      Console1984.username_resolver.current.presence || "unknown"
+    end
+
+    def session_reason
+      if agent = detected_agent
+        "rails query (via #{agent})"
+      else
+        "rails query"
+      end
+    end
+
+    def detected_agent
+      known_agents.find { |var, _| ENV[var].present? }&.last
+    end
+end

data/lib/console1984/version.rb

@@ -1,3 +1,3 @@
 module Console1984
-  VERSION = "0.2.3"
+  VERSION = "0.2.4"
 end

metadata

@@ -1,7 +1,7 @@
 --- !ruby/object:Gem::Specification
 name: console1984
 version: !ruby/object:Gem::Version
-  version: 0.2.3
+  version: 0.2.4
 platform: ruby
 authors:
 - Jorge Manrubia
@@ -275,6 +275,7 @@ files:
 - lib/console1984/input_output.rb
 - lib/console1984/messages.rb
 - lib/console1984/protections_config.rb
+- lib/console1984/query_auditor.rb
 - lib/console1984/refrigerator.rb
 - lib/console1984/sessions_logger/database.rb
 - lib/console1984/shield.rb
@@ -309,7 +310,7 @@ required_rubygems_version: !ruby/object:Gem::Requirement
     - !ruby/object:Gem::Version
       version: '0'
 requirements: []
-rubygems_version: 3.6.9
+rubygems_version: 4.0.3
 specification_version: 4
 summary: Your Rails console, 1984 style
 test_files: []