console1984 0.2.2 → 0.2.4

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: 2780f949e661adfabca876c59cbe208b724728ba49d48e06caa3301c58419eb5
-  data.tar.gz: c6e5dd28ac9aab44c1eb8be6a76a34606cadac94a3d3545a1c6991fde636173c
+  metadata.gz: 62a1a63354e44bfc19ab3ca033e14a44505c55832aa150ae1fc11b77b8d01919
+  data.tar.gz: beef047a7ec407f4fac7d08601a7522689d2cb0365d186447a4f4bbf0f06ebfe
 SHA512:
-  metadata.gz: 94f9f5032b7211bf3bec1b798417aa02ce33ac383b166808e92f7fff654fe150fb48a2d846adc2cfc14465abed6cc017061c0ebf7694192932744b64962f685d
-  data.tar.gz: 0f8e68ebd3aadbcee4904605b74ba47ef88e1ee3b99e3693ad97c39ca223f696f5484794457631348205ecc75283ae19477b926599aaa53ccb010aea6710cf7a
+  metadata.gz: 925ef9d2ec34d823fe1ed7714164ca6ef7842e91f952c8746fdc60d53d8e5e7a9870a0b0883c702f5d5f7f26f653251f09325814bac8b504a8d40de2eab2b67a
+  data.tar.gz: a362cb02f0499406b7aea4e9e415265ceabefe9aaeb4661fe6097789252c746a4fd52d8faad4aaed56b7c5b48abefc1045cc539cf605077327300ec9d1b94483

data/README.md

@@ -192,8 +192,31 @@ The test suite runs against SQLite by default, but can be run against Postgres a
 To run the suite in your computer, first, run `bin/setup` to create the docker containers for MySQL/PostgreSQL and create the databases. Then run:
 
 ```bash
-bin/rails test # against SQLite (default) 
-bin/rails test TARGET_DB=mysql 
-bin/rails test TARGET_DB=postgres 
-bin/rails test TARGET_DB=sqlite  
+bin/rails test # against SQLite (default)
+bin/rails test TARGET_DB=mysql
+bin/rails test TARGET_DB=postgres
+bin/rails test TARGET_DB=sqlite
+```
+
+### Testing against different Rails versions
+
+This project uses [Appraisal](https://github.com/thoughtbot/appraisal) to test against multiple Rails versions. The `Appraisals` file defines the matrix and the generated gemfiles live in `gemfiles/`.
+
+To run tests against a specific Rails version:
+
+```bash
+bundle exec appraisal rails-8-0 bin/rails test
+bundle exec appraisal rails-8-1 bin/rails test
+```
+
+To run tests against all Rails versions:
+
+```bash
+bundle exec appraisal bin/rails test
+```
+
+To regenerate the appraisal gemfiles after changing the `Appraisals` file:
+
+```bash
+bundle exec appraisal install
 ```

data/Rakefile

@@ -17,8 +17,6 @@ end
 APP_RAKEFILE = File.expand_path('test/dummy/Rakefile', __dir__)
 load 'rails/tasks/engine.rake'
 
-load 'rails/tasks/statistics.rake'
-
 require 'bundler/gem_tasks'
 
 require 'rake/testtask'

data/app/jobs/console1984/incineration_job.rb

@@ -10,6 +10,8 @@ module Console1984
 
     def perform(session)
       session.incinerate
+    rescue Console1984::Errors::ForbiddenIncineration
+      self.class.set(wait_until: session.created_at + Console1984.incinerate_after).perform_later(session)
     end
   end
 end

data/lib/console1984/command_validator/.command_parser.rb

@@ -40,7 +40,7 @@ class Console1984::CommandValidator::CommandParser < ::Parser::AST::Processor
   def on_const(node)
     super
     name, const_name = *node
-    const_name = const_name.to_s
+    const_name = const_name.to_s.dup
     last_constant = @constants.last
 
     if name.nil? || (name && name.type == :cbase) # cbase = leading ::
@@ -56,7 +56,7 @@ class Console1984::CommandValidator::CommandParser < ::Parser::AST::Processor
 
   def on_casgn(node)
     super
-    scope_node, name, value_node = *node
+    _, _, value_node = *node
     @constant_assignments.push(*extract_constants(value_node))
   end
 

data/lib/console1984/engine.rb

@@ -24,5 +24,9 @@ module Console1984
         Console1984.supervisor.start
       end
     end
+
+    initializer "console1984.query_auditor" do
+      Console1984::QueryAuditor.install
+    end
   end
 end

data/lib/console1984/ext/active_record/protected_auditable_tables.rb

@@ -5,7 +5,7 @@ module Console1984::Ext::ActiveRecord::ProtectedAuditableTables
   %i[ execute exec_query exec_insert exec_delete exec_update exec_insert_all ].each do |method|
     define_method method do |*args, **kwargs|
       sql = args.first
-      if Console1984.command_executor.executing_user_command? && sql.b =~ auditable_tables_regexp
+      if Console1984.command_executor.executing_user_command? && auditable_sql(sql) =~ auditable_tables_regexp
         raise Console1984::Errors::ForbiddenCommandAttempted, "#{sql}"
       else
         super(*args, **kwargs)
@@ -14,6 +14,14 @@ module Console1984::Ext::ActiveRecord::ProtectedAuditableTables
   end
 
   private
+    # exec_insert_all receives an ActiveRecord::InsertAll, not a SQL string, so
+    # #b is undefined on it. Check its target table name instead, so insert_all
+    # and upsert_all don't blow up when run from the console.
+    def auditable_sql(sql)
+      string = sql.is_a?(String) ? sql : (sql.try(:model)&.table_name || sql.to_s)
+      string.b
+    end
+
     def auditable_tables_regexp
       @auditable_tables_regexp ||= Regexp.new("#{auditable_tables.join("|")}")
     end

data/lib/console1984/input_output.rb

@@ -31,7 +31,13 @@ module Console1984::InputOutput
 
     def ask_for_value(message)
       puts Rainbow("#{message}").green
-      reason = $stdin.gets.strip until reason.present?
-      reason
+      original_output_modifier_proc = Reline.output_modifier_proc
+      begin
+        Reline.output_modifier_proc = nil
+        reason = Reline.readline.strip until reason.present?
+        reason
+      ensure
+        Reline.output_modifier_proc = original_output_modifier_proc
+      end
     end
 end

data/lib/console1984/query_auditor.rb

@@ -0,0 +1,40 @@
+class Console1984::QueryAuditor
+  mattr_accessor :known_agents, default: {
+    "CLAUDECODE"      => "Claude Code",
+    "CODEX_THREAD_ID" => "Codex"
+  }
+
+  def self.install
+    ActiveSupport::Notifications.subscribe("query.rails", new)
+  end
+
+  def start(name, id, payload)
+    return unless Console1984.running_protected_environment?
+
+    Console1984.session_logger.start_session(resolved_username, session_reason)
+    Console1984.session_logger.before_executing([ payload[:expression].to_s ])
+  end
+
+  def finish(name, id, payload)
+    return unless Console1984.running_protected_environment?
+
+    Console1984.session_logger.finish_session
+  end
+
+  private
+    def resolved_username
+      Console1984.username_resolver.current.presence || "unknown"
+    end
+
+    def session_reason
+      if agent = detected_agent
+        "rails query (via #{agent})"
+      else
+        "rails query"
+      end
+    end
+
+    def detected_agent
+      known_agents.find { |var, _| ENV[var].present? }&.last
+    end
+end

data/lib/console1984/version.rb

@@ -1,3 +1,3 @@
 module Console1984
-  VERSION = "0.2.2"
+  VERSION = "0.2.4"
 end

metadata

@@ -1,14 +1,13 @@
 --- !ruby/object:Gem::Specification
 name: console1984
 version: !ruby/object:Gem::Version
-  version: 0.2.2
+  version: 0.2.4
 platform: ruby
 authors:
 - Jorge Manrubia
-autorequire:
 bindir: bin
 cert_chain: []
-date: 2025-01-30 00:00:00.000000000 Z
+date: 1980-01-02 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: rainbow
@@ -220,7 +219,20 @@ dependencies:
     - - ">="
       - !ruby/object:Gem::Version
         version: '0'
-description:
+- !ruby/object:Gem::Dependency
+  name: ostruct
+  requirement: !ruby/object:Gem::Requirement
+    requirements:
+    - - ">="
+      - !ruby/object:Gem::Version
+        version: '0'
+  type: :development
+  prerelease: false
+  version_requirements: !ruby/object:Gem::Requirement
+    requirements:
+    - - ">="
+      - !ruby/object:Gem::Version
+        version: '0'
 email:
 - jorge@basecamp.com
 executables: []
@@ -263,6 +275,7 @@ files:
 - lib/console1984/input_output.rb
 - lib/console1984/messages.rb
 - lib/console1984/protections_config.rb
+- lib/console1984/query_auditor.rb
 - lib/console1984/refrigerator.rb
 - lib/console1984/sessions_logger/database.rb
 - lib/console1984/shield.rb
@@ -283,7 +296,6 @@ licenses:
 - MIT
 metadata:
   allowed_push_host: https://rubygems.org
-post_install_message:
 rdoc_options: []
 require_paths:
 - lib
@@ -298,8 +310,7 @@ required_rubygems_version: !ruby/object:Gem::Requirement
     - !ruby/object:Gem::Version
       version: '0'
 requirements: []
-rubygems_version: 3.5.3
-signing_key:
+rubygems_version: 4.0.3
 specification_version: 4
 summary: Your Rails console, 1984 style
 test_files: []