consistency_fail 0.3.5 → 0.3.6

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA1:
-  metadata.gz: c507681aa9fdff8f28a5bb8d5c1b5b5e90224865
-  data.tar.gz: c3ca7f71bdb87dccd25411da929196fdb6d4f318
+  metadata.gz: 531019a9820d2e2099018388c98a966b41ecff84
+  data.tar.gz: 58bcc05d1259e0e7f6fcd6e80388003c15d07785
 SHA512:
-  metadata.gz: d06468cad8ded7968fd766fb8acda9fcb8fee9e7c32a98ed54efe7696725fcf53d96a9463b59906f6ac37c0b08d8d76f6258e6940bf3fb236c3cc7622fbacf79
-  data.tar.gz: ef0b8fe78a001d6a82126dbe482e986a2092056be2399b4a3dd37e563438b7a06a3bf0f1353ec71d362c1120643b77b7b490ea33da161096935ff8ea07bf4394
+  metadata.gz: a065a54f5c469dc3741d37d06e5a9de36e49cfc1193020c22ddf672b1dea7cca39b6528dca7b45120cafe36266133579bb7a996c007e5611757e3fb62e09e593
+  data.tar.gz: af440e0d00c9e6dd7785542ede83284c2351a89a7149b7b3d3109216242bf78c5d42b1fcb6cbd52c144c0ec971e11fa3971e58ca27623015ea437a588acbd6f4

data/Gemfile

@@ -2,3 +2,9 @@ source "https://rubygems.org"
 
 # Specify your gem's dependencies in consistency_fail.gemspec
 gemspec
+
+gem 'pry'
+
+group :test do
+  gem 'activesupport', '~> 5.0'
+end

data/README.md

@@ -17,19 +17,35 @@ database-level enforcement is lacking there as well.
 For more detail, see [my blog post on the
 subject](http://blog.8thlight.com/articles/2011/6/11/winning-at-consistency).
 
+
 ## Installation
 
-I'm currently only maintaining consistency\_fail for Rails 3. If you need or
-want Rails 2.3 support, I'd be happy to take patches based off the 0.1.1
-branch.
+You can install the gem directly:
 
     gem install consistency_fail
 
-Or, even better if you're using bundler, add it to your Gemfile, with the
-appropriate version number to match your Rails version.
+Or if you're using Bundler (which you probably are), add it to your Gemfile.
+
+    gem 'consistency_fail'
+
 
 ## Limitations
 
+The master branch should work for the following ActiveRecord versions:
+
+- 5.x
+- 4.x (*has a known issue around views*)
+- 3.x
+- 2.3 (on the `rails-2.3` branch)
+
+The known issue with views in ActiveRecord 4.x is that in this version, the
+connection adapter's `tables` method includes both tables and views. This means
+that without additional monkeypatches to the various connection adapters, we
+cannot reliably detect whether a given model is backed by a table or a view. I
+wouldn't mind monkeypatching a bounded set of adapters, but I don't want to be
+on the hook for arbitrary connection adapters that may require licenses to test
+(e.g. SQL Server, Oracle).
+
 consistency\_fail depends on being able to find all your `ActiveRecord::Base`
 subclasses with some `$LOAD_PATH` trickery. If any models are in a path either
 not on your project's load path or in a path that doesn't include the word

data/consistency_fail.gemspec

@@ -21,7 +21,7 @@ stop ignoring the C in ACID.
 EOF
   s.license = "MIT"
 
-  s.add_development_dependency "activerecord", "~>3.0"
+  s.add_development_dependency "activerecord", "~>5.0"
   s.add_development_dependency "sqlite3", "~>1.3"
   s.add_development_dependency "rspec", "~>3.2"
 

data/lib/consistency_fail/models.rb

@@ -17,8 +17,9 @@ module ConsistencyFail
 
     def preload_all
       self.dirs.each do |d|
-        Dir.glob(File.join(d, "**", "*.rb")).each do |model_filename|
-          Kernel.require_dependency model_filename
+        ruby_files = Dir.glob(File.join(d, "**", "*.rb")).sort
+        ruby_files.each do |model_filename|
+          Kernel.require model_filename
         end
       end
     end

data/lib/consistency_fail/version.rb

@@ -1,3 +1,3 @@
 module ConsistencyFail
-  VERSION = "0.3.5"
+  VERSION = "0.3.6"
 end

data/spec/index_spec.rb

@@ -1,13 +1,16 @@
+require_relative 'support/models/correct_address'
+require_relative 'support/models/wrong_address'
+
 describe ConsistencyFail::Index do
-  
+
   let(:index) do
     ConsistencyFail::Index.new(
-      CorrectAddress, 
-      CorrectAddress.table_name, 
+      CorrectAddress,
+      CorrectAddress.table_name,
       ["city", "state"]
     )
   end
-  
+
   describe "value objectiness" do
     it "holds onto model, table name, and columns" do
       expect(index.model).to eq(CorrectAddress)
@@ -24,12 +27,12 @@ describe ConsistencyFail::Index do
     end
   end
 
-  describe "equality test" do  
+  describe "equality test" do
     it "passes when everything matches" do
       expect(index).to eq(
         ConsistencyFail::Index.new(
-          "CorrectAddress".constantize, 
-          "correct_addresses", 
+          "CorrectAddress".constantize,
+          "correct_addresses",
           ["city", "state"]
         )
       )
@@ -38,8 +41,8 @@ describe ConsistencyFail::Index do
     it "fails when tables are different" do
       expect(index).not_to eq(
         ConsistencyFail::Index.new(
-          CorrectAttachment, 
-          CorrectAttachment.table_name, 
+          CorrectAttachment,
+          CorrectAttachment.table_name,
           ["attachable_id", "attachable_type"]
         )
       )
@@ -48,12 +51,12 @@ describe ConsistencyFail::Index do
     it "fails when columns are different" do
       expect(index).not_to eq(
         ConsistencyFail::Index.new(
-          CorrectAddress, 
-          CorrectAddress.table_name, 
+          CorrectAddress,
+          CorrectAddress.table_name,
           ["correct_user_id"]
         )
       )
     end
   end
-  
+
 end

data/spec/models_spec.rb

@@ -1,5 +1,5 @@
 describe ConsistencyFail::Models do
-  
+
   def models(load_path)
     ConsistencyFail::Models.new(load_path)
   end
@@ -19,7 +19,7 @@ describe ConsistencyFail::Models do
     expect(models.dirs).to eq([Pathname.new("app/models")])
   end
 
-  it "preloads models by calling require_dependency" do
+  it "preloads models" do
     models = models(["foo/bar/baz", "app/models", "some/other/models"])
     allow(Dir).to receive(:glob).
         with(File.join("app/models", "**", "*.rb")).
@@ -28,9 +28,9 @@ describe ConsistencyFail::Models do
         with(File.join("some/other/models", "**", "*.rb")).
         and_return(["some/other/models/foo.rb"])
 
-    expect(Kernel).to receive(:require_dependency).with("app/models/user.rb")
-    expect(Kernel).to receive(:require_dependency).with("app/models/address.rb")
-    expect(Kernel).to receive(:require_dependency).with("some/other/models/foo.rb")
+    expect(Kernel).to receive(:require).with("app/models/user.rb")
+    expect(Kernel).to receive(:require).with("app/models/address.rb")
+    expect(Kernel).to receive(:require).with("some/other/models/foo.rb")
 
     models.preload_all
   end
@@ -44,5 +44,9 @@ describe ConsistencyFail::Models do
 
     expect(models([]).all).to eq([model_a, model_c, model_b])
   end
-  
+
+  it "preloads models successfully" do
+    models = models([File.join(File.dirname(__FILE__), "support/models")])
+    expect {models.preload_all}.not_to raise_error
+  end
 end

data/spec/spec_helper.rb

@@ -2,7 +2,10 @@ require 'bundler/setup'
 
 Bundler.require(:default, :test)
 
-Dir['./spec/support/**/*.rb'].sort.each { |file| require file }
+require_relative 'support/active_record'
+require_relative 'support/schema'
+require 'active_support/dependencies'
+ActiveSupport::Dependencies.autoload_paths << './spec/support/models'
 
 RSpec.configure do |config|
   config.around do |example|

data/spec/support/models/blob.rb

@@ -0,0 +1,4 @@
+class Blob < ActiveRecord::Base
+  require_dependency 'blob/edible'
+  include Edible
+end

data/spec/support/models/blob/edible.rb

@@ -0,0 +1,2 @@
+module Blob::Edible
+end

data/spec/support/schema.rb

@@ -118,4 +118,8 @@ ActiveRecord::Schema.define(version: 0) do
   execute 'CREATE VIEW new_correct_people AS '\
           'SELECT * FROM correct_people '\
           'WHERE created_at = updated_at'
+
+  create_table :blob do |t|
+    t.timestamps
+  end
 end

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: consistency_fail
 version: !ruby/object:Gem::Version
-  version: 0.3.5
+  version: 0.3.6
 platform: ruby
 authors:
 - Colin Jones
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2017-02-01 00:00:00.000000000 Z
+date: 2018-10-09 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: activerecord
@@ -16,14 +16,14 @@ dependencies:
     requirements:
     - - "~>"
       - !ruby/object:Gem::Version
-        version: '3.0'
+        version: '5.0'
   type: :development
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
     - - "~>"
       - !ruby/object:Gem::Version
-        version: '3.0'
+        version: '5.0'
 - !ruby/object:Gem::Dependency
   name: sqlite3
   requirement: !ruby/object:Gem::Requirement
@@ -98,6 +98,8 @@ files:
 - spec/reporter_spec.rb
 - spec/spec_helper.rb
 - spec/support/active_record.rb
+- spec/support/models/blob.rb
+- spec/support/models/blob/edible.rb
 - spec/support/models/correct_account.rb
 - spec/support/models/correct_address.rb
 - spec/support/models/correct_attachment.rb
@@ -150,6 +152,8 @@ test_files:
 - spec/reporter_spec.rb
 - spec/spec_helper.rb
 - spec/support/active_record.rb
+- spec/support/models/blob.rb
+- spec/support/models/blob/edible.rb
 - spec/support/models/correct_account.rb
 - spec/support/models/correct_address.rb
 - spec/support/models/correct_attachment.rb
@@ -168,4 +172,3 @@ test_files:
 - spec/support/models/wrong_post.rb
 - spec/support/models/wrong_user.rb
 - spec/support/schema.rb
-has_rdoc: