connection_pool 2.1.2 → 2.1.3

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA1:
-  metadata.gz: cba01c34d4f2ac4cd9beb4d71ade9808e66095a0
-  data.tar.gz: 541e73dc97f93b16a7a2725be6157395a76b2295
+  metadata.gz: ec91685df50fe18b79ef2cd2ed2fb038e322ff81
+  data.tar.gz: 99b88e1aa01811e18c2737e8e062c4726ce54666
 SHA512:
-  metadata.gz: d2d9e0deee042e07bd04a4715c97d67bc0c6d59fc6670a307a740024d7ff38ad6fe46dbe9edc482bdef7d6ed51abaeb5297df1a3664c6ec26ba0f2d0e51512c7
-  data.tar.gz: 2dbf1090f068f706141e92aae4dfefb1f596e96be621e0ad1d4e4824c9abae734f337d7ea2e4c5d7943f612835f4ca429469347f1270359c4e604033329dabc4
+  metadata.gz: 53d34f8ca6a7d51ce535a83e2821dd33eb15a623df3022b89775c232876c8fec28a2b33adda24248136014d99f0ebe9f09c1f49e1f0ced76435db26538e907a7
+  data.tar.gz: 660f22d0f828c789942da1da3d7c4131e008dd383a83c74e59ea03f306a59b966e879d42f9704ffa3b7de6accb6c114cfff982d3343bbe34c5e60ecc8f705ac5

data/Changes.md

@@ -1,3 +1,9 @@
+2.1.3
+------
+
+- Don't increment created count until connection is successfully
+  created. [mylesmegyesi, #73]
+
 2.1.2
 ------
 

data/lib/connection_pool/timed_stack.rb

@@ -188,8 +188,9 @@ class ConnectionPool::TimedStack
 
   def try_create(options = nil)
     unless @created == @max
+      object = @create_block.call
       @created += 1
-      @create_block.call
+      object
     end
   end
 end

data/lib/connection_pool/version.rb

@@ -1,3 +1,3 @@
 class ConnectionPool
-  VERSION = "2.1.2"
+  VERSION = "2.1.3"
 end

data/test/test_connection_pool_timed_stack.rb

@@ -34,6 +34,25 @@ class TestConnectionPoolTimedStack < Minitest::Test
     assert_equal 1, stack.length
   end
 
+  def test_object_creation_fails
+    stack = ConnectionPool::TimedStack.new(2) { raise 'failure' }
+
+    begin
+      stack.pop
+    rescue => error
+      assert_equal 'failure', error.message
+    end
+
+    begin
+      stack.pop
+    rescue => error
+      assert_equal 'failure', error.message
+    end
+
+    refute_empty stack
+    assert_equal 2, stack.length
+  end
+
   def test_pop
     object = Object.new
     @stack.push object

metadata

@@ -1,7 +1,7 @@
 --- !ruby/object:Gem::Specification
 name: connection_pool
 version: !ruby/object:Gem::Version
-  version: 2.1.2
+  version: 2.1.3
 platform: ruby
 authors:
 - Mike Perham
@@ -9,7 +9,7 @@ authors:
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2015-03-02 00:00:00.000000000 Z
+date: 2015-03-19 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: bundler