configurations 1.3.4 → 1.3.5

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA1:
-  metadata.gz: 877c1c2cfb4af009d16fa6a91452fc214e846b13
-  data.tar.gz: d87d69a891eb5a54160ad0a4424f86ec0b927a0e
+  metadata.gz: 91fb60bb5d9360f44127b6fe04e9ee5a44fc8cc4
+  data.tar.gz: f6954851568a3a8dc02abb41867391ac9e83133d
 SHA512:
-  metadata.gz: 35339199e77ff86125b9624a52033eed03592fe599c48e067cb6215cb2899541c437f1b62768772a8b53cb5367bd7167651bd22139766e7386ea1cd576ae2f90
-  data.tar.gz: 3f6c9f7c82910f9d766345a4e7f2637f6aaa6cb3a6d9d5a235cb11beee5ba0d0bace240765228357589470c2abf77400243f73ac2176ec46e35870d5ef34d562
+  metadata.gz: e5e0337c82a36aecf0716baaad50605372f31048ae57cfcea910a5946e6e7a04b6345ce08b851fe08c9721b80ac958f9b15c94d7573a1f4b027ec3f0be7cafb9
+  data.tar.gz: 513d1a3804e612121dde365f0966edc22120b6d5ce7f17c8d173c14751d9de0967934111a05922afdf86770b16b1853b650b970bac3ce2f299bf83ace3c32ca3

data/README.md

@@ -206,7 +206,7 @@ MyGem.configuration.to_h #=> a Hash
 
 ### Some caveats
 
-The `to_h` from above is along with `method_missing`, `object_id` and `initialize` the only purposely defined method which you can not overwrite with a configuration value.
+The `to_h` from above is along with `method_missing`, `object_id` and `initialize` the only purposely defined API method which you can not overwrite with a configuration value.
 Apart from these methods, you should be able to set pretty much any property name you like. `Configuration` inherits from `BasicObject`, so even `Kernel` and `Object` method names are available.
 
 ## Contributing

data/lib/configurations.rb

@@ -12,5 +12,5 @@ module Configurations
 
   # Version number of Configurations
   #
-  VERSION = '1.3.4'
+  VERSION = '1.3.5'
 end

data/lib/configurations/configuration.rb

@@ -61,11 +61,11 @@ module Configurations
       property = method.to_s[0..-2].to_sym
       value = args.first
 
-      if _is_writer?(method) && @_writeable && _configurable?(property)
+      if _respond_to_writer?(method)
         _assign!(property, value)
-      elsif !_is_writer?(method) && @_writeable || _configured?(method)
+      elsif _respond_to_property?(method)
         @configuration[method]
-      elsif ::Kernel.respond_to?(method, true)
+      elsif _can_delegate_to_kernel?(method)
         ::Kernel.send(method, *args, &block)
       else
         super
@@ -74,10 +74,8 @@ module Configurations
 
     # Respond to missing according to the method_missing implementation
     #
-    def respond_to_missing?(method, include_private = false)
-      (_is_writer?(method) && @_writeable && _configurable?(property)) ||
-      (!_is_writer?(method) && @_writeable || _configured?(method)) ||
-      ::Kernel.respond_to?(method, include_private) || super
+    def respond_to?(method, include_private = false)
+      _respond_to_writer?(method) or _respond_to_property?(method) or _can_delegate_to_kernel?(method) or super
     end
 
     # Set the configuration to writeable or read only. Access to writer methods is only allowed within the
@@ -214,5 +212,33 @@ module Configurations
       method.to_s.end_with?('=')
     end
 
+    # @param [Symbol] method the method to test for
+    # @return [Boolean] whether the configuration responds to the given method writer
+    #
+    def _respond_to_writer?(method)
+      _is_writer?(method) and @_writeable and _configurable?(_property_from_writer(method))
+    end
+
+    # @param [Symbol] method the method to test for
+    # @return [Boolean] whether the configuration responds to the given property as a method
+    #
+    def _respond_to_property?(method)
+      not _is_writer?(method) and (@_writeable or _configured?(method))
+    end
+
+    # @param [Symbol] method the method to test for
+    # @return [Boolean] whether the configuration can delegate the given method to Kernel
+    #
+    def _can_delegate_to_kernel?(method)
+      ::Kernel.respond_to?(method, true)
+    end
+
+    # @param [Symbol] method the writer method to turn into a property
+    # @return [Symbol] the property derived from the writer method
+    #
+    def _property_from_writer(method)
+      method.to_s[0..-2].to_sym
+    end
+
   end
 end

data/test/configurations/test_configuration.rb

@@ -120,7 +120,17 @@ class TestConfiguration < Minitest::Test
     end
   end
 
-  def test_respond_to_missing_on_kernel_method
+  def test_respond_to_on_writer_while_writeable
+    ConfigurationTestModule.configure do |c|
+      assert_equal true, c.respond_to?(:pah=)
+    end
+  end
+
+  def test_respond_to_on_writer_when_not_writeable
+    assert_equal false, @configuration.respond_to?(:pah=)
+  end
+
+  def test_respond_to_on_kernel_method
     assert_equal true, @configuration.respond_to?(:puts)
   end
 

metadata

@@ -1,7 +1,7 @@
 --- !ruby/object:Gem::Specification
 name: configurations
 version: !ruby/object:Gem::Version
-  version: 1.3.4
+  version: 1.3.5
 platform: ruby
 authors:
 - Beat Richartz