configurations 1.0.1 → 1.1.0

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA1:
-  metadata.gz: 0e15768b4735b836614316e5add917727b13f06a
-  data.tar.gz: e211a39356c76a333f2b855bc831341de38c876b
+  metadata.gz: 039597b55adc73ff8cddc05edd7c199f5f2c252f
+  data.tar.gz: 1dec69ab7582283ab60f950dc3caa96e92ff2b95
 SHA512:
-  metadata.gz: 5d0140d31188351ae3af656201eedebe5c1f68e4f98f4ad44c27557c366f761cf9a84079199ea1cc800dddaf753a09ce02645e75c9497a295bb0af17f44ac929
-  data.tar.gz: 6cb2bb2c5e950d40e49bcd1342017eb7723916799883770d7f98d9fb2d2a1a6873c69a8b59a3ac404c372999266a07df98e639c261c7ad1a22715e83d17d90ad
+  metadata.gz: e7a927942a4bce9f187a1f491f9469ac898cc62e2687c3b2111163d6b8b665ebaea70767f52fabcdb2e11c1544bc005168610317632ecabe8211373c993897d3
+  data.tar.gz: 97ae55c4e7c2ccae76aab97aa75c912c4b79bbf4a5fc7ebdb752b7150d9b0be821598fc9f060f484e7b456a1a153072a5a5672260c2ca96548d1c2789c6ca89e

data/README.md

@@ -140,13 +140,13 @@ MyGem.configuration.to_h #=> a Hash
 ### Some caveats
 
 The `to_h` from above is along with `method_missing`, `object_id` and `initialize` the only purposely defined method which you can not overwrite with a configuration value.
-Apart from these methods, you should be able to set pretty much any property name you like. `Configuration` inherits from `BasicObject`, so even standard Ruby method names are available.
+Apart from these methods, you should be able to set pretty much any property name you like. `Configuration` inherits from `BasicObject`, so even `Kernel` and `Object` method names are available.
 
 ## Contributing
 
 YES!
 
-Let's make this awesome. Write tests for your added stuff, bonus points for feature branches. If you don't have to time to write a fix, raise an issue.
+Let's make this awesome. Write tests for your added stuff, bonus points for feature branches. If you don't have the time to write a fix, raise an issue.
 
 ### Copyright
 

data/lib/configurations.rb

@@ -12,5 +12,5 @@ module Configurations
 
   # Version number of Configurations
   #
-  VERSION = '1.0.1'
+  VERSION = '1.1.0'
 end

data/lib/configurations/configurable.rb

@@ -20,8 +20,10 @@ module Configurations
         class << self
           # The central configure method
           # @params [Proc] block the block to configure host module with
+          # @raise [ArgumentError] error when not given a block
           #
           def configure(&block)
+            raise ArgumentError, 'can not configure without a block' unless block_given?
             @configuration = #{self}::Configuration.new(@configuration_defaults, @configurable, &block)
           end
         end
@@ -33,7 +35,9 @@ module Configurations
     module ClassMethods
       # A reader for Configuration
       #
-      attr_reader :configuration
+      def configuration
+        @configuration ||= @configuration_defaults && configure { }
+      end
 
       # Configuration defaults can be used to set the defaults of any Configuration
       # @param [Proc] block setting the default values of the configuration

data/lib/configurations/configuration.rb

@@ -60,7 +60,7 @@ module Configurations
     def method_missing(method, *args, &block)
       property = method.to_s[0..-2].to_sym
 
-      if _is_writer?(method) && _configurable?(property)
+      if _is_writer?(method) && @_writeable && _configurable?(property)
         _assert_type!(property, args.first)
         @configuration[property] = args.first
       elsif !_is_writer?(method) && @_writeable || _configured?(method)

data/test/configurations/test_configuration.rb

@@ -3,6 +3,9 @@ require 'test_helper'
 class TestConfiguration < Minitest::Test
 
   ConfigurationTestModule = testmodule_for(Configurations)
+  ConfigurationDefaultTestModule = testmodule_for(Configurations)
+  ConfigurationNoDefaultTestModule = testmodule_for(Configurations)
+
   ConfigurationTestModule.module_eval do
     configuration_defaults do |c|
       c.uh.this.is.neat = 'NEAT'
@@ -11,6 +14,13 @@ class TestConfiguration < Minitest::Test
       c.overwriteee = 'BLA'
     end
   end
+
+  ConfigurationDefaultTestModule.module_eval do
+    configuration_defaults do |c|
+      c.set = 'SET'
+    end
+  end
+
   def setup
     ConfigurationTestModule.configure do |c|
       c.basic = 'BASIC'
@@ -51,10 +61,24 @@ class TestConfiguration < Minitest::Test
       }, @configuration.to_h)
   end
 
+  def test_not_configurable_unless_block_given
+    assert_raises ArgumentError do
+      ConfigurationTestModule.configure
+    end
+  end
+
   def test_defaults
     assert_equal 'PUH', @configuration.pah
   end
 
+  def test_defaults_without_configure
+    assert_equal 'SET', ConfigurationDefaultTestModule.configuration.set
+  end
+
+  def test_no_defaults_without_configure
+    assert_nil ConfigurationNoDefaultTestModule.configuration
+  end
+
   def test_defaults_overwrite
     assert_equal 'YEAH', @configuration.overwriteee
   end

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: configurations
 version: !ruby/object:Gem::Version
-  version: 1.0.1
+  version: 1.1.0
 platform: ruby
 authors:
 - Beat Richartz
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2014-08-16 00:00:00.000000000 Z
+date: 2014-08-17 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: minitest