configuration_service 1.1.4 → 2.0.0

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA1:
-  metadata.gz: 6cd9fc6de7766ed90bd9dd238497c725b395fe4b
-  data.tar.gz: 8e3153bef43bac67e3f8b7a1e43978a42536616d
+  metadata.gz: ddbe076b82f49004024915c4940b8c4b659f987c
+  data.tar.gz: f6ef3e349a750383dc5c13239b0e1cbb3e9a7b2d
 SHA512:
-  metadata.gz: f3e144c0799f65f1f979d66cbd80d58605a0a0a744650c3a32542e7a7273abeb44a728ea0552868fb3480c9babff8fd0a862fae6d1957d1566da9db00d52adfe
-  data.tar.gz: 0a995102ba7f9bd104450093b4dd9f828740ff63503464d5bc74abb1cf48777897809e92c8c4ffc09278c4dcf3673758393a8af9ed9121cfbbf4e6d8c2e207c0
+  metadata.gz: 83dcd2e4e86d9d330e052ea60a17ce04cba84fd571476b7ae41dd5e162e918875fc5941397bcabb311a40bccecffb0525d616a087e65f6b9c75f21f7b85eec80
+  data.tar.gz: 0588eeb4508c67bbee33604807a444bf3f832ee1d84f94f3ff9bd1f2126f4cd0217ac6af32bbbc61976f3923128097263ca32600e2713beb7322b0d0cc50849b

data/.gitignore

@@ -1,5 +1,6 @@
 *.gem
 *.rbc
+/Gemfile.lock
 /.config
 /coverage/
 /InstalledFiles

data/README.rdoc

@@ -36,11 +36,8 @@ Our +main.rb+ (or +config.ru+ or whatever) is simple:
   Bundler.require(:default)
 
   service = ConfigurationService::Factory::EnvironmentContext.create
-  if configuraton = service.request_configuration
-    AcmeApplication.new(configuration.data).run
-  else
-    raise "configuration not found"
-  end
+  configuraton = service.request_configuration
+  AcmeApplication.new(configuration.data).run
 
 This relies on a bundler Gemfile to load the gem that contains whatever
 service provider we configure in the environment:
@@ -76,9 +73,6 @@ construct the service yourself:
       address: "http://127.0.0.1:8200"
     )
   )
-  if configuraton = service.request_configuration
-    AcmeApplication.new(configuration.data).run
-  else
-    raise "configuration not found"
-  end
+  configuraton = service.request_configuration
+  AcmeApplication.new(configuration.data).run
 

data/lib/configuration_service/base.rb

@@ -42,10 +42,12 @@ module ConfigurationService
     # Delegates the request to the provider.
     #
     # Returns a Configuration object or raises an Error on failure.
-    # Returns +nil+ if no matching configuration was found.
+    # Raises ConfigurationNotFoundError if no matching configuration
+    # was found.
     #
     def request_configuration
-      @provider.request_configuration(@identifier, @token)
+      @provider.request_configuration(@identifier, @token) or
+        raise ConfigurationNotFoundError, "configuration not found for identifier: #{@identifier}"
     end
 
     ##

data/lib/configuration_service/errors.rb

@@ -21,4 +21,11 @@ module ConfigurationService
   class ProviderNotFoundError < Error
   end
 
+  ##
+  #
+  # Configuration with the requested identifier was not found
+  #
+  class ConfigurationNotFoundError < Error
+  end
+
 end

data/lib/configuration_service/factory/environment_context.rb

@@ -26,11 +26,8 @@ module ConfigurationService
     #   Bundler.require(:default) # Registers the vault provider
     #
     #   service = ConfigurationService::Factory::EnvironmentContext.create
-    #   if configuraton = service.request_configuration
-    #     AcmeApplication.new(configuration.data).run
-    #   else
-    #     raise "configuration not found"
-    #   end
+    #   configuraton = service.request_configuration
+    #   AcmeApplication.new(configuration.data).run
     #
     class EnvironmentContext
 

data/lib/configuration_service/test/orchestration_provider.rb

@@ -252,6 +252,8 @@ module ConfigurationService
         def wrap_response # :nodoc:
           begin
             ConfigurationService::Test::Response::Success.new(yield)
+          rescue ConfigurationService::ConfigurationNotFoundError
+            ConfigurationService::Test::Response::Success.new(nil)
           rescue ConfigurationService::Error => e
             ConfigurationService::Test::Response::Failure.new(e)
           end

data/lib/configuration_service/version.rb

@@ -1,5 +1,5 @@
 module ConfigurationService
 
-  VERSION = "1.1.4"
+  VERSION = "2.0.0"
 
 end

metadata

@@ -1,7 +1,7 @@
 --- !ruby/object:Gem::Specification
 name: configuration_service
 version: !ruby/object:Gem::Version
-  version: 1.1.4
+  version: 2.0.0
 platform: ruby
 authors:
 - Sheldon Hearn
@@ -91,7 +91,6 @@ files:
 - ".gitignore"
 - ".rspec"
 - Gemfile
-- Gemfile.lock
 - README.md
 - README.rdoc
 - Rakefile

data/Gemfile.lock

@@ -1,51 +0,0 @@
-PATH
-  remote: .
-  specs:
-    configuration_service (1.1.3)
-
-GEM
-  remote: https://rubygems.org/
-  specs:
-    builder (3.2.2)
-    cucumber (2.0.2)
-      builder (>= 2.1.2)
-      cucumber-core (~> 1.2.0)
-      diff-lcs (>= 1.1.3)
-      gherkin (~> 2.12)
-      multi_json (>= 1.7.5, < 2.0)
-      multi_test (>= 0.1.2)
-    cucumber-core (1.2.0)
-      gherkin (~> 2.12.0)
-    diff-lcs (1.2.5)
-    gherkin (2.12.2)
-      multi_json (~> 1.3)
-    multi_json (1.11.2)
-    multi_test (0.1.2)
-    rake (10.4.2)
-    rspec (3.3.0)
-      rspec-core (~> 3.3.0)
-      rspec-expectations (~> 3.3.0)
-      rspec-mocks (~> 3.3.0)
-    rspec-core (3.3.2)
-      rspec-support (~> 3.3.0)
-    rspec-expectations (3.3.1)
-      diff-lcs (>= 1.2.0, < 2.0)
-      rspec-support (~> 3.3.0)
-    rspec-mocks (3.3.2)
-      diff-lcs (>= 1.2.0, < 2.0)
-      rspec-support (~> 3.3.0)
-    rspec-support (3.3.0)
-
-PLATFORMS
-  ruby
-
-DEPENDENCIES
-  bundler (~> 1.10)
-  configuration_service!
-  cucumber (~> 2.0)
-  rake (~> 10.0)
-  rspec (~> 3.3)
-  rspec-expectations (~> 3.3)
-
-BUNDLED WITH
-   1.10.3