confetti 0.2.4 → 0.2.5

data/Gemfile.lock

@@ -1,7 +1,7 @@
 PATH
   remote: .
   specs:
-    confetti (0.2.4)
+    confetti (0.2.5)
       mustache (= 0.11.2)
       thor (= 0.14.3)
 

data/lib/confetti/template_helper.rb

@@ -18,9 +18,15 @@ module Confetti
           filepath = args.first
 
           template = send generate_method
-          filepath ||= File.join(Dir.pwd, template.output_filename)
 
-          open(filepath, 'w') { |f| f.puts template.render }
+          begin
+            output = template.render
+            filepath ||= File.join(Dir.pwd, template.output_filename)
+
+            open(filepath, 'w') { |f| f.puts output }
+          rescue
+            raise IOError, "unable to write template file"
+          end
         end
       end
     end

data/lib/confetti/templates/java_checks.rb

@@ -10,8 +10,10 @@ module Confetti
       end
 
       def is_java_package_id(str)
+        components = str.split('.', -1)
+
         # second param to #split ensures can't be dot-terminated
-        str.split('.', -1).all? { |s| is_java_identifier(s) }
+        components.length > 1 and components.all? { |s| is_java_identifier(s) }
       end
     end
   end

data/lib/confetti/version.rb

@@ -1,3 +1,3 @@
 module Confetti
-  VERSION = "0.2.4"
+  VERSION = "0.2.5"
 end

data/spec/spec_helper.rb

@@ -57,21 +57,31 @@ module ConfigHelpers
             @output = mock(IO)
 
             @config.should_receive(generate_method).and_return(@template)
-            @template.should_receive(:render).and_return(@contents)
-            @output.should_receive(:puts).with(@contents)
           end
 
           it "should write the rendered #{ default_filename } to the fs" do
             filepath = "my_directory/#{ default_filename }"
             @config.should_receive(:open).with(filepath, 'w').and_yield(@output)
+            @template.should_receive(:render).and_return(@contents)
+            @output.should_receive(:puts).with(@contents)
 
             @config.send(write_method, filepath)
           end
 
+          it "should not write to the fs if the render call fails" do
+            filepath = "my_directory/#{ default_filename }"
+            @template.should_receive(:render).and_raise(IOError)
+            @config.should_not_receive(:open).with(filepath, 'w')
+
+            lambda { @config.send(write_method, filepath) }.should raise_error
+          end
+
           describe "when no filepath is passed" do
             it "should write the rendered #{ default_filename } to the default location" do
               default_path = File.join(Dir.pwd, default_filename)
               @config.should_receive(:open).with(default_path, 'w').and_yield(@output)
+              @template.should_receive(:render).and_return(@contents)
+              @output.should_receive(:puts).with(@contents)
 
               @config.send(write_method)
             end

data/spec/templates/java_checks_spec.rb

@@ -55,5 +55,9 @@ describe Confetti::Template::JavaChecks do
     it "should not accept a dot-first string" do
       is_java_package_id(".com.alunny.foo").should be_false
     end
+
+    it "should not accept a single java identifier" do
+      is_java_package_id("a27a4").should be_false
+    end
   end
 end

metadata

@@ -1,13 +1,13 @@
 --- !ruby/object:Gem::Specification 
 name: confetti
 version: !ruby/object:Gem::Version 
-  hash: 31
-  prerelease: 
+  hash: 29
+  prerelease: false
   segments: 
   - 0
   - 2
-  - 4
-  version: 0.2.4
+  - 5
+  version: 0.2.5
 platform: ruby
 authors: 
 - Andrew Lunny
@@ -15,7 +15,7 @@ autorequire:
 bindir: bin
 cert_chain: []
 
-date: 2011-04-12 00:00:00 -07:00
+date: 2011-04-20 00:00:00 -07:00
 default_executable: 
 dependencies: 
 - !ruby/object:Gem::Dependency 
@@ -213,7 +213,7 @@ required_rubygems_version: !ruby/object:Gem::Requirement
 requirements: []
 
 rubyforge_project: confetti
-rubygems_version: 1.5.0
+rubygems_version: 1.3.7
 signing_key: 
 specification_version: 3
 summary: Generate mobile app config files