conekta 0.4.4 → 0.4.5

checksums.yaml

@@ -1,15 +1,15 @@
 ---
 !binary "U0hBMQ==":
   metadata.gz: !binary |-
-    ZWRlMTZkMzZlNjEwZDMwZmQyYWViYTk3ODdhNjJiYWJjM2Q4MTExNQ==
+    NDBkYWQ2NWE4ODYzZDA5MTExOTU0YzJiOGVmZTU1ZjU1NDU2ZjA0ZQ==
   data.tar.gz: !binary |-
-    YjJhY2Q1N2IxOTE4Y2ZkYTJlZGNiYzJmZTYyMjNlZTE5MTRkNzE2Zg==
+    NjBmNDgyYmYyYzJmNDFkMWQ0ZDZiNTU3ZTFlN2ZmMjgyNzQ1Nzk5MQ==
 SHA512:
   metadata.gz: !binary |-
-    NDhlMTYyMzA3M2EzMTYzZWI0MjVhZTE1ZGEzNjRiOGVkMzJjNGEyZDUzNDkz
-    N2U0NGZiOTMyMDAyOTBjYWU2NjIwZWM2N2ZiNDdiZjM2OWEyNGU4NTYxYjBl
-    MjYwN2NmMzFkZjI2OGNhY2M5YjYyMmMzZWU3YzZjMWNjZGNlZDU=
+    M2IyNmRkMjI1YWU3MDEyYTFjMWY3MDJiNDUyNjVlYzQwZTMzNGQyZjFmN2E0
+    ZWYzNDgxY2M5NjcyOTMwNzkxODU1YjgxM2QwMDQyNDQ5ZmJlYTQyMzc0NzIy
+    MjY5MTI4NTZjNjE3ZmYzMjFjZmEzYjBiYzUzYjAwNzk0ZmNjNWY=
   data.tar.gz: !binary |-
-    OGFjMTYxNjM0MWFjMzYzYTAxYjdiZmE1NTc5ODg0YjY3MzFjMDQ5ZDE2M2Jj
-    OWU2OTMwNGYwMzk3YjRjNzA0YjYxY2QwNjcxMTgxYTJiOTY1MTA1OTc2ZmE0
-    NzRhOTgzOWZlMGY2OGJmMzdiNTZmODQ2MGRmZGIyMzYwZmYwOGQ=
+    MDJkMzNhNjkzMTEwMDk2NDg4YmVhODQ2NWEwYjAxZjUzNGZmZWI0MGU4MzA0
+    ZTZhMGVhNWJkOGIyMDY2ZGNjNDY5NDdlMjA1ZTJjNzMxYTZlYzBmMzAyMDc2
+    NmY2YWI5MDcxMzE1Mjc4NzE0YmQ5M2E1ZDNhNWU0YzdlZjZiOTk=

data/CHANGELOG

@@ -32,3 +32,7 @@
 === 0.4.4 2014-06-04
 
 * Fix requestor and where method.
+
+=== 0.4.5 2014-07-08
+
+* Sprinkling small Ruby style conventions here and there (antillas21).

data/README.md

@@ -21,17 +21,27 @@ Or install it yourself as:
     Conekta.locale = :es
     
     Conekta.api_key = '1tv5yJp3xnVZ7eK67m4h'
-    @my_card = {number: '4242424242424242', exp_month: 5, exp_year: 2015, cvc: 123, name: 'Mario Moreno'}
+    
     begin
-      charge = Conekta::Charge.create({card: @my_card, description: 'Some desc', amount: 2000, currency: 'mxn'})
-      p charge
+        charge = Conekta::Charge.create({
+                    amount: 51000,
+                    currency: "MXN",
+                    description: "Pizza Delivery",
+                    reference_id: "orden_de_id_interno",
+                    card: params[:conektaTokenId] 
+                    #"tok_a4Ff0dD2xYZZq82d9"
+                    })
+    rescue Conekta::ParameterValidationError => e
+        puts e.message 
+        #alguno de los parámetros fueron inválidos
+    rescue Conekta::ProcessingError => e
+        puts e.message 
+        #la tarjeta no pudo ser procesada
     rescue Conekta::Error
-      # Catch all exceptions including validation errors.
-      e.message
-      
-      # Error message translated
-      e.message_to_purchaser
+        puts e.message 
+        #un error ocurrió que no sucede en el flujo normal de cobros como por ejemplo un auth_key incorrecto
     end
+    
 
     {
         "id": "5286828b8ee31e64b7001739",

data/lib/conekta/card.rb

@@ -4,9 +4,7 @@ module Conekta
     include Conekta::Operations::Update
     include Conekta::Operations::CustomAction
     def url
-      if id == nil || id == ""
-        raise Error.new('Could not get the id of ' + self.class.class_name + ' instance.')
-      end
+      raise Error.new('Could not get the id of ' + self.class.class_name + ' instance.') if (id.nil? || id.empty?)
       self.customer.url + self.class.url + "/" + id
     end
     def delete

data/lib/conekta/charge.rb

@@ -5,14 +5,10 @@ module Conekta
     include Conekta::Operations::Create
     include Conekta::Operations::CustomAction
     def capture
-      custom_action(:post, 'capture', nil)
+      custom_action(:post, 'capture')
     end
     def refund(params=nil)
-      if params == nil
-        params = {"amount" => self.amount}
-      else
-        params = {"amount" => params}
-      end
+      params = { 'amount' => (params || self.amount) }
       custom_action(:post, 'refund', params)
     end
   end

data/lib/conekta/operations/create.rb

@@ -3,9 +3,8 @@ module Conekta
     module Create
       module ClassMethods
         def create(params)
-          requestor = Requestor.new
           url = Util.types[self.class_name.downcase].url
-          response = requestor.request(:post, url, params)
+          response = Requestor.new.request(:post, url, params)
           instance = self.new
           instance.load_from(response)
           instance

data/lib/conekta/operations/create_member.rb

@@ -2,13 +2,13 @@ module Conekta
   module Operations
     module CreateMember
       def create_member(member, params)
-        url = self.url + "/" + member
+        url = [self.url, member].join('/')
         member = member.to_sym
-        requestor = Requestor.new
-        response = requestor.request(:post, url, params)
+        response = Requestor.new.request(:post, url, params)
+
         if self.method(member).call and self.method(member).call.class.class_name == "ConektaObject"
           arr = []
-          self.method(member).call.values.each do |(k,v)|
+          self.method(member).call.values.each do |_,v|
             arr << v.to_hash
           end
           arr << response

data/lib/conekta/operations/custom_action.rb

@@ -2,13 +2,9 @@ module Conekta
   module Operations
     module CustomAction
       def custom_action(method, action=nil, params=nil)
-        requestor = Requestor.new
-        if action
-          url = self.url + "/" + action
-        else
-          url = self.url
-        end
-        response = requestor.request(method, url, params)
+        url = action ? [self.url, action].join('/') : self.url
+        response = Requestor.new.request(method, url, params)
+
         self.load_from(response)
         self
       end

data/lib/conekta/operations/find.rb

@@ -4,21 +4,13 @@ module Conekta
       module ClassMethods
         def find(id)
           instance = self.new(id)
-          url = instance.url
-          requestor = Requestor.new
-          response = requestor.request(:get, url)
+          response = Requestor.new.request(:get, instance.url)
           instance.load_from(response)
           instance
         end
+
         # <b>DEPRECATED:</b> Please use <tt>find</tt> instead.
-        def retrieve(id)
-          instance = self.new(id)
-          url = instance.url
-          requestor = Requestor.new
-          response = requestor.request(:get, url)
-          instance.load_from(response)
-          instance
-        end
+        alias_method :retrieve, :find
       end
       def self.included(base)
         base.extend(ClassMethods)

data/lib/conekta/operations/update.rb

@@ -2,9 +2,7 @@ module Conekta
   module Operations
     module Update
       def update(params)
-        requestor = Requestor.new
-        url = self.url
-        response = requestor.request(:put, url, params)
+        response = Requestor.new.request(:put, self.url, params)
         self.load_from(response)
         self
       end

data/lib/conekta/operations/where.rb

@@ -5,20 +5,13 @@ module Conekta
         def where(params=nil)
           instance = ConektaObject.new
           url = Util.types[self.class_name.downcase].url
-          requestor = Requestor.new
-          response = requestor.request(:get, url,params)
+          response = Requestor.new.request(:get, url,params)
           instance.load_from(response)
           instance
         end
+
         # <b>DEPRECATED:</b> Please use <tt>where</tt> instead.
-        def all(params=nil)
-          instance = ConektaObject.new
-          url = Util.types[self.class_name.downcase].url
-          requestor = Requestor.new
-          response = requestor.request(:get, url)
-          instance.load_from(response)
-          instance
-        end
+        alias_method :all, :where
       end
       def self.included(base)
         base.extend(ClassMethods)

data/lib/conekta/payout_method.rb

@@ -4,9 +4,7 @@ module Conekta
     include Conekta::Operations::Update
     include Conekta::Operations::CustomAction
     def url
-      if id == nil || id == ""
-        raise Error.new('Could not get the id of ' + self.class.class_name + ' instance.')
-      end
+      raise Error.new('Could not get the id of ' + self.class.class_name + ' instance.') if (id.nil? || id.empty?)
       self.payee.url + self.class.url + "/" + id
     end
     def delete

data/lib/conekta/resource.rb

@@ -4,10 +4,9 @@ module Conekta
       "/#{CGI.escape(self.class_name.downcase)}s"
     end
     def url
-      if id == nil || id == ""
-        raise Error.new(I18n.t('error.resource.id',  {resource: self.class.class_name, locale: :en}), I18n.t('error.resource.id',  {resource: self.class.class_name, locale: Conekta.locale.to_sym}))
-      end
-      self.class.url + "/" + id
+      raise Error.new(I18n.t('error.resource.id',  {resource: self.class.class_name, locale: :en}), I18n.t('error.resource.id',  {resource: self.class.class_name, locale: Conekta.locale.to_sym})) if (id.nil? || id.empty?)
+
+      return [self.class.url, id].join('/')
     end
   end
 end

data/lib/conekta/subscription.rb

@@ -3,9 +3,8 @@ module Conekta
     include Conekta::Operations::Update
     include Conekta::Operations::CustomAction
     def url
-      if id == nil || id == ""
-        raise Error.new('Could not get the id of ' + self.class.class_name + ' instance.')
-      end
+      raise Error.new('Could not get the id of ' + self.class.class_name + ' instance.') if (id.nil? || id.empty?)
+
       self.customer.url + "/subscription"
     end
     def pause

data/lib/conekta/version.rb

@@ -1,3 +1,3 @@
 module Conekta
-  VERSION = '0.4.4'
+  VERSION = '0.4.5'
 end

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: conekta
 version: !ruby/object:Gem::Version
-  version: 0.4.4
+  version: 0.4.5
 platform: ruby
 authors:
 - MauricioMurga
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2014-06-04 00:00:00.000000000 Z
+date: 2014-07-08 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: bundler