conduit 0.6.4 → 0.6.5

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA1:
-  metadata.gz: b11a31f5c1d58a96106aa68612e5feb2ca2f0eb9
-  data.tar.gz: f1a5d44a55d854d7b46b84dc94fa15adb23581c7
+  metadata.gz: d7cf39a8b5a40460f2718e1b91f4bd6f80063d88
+  data.tar.gz: 6648815b5ab817132226aca79e505fd5ef598df6
 SHA512:
-  metadata.gz: 0472bc70340ddb7ae4d9674719ea55709b41ebb00cb5d9b0ab8c23dd4428f2a86d66dcec937e618305d1fde503afebcb3cee15904fee1a435c75ffda2aeef0df
-  data.tar.gz: 729632b1795b0067db4a82b1d2967c9d90613e03dcd44bd6fc3a47321afbe69052737cd976392c69fcdfc624a8a0951f0b2ad87573a64aaefdfb067c64b7d64f
+  metadata.gz: acbfca131ac308212a6f87350320b2c6ce04fa3d4688169d0b3439245b6427f3a116b7c293b148f906352676e8b741bcfbf74a834d747196daaee1a14ebcfbec
+  data.tar.gz: 69241d1f40d6be02edb49cfe7b7faa485b7bcdabdf0665f1bdf5b43fb9da42fa1b52ad279850dfdef96257a245ffdf4b50d79a70bcf3d926e84da59486ce1b8f

data/lib/conduit/core/action.rb

@@ -13,7 +13,6 @@
 #
 
 require 'active_support/inflector'
-require 'active_support/core_ext/object/blank'
 require 'forwardable'
 require 'ostruct'
 require 'set'
@@ -140,36 +139,11 @@ module Conduit
         # an ArgumentError listing missing attributes
         #
         def validate!(options)
-          !missing_required_keys?(options) &&
-            !required_keys_not_present?(options)
-        end
-
-        # Raises an Argument error if any required keys
-        # are not present in the options hash; otherwise
-        # returns false
-        #
-        def missing_required_keys?(options)
           missing_keys = (requirements.to_a - options.keys)
           if missing_keys.any?
             raise ArgumentError,
               "Missing keys: #{missing_keys.join(', ')}"
           end
-          false
-        end
-
-        # Raises an Argument error if any required keys
-        # are present in the options hash but have nil values;
-        # otherwise returns false
-        #
-        def required_keys_not_present?(options)
-          required_options_not_present = requirements.reject do |required_key|
-            options[required_key].present?
-          end
-          if required_options_not_present.any?
-            raise ArgumentError,
-              "Nil keys: #{required_options_not_present.join(', ')}"
-          end
-          false
         end
 
         # Returns the parser for this action

data/lib/conduit/core/connection.rb

@@ -54,10 +54,6 @@ module Conduit
           raise(Conduit::TimeOut, timeout.message)
         rescue Excon::Errors::Error => error
           raise(Conduit::ConnectionError, error.message)
-        rescue SocketError => error
-          msg = 'Could not connect to the server.  Please check your internet connection.' +
-            "\n#{error.message}"
-          raise(Conduit::ConnectionError, msg)
         end
 
         private

data/lib/conduit/version.rb

@@ -1,3 +1,3 @@
 module Conduit
-  VERSION = '0.6.4'
+  VERSION = '0.6.5'
 end

data/spec/classes/core/action_spec.rb

@@ -40,33 +40,6 @@ shared_examples_for Conduit::Core::Action do
       end
     end
 
-    describe '.new' do
-      it 'should raise an error if any required arguments are not supplied' do
-        expect { described_class.new({}) }.to raise_error(ArgumentError)
-      end
-
-      it 'should raise an error if any required arguments are nil' do
-        options = request_attributes.inject({}) do |h, (k, _v)|
-          h.merge(k => nil)
-        end
-        expect { described_class.new(options) }.to raise_error(ArgumentError)
-      end
-
-      it 'should raise an error if any of the required arguments are blank' do
-        options = request_attributes.inject({}) do |h, (k, _v)|
-          h.merge(k => '')
-        end
-        expect { described_class.new(options) }.to raise_error(ArgumentError)
-      end
-
-      it 'should raise an error if any of the required arguments are empty' do
-        options = request_attributes.inject({}) do |h, (k, _v)|
-          h.merge(k => [])
-        end
-        expect { described_class.new(options) }.to raise_error(ArgumentError)
-      end
-    end
-
     describe '#perform' do
       before { Excon.stub({}, body: response, status: 200) }
 

data/spec/spec_helper.rb

@@ -18,7 +18,7 @@ RSpec.configure do |config|
   config.include Helper
 
   config.expect_with :rspec do |c|
-    c.syntax = [:should, :expect]
+    c.syntax = :should
   end
 
   config.before(:suite) do
@@ -29,4 +29,4 @@ RSpec.configure do |config|
 
     Conduit::Driver.load_drivers
   end
-end
+end

metadata

@@ -1,7 +1,7 @@
 --- !ruby/object:Gem::Specification
 name: conduit
 version: !ruby/object:Gem::Version
-  version: 0.6.4
+  version: 0.6.5
 platform: ruby
 authors:
 - Mike Kelley