conditional_validation 0.1.0 → 1.0.0

data/lib/conditional_validation.rb

@@ -1,5 +1,5 @@
-require "conditional_validation/validation_flag"
-require "conditional_validation/validation_accessor"
-
 module ConditionalValidation
 end
+
+require "conditional_validation/version"
+require "conditional_validation/validation_flag"

data/lib/conditional_validation/validation_flag.rb

@@ -1,47 +1,43 @@
 module ConditionalValidation
+  # ConditionalValidation::ValidationFlag is extended by model classes to add
+  # the `validation_flag` macro.
   module ValidationFlag
-    extend ActiveSupport::Concern
+    # Macro method for defining attr_accessor methods, and the associated
+    # enable/disable/predicate methods that wrap the attr_acessor methods, for
+    # determining when to run validation sets on a model.
+    #
+    # @param flags [*Array<String>] the validation flag names
+    #
+    # @example
+    #   class User
+    #     validation_flag :address_attributes
+    #   end
+    def validation_flag(*flags)
+      raise ArgumentError, "flags can't be empty" if flags.empty?
 
-    module ClassMethods
-      # Macro method for defining an attr_accessor and
-      # enable/disable/predicate methods that wrap the attr_acessor for
-      # determining when to run a set of validation on an ActiveRecord model.
-      #
-      # @param [*Array] flags the section names for which to define
-      #   validation flags for
-      #
-      # @example
-      #   class User
-      #     validation_flag :address_attributes
-      #   end
-      #
-      #   # => Defines the following methods on instances of the User class:
-      #   #      enable_address_attributes_validation
-      #   #      disable_address_attributes_validation
-      #   #      validate_on_address_attributes?
-      def validation_flag(*flags)
-        attr_accessor *flags.map { |flag| "_#{flag}_validation_flag" }
+      accessor_method_names = flags.map { |flag| "_#{flag}_validation_flag" }
+      attr_accessor(*accessor_method_names)
 
-        flags.each do |flag|
-          class_eval <<-METHODS, __FILE__, __LINE__ + 1
-            def enable_#{flag}_validation
-              self._#{flag}_validation_flag = true
-              self
-            end
+      flags.each do |flag|
+        # def enable_address_attributes_validation
+        # def disable_address_attributes_validation
+        # def validate_on_address_attributes?
+        class_eval <<-RUBY, __FILE__, __LINE__ + 1
+          def enable_#{flag}_validation
+            self._#{flag}_validation_flag = true
+            self
+          end
 
-            def disable_#{flag}_validation
-              self._#{flag}_validation_flag = false
-              self
-            end
+          def disable_#{flag}_validation
+            self._#{flag}_validation_flag = false
+            self
+          end
 
-            def validate_on_#{flag}?
-              !!_#{flag}_validation_flag
-            end
-          METHODS
-        end
+          def validate_on_#{flag}?
+            !!_#{flag}_validation_flag
+          end
+        RUBY
       end
     end
   end
 end
-
-ActiveRecord::Base.send(:include, ConditionalValidation::ValidationFlag)

data/lib/conditional_validation/version.rb

@@ -1,3 +1,3 @@
 module ConditionalValidation
-  VERSION = "0.1.0"
+  VERSION = "1.0.0"
 end

metadata

@@ -1,114 +1,149 @@
 --- !ruby/object:Gem::Specification
 name: conditional_validation
 version: !ruby/object:Gem::Version
-  version: 0.1.0
+  version: 1.0.0
 platform: ruby
 authors:
 - Paul Dobbins
 autorequire: 
-bindir: bin
+bindir: exe
 cert_chain: []
-date: 2014-08-31 00:00:00.000000000 Z
+date: 2018-04-17 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
-  name: rails
+  name: bundler
   requirement: !ruby/object:Gem::Requirement
     requirements:
-    - - ">="
+    - - "~>"
       - !ruby/object:Gem::Version
-        version: 3.0.0
-  type: :runtime
+        version: '1.16'
+  type: :development
+  prerelease: false
+  version_requirements: !ruby/object:Gem::Requirement
+    requirements:
+    - - "~>"
+      - !ruby/object:Gem::Version
+        version: '1.16'
+- !ruby/object:Gem::Dependency
+  name: rake
+  requirement: !ruby/object:Gem::Requirement
+    requirements:
+    - - "~>"
+      - !ruby/object:Gem::Version
+        version: '10.0'
+  type: :development
+  prerelease: false
+  version_requirements: !ruby/object:Gem::Requirement
+    requirements:
+    - - "~>"
+      - !ruby/object:Gem::Version
+        version: '10.0'
+- !ruby/object:Gem::Dependency
+  name: minitest
+  requirement: !ruby/object:Gem::Requirement
+    requirements:
+    - - "~>"
+      - !ruby/object:Gem::Version
+        version: '5.0'
+  type: :development
+  prerelease: false
+  version_requirements: !ruby/object:Gem::Requirement
+    requirements:
+    - - "~>"
+      - !ruby/object:Gem::Version
+        version: '5.0'
+- !ruby/object:Gem::Dependency
+  name: minitest-reporters
+  requirement: !ruby/object:Gem::Requirement
+    requirements:
+    - - "~>"
+      - !ruby/object:Gem::Version
+        version: '1.2'
+  type: :development
+  prerelease: false
+  version_requirements: !ruby/object:Gem::Requirement
+    requirements:
+    - - "~>"
+      - !ruby/object:Gem::Version
+        version: '1.2'
+- !ruby/object:Gem::Dependency
+  name: simplecov
+  requirement: !ruby/object:Gem::Requirement
+    requirements:
+    - - "~>"
+      - !ruby/object:Gem::Version
+        version: '0.16'
+  type: :development
+  prerelease: false
+  version_requirements: !ruby/object:Gem::Requirement
+    requirements:
+    - - "~>"
+      - !ruby/object:Gem::Version
+        version: '0.16'
+- !ruby/object:Gem::Dependency
+  name: byebug
+  requirement: !ruby/object:Gem::Requirement
+    requirements:
+    - - "~>"
+      - !ruby/object:Gem::Version
+        version: '10.0'
+  type: :development
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
-    - - ">="
+    - - "~>"
       - !ruby/object:Gem::Version
-        version: 3.0.0
+        version: '10.0'
 - !ruby/object:Gem::Dependency
-  name: sqlite3
+  name: pry
   requirement: !ruby/object:Gem::Requirement
     requirements:
-    - - ">="
+    - - "~>"
       - !ruby/object:Gem::Version
-        version: '0'
+        version: '0.11'
   type: :development
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
-    - - ">="
+    - - "~>"
       - !ruby/object:Gem::Version
-        version: '0'
+        version: '0.11'
 - !ruby/object:Gem::Dependency
-  name: minitest-rails
+  name: pry-byebug
   requirement: !ruby/object:Gem::Requirement
     requirements:
-    - - ">="
+    - - "~>"
       - !ruby/object:Gem::Version
-        version: '0'
+        version: '3.6'
   type: :development
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
-    - - ">="
+    - - "~>"
       - !ruby/object:Gem::Version
-        version: '0'
-description: Conditional Validation allows validation flags to be enabled to determine
-  when certain validations should be run on a model.
+        version: '3.6'
+description: ConditionalValidation simplifies adding validation flags and then querying
+  state to determine when associated validations should be run on models.
 email:
-- pdobbins@gmail.com
+- paul.dobbins@icloud.com
 executables: []
 extensions: []
 extra_rdoc_files: []
 files:
-- MIT-LICENSE
+- ".gitignore"
+- ".travis.yml"
+- CHANGELOG.md
+- Gemfile
+- Gemfile.lock
+- LICENSE.txt
 - README.md
 - Rakefile
+- bin/console
+- bin/setup
+- conditional_validation.gemspec
 - lib/conditional_validation.rb
-- lib/conditional_validation/validation_accessor.rb
 - lib/conditional_validation/validation_flag.rb
 - lib/conditional_validation/version.rb
-- test/conditional_validation_test.rb
-- test/dummy/README.rdoc
-- test/dummy/Rakefile
-- test/dummy/app/assets/javascripts/application.js
-- test/dummy/app/assets/stylesheets/application.css
-- test/dummy/app/controllers/application_controller.rb
-- test/dummy/app/helpers/application_helper.rb
-- test/dummy/app/models/user.rb
-- test/dummy/app/views/layouts/application.html.erb
-- test/dummy/bin/bundle
-- test/dummy/bin/rails
-- test/dummy/bin/rake
-- test/dummy/config.ru
-- test/dummy/config/application.rb
-- test/dummy/config/boot.rb
-- test/dummy/config/database.yml
-- test/dummy/config/environment.rb
-- test/dummy/config/environments/development.rb
-- test/dummy/config/environments/production.rb
-- test/dummy/config/environments/test.rb
-- test/dummy/config/initializers/backtrace_silencers.rb
-- test/dummy/config/initializers/filter_parameter_logging.rb
-- test/dummy/config/initializers/inflections.rb
-- test/dummy/config/initializers/mime_types.rb
-- test/dummy/config/initializers/secret_token.rb
-- test/dummy/config/initializers/session_store.rb
-- test/dummy/config/initializers/wrap_parameters.rb
-- test/dummy/config/locales/en.yml
-- test/dummy/config/routes.rb
-- test/dummy/db/development.sqlite3
-- test/dummy/db/migrate/20131119215801_create_users.rb
-- test/dummy/db/schema.rb
-- test/dummy/db/test.sqlite3
-- test/dummy/log/development.log
-- test/dummy/log/test.log
-- test/dummy/public/404.html
-- test/dummy/public/422.html
-- test/dummy/public/500.html
-- test/dummy/public/favicon.ico
-- test/dummy/test/fixtures/users.yml
-- test/dummy/test/models/user_test.rb
-- test/test_helper.rb
 homepage: https://github.com/pdobb/conditional_validation
 licenses:
 - MIT
@@ -129,51 +164,8 @@ required_rubygems_version: !ruby/object:Gem::Requirement
       version: '0'
 requirements: []
 rubyforge_project: 
-rubygems_version: 2.4.1
+rubygems_version: 2.7.6
 signing_key: 
 specification_version: 4
-summary: Add conditional validation flags to a model.
-test_files:
-- test/conditional_validation_test.rb
-- test/dummy/app/assets/javascripts/application.js
-- test/dummy/app/assets/stylesheets/application.css
-- test/dummy/app/controllers/application_controller.rb
-- test/dummy/app/helpers/application_helper.rb
-- test/dummy/app/models/user.rb
-- test/dummy/app/views/layouts/application.html.erb
-- test/dummy/bin/bundle
-- test/dummy/bin/rails
-- test/dummy/bin/rake
-- test/dummy/config/application.rb
-- test/dummy/config/boot.rb
-- test/dummy/config/database.yml
-- test/dummy/config/environment.rb
-- test/dummy/config/environments/development.rb
-- test/dummy/config/environments/production.rb
-- test/dummy/config/environments/test.rb
-- test/dummy/config/initializers/backtrace_silencers.rb
-- test/dummy/config/initializers/filter_parameter_logging.rb
-- test/dummy/config/initializers/inflections.rb
-- test/dummy/config/initializers/mime_types.rb
-- test/dummy/config/initializers/secret_token.rb
-- test/dummy/config/initializers/session_store.rb
-- test/dummy/config/initializers/wrap_parameters.rb
-- test/dummy/config/locales/en.yml
-- test/dummy/config/routes.rb
-- test/dummy/config.ru
-- test/dummy/db/development.sqlite3
-- test/dummy/db/migrate/20131119215801_create_users.rb
-- test/dummy/db/schema.rb
-- test/dummy/db/test.sqlite3
-- test/dummy/log/development.log
-- test/dummy/log/test.log
-- test/dummy/public/404.html
-- test/dummy/public/422.html
-- test/dummy/public/500.html
-- test/dummy/public/favicon.ico
-- test/dummy/Rakefile
-- test/dummy/README.rdoc
-- test/dummy/test/fixtures/users.yml
-- test/dummy/test/models/user_test.rb
-- test/test_helper.rb
-has_rdoc: 
+summary: ConditionalValidation simplifies adding validation flags to models.
+test_files: []

data/MIT-LICENSE

@@ -1,20 +0,0 @@
-Copyright 2013 Paul Dobbins
-
-Permission is hereby granted, free of charge, to any person obtaining
-a copy of this software and associated documentation files (the
-"Software"), to deal in the Software without restriction, including
-without limitation the rights to use, copy, modify, merge, publish,
-distribute, sublicense, and/or sell copies of the Software, and to
-permit persons to whom the Software is furnished to do so, subject to
-the following conditions:
-
-The above copyright notice and this permission notice shall be
-included in all copies or substantial portions of the Software.
-
-THE SOFTWARE IS PROVIDED "AS IS", WITHOUT WARRANTY OF ANY KIND,
-EXPRESS OR IMPLIED, INCLUDING BUT NOT LIMITED TO THE WARRANTIES OF
-MERCHANTABILITY, FITNESS FOR A PARTICULAR PURPOSE AND
-NONINFRINGEMENT. IN NO EVENT SHALL THE AUTHORS OR COPYRIGHT HOLDERS BE
-LIABLE FOR ANY CLAIM, DAMAGES OR OTHER LIABILITY, WHETHER IN AN ACTION
-OF CONTRACT, TORT OR OTHERWISE, ARISING FROM, OUT OF OR IN CONNECTION
-WITH THE SOFTWARE OR THE USE OR OTHER DEALINGS IN THE SOFTWARE.

data/lib/conditional_validation/validation_accessor.rb

@@ -1,51 +0,0 @@
-module ConditionalValidation
-  module ValidationAccessor
-    extend ActiveSupport::Concern
-
-    module ClassMethods
-      # Macro method for defining an attr_accessor and various
-      # enable/disable/predicate methods that wrap the attr_acessor for
-      # determining when to run a set of validation on an ActiveRecord model.
-      #
-      # @param args [*accessors] the section names for which to define
-      #   validation accessors for
-      #
-      # @example
-      #   class User
-      #     validation_accessor :address_attributes
-      #   end
-      #
-      #   # => Defines the following methods on instances of the User class:
-      #   #      enable_address_attributes_validation
-      #   #      disable_address_attributes_validation
-      #   #      validate_on_address_attributes?
-      def validation_accessor(*accessors)
-        attr_accessor *accessors.map { |accessor|
-          "_#{accessor}_validation_accessor"
-        }
-
-        accessors.each do |accessor|
-          class_eval <<-METHODS, __FILE__, __LINE__ + 1
-            def enable_#{accessor}_validation
-              self._#{accessor}_validation_accessor = true
-              self
-            end
-
-            def disable_#{accessor}_validation
-              self._#{accessor}_validation_accessor = false
-              self
-            end
-
-            def validate_on_#{accessor}?
-              !!_#{accessor}_validation_accessor
-            end
-          METHODS
-        end
-      end
-      deprecate validation_accessor: :validation_flag,
-                deprecator: ActiveSupport::Deprecation.new('1.0', 'Conditional Validation')
-    end
-  end
-end
-
-ActiveRecord::Base.send(:include, ConditionalValidation::ValidationAccessor)

data/test/conditional_validation_test.rb

@@ -1,101 +0,0 @@
-require 'test_helper'
-
-describe ConditionalValidation do
-  describe "#validation_flag" do
-    # User is defined in test/dummy/app/models/user.rb and is setup with
-    # validation_flags already.
-    subject { User.new }
-
-    it "is available to ActiveRecord models by default" do
-      class SomeClass < ActiveRecord::Base; end
-      SomeClass.must_respond_to(:validation_flag)
-    end
-
-    it "defines validation_flag methods" do
-      [:enable_flag_attributes_validation,
-        :disable_flag_attributes_validation,
-        :validate_on_flag_attributes?].each do |method|
-        subject.must_respond_to(method)
-      end
-    end
-
-    it "does not define validation_flag methods for unrequested validation_flags" do
-      [:"enable_unknown_attributes_validation",
-        :"disable_unknown_attributes_validation",
-        :"validate_on_unknown_attributes?"].each do |method|
-        subject.wont_respond_to(method)
-      end
-    end
-
-    describe "validation_flag methods" do
-      it "allows method chaining" do
-        subject.enable_flag_attributes_validation.must_equal subject
-        subject.disable_flag_attributes_validation.must_equal subject
-      end
-
-      it "requests validation when enabled" do
-        refute subject.validate_on_flag_attributes?
-
-        subject.enable_flag_attributes_validation
-        assert subject.validate_on_flag_attributes?
-      end
-
-      it "does not request validation when disabled" do
-        subject.enable_flag_attributes_validation
-        assert subject.validate_on_flag_attributes?
-
-        subject.disable_flag_attributes_validation
-        refute subject.validate_on_flag_attributes?
-      end
-    end
-  end
-
-  describe "#validation_accessor" do
-    # User is defined in test/dummy/app/models/user.rb and is setup with
-    # validation_flags already.
-    subject { User.new }
-
-    it "is available to ActiveRecord models by default" do
-      class SomeClass < ActiveRecord::Base; end
-      SomeClass.must_respond_to(:validation_accessor)
-    end
-
-    it "defines validation_accessor methods" do
-      [:enable_accessor_attributes_validation,
-        :disable_accessor_attributes_validation,
-        :validate_on_accessor_attributes?].each do |method|
-        subject.must_respond_to(method)
-      end
-    end
-
-    it "does not define validation_accessor methods for unrequested validation_accessors" do
-      [:"enable_unknown_attributes_validation",
-        :"disable_unknown_attributes_validation",
-        :"validate_on_unknown_attributes?"].each do |method|
-        subject.wont_respond_to(method)
-      end
-    end
-
-    describe "validation_accessor methods" do
-      it "allows method chaining" do
-        subject.enable_accessor_attributes_validation.must_equal subject
-        subject.disable_accessor_attributes_validation.must_equal subject
-      end
-
-      it "requests validation when enabled" do
-        refute subject.validate_on_accessor_attributes?
-
-        subject.enable_accessor_attributes_validation
-        assert subject.validate_on_accessor_attributes?
-      end
-
-      it "does not request validation when disabled" do
-        subject.enable_accessor_attributes_validation
-        assert subject.validate_on_accessor_attributes?
-
-        subject.disable_accessor_attributes_validation
-        refute subject.validate_on_accessor_attributes?
-      end
-    end
-  end
-end