conditional_counter_cache 0.0.1 → 0.0.2

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA1:
-  metadata.gz: 1a7dd773fc250091226da0a2a5efdedc39b8da51
-  data.tar.gz: 1d9d5bcc9e6712100f44ef3894243c77bd67a12c
+  metadata.gz: 00a4bcb0f63a7936b1f0ccf93a62f88ab2636172
+  data.tar.gz: ee002eeb7f874e9ca7f31f309ed7fa2437cebcf8
 SHA512:
-  metadata.gz: f6fc68c2c9700a7456d1f3de057010645f390b8ae4a9e608b6d4809ac84128f4d5788faad1d44f101d5b3aa274ad2987d0274c748ad3a6c73e0e3957d4938547
-  data.tar.gz: 484034592c1b600f73ef671592ea2211c97da011451a872f4007890812c920c0e7ac2e09f7730b115615be484745752e23bae9810d0d5c88e9d562678cee2071
+  metadata.gz: 13441a35f7f0c13dfe7b8b30386edadf10244178dc5b44f08eeb1fe7115d3444375e2d48f41904462f88b04781a75ebd02fa550f73776169ce536f43c5564a39
+  data.tar.gz: bd069a40e093f2785586083894279ef8dd379a2024e7131c3205b3dcedab72178da50fab757cc65041baf1b69df715f33f88cf26cf93deb49a3310a340e0cd03

data/CHANGELOG.md

@@ -0,0 +1,5 @@
+## 0.0.2
+* Fix non counter-cached belongs_to association
+
+## 0.0.1
+* 1st release

data/README.md

@@ -7,7 +7,7 @@ Customize condition via `:counter_cache` option:
 ```ruby
 class Tagging < ActiveRecord::Base
   belongs_to :item
-  belongs_to :tag, counter_cache: { condition: -> { !tagging.item.private? } }
+  belongs_to :tag, counter_cache: { condition: -> { !item.private? } }
 end
 ```
 
@@ -16,7 +16,14 @@ Other examples:
 ```ruby
 belongs_to :tag, counter_cache: true
 belongs_to :tag, counter_cache: "items_count"
-belongs_to :tag, counter_cache: { condition: -> { !tagging.item.private? } }
+belongs_to :tag, counter_cache: { condition: -> { !item.private? } }
+belongs_to :tag, counter_cache: { condition: -> :your_favorite_method_name }
 belongs_to :tag, counter_cache: { column_name: "items_count" }
-belongs_to :tag, counter_cache: { column_name: "items_count", condition: -> { !tagging.item.private? } }
+belongs_to :tag, counter_cache: { column_name: "items_count", condition: -> { !item.private? } }
 ```
+
+## See also
+* [Active Record Associations — Ruby on Rails Guides](http://guides.rubyonrails.org/association_basics.html)
+* [#23 Counter Cache Column - RailsCasts](http://railscasts.com/episodes/23-counter-cache-column)
+* [magnusvk/counter_culture](https://github.com/magnusvk/counter_culture)
+* [Counterculture - Wikipedia, the free encyclopedia](http://en.wikipedia.org/wiki/Counterculture)

data/lib/conditional_counter_cache/reflection.rb

@@ -2,13 +2,12 @@ module ConditionalCounterCache
   module Reflection
     # @note Overridden
     def counter_cache_column
-      Option.new(options[:counter_cache]).column_name ||
-        "#{active_record.name.demodulize.underscore.pluralize}_count"
+      Option.new(self).column_name
     end
 
     # @return [true, false]
     def has_countable?(record)
-      Option.new(options[:counter_cache]).condition.call(record)
+      Option.new(self).condition.call(record)
     end
 
     # Utility wrapper of `option[:counter_cache][:condition]`.
@@ -30,22 +29,24 @@ module ConditionalCounterCache
       end
     end
 
-    # Utility wrapper of `option[:counter_cache]`.
+    # Utility wrapper of reflection to process `option[:counter_cache]`.
     class Option
-      # @param [Hash, String, true, nil]
-      def initialize(value)
-        @value = value
+      # @param [ActiveRecord::Reflection]
+      def initialize(reflection)
+        @reflection = reflection
       end
 
       # @return [String, nil] Specified column name, or nil meaning "use default column name".
       def column_name
-        case
-        when has_hash_value?
-          @value[:column_name]
-        when has_true_value?
-          nil
+        case cache
+        when Hash
+          cache[:column_name]
+        when String, Symbol
+          cache.to_s
+        when true
+          "#{@reflection.active_record.name.demodulize.underscore.pluralize}_count"
         else
-          @value.to_s
+          nil
         end
       end
 
@@ -56,17 +57,13 @@ module ConditionalCounterCache
 
       private
 
-      def has_hash_value?
-        @value.is_a?(Hash)
-      end
-
-      def has_true_value?
-        @value == true
+      def cache
+        @reflection.options[:counter_cache]
       end
 
       # @return [Proc, String, Symbol, nil]
       def raw_condition
-        @value[:condition] if has_hash_value?
+        cache[:condition] if cache.is_a?(Hash)
       end
     end
   end

data/lib/conditional_counter_cache/version.rb

@@ -1,3 +1,3 @@
 module ConditionalCounterCache
-  VERSION = "0.0.1"
+  VERSION = "0.0.2"
 end

metadata

@@ -1,7 +1,7 @@
 --- !ruby/object:Gem::Specification
 name: conditional_counter_cache
 version: !ruby/object:Gem::Version
-  version: 0.0.1
+  version: 0.0.2
 platform: ruby
 authors:
 - Ryo Nakamura
@@ -122,6 +122,7 @@ extensions: []
 extra_rdoc_files: []
 files:
 - ".gitignore"
+- CHANGELOG.md
 - Gemfile
 - LICENSE.txt
 - README.md