condition_coverage 0.0.3 → 0.0.4

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: e0b1aba7a743838c35d3b4d139b40efebafd48edef44b82ffc48f7c045eb6861
-  data.tar.gz: '074496c6beaf83b9c6ec438019eb20e7b4f8231230ba94cd5e7a87cc2dc01eb1'
+  metadata.gz: eb36ad570a0050db876bba37548a59c929604eb35b88ed4b8ac4a155dde4db6e
+  data.tar.gz: 77f2dd1b7da7815a216fac0bee73f251f1c8d2c9490ad416d26125ac1adcfbe8
 SHA512:
-  metadata.gz: debb313edef170467b8146405bc25f212b852798c19492b20699a111d255c05015ade7357a90cc9666e9a5642674fa31a0dcea3f930978bd2ef8bad2b37cab04
-  data.tar.gz: e90aa8e71930f57e5e50b5f70155d7166ace8741f300abb7092bafbb3d47bafaaa3ce409cfe7102fc1795dfe7cea5224961a8497e027a617351b371010d83432
+  metadata.gz: 5571a2753478ab9ed18b6a1e04b47df6f4f96b03f10637ac9bf8e0ad4149b8a02d6b6abf754b45e533c0eb37a417fffe9a7a937c3c86a6bf15b51fe13d2bed03
+  data.tar.gz: 5d97b90e7c1bff46242a833f234ef1a5ef62e8732bd2a2fe3f9b1f65fe441b0bcad5da1eeaf2ad0912ae7406ce3baf1c77067571b0751e6a9c6f602e831eca62

data/README.md

@@ -3,7 +3,7 @@
 Condition coverage for Ruby, to run alongside SimpleCov's line and branch
 coverage.
 
-Status: 0.0.3 covers `&&`, `||`, `and` and `or`: each leaf operand of a
+Status: 0.0.4 covers `&&`, `||`, `and` and `or`: each leaf operand of a
 condition, however its operators are chained, nested or grouped. Decisions
 hidden inside calls come next (see Roadmap).
 
@@ -75,6 +75,15 @@ A chain of one operator is flat; a change of operator, by precedence or by
 parentheses, nests. Parentheses are not part of the tree, since they decide
 nothing.
 
+An operand whose form allows one outcome only needs only to be evaluated:
+its other outcome is impossible, not a gap. `Foo.new`, literals (`'s'`,
+`1`, `:k`, `[]`, `{}`, `true`) and lambdas can only be truthy; `nil` and
+`false` only falsy:
+
+```ruby
+@clock = options[:clock] || MonotonicClock.new  # operand 1: never evaluated, or no gap
+```
+
 - `:html` writes `index.html` to `coverage_dir`: the covered files with
   their sites, outcomes seen (with a percent) and outcomes missing, each
   column sortable. Each file name opens `files/<path>.html`, the file's

data/lib/condition_coverage/condition.rb

@@ -2,10 +2,12 @@ module ConditionCoverage
   # One site's condition as the manifest found it: its operator
   # and its operands, each the byte range of a leaf or a nested
   # Condition. A site's commands are the byte ranges of its
-  # leaves that are command calls, eg `ok? id`.
-  Condition = Data.define(:operator, :operands, :commands) do
-    # A condition with no command-call leaves by default.
-    def initialize(operator:, operands:, commands: [])
+  # leaves that are command calls, eg `ok? id`; its fixed are
+  # { byte range => :truthy } for leaves that can have that one
+  # outcome only, eg `Clock.new`.
+  Condition = Data.define(:operator, :operands, :commands, :fixed) do
+    # A condition with no command-call or fixed leaves by default.
+    def initialize(operator:, operands:, commands: [], fixed: {})
       super
     end
 

data/lib/condition_coverage/gaps.rb

@@ -25,9 +25,11 @@ module ConditionCoverage
       end
     end
 
-    # The one outcome this operand is missing, if any.
+    # The one outcome this operand is missing, if any; a fixed
+    # leaf, which can have one outcome only, needs only to run.
     def self.operand_gap(counts)
       return ['never evaluated'] if never_ran?(counts)
+      return [] if counts[:only]
       return ['never true'] if counts[:truthy].zero?
       return ['never false'] if counts[:falsy].zero?
 

data/lib/condition_coverage/manifest.rb

@@ -19,7 +19,7 @@ module ConditionCoverage
       def initialize(path)
         @path = path
         @sites = {}
-        @commands = []
+        @notes = nil
         super()
       end
 
@@ -44,11 +44,11 @@ module ConditionCoverage
       def add_site(node)
         site = Site.of(@path, node)
         @sites[site] = nil
-        outer = @commands
-        @commands = []
+        outer = @notes
+        @notes = { commands: [], fixed: {} }
         condition = condition_of(node)
-        @sites[site] = condition.with(commands: @commands)
-        @commands = outer
+        @sites[site] = condition.with(**@notes)
+        @notes = outer
       end
 
       # node as a Condition, operands and all, named by its
@@ -77,16 +77,38 @@ module ConditionCoverage
       end
 
       # The byte range of a leaf operand, once any site inside
-      # it is noted too, and the range among its site's commands
-      # if it is a command call.
+      # it is noted too, and the range noted among its site's
+      # commands and fixed leaves where it is one.
       def leaf(operand)
         operand.accept(self)
         loc = operand.location
         range = loc.start_offset...loc.end_offset
-        @commands << range if command?(operand)
+        @notes[:commands] << range if command?(operand)
+        outcome = fixed_outcome(operand)
+        @notes[:fixed][range] = outcome if outcome
         range
       end
 
+      TRUTHY_TYPES = %i[
+        string_node integer_node symbol_node array_node hash_node
+        true_node lambda_node
+      ].freeze
+      FALSY_TYPES = %i[nil_node false_node].freeze
+
+      # The one outcome a leaf can have, eg :truthy for `Clock.new`
+      # or a literal, :falsy for `nil`; nil for a leaf that can
+      # have either.
+      def fixed_outcome(node)
+        return :falsy if FALSY_TYPES.include?(node.type)
+
+        :truthy if TRUTHY_TYPES.include?(node.type) || new_call?(node)
+      end
+
+      # True for a call to new, eg `Clock.new`.
+      def new_call?(node)
+        node.type == :call_node && node.name == :new
+      end
+
       # True for a call to a named method with arguments and no
       # parentheses, eg `id.include? 'N'`, but not `id.size == 6`.
       def command?(node)

data/lib/condition_coverage/result.rb

@@ -13,16 +13,26 @@ module ConditionCoverage
     end
 
     # { site => [counts of operand 0, counts of operand 1, ...] },
-    # with zero counts for an operand that never ran.
+    # with zero counts for an operand that never ran, and
+    # only: naming the one outcome a fixed leaf can have.
     def operands
       @sites.to_h do |site, condition|
-        size = condition.leaves.size
-        [site, Array.new(size) { |i| counts_of(site, i) }]
+        leaves = condition.leaves.each_with_index.map do |range, i|
+          leaf(site, condition, range, i)
+        end
+        [site, leaves]
       end
     end
 
     private
 
+    # The counts of one leaf, with only: when it is fixed.
+    def leaf(site, condition, range, index)
+      counts = counts_of(site, index)
+      only = condition.fixed[range]
+      only ? counts.merge(only:) : counts
+    end
+
     # The recorded counts of one operand, or zeros.
     def counts_of(site, index)
       @counts.fetch([site, index], NEVER_RAN)

data/lib/condition_coverage/source_lines.rb

@@ -1,3 +1,5 @@
+require_relative 'gaps'
+
 module ConditionCoverage
   # The lines of one file's page, each with the status of the
   # conditions on it.
@@ -58,14 +60,10 @@ module ConditionCoverage
       [one, other].include?(:gaps) ? :gaps : :covered
     end
 
-    # :covered when every operand was seen both ways, else :gaps.
+    # :covered when no operand has a gap, else :gaps.
     def self.status_of(counts)
-      counts.all? { |operand| seen_both?(operand) } ? :covered : :gaps
-    end
-
-    # True when the operand was seen both true and false.
-    def self.seen_both?(counts)
-      counts[:truthy].positive? && counts[:falsy].positive?
+      gaps = counts.flat_map { |operand| Gaps.operand_gap(operand) }
+      gaps.empty? ? :covered : :gaps
     end
 
     # The line a site starts on, from its path:line:column name.

data/lib/condition_coverage/summary.rb

@@ -10,7 +10,7 @@ module ConditionCoverage
     # The summary row of one file's sites.
     def self.row(path, sites)
       operands = sites.flat_map { |_, counts| counts }
-      outcomes = operands.size * 2
+      outcomes = operands.sum { |counts| counts[:only] ? 1 : 2 }
       seen = operands.sum { |counts| seen_in(counts) }
       {
         path:, sites: sites.size, seen:, outcomes:,

data/lib/condition_coverage/version.rb

@@ -1,3 +1,3 @@
 module ConditionCoverage
-  VERSION = '0.0.3'.freeze
+  VERSION = '0.0.4'.freeze
 end

metadata

@@ -1,7 +1,7 @@
 --- !ruby/object:Gem::Specification
 name: condition_coverage
 version: !ruby/object:Gem::Version
-  version: 0.0.3
+  version: 0.0.4
 platform: ruby
 authors:
 - Jon Jagger