condenser-rails 1.2 → 2.0.0.rc1

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: 85ea54efa8084fec3370c9109968566c25fc42e2c1dda0117af935509cdd3d04
-  data.tar.gz: 85d88db655be386be3fb03bcd0fdaf176b032a41d6ef0ee5025de6bfb3215bea
+  metadata.gz: af5ea6490579f3e2d0ad960b7b105ead8d9e65841d5c3554275f77593d9dea40
+  data.tar.gz: 6b3be923f9411e60fa19c16e4e9087210d8251247066e7b560dc8c6f8406ea58
 SHA512:
-  metadata.gz: 32f2939a3411dd310790767e50da0dc331421752082a4f548d7e1c5dc2dffa82e3b5ea559afa9d570fc5398f0eaaa933b61184fad727b11c59162441aa390f69
-  data.tar.gz: bdcb847ece9af49935ec5497d053912e7114871463f1af9573e73441c7500609d7a5a80cd675d7971ae16219e84c76c7e15a3b7fe669f3bc7dcc1c58d2028719
+  metadata.gz: c5b51b307cff02a363c48855bc66741e31b942d8c8ca70a756a1409637d12e6b4a9883fdcc459141d31bba40995cd84bda2932eb321aac8f395ccb1da329ba8d
+  data.tar.gz: 8a6c9793fc11a839dd02898ad2823b57ef051fa3eeb031efdd7bec105d368a145f35466b1d2eed826e811e4da31fc04a51c0f5955891d0cc7ea941b89f0d1edd

data/README.md

@@ -2,15 +2,57 @@
 
 Provides Condenser integration for the Rails Asset Pipeline.
 
+Requires Condenser 2.0, Ruby 3.3 or newer, Rails 8.0 or newer, and Node
+wherever assets are compiled. Upgrading from an earlier version? See
+[Upgrading to Condenser 2](#upgrading-to-condenser-2).
+
 ## Installation
 
 ``` ruby
 gem 'condenser-rails'
+gem 'sass-embedded'                     # Sass and SCSS
+gem 'lightningcss', '>= 1.33.0.2'       # the default CSS minifier
 ```
 
 Or alternatively `require 'condenser/railtie'` in your `config/application.rb`
 if you have Bundler auto-require disabled.
 
+Sass and SCSS are compiled with [Sass Embedded](https://github.com/sass-contrib/sass-embedded-host-ruby).
+CSS is minified with [Lightning CSS](https://lightningcss.dev); `lightningcss`
+isn't needed if `config.assets.css_minifier` is `:sass` or `nil`.
+
+### JavaScript bundling
+
+JavaScript is bundled, and minified, with [Rolldown](https://rolldown.rs) by
+default. Rolldown runs in Node, so Node must be installed wherever assets are
+compiled. The `rolldown` npm package is installed into the npm path
+(`config.assets.npm_path`, `Rails.root` by default) the first time it's needed.
+
+To configure Rolldown, replace the default exporter with a configured
+`Condenser::RolldownProcessor` instance. Registering the class, as in earlier
+versions, no longer works. Pass `minify:` yourself, since it defaults to
+`false`:
+
+``` ruby
+config.assets.configure do |app, env|
+  env.unregister_exporter('application/javascript', Condenser::RolldownProcessor)
+  env.register_exporter('application/javascript', Condenser::RolldownProcessor.new(env.npm_path,
+    minify: !Rails.env.local?,
+    aliases: { 'jquery' => app.root.join('vendor/assets/javascripts/jquery.js').to_s }
+  ))
+end
+```
+
+Rollup is deprecated, and will be removed in Condenser 3.
+To use it instead of Rolldown:
+
+``` ruby
+config.assets.configure do |app, env|
+  env.unregister_exporter('application/javascript')
+  env.register_exporter('application/javascript', Condenser::RollupProcessor)
+end
+```
+
 ## Usage
 
 ### Rake task
@@ -54,15 +96,45 @@ on assets being precompiled to `public/assets` in order to link to them.
 Initializers expecting `Rails.application.assets` during boot should be accessing
 the environment in a `config.assets.configure` block. See below.
 
+**`config.assets.npm_path`**
+
+The directory npm packages, such as `rolldown`, are installed into and loaded
+from. Defaults to `Rails.root`.
+
+**`config.assets.watch`**
+
+Directories, relative to `Rails.root` or absolute, that a running server
+watches for changes to files assets depend on, without adding them to the load
+path. Defaults to `['config']`; missing directories are skipped. A
+`depends_on` path starting with `!` is a file relative to `Rails.root`, and
+only rebuilds a running server's assets when it's under a load path or a
+watched directory:
+
+``` js
+// depends_on !config/foo.yml
+const foo = <%= YAML.load_file(Rails.root.join('config/foo.yml')).to_json %>;
+```
+
+``` ruby
+config.assets.watch << 'data'
+```
+
 **`config.assets.js_minifier`**
 
-The JS minifier to use to minify javascript sources. Default is `:terser`, valid
-options are `:terser`, `:uglify`, and `false` to disable minification.
+The JS minifier to use to minify javascript sources. Valid options are
+`:rolldown` (the default, Rolldown minifies its own output), `:terser`, your own
+minifier, and `false` or `nil` to disable minification. `:terser` runs in Node,
+is npm-installed into the npm path when first used, and turns Rolldown's
+minifier off.
 
 **`config.assets.css_minifier`**
 
-The CSS minifier to use to minify css sources. Default is `:sass`, valid options
-are `:sass`, and `false` to disable minification.
+The CSS minifier to use to minify css sources. Valid options are
+`:lightning_css` (the default, which needs the `lightningcss` gem), `:sass`
+(which needs the `sass-embedded` gem), your own minifier, and `false` or `nil`
+to disable minification.
+
+Assets are only minified outside the `development` and `test` environments.
 
 **`config.assets.compressors`**
 
@@ -81,8 +153,7 @@ access to the environment instance and lets you lazily load libraries only neede
 for asset compiling.
 
 ``` ruby
-config.assets.configure do |env|
-
+config.assets.configure do |app, env|
   require 'my_processor'
   env.register_preprocessor 'application/javascript', MyProcessor
 end
@@ -99,9 +170,33 @@ javascript_include_tag :application, integrity: true
 # => "<script src="/assets/application.js" integrity="sha256-TvVUHzSfftWg1rcfL6TIJ0XKEGrgLyEq6lEpcmrG9qs="></script>"
 ```
 
-Note that `condenser-rails` only adds integrity hashes to assets when served in a
-secure context (over an HTTPS connection or localhost).
+The hash is added whenever `integrity: true` is passed, over HTTP as well as
+HTTPS.
+
+## Upgrading to Condenser 2
+
+- Requires Condenser 2.0, Ruby 3.3 or newer, Rails 8.0 or newer, and Node
+  wherever assets are compiled.
+- Replace `gem 'sassc'` with `gem 'sass-embedded'`, and add
+  `gem 'lightningcss', '>= 1.33.0.2'` unless `config.assets.css_minifier` is
+  `:sass` or `nil`.
+- JavaScript is bundled and minified by Rolldown by default. `:uglify` is
+  removed; `:terser` still works, and turns Rolldown's minifier off.
+- CSS is minified by Lightning CSS by default.
+- A custom Rolldown exporter must be an instance:
+  `Condenser::RolldownProcessor.new(env.npm_path, minify: !Rails.env.local?, …)`.
+- A bare `// depends_on` path that matches nothing now raises
+  `Condenser::FileNotFound` (globs don't). Files relative to the app root need
+  a `!`, e.g. `// depends_on !config/foo.yml`. `config/` is watched by default
+  so a running server picks up changes to them.
+- A JavaScript import that can't be resolved now fails the build.
+- JSON files can be imported from JavaScript, e.g. `import data from 'data.json'`.
+- Sass `@use` and `@import` of npm packages pick the package's stylesheet from
+  its `exports` (`sass` or `style` condition), `sass` or `style` field.
+- A configured `config.assets.npm_path` is now respected instead of being
+  reset to `Rails.root`.
+- Clear `tmp/cache/assets` and `public/assets` after upgrading.
 
 ## License
 
-Condenser Rails is released under the [MIT License](MIT-LICENSE).
+Condenser Rails is released under the [MIT License](LICENSE).

data/lib/condenser/rails/context.rb

@@ -18,7 +18,7 @@ class Condenser
 
       def compute_asset_path(path, options = {})
         if asset = environment.find(path)
-          @dependencies << asset.source_file
+          depend_on(asset)
           File.join(assets_prefix || "/", asset.path)
         else
           super

data/lib/condenser/rails/helper.rb

@@ -32,7 +32,7 @@ module Condenser::Rails
     end
 
     def self.extended(obj)
-      obj.class_eval do
+      obj.singleton_class.class_eval do
         attr_accessor(*VIEW_ACCESSORS)
       end
     end
@@ -97,7 +97,7 @@ module Condenser::Rails
         else
           options["type"]
         end
-        rel = options["type"] == "module" ? "modulepreload" : "preload"
+        rel = type == "module" ? "modulepreload" : "preload"
         
         if use_preload_links_header && !options["defer"] && href.present? && !href.start_with?("data:")
           preload_link = "<#{href}>; rel=#{rel}; as=script"

data/lib/condenser/rails/task.rb

@@ -17,9 +17,8 @@ module Condenser::Rails
 
     def environment
       if app
-        # Use initialized app.assets or force build an environment if
-        # config.assets.compile is disabled
-        app.assets || Condenser::Railtie.build_environment(app)
+        # Its own environment, so compiling never starts a file listener
+        @app_environment ||= Condenser::Railtie.build_environment(app, listen: false)
       else
         super
       end

data/lib/condenser/rails/version.rb

@@ -2,6 +2,6 @@
 
 class Condenser
   module Rails
-    VERSION = "1.2"
+    VERSION = "2.0.0.rc1"
   end
 end

data/lib/condenser/railtie.rb

@@ -43,7 +43,8 @@ module Rails
       app.config.assets.path.unshift(*paths["vendor/assets"].existent_directories)
       app.config.assets.path.unshift(*paths["lib/assets"].existent_directories)
       app.config.assets.path.unshift(*paths["app/assets"].existent_directories)
-      app.config.assets.npm_path = app.root
+      # Runs after the app's config, so keep an npm_path the app set
+      app.config.assets.npm_path ||= app.root
     end
   end
 end
@@ -72,11 +73,19 @@ class Condenser::Railtie < ::Rails::Railtie
   config.assets.digest      = true
   config.assets.cache_limit = 1_000.megabytes
   config.assets.compressors = [:zlib]
+  # Used outside development and test; set to nil or false to disable
+  config.assets.js_minifier  = :rolldown
+  config.assets.css_minifier = :lightning_css
+  # Directories, relative to Rails.root or absolute, whose files can be
+  # `depends_on`'d and rebuild assets when they change
+  config.assets.watch        = ['config']
 
   config.assets.configure do |app, env|
     config.assets.path.each { |path| env.append_path(path) }
-    if config.assets.npm_path && File.directory?(config.assets.npm_path)
-      env.append_npm_path(config.assets.npm_path)
+    # A no-op unless condenser is listening for changes
+    Array(config.assets.watch).each do |path|
+      path = File.expand_path(path, app.root)
+      env.watch(path) if File.directory?(path)
     end
   end
 
@@ -99,9 +108,14 @@ class Condenser::Railtie < ::Rails::Railtie
     Condenser::Rails::Task.new(app)
   end
   
+  # Minifier names that don't camelize to their class name
+  MINIFIERS = {
+    lightning_css: 'Condenser::LightningCSSMinifier'
+  }.freeze
+
   def resolve_minifier(value)
     if value.is_a?(Symbol) || value.is_a?(String)
-      "Condenser::#{value.to_s.camelize}Minifier".constantize
+      (MINIFIERS[value.to_sym] || "Condenser::#{value.to_s.camelize}Minifier").constantize
     else
       value
     end
@@ -115,24 +129,35 @@ class Condenser::Railtie < ::Rails::Railtie
     end
   end
 
-  def build_environment(app, initialized = nil)
+  # listen - Whether condenser watches the asset paths for changes. Default
+  #          only in development and test.
+  def build_environment(app, initialized = nil, listen: ::Rails.env.local?)
     initialized = app.initialized? if initialized.nil?
     unless initialized
       ::Rails.logger.warn "Application uninitialized: Try calling YourApp::Application.initialize!"
     end
 
-    env = Condenser.new(pipeline: false, logger: ::Rails.logger, base: app.root.to_s)
     config = app.config
 
+    # Set the npm path up front so exporters and custom pipelines can use it
+    npm_path = config.assets.npm_path if config.assets.npm_path && File.directory?(config.assets.npm_path)
+    env = Condenser.new(pipeline: false, logger: ::Rails.logger, base: app.root.to_s, npm_path: npm_path, listen: listen)
+
     if config.assets._pipeline
       config.assets._pipeline.call(env)
     else
+      # Only minify outside development and test
+      minify = !::Rails.env.local?
+      js_minifier = config.assets.js_minifier
+      # Rolldown minifies its own output unless another JS minifier is chosen
+      rolldown_minifies = minify && js_minifier.to_s == 'rolldown'
+
       env.register_transformer  'text/scss', 'text/css', Condenser::ScssTransformer.new
       env.register_preprocessor 'application/javascript', Condenser::JSAnalyzer
-      env.register_exporter       'application/javascript', Condenser::RollupProcessor
+      env.register_exporter       'application/javascript', Condenser::RolldownProcessor.new(env.npm_path, minify: rolldown_minifies)
 
-      if ::Rails.env != 'development'
-        env.register_minifier       'application/javascript', resolve_minifier(config.assets.js_minifier) if config.assets.js_minifier
+      if minify
+        env.register_minifier       'application/javascript', resolve_minifier(js_minifier) if js_minifier && !rolldown_minifies
         env.register_minifier       'text/css', resolve_minifier(config.assets.css_minifier) if config.assets.css_minifier
       end
 
@@ -164,7 +189,7 @@ class Condenser::Railtie < ::Rails::Railtie
       app.assets = self.build_environment(app, true)
       require 'condenser/server'
       app.routes.prepend do
-        mount Condenser::Server.new(app.assets, logger: Rails.logger) => config.assets.prefix
+        mount Condenser::Server.new(app.assets, logger: Rails.logger), at: config.assets.prefix
       end
     end
 

metadata

@@ -1,14 +1,13 @@
 --- !ruby/object:Gem::Specification
 name: condenser-rails
 version: !ruby/object:Gem::Version
-  version: '1.2'
+  version: 2.0.0.rc1
 platform: ruby
 authors:
 - Jonathan Bracy
-autorequire:
 bindir: bin
 cert_chain: []
-date: 2025-07-22 00:00:00.000000000 Z
+date: 1980-01-02 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: condenser
@@ -16,56 +15,62 @@ dependencies:
     requirements:
     - - ">="
       - !ruby/object:Gem::Version
-        version: 1.5.1
+        version: 2.0.0.rc1
+    - - "<"
+      - !ruby/object:Gem::Version
+        version: '3'
   type: :runtime
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
     - - ">="
       - !ruby/object:Gem::Version
-        version: 1.5.1
+        version: 2.0.0.rc1
+    - - "<"
+      - !ruby/object:Gem::Version
+        version: '3'
 - !ruby/object:Gem::Dependency
   name: actionpack
   requirement: !ruby/object:Gem::Requirement
     requirements:
     - - ">="
       - !ruby/object:Gem::Version
-        version: '6.0'
+        version: '8.0'
   type: :runtime
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
     - - ">="
       - !ruby/object:Gem::Version
-        version: '6.0'
+        version: '8.0'
 - !ruby/object:Gem::Dependency
   name: activesupport
   requirement: !ruby/object:Gem::Requirement
     requirements:
     - - ">="
       - !ruby/object:Gem::Version
-        version: '6.0'
+        version: '8.0'
   type: :runtime
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
     - - ">="
       - !ruby/object:Gem::Version
-        version: '6.0'
+        version: '8.0'
 - !ruby/object:Gem::Dependency
   name: railties
   requirement: !ruby/object:Gem::Requirement
     requirements:
     - - ">="
       - !ruby/object:Gem::Version
-        version: '6.0'
+        version: '8.0'
   type: :development
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
     - - ">="
       - !ruby/object:Gem::Version
-        version: '6.0'
+        version: '8.0'
 - !ruby/object:Gem::Dependency
   name: rake
   requirement: !ruby/object:Gem::Requirement
@@ -95,7 +100,7 @@ dependencies:
       - !ruby/object:Gem::Version
         version: '0'
 - !ruby/object:Gem::Dependency
-  name: sassc
+  name: sass-embedded
   requirement: !ruby/object:Gem::Requirement
     requirements:
     - - ">="
@@ -108,6 +113,20 @@ dependencies:
     - - ">="
       - !ruby/object:Gem::Version
         version: '0'
+- !ruby/object:Gem::Dependency
+  name: lightningcss
+  requirement: !ruby/object:Gem::Requirement
+    requirements:
+    - - ">="
+      - !ruby/object:Gem::Version
+        version: 1.33.0.2
+  type: :development
+  prerelease: false
+  version_requirements: !ruby/object:Gem::Requirement
+    requirements:
+    - - ">="
+      - !ruby/object:Gem::Version
+        version: 1.33.0.2
 - !ruby/object:Gem::Dependency
   name: minitest-reporters
   requirement: !ruby/object:Gem::Requirement
@@ -122,7 +141,6 @@ dependencies:
     - - ">="
       - !ruby/object:Gem::Version
         version: '0'
-description:
 email: jonbracy@gmail.com
 executables: []
 extensions: []
@@ -141,7 +159,6 @@ homepage: https://github.com/malomalo/condenser-rails
 licenses:
 - MIT
 metadata: {}
-post_install_message:
 rdoc_options: []
 require_paths:
 - lib
@@ -149,15 +166,14 @@ required_ruby_version: !ruby/object:Gem::Requirement
   requirements:
   - - ">="
     - !ruby/object:Gem::Version
-      version: 2.5.0
+      version: 3.3.0
 required_rubygems_version: !ruby/object:Gem::Requirement
   requirements:
   - - ">="
     - !ruby/object:Gem::Version
       version: '0'
 requirements: []
-rubygems_version: 3.5.21
-signing_key:
+rubygems_version: 4.0.11
 specification_version: 4
 summary: Condenser integration for Rails
 test_files: []