concurrent_rails 0.2.1 → 0.4.0

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: a0352c1516c930c65708383fa734cd7444b02b0a213c0ef1f794e5e31f8e1fdf
-  data.tar.gz: 33ec089c95b33ff31a4652a073feac356e8b23a8d7e30bd214ea0a0dbc4aedcb
+  metadata.gz: f546ccc88f5ebbe088d526b38964a490ccbd7ad2e71a540efd8967c0ff608170
+  data.tar.gz: 50cb65d1f7600f44aa900179614c143d5e402e296f80f926eda2233b9c3dc289
 SHA512:
-  metadata.gz: a486a3ab777574962127795db050fd2615b69594d0bc88adb5114368c7d90492f2b51b237817f97118a31969396d53171bf66371240577051977a052d935148a
-  data.tar.gz: db095fe9e33e527a3ade62e8a40aec1866718bfce6b55ef519775cd1761d78b1eb1868d8c8b0ab799dcd05f78980ba16e31f5a7912b87ab3e2dd49d917dab004
+  metadata.gz: 0b33613492e179d066fbc5882140693fee391862241b5f76d6cd18d3fafb9c35079c8ba9eefbca11ede757f491fca51c4433ae207dc584d9ac3f39ebe498eabe
+  data.tar.gz: '0329ed54f4e87a12910dc345993193feff12537ea8fecf9d57125966696cd314deb86fbe3774c306b7a60d23802e2e8e3ac98ef79e56e2a1062d70f406d4dbba'

data/README.md

@@ -2,7 +2,7 @@
 
 ![status](https://github.com/luizkowalski/concurrent_rails/actions/workflows/ruby.yml/badge.svg?branch=master)
 
-Multithread is hard. [concurrent-ruby](https://github.com/ruby-concurrency/concurrent-ruby) did an amazing job implementing the concepts of multithread in the Ruby world. The problem is that Rails doesn't play nice with it. Rails have a complex way of managing threads called Executor and concurrent-ruby (most specifically, [Future](https://github.com/ruby-concurrency/concurrent-ruby/blob/master/docs-source/future.md)) does not work seamlessly with it.
+Multithread is hard. [concurrent-ruby](https://github.com/ruby-concurrency/concurrent-ruby) did an amazing job implementing the concepts of multithread in the Ruby world. The problem is that Rails doesn't play nice with it. Rails has a complex way of managing threads called Executor and concurrent-ruby (most specifically, [Future](https://github.com/ruby-concurrency/concurrent-ruby/blob/master/docs-source/future.md)) does not work seamlessly with it.
 
 The goal of this gem is to provide a simple library that allows the developer to work with Futures without having to care about Rails's Executor and the whole pack of problems that come with it: autoload, thread pools, active record connections, etc.
 
@@ -174,12 +174,12 @@ irb(main):007:0> multi.errors
 It is worth mention that a failed proc will return `nil`.
 
 ## Testing
-If you are using RSpec, you will notice that it might not play well with threads. ActiveRecord opens a database connection for every thread and since RSpec tests are wrapped in a transaction, by the time you promise tries to access something on the database, for example, a user, gems like Database Cleaner probably already triggered and deleted the user, resulting in `ActiveRecord::RecordNotFound` errors. You have a couple of solutions like disable transactional fixtures if you are using it or update the Database Cleaner strategy (that will result in much slower tests).
-Since none of these solutions were satisfactory to me, I created `ConcurrentRails::Testing` with two strategies: `immediate!` and `fake!`. When you wrap a Promise's `future` with `immediate!`, the executor gets replaced from `:io` to `:immediate`. It still returns a promise anyway. This is not the case with `fake!` strategy: it executes the task outside the `ConcurrentRails` engine and returns whatever `.value` would return:
+If you are using RSpec, you will notice that it might not play well with threads. ActiveRecord opens a database connection for every thread and since RSpec tests are wrapped in a transaction, by the time your promise tries to access something on the database, for example, a user, gems like Database Cleaner probably already triggered and deleted the user, resulting in `ActiveRecord::RecordNotFound` errors. You have a couple of solutions like disable transactional fixtures if you are using it or update the Database Cleaner strategy (that will result in much slower tests).
+Since none of these solutions were satisfactory to me, I created `ConcurrentRails::Testing` with two strategies: `immediate` and `fake`. When you wrap a Promise's `future` with `immediate`, the executor gets replaced from `:io` to `:immediate`. It still returns a promise anyway. This is not the case with `fake` strategy: it executes the task outside the `ConcurrentRails` engine and returns whatever `.value` would return:
 
-`immediate!` strategy:
+`immediate` strategy:
 ```ruby
-irb(main):001:1* result = ConcurrentRails::Testing.immediate! do
+irb(main):001:1* result = ConcurrentRails::Testing.immediate do
 irb(main):002:1*       ConcurrentRails::Promises.future { 42 }
 irb(main):003:0> end
 =>
@@ -191,10 +191,10 @@ irb(main):005:0> result.executor
 => :immediate # <-- default executor (:io) gets replaced
 ```
 
-`fake!` strategy:
+`fake` strategy:
 
 ```ruby
-irb(main):001:1* result = ConcurrentRails::Testing.fake! do
+irb(main):001:1* result = ConcurrentRails::Testing.fake do
 irb(main):002:1*       ConcurrentRails::Promises.future { 42 }
 irb(main):003:0> end
 => 42 # <-- yields the task but does not return a Promise
@@ -202,6 +202,8 @@ irb(main):004:0> result.class
 => Integer
 ```
 
+You can also set the stragegy globally using `ConcurrentRails::Testing.fake!` or `ConcurrentRails::Testing.immediate!`
+
 ## Further reading
 
 For more information on how Futures work and how Rails handle multithread check these links:

data/lib/concurrent_rails/{adapters/delay.rb → delay_adapter.rb}

@@ -1,7 +1,7 @@
 # frozen_string_literal: true
 
-module ConcurrentRails::Adapters
-  module Delay
+module ConcurrentRails
+  module DelayAdapter
     extend ActiveSupport::Concern
 
     class_methods do

data/lib/concurrent_rails/{adapters/future.rb → future_adapter.rb}

@@ -1,7 +1,7 @@
 # frozen_string_literal: true
 
-module ConcurrentRails::Adapters
-  module Future
+module ConcurrentRails
+  module FutureAdapter
     extend ActiveSupport::Concern
 
     class_methods do

data/lib/concurrent_rails/promises.rb

@@ -1,13 +1,13 @@
 # frozen_string_literal: true
 
-require 'concurrent_rails/adapters/future'
-require 'concurrent_rails/adapters/delay'
+require 'concurrent_rails/future_adapter'
+require 'concurrent_rails/delay_adapter'
 
 module ConcurrentRails
   class Promises
     include Concurrent::Promises::FactoryMethods
-    include ConcurrentRails::Adapters::Delay
-    include ConcurrentRails::Adapters::Future
+    include ConcurrentRails::DelayAdapter
+    include ConcurrentRails::FutureAdapter
 
     def initialize(executor)
       @executor = executor
@@ -16,7 +16,7 @@ module ConcurrentRails
     %i[value value!].each do |method_name|
       define_method(method_name) do |timeout = nil, timeout_value = nil|
         permit_concurrent_loads do
-          instance.__send__(method_name, timeout, timeout_value)
+          instance.public_send(method_name, timeout, timeout_value)
         end
       end
     end
@@ -25,7 +25,7 @@ module ConcurrentRails
       define_method(chainable) do |*args, &task|
         method = "#{chainable}_on"
         @instance = rails_wrapped do
-          instance.__send__(method, executor, *args, &task)
+          instance.public_send(method, executor, *args, &task)
         end
 
         self

data/lib/concurrent_rails/testing.rb

@@ -5,33 +5,37 @@ module ConcurrentRails
     class << self
       attr_reader :execution_mode
 
-      %i[immediate fake].each do |exec_method|
-        define_method("#{exec_method}!") do |&task|
-          @execution_mode = exec_method
-          result = task.call
+      %w[immediate fake real].each do |test_mode|
+        define_method(test_mode) do |&task|
+          @execution_mode = test_mode
+          result          = task.call
           @execution_mode = :real
 
           result
         end
 
-        define_method("#{exec_method}?") do
-          execution_mode == exec_method
+        define_method("#{test_mode}!") do
+          @execution_mode = test_mode
         end
-      end
 
-      module TestingFuture
-        def future(*args, &task)
-          if ConcurrentRails::Testing.immediate?
-            future_on(:immediate, *args, &task)
-          elsif ConcurrentRails::Testing.fake?
-            yield
-          else
-            super
-          end
+        define_method("#{test_mode}?") do
+          execution_mode == test_mode
         end
       end
+    end
 
-      ConcurrentRails::Promises.extend(TestingFuture)
+    module TestingFuture
+      def future(*args, &task)
+        if ConcurrentRails::Testing.immediate?
+          future_on(:immediate, *args, &task)
+        elsif ConcurrentRails::Testing.fake?
+          yield
+        else
+          super
+        end
+      end
     end
+
+    ConcurrentRails::Promises.extend(TestingFuture)
   end
 end

data/lib/concurrent_rails/version.rb

@@ -1,5 +1,5 @@
 # frozen_string_literal: true
 
 module ConcurrentRails
-  VERSION = '0.2.1'
+  VERSION = '0.4.0'
 end

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: concurrent_rails
 version: !ruby/object:Gem::Version
-  version: 0.2.1
+  version: 0.4.0
 platform: ruby
 authors:
 - Luiz Eduardo Kowalski
 autorequire:
 bindir: bin
 cert_chain: []
-date: 2021-06-15 00:00:00.000000000 Z
+date: 2022-09-10 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: rails
@@ -24,62 +24,76 @@ dependencies:
     - - ">="
       - !ruby/object:Gem::Version
         version: '5.2'
+- !ruby/object:Gem::Dependency
+  name: minitest-reporters
+  requirement: !ruby/object:Gem::Requirement
+    requirements:
+    - - "~>"
+      - !ruby/object:Gem::Version
+        version: '1.5'
+  type: :development
+  prerelease: false
+  version_requirements: !ruby/object:Gem::Requirement
+    requirements:
+    - - "~>"
+      - !ruby/object:Gem::Version
+        version: '1.5'
 - !ruby/object:Gem::Dependency
   name: rubocop
   requirement: !ruby/object:Gem::Requirement
     requirements:
     - - ">="
       - !ruby/object:Gem::Version
-        version: '1.12'
+        version: '1.33'
   type: :development
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
     - - ">="
       - !ruby/object:Gem::Version
-        version: '1.12'
+        version: '1.33'
 - !ruby/object:Gem::Dependency
   name: rubocop-minitest
   requirement: !ruby/object:Gem::Requirement
     requirements:
     - - ">="
       - !ruby/object:Gem::Version
-        version: '0.12'
+        version: '0.21'
   type: :development
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
     - - ">="
       - !ruby/object:Gem::Version
-        version: '0.12'
+        version: '0.21'
 - !ruby/object:Gem::Dependency
   name: rubocop-performance
   requirement: !ruby/object:Gem::Requirement
     requirements:
     - - ">="
       - !ruby/object:Gem::Version
-        version: '1.10'
+        version: '1.14'
   type: :development
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
     - - ">="
       - !ruby/object:Gem::Version
-        version: '1.10'
+        version: '1.14'
 - !ruby/object:Gem::Dependency
-  name: sqlite3
+  name: ruby-lsp
   requirement: !ruby/object:Gem::Requirement
     requirements:
-    - - "~>"
+    - - ">="
       - !ruby/object:Gem::Version
-        version: '1.4'
+        version: '0.3'
   type: :development
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
-    - - "~>"
+    - - ">="
       - !ruby/object:Gem::Version
-        version: '1.4'
+        version: '0.3'
 description: Small library to make concurrent-ruby and Rails play nice together
 email:
 - luizeduardokowalski@gmail.com
@@ -91,9 +105,9 @@ files:
 - README.md
 - Rakefile
 - lib/concurrent_rails.rb
-- lib/concurrent_rails/adapters/delay.rb
-- lib/concurrent_rails/adapters/future.rb
+- lib/concurrent_rails/delay_adapter.rb
 - lib/concurrent_rails/future.rb
+- lib/concurrent_rails/future_adapter.rb
 - lib/concurrent_rails/multi.rb
 - lib/concurrent_rails/promises.rb
 - lib/concurrent_rails/railtie.rb
@@ -103,9 +117,7 @@ homepage: https://github.com/luizkowalski/concurrent_rails
 licenses:
 - MIT
 metadata:
-  homepage_uri: https://github.com/luizkowalski/concurrent_rails
-  source_code_uri: https://github.com/luizkowalski/concurrent_rails
-  changelog_uri: https://github.com/luizkowalski/concurrent_rails/blob/master/CHANGELOG.md
+  rubygems_mfa_required: 'true'
 post_install_message:
 rdoc_options: []
 require_paths:
@@ -114,14 +126,14 @@ required_ruby_version: !ruby/object:Gem::Requirement
   requirements:
   - - ">="
     - !ruby/object:Gem::Version
-      version: '2.6'
+      version: '2.7'
 required_rubygems_version: !ruby/object:Gem::Requirement
   requirements:
   - - ">="
     - !ruby/object:Gem::Version
       version: '0'
 requirements: []
-rubygems_version: 3.2.20
+rubygems_version: 3.3.22
 signing_key:
 specification_version: 4
 summary: Multithread is hard