concurrent_rails 0.1.3 → 0.1.8

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: afa4c6f568f01ea4ada14fabc78e2e47b7c9a8c3f7ddaa3f3cbc8d3c39dad949
-  data.tar.gz: cc4165e43a1a6a48fc0dd2bb5b6154257af0ab4d8c32a3620c61b6425e3f32c1
+  metadata.gz: 257bcdcbd99076d7b73c193297ce5bc410c1fd5962bb823b965b5abbdf21197c
+  data.tar.gz: 5ae2230ba4416193fac70bcd9500673e7d96081491786717eb8d6ce95c938f92
 SHA512:
-  metadata.gz: f68e51f1d5fdc986e4fe70a16beac361f77334727da261ae545dc725f2d9424c9d9b0df7755e7b1e8fb22b010d03db253e1c5206217e13640b246c60c9330177
-  data.tar.gz: d20462ad8cd6a4b72c86e36654441b53b614e0c98684f4c087d5b7fff251e7dbe8f2e4c1627df623d2e332da8c6017b941d0d922160f78c27023ed942f3adf4f
+  metadata.gz: df4405c6f8e8efe155dea24db8a3799955b59c4d3a93118153b557711941c66428027caea64d245df4437be49d3d0482ffb2461bad863b38877e152f57eb6970
+  data.tar.gz: 8c11ffcd0afbeedf533a8da19ca19f79a1e2566e326946f55e699337f45c179a2f245f5b4fd46f62b694a9803ac317cf0bfb6dec95c38285cf3487c5631a4457

data/README.md

@@ -9,7 +9,7 @@ The goal of this gem is to provide a simple library that allows the developer to
 
 ## Usage
 
-This library provides three classes that will help you run tasks in parallel: `ConcurrentRails::Promises`,  `ConcurrentRails::Future` and `ConcurrentRails::Multi`
+This library provides three classes that will help you run tasks in parallel: `ConcurrentRails::Promises`,  `ConcurrentRails::Future` ([in process of being deprecated by concurrent-ruby](https://github.com/ruby-concurrency/concurrent-ruby#deprecated)) and `ConcurrentRails::Multi`
 
 ### Promises
 
@@ -17,26 +17,26 @@ This library provides three classes that will help you run tasks in parallel: `C
 Similar to other classes, all you have to do is call `.future` helper and pass a block:
 
 ```ruby
-irb(main):001:0> future = ConcurrentRails::Promises.future { sleep(5); 42 }
-=> #<ConcurrentRails::Promises:0x00007fe92ea9ff28 @future_instance=#<Con...
+irb(main):001:0> future = ConcurrentRails::Promises.future(5) { |v| sleep(v); 42 }
+=> #<ConcurrentRails::Promises:0x00007fed68db66b0 @future_instance=#<Concurrent::Promises::Future
 
-irb(main):003:0> future.state
+irb(main):002:0> future.state
 => :pending
 
-# After future is processed
-irb(main):004:0> future.state
+# After the process slept for 5 seconds
+irb(main):003:0> future.state
 => :fulfilled
 
-irb(main):005:0> future.value
+irb(main):004:0> future.value
 => 42
 ```
 
 The benefit of `Promises` over a pure `Future` class is that you can chain futures without blocking the main thread.
 
 ```ruby
-irb(main):006:0> future = ConcurrentRails::Promises.future { 42 }.then { |v| v * 2 }
+irb(main):001:0> future = ConcurrentRails::Promises.future { 42 }.then { |v| v * 2 }
 => #<ConcurrentRails::Promises:0x00007fe92eba3460 @future_instance=#...
-irb(main):007:0> future.value
+irb(main):002:0> future.value
 => 84
 ```
 
@@ -143,7 +143,7 @@ For more information on how Futures work and how Rails handle multithread check
 Add this line to your application's Gemfile:
 
 ```ruby
-gem 'concurrent_rails', '~> 0.1.3'
+gem 'concurrent_rails', '~> 0.1.8'
 ```
 
 And then execute:

data/lib/concurrent_rails.rb

@@ -1,10 +1,10 @@
 # frozen_string_literal: true
 
-require 'concurrent_rails/version'
-require 'concurrent_rails/railtie'
 require 'concurrent_rails/future'
 require 'concurrent_rails/multi'
 require 'concurrent_rails/promises'
+require 'concurrent_rails/railtie'
+require 'concurrent_rails/version'
 
 module ConcurrentRails
 end

data/lib/concurrent_rails/future.rb

@@ -4,8 +4,7 @@ module ConcurrentRails
   class Future
     extend Forwardable
 
-    def initialize(executor: :io, &block)
-      @task     = block
+    def initialize(executor: :fast, &block)
       @executor = executor
       @future   = run_on_rails(block)
     end
@@ -16,15 +15,13 @@ module ConcurrentRails
       self
     end
 
-    def value
-      Rails.application.executor.wrap do
-        result = nil
-
-        ActiveSupport::Dependencies.interlock.permit_concurrent_loads do
-          result = future.value
+    %i[value value!].each do |method_name|
+      define_method method_name do
+        rails_wrapped do
+          ActiveSupport::Dependencies.interlock.permit_concurrent_loads do
+            future.__send__(method_name)
+          end
         end
-
-        result
       end
     end
 
@@ -33,13 +30,17 @@ module ConcurrentRails
     private
 
     def run_on_rails(block)
-      @future = Rails.application.executor.wrap do
+      @future = rails_wrapped do
         Concurrent::Future.new(executor: executor) do
-          Rails.application.executor.wrap(&block)
+          rails_wrapped(&block)
         end
       end
     end
 
-    attr_reader :executor, :task, :future
+    def rails_wrapped(&block)
+      Rails.application.executor.wrap(&block)
+    end
+
+    attr_reader :executor, :future
   end
 end

data/lib/concurrent_rails/multi.rb

@@ -30,6 +30,10 @@ module ConcurrentRails
       futures.map(&:value)
     end
 
+    def compute!
+      futures.map(&:value!)
+    end
+
     def complete?
       futures.all?(&:complete?)
     end

data/lib/concurrent_rails/promises.rb

@@ -2,47 +2,60 @@
 
 module ConcurrentRails
   class Promises
-    include Concurrent::Promises::FactoryMethods
     extend Forwardable
+    include Concurrent::Promises::FactoryMethods
 
-    def self.future(*args, &block)
-      new.run_on_rails(*args, &block)
-    end
+    class << self
+      def future(*args, &task)
+        future_on(:fast, *args, &task)
+      end
 
-    def then(*args, &block)
-      @future_instance = Rails.application.executor.wrap do
-        future_instance.then(*args, &block)
+      def future_on(executor, *args, &task)
+        new(executor).run_on_rails(*args, &task)
       end
+    end
 
-      self
+    def initialize(executor)
+      @executor = executor
     end
 
-    %i[value value!].each do |method_name|
-      define_method method_name do
-        Rails.application.executor.wrap do
-          result = nil
+    def run_on_rails(*args, &task)
+      @future_instance = rails_wrapped { future_on(executor, *args, &task) }
 
-          ActiveSupport::Dependencies.interlock.permit_concurrent_loads do
-            result = future_instance.__send__(method_name)
-          end
+      self
+    end
 
-          result
+    %i[then chain].each do |chainable|
+      define_method(chainable) do |*args, &task|
+        method = "#{chainable}_on"
+        @future_instance = rails_wrapped do
+          future_instance.__send__(method, executor, *args, &task)
         end
+
+        self
       end
     end
 
-    def run_on_rails(*args, &block)
-      @future_instance = Rails.application.executor.wrap do
-        future(args, &block)
+    %i[value value!].each do |method_name|
+      define_method(method_name) do |timeout = nil, timeout_value = nil|
+        rails_wrapped do
+          ActiveSupport::Dependencies.interlock.permit_concurrent_loads do
+            future_instance.__send__(method_name, timeout, timeout_value)
+          end
+        end
       end
-
-      self
     end
 
-    def_delegators :@future_instance, :state, :reason, :rejected?, :complete?
+    %i[state reason rejected? resolved? fulfilled?].each do |delegatable|
+      def_delegator :@future_instance, delegatable
+    end
 
     private
 
-    attr_reader :task, :future_instance
+    def rails_wrapped(&block)
+      Rails.application.executor.wrap(&block)
+    end
+
+    attr_reader :future_instance, :executor
   end
 end

data/lib/concurrent_rails/version.rb

@@ -1,5 +1,5 @@
 # frozen_string_literal: true
 
 module ConcurrentRails
-  VERSION = '0.1.3'
+  VERSION = '0.1.8'
 end

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: concurrent_rails
 version: !ruby/object:Gem::Version
-  version: 0.1.3
+  version: 0.1.8
 platform: ruby
 authors:
 - Luiz Eduardo Kowalski
 autorequire:
 bindir: bin
 cert_chain: []
-date: 2021-04-19 00:00:00.000000000 Z
+date: 2021-05-05 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: rails
@@ -68,14 +68,13 @@ files:
 - lib/concurrent_rails/promises.rb
 - lib/concurrent_rails/railtie.rb
 - lib/concurrent_rails/version.rb
-- lib/tasks/concurrent_rails_tasks.rake
 homepage: https://github.com/luizkowalski/concurrent_rails
 licenses:
 - MIT
 metadata:
   homepage_uri: https://github.com/luizkowalski/concurrent_rails
   source_code_uri: https://github.com/luizkowalski/concurrent_rails
-  changelog_uri: https://github.com/luizkowalski/concurrent_rails/CHANGELOG.md
+  changelog_uri: https://github.com/luizkowalski/concurrent_rails/blob/master/CHANGELOG.md
 post_install_message:
 rdoc_options: []
 require_paths:

data/lib/tasks/concurrent_rails_tasks.rake

@@ -1,5 +0,0 @@
-# frozen_string_literal: true
-# desc "Explaining what the task does"
-# task :concurrent_rails do
-#   # Task goes here
-# end