concurrent-ruby 0.8.0 → 0.9.0.pre2

data/lib/concurrent/mvar.rb

@@ -1,39 +1,42 @@
-require 'concurrent/dereferenceable'
-require 'concurrent/atomic/condition'
-require 'concurrent/atomic/event'
+require 'concurrent/concern/dereferenceable'
 
 module Concurrent
 
-  # An `MVar` is a synchronized single element container. They are empty or contain one item.
-  # Taking a value from an empty `MVar` blocks, as does putting a value into a full one.
-  # You can either think of them as blocking queue of length one, or a special kind of
-  # mutable variable. 
-  # 
-  # On top of the fundamental `#put` and `#take` operations, we also provide a `#mutate`
-  # that is atomic with respect to operations on the same instance. These operations all
-  # support timeouts. 
-  # 
-  # We also support non-blocking operations `#try_put!` and `#try_take!`, a `#set!` that
-  # ignores existing values, a `#value` that returns the value without removing it or
-  # returns `MVar::EMPTY`, and a `#modify!` that yields `MVar::EMPTY` if the `MVar` is
-  # empty and can be used to set `MVar::EMPTY`. You shouldn't use these operations in the
-  # first instance. 
-  # 
+  # An `MVar` is a synchronized single element container. They are empty or
+  # contain one item. Taking a value from an empty `MVar` blocks, as does
+  # putting a value into a full one. You can either think of them as blocking
+  # queue of length one, or a special kind of mutable variable.
+  #
+  # On top of the fundamental `#put` and `#take` operations, we also provide a
+  # `#mutate` that is atomic with respect to operations on the same instance.
+  # These operations all support timeouts.
+  #
+  # We also support non-blocking operations `#try_put!` and `#try_take!`, a
+  # `#set!` that ignores existing values, a `#value` that returns the value
+  # without removing it or returns `MVar::EMPTY`, and a `#modify!` that yields
+  # `MVar::EMPTY` if the `MVar` is empty and can be used to set `MVar::EMPTY`.
+  # You shouldn't use these operations in the first instance.
+  #
   # `MVar` is a [Dereferenceable](Dereferenceable).
-  # 
+  #
   # `MVar` is related to M-structures in Id, `MVar` in Haskell and `SyncVar` in Scala.
   #
   # Note that unlike the original Haskell paper, our `#take` is blocking. This is how
   # Haskell and Scala do it today.
-  # 
-  # **See Also:**
-  # 
-  # 1. P. Barth, R. Nikhil, and Arvind. [M-Structures: Extending a parallel, non-
-  # strict, functional language with state](http://dl.acm.org/citation.cfm?id=652538). In Proceedings of the 5th ACM Conference on Functional Programming Languages and Computer Architecture (FPCA), 1991.
-  # 2. S. Peyton Jones, A. Gordon, and S. Finne. [Concurrent Haskell](http://dl.acm.org/citation.cfm?id=237794). In Proceedings of the 23rd Symposium on Principles of Programming Languages (PoPL), 1996.
+  #
+  # @!macro copy_options
+  #
+  # ## See Also
+  #
+  # 1. P. Barth, R. Nikhil, and Arvind. [M-Structures: Extending a parallel, non- strict, functional language with state](http://dl.acm.org/citation.cfm?id=652538). In Proceedings of the 5th
+  #    ACM Conference on Functional Programming Languages and Computer Architecture (FPCA), 1991.
+  #
+  # 2. S. Peyton Jones, A. Gordon, and S. Finne. [Concurrent Haskell](http://dl.acm.org/citation.cfm?id=237794).
+  #    In Proceedings of the 23rd Symposium on Principles of Programming Languages
+  #    (PoPL), 1996.
   class MVar
 
-    include Dereferenceable
+    include Concern::Dereferenceable
 
     # Unique value that represents that an `MVar` was empty
     EMPTY = Object.new
@@ -45,20 +48,13 @@ module Concurrent
     # Create a new `MVar`, either empty or with an initial value.
     #
     # @param [Hash] opts the options controlling how the future will be processed
-    # @option opts [Boolean] :operation (false) when `true` will execute the future on the global
-    #   operation pool (for long-running operations), when `false` will execute the future on the
-    #   global task pool (for short-running tasks)
-    # @option opts [object] :executor when provided will run all operations on
-    #   this executor rather than the global thread pool (overrides :operation)
-    # @option opts [String] :dup_on_deref (false) call `#dup` before returning the data
-    # @option opts [String] :freeze_on_deref (false) call `#freeze` before returning the data
-    # @option opts [String] :copy_on_deref (nil) call the given `Proc` passing the internal value and
-    #   returning the value returned from the proc
+    #
+    # @!macro deref_options
     def initialize(value = EMPTY, opts = {})
       @value = value
       @mutex = Mutex.new
-      @empty_condition = Condition.new
-      @full_condition = Condition.new
+      @empty_condition = ConditionVariable.new
+      @full_condition = ConditionVariable.new
       set_deref_options(opts)
     end
 
@@ -184,7 +180,7 @@ module Concurrent
 
     # Returns if the `MVar` currently contains a value.
     def full?
-      not empty?
+      !empty?
     end
 
     private
@@ -206,12 +202,17 @@ module Concurrent
     end
 
     def wait_while(condition, timeout)
-      remaining = Condition::Result.new(timeout)
-      while yield && remaining.can_wait?
-        remaining = condition.wait(@mutex, remaining.remaining_time)
+      if timeout.nil?
+        while yield
+          condition.wait(@mutex)
+        end
+      else
+        stop = Concurrent.monotonic_time + timeout
+        while yield && timeout > 0.0
+          condition.wait(@mutex, timeout)
+          timeout = stop - Concurrent.monotonic_time
+        end
       end
     end
-
   end
-
 end

data/lib/concurrent/promise.rb

@@ -1,7 +1,7 @@
 require 'thread'
-
-require 'concurrent/obligation'
-require 'concurrent/options_parser'
+require 'concurrent/errors'
+require 'concurrent/ivar'
+require 'concurrent/executor/executor'
 
 module Concurrent
 
@@ -9,221 +9,236 @@ module Concurrent
 
   # Promises are inspired by the JavaScript [Promises/A](http://wiki.commonjs.org/wiki/Promises/A)
   # and [Promises/A+](http://promises-aplus.github.io/promises-spec/) specifications.
-  # 
-  # > A promise represents the eventual value returned from the single completion of an operation.
-  # 
-  # Promises are similar to futures and share many of the same behaviours. Promises are far more
-  # robust, however. Promises can be chained in a tree structure where each promise may have zero
-  # or more children. Promises are chained using the `then` method. The result of a call to `then`
-  # is always another promise. Promises are resolved asynchronously (with respect to the main thread)
-  # but in a strict order: parents are guaranteed to be resolved before their children, children
-  # before their younger siblings. The `then` method takes two parameters: an optional block to
-  # be executed upon parent resolution and an optional callable to be executed upon parent failure.
-  # The result of each promise is passed to each of its children upon resolution. When a promise
-  # is rejected all its children will be summarily rejected and will receive the reason. 
-  # 
-  # Promises have four possible states: *unscheduled*, *pending*, *rejected*, and *fulfilled*. A
-  # Promise created using `.new` will be *unscheduled*. It is scheduled by calling the `execute`
-  # method. Upon execution the Promise and all its children will be set to *pending*. When a promise
-  # is *pending* it will remain in that state until processing is complete. A completed Promise is
-  # either *rejected*, indicating that an exception was thrown during processing, or *fulfilled*,
-  # indicating it succeeded. If a Promise is *fulfilled* its `value` will be updated to reflect
-  # the result of the operation. If *rejected* the `reason` will be updated with a reference to
-  # the thrown exception. The predicate methods `unscheduled?`, `pending?`, `rejected?`, and
-  # `fulfilled?` can be called at any time to obtain the state of the Promise, as can the `state`
-  # method, which returns a symbol. A Promise created using `.execute` will be *pending*, a Promise
-  # created using `.fulfill(value)` will be *fulfilled* with the given value and a Promise created
-  # using `.reject(reason)` will be *rejected* with the given reason. 
-  # 
-  # Retrieving the value of a promise is done through the `value` (alias: `deref`) method. Obtaining
-  # the value of a promise is a potentially blocking operation. When a promise is *rejected* a call
-  # to `value` will return `nil` immediately. When a promise is *fulfilled* a call to `value` will
-  # immediately return the current value. When a promise is *pending* a call to `value` will block
-  # until the promise is either *rejected* or *fulfilled*. A *timeout* value can be passed to `value`
-  # to limit how long the call will block. If `nil` the call will block indefinitely. If `0` the call
-  # will not block. Any other integer or float value will indicate the maximum number of seconds to block. 
-  # 
+  #
+  # > A promise represents the eventual value returned from the single
+  # > completion of an operation.
+  #
+  # Promises are similar to futures and share many of the same behaviours.
+  # Promises are far more robust, however. Promises can be chained in a tree
+  # structure where each promise may have zero or more children. Promises are
+  # chained using the `then` method. The result of a call to `then` is always
+  # another promise. Promises are resolved asynchronously (with respect to the
+  # main thread) but in a strict order: parents are guaranteed to be resolved
+  # before their children, children before their younger siblings. The `then`
+  # method takes two parameters: an optional block to be executed upon parent
+  # resolution and an optional callable to be executed upon parent failure. The
+  # result of each promise is passed to each of its children upon resolution.
+  # When a promise is rejected all its children will be summarily rejected and
+  # will receive the reason.
+  #
+  # Promises have four possible states: *unscheduled*, *pending*, *rejected*,
+  # and *fulfilled*. A Promise created using `.new` will be *unscheduled*. It is
+  # scheduled by calling the `execute` method. Upon execution the Promise and
+  # all its children will be set to *pending*. When a promise is *pending* it
+  # will remain in that state until processing is complete. A completed Promise
+  # is either *rejected*, indicating that an exception was thrown during
+  # processing, or *fulfilled*, indicating it succeeded. If a Promise is
+  # *fulfilled* its `value` will be updated to reflect the result of the
+  # operation. If *rejected* the `reason` will be updated with a reference to
+  # the thrown exception. The predicate methods `unscheduled?`, `pending?`,
+  # `rejected?`, and `fulfilled?` can be called at any time to obtain the state
+  # of the Promise, as can the `state` method, which returns a symbol. A Promise
+  # created using `.execute` will be *pending*, a Promise created using
+  # `.fulfill(value)` will be *fulfilled* with the given value and a Promise
+  # created using `.reject(reason)` will be *rejected* with the given reason.
+  #
+  # Retrieving the value of a promise is done through the `value` (alias:
+  # `deref`) method. Obtaining the value of a promise is a potentially blocking
+  # operation. When a promise is *rejected* a call to `value` will return `nil`
+  # immediately. When a promise is *fulfilled* a call to `value` will
+  # immediately return the current value. When a promise is *pending* a call to
+  # `value` will block until the promise is either *rejected* or *fulfilled*. A
+  # *timeout* value can be passed to `value` to limit how long the call will
+  # block. If `nil` the call will block indefinitely. If `0` the call will not
+  # block. Any other integer or float value will indicate the maximum number of
+  # seconds to block.
+  #
   # Promises run on the global thread pool.
-  # 
+  #
+  # @!macro copy_options
+  #
   # ### Examples
-  # 
+  #
   # Start by requiring promises
-  # 
+  #
   # ```ruby
   # require 'concurrent'
   # ```
-  # 
+  #
   # Then create one
-  # 
+  #
   # ```ruby
   # p = Concurrent::Promise.execute do
   #       # do something
   #       42
   #     end
   # ```
-  # 
-  # Promises can be chained using the `then` method. The `then` method accepts a block, to be executed
-  # on fulfillment, and a callable argument to be executed on rejection. The result of the each promise
-  # is passed as the block argument to chained promises. 
-  # 
+  #
+  # Promises can be chained using the `then` method. The `then` method accepts a
+  # block, to be executed on fulfillment, and a callable argument to be executed
+  # on rejection. The result of the each promise is passed as the block argument
+  # to chained promises.
+  #
   # ```ruby
   # p = Concurrent::Promise.new{10}.then{|x| x * 2}.then{|result| result - 10 }.execute
   # ```
-  # 
+  #
   # And so on, and so on, and so on...
-  # 
+  #
   # ```ruby
   # p = Concurrent::Promise.fulfill(20).
   #     then{|result| result - 10 }.
   #     then{|result| result * 3 }.
   #     then{|result| result % 5 }.execute
   # ```
-  # 
+  #
   # The initial state of a newly created Promise depends on the state of its parent:
   # - if parent is *unscheduled* the child will be *unscheduled*
   # - if parent is *pending* the child will be *pending*
   # - if parent is *fulfilled* the child will be *pending*
   # - if parent is *rejected* the child will be *pending* (but will ultimately be *rejected*)
-  # 
-  # Promises are executed asynchronously from the main thread. By the time a child Promise finishes 
-  # nitialization it may be in a different state that its parent (by the time a child is created its parent
-  # may have completed execution and changed state). Despite being asynchronous, however, the order of
-  # execution of Promise objects in a chain (or tree) is strictly defined. 
-  # 
-  # There are multiple ways to create and execute a new `Promise`. Both ways provide identical behavior:
-  # 
+  #
+  # Promises are executed asynchronously from the main thread. By the time a
+  # child Promise finishes nitialization it may be in a different state that its
+  # parent (by the time a child is created its parent may have completed
+  # execution and changed state). Despite being asynchronous, however, the order
+  # of execution of Promise objects in a chain (or tree) is strictly defined.
+  #
+  # There are multiple ways to create and execute a new `Promise`. Both ways
+  # provide identical behavior:
+  #
   # ```ruby
   # # create, operate, then execute
   # p1 = Concurrent::Promise.new{ "Hello World!" }
   # p1.state #=> :unscheduled
   # p1.execute
-  # 
+  #
   # # create and immediately execute
   # p2 = Concurrent::Promise.new{ "Hello World!" }.execute
-  # 
+  #
   # # execute during creation
   # p3 = Concurrent::Promise.execute{ "Hello World!" }
   # ```
-  # 
+  #
   # Once the `execute` method is called a `Promise` becomes `pending`:
-  # 
+  #
   # ```ruby
   # p = Concurrent::Promise.execute{ "Hello, world!" }
   # p.state    #=> :pending
   # p.pending? #=> true
   # ```
-  # 
+  #
   # Wait a little bit, and the promise will resolve and provide a value:
-  # 
+  #
   # ```ruby
   # p = Concurrent::Promise.execute{ "Hello, world!" }
   # sleep(0.1)
-  # 
+  #
   # p.state      #=> :fulfilled
   # p.fulfilled? #=> true
   # p.value      #=> "Hello, world!"
   # ```
-  # 
+  #
   # If an exception occurs, the promise will be rejected and will provide
   # a reason for the rejection:
-  # 
+  #
   # ```ruby
   # p = Concurrent::Promise.execute{ raise StandardError.new("Here comes the Boom!") }
   # sleep(0.1)
-  # 
+  #
   # p.state     #=> :rejected
   # p.rejected? #=> true
   # p.reason    #=> "#<StandardError: Here comes the Boom!>"
   # ```
-  # 
+  #
   # #### Rejection
-  # 
-  # When a promise is rejected all its children will be rejected and will receive the rejection `reason`
-  # as the rejection callable parameter:
-  # 
+  #
+  # When a promise is rejected all its children will be rejected and will
+  # receive the rejection `reason` as the rejection callable parameter:
+  #
   # ```ruby
   # p = [ Concurrent::Promise.execute{ Thread.pass; raise StandardError } ]
-  # 
+  #
   # c1 = p.then(Proc.new{ |reason| 42 })
   # c2 = p.then(Proc.new{ |reason| raise 'Boom!' })
-  # 
+  #
   # sleep(0.1)
-  # 
+  #
   # c1.state  #=> :rejected
   # c2.state  #=> :rejected
   # ```
-  # 
-  # Once a promise is rejected it will continue to accept children that will receive immediately rejection
-  # (they will be executed asynchronously).
-  # 
+  #
+  # Once a promise is rejected it will continue to accept children that will
+  # receive immediately rejection (they will be executed asynchronously).
+  #
   # #### Aliases
-  # 
-  # The `then` method is the most generic alias: it accepts a block to be executed upon parent fulfillment
-  # and a callable to be executed upon parent rejection. At least one of them should be passed. The default
-  # block is `{ |result| result }` that fulfills the child with the parent value. The default callable is
-  # `{ |reason| raise reason }` that rejects the child with the parent reason. 
-  # 
+  #
+  # The `then` method is the most generic alias: it accepts a block to be
+  # executed upon parent fulfillment and a callable to be executed upon parent
+  # rejection. At least one of them should be passed. The default block is `{
+  # |result| result }` that fulfills the child with the parent value. The
+  # default callable is `{ |reason| raise reason }` that rejects the child with
+  # the parent reason.
+  #
   # - `on_success { |result| ... }` is the same as `then {|result| ... }`
   # - `rescue { |reason| ... }` is the same as `then(Proc.new { |reason| ... } )`
   # - `rescue` is aliased by `catch` and `on_error`
-  class Promise
-    # TODO unify promise and future to single class, with dataflow
-    include Obligation
+  class Promise < IVar
 
     # Initialize a new Promise with the provided options.
     #
-    # @!macro [attach] promise_init_options
+    # @!macro executor_and_deref_options
     #
-    #   @param [Hash] opts the options used to define the behavior at update and deref
+    # @!macro [attach] promise_init_options
     #
     #   @option opts [Promise] :parent the parent `Promise` when building a chain/tree
     #   @option opts [Proc] :on_fulfill fulfillment handler
     #   @option opts [Proc] :on_reject rejection handler
+    #   @option opts [object, Array] :args zero or more arguments to be passed
+    #    the task block on execution
     #
-    #   @option opts [Boolean] :operation (false) when `true` will execute the future on the global
-    #     operation pool (for long-running operations), when `false` will execute the future on the
-    #     global task pool (for short-running tasks)
-    #   @option opts [object] :executor when provided will run all operations on
-    #     this executor rather than the global thread pool (overrides :operation)
-    #   @option opts [object, Array] :args zero or more arguments to be passed the task block on execution
+    # @yield The block operation to be performed asynchronously.
     #
-    #   @option opts [String] :dup_on_deref (false) call `#dup` before returning the data
-    #   @option opts [String] :freeze_on_deref (false) call `#freeze` before returning the data
-    #   @option opts [String] :copy_on_deref (nil) call the given `Proc` passing the internal value and
-    #     returning the value returned from the proc
+    # @raise [ArgumentError] if no block is given
     #
     # @see http://wiki.commonjs.org/wiki/Promises/A
     # @see http://promises-aplus.github.io/promises-spec/
     def initialize(opts = {}, &block)
       opts.delete_if { |k, v| v.nil? }
-
-      @executor = OptionsParser::get_executor_from(opts) || Concurrent.configuration.global_operation_pool
-      @args = OptionsParser::get_arguments_from(opts)
-
-      @parent = opts.fetch(:parent) { nil }
-      @on_fulfill = opts.fetch(:on_fulfill) { Proc.new { |result| result } }
-      @on_reject = opts.fetch(:on_reject) { Proc.new { |reason| raise reason } }
-
-      @promise_body = block || Proc.new { |result| result }
-      @state = :unscheduled
-      @children = []
-
-      init_obligation
-      set_deref_options(opts)
+      super(IVar::NO_VALUE, opts.merge(__promise_body_from_block__: block), &nil)
     end
 
-    # @return [Promise]
+    # Create a new `Promise` and fulfill it immediately.
+    #
+    # @!macro executor_and_deref_options
+    #
+    # @!macro promise_init_options
+    #
+    # @raise [ArgumentError] if no block is given
+    #
+    # @return [Promise] the newly created `Promise`
     def self.fulfill(value, opts = {})
       Promise.new(opts).tap { |p| p.send(:synchronized_set_state!, true, value, nil) }
     end
 
-
-    # @return [Promise]
+    # Create a new `Promise` and reject it immediately.
+    #
+    # @!macro executor_and_deref_options
+    #
+    # @!macro promise_init_options
+    #
+    # @raise [ArgumentError] if no block is given
+    #
+    # @return [Promise] the newly created `Promise`
     def self.reject(reason, opts = {})
       Promise.new(opts).tap { |p| p.send(:synchronized_set_state!, false, nil, reason) }
     end
 
-    # @return [Promise]
+    # Execute an `:unscheduled` `Promise`. Immediately sets the state to `:pending` and
+    # passes the block to a new thread/thread pool for eventual execution.
+    # Does nothing if the `Promise` is in any state other than `:unscheduled`.
+    #
+    # @return [Promise] a reference to `self`
     def execute
       if root?
         if compare_and_set_state(:pending, :unscheduled)
@@ -236,9 +251,34 @@ module Concurrent
       self
     end
 
+    # @!macro ivar_set_method
+    #
+    # @raise [Concurrent::PromiseExecutionError] if not the root promise
+    def set(value = IVar::NO_VALUE, &block)
+      raise PromiseExecutionError.new('supported only on root promise') unless root?
+      check_for_block_or_value!(block_given?, value)
+      synchronize do
+        if @state != :unscheduled
+          raise MultipleAssignmentError
+        else
+          @promise_body = block || Proc.new { |result| value }
+        end
+      end
+      execute
+    end
+
+    # @!macro ivar_fail_method
+    #
+    # @raise [Concurrent::PromiseExecutionError] if not the root promise
+    def fail(reason = StandardError.new)
+      set { raise reason }
+    end
+
     # Create a new `Promise` object with the given block, execute it, and return the
     # `:pending` object.
     #
+    # @!macro executor_and_deref_options
+    #
     # @!macro promise_init_options
     #
     # @return [Promise] the newly created `Promise` in the `:pending` state
@@ -252,6 +292,13 @@ module Concurrent
       new(opts, &block).execute
     end
 
+    # Chain a new promise off the current promise.
+    #
+    # @param [Proc] rescuer An optional rescue block to be executed if the
+    #   promise is rejected.
+    #
+    # @yield The block operation to be performed asynchronously.
+    #
     # @return [Promise] the new promise
     def then(rescuer = nil, &block)
       raise ArgumentError.new('rescuers and block are both missing') if rescuer.nil? && !block_given?
@@ -263,7 +310,7 @@ module Concurrent
         on_reject: rescuer
       )
 
-      mutex.synchronize do
+      synchronize do
         child.state = :pending if @state == :pending
         child.on_fulfill(apply_deref_options(@value)) if @state == :fulfilled
         child.on_reject(@reason) if @state == :rejected
@@ -273,13 +320,23 @@ module Concurrent
       child
     end
 
-    # @return [Promise]
+    # Chain onto this promise an action to be undertaken on success
+    # (fulfillment).
+    #
+    # @yield The block to execute
+    #
+    # @return [Promise] self
     def on_success(&block)
       raise ArgumentError.new('no block given') unless block_given?
       self.then(&block)
     end
 
-    # @return [Promise]
+    # Chain onto this promise an action to be undertaken on failure
+    # (rejection).
+    #
+    # @yield The block to execute
+    #
+    # @return [Promise] self
     def rescue(&block)
       self.then(block)
     end
@@ -381,6 +438,21 @@ module Concurrent
 
     protected
 
+    def ns_initialize(value, opts)
+      super
+
+      @executor = Executor.executor_from_options(opts) || Concurrent.global_io_executor
+      @args = get_arguments_from(opts)
+
+      @parent = opts.fetch(:parent) { nil }
+      @on_fulfill = opts.fetch(:on_fulfill) { Proc.new { |result| result } }
+      @on_reject = opts.fetch(:on_reject) { Proc.new { |reason| raise reason } }
+
+      @promise_body = opts[:__promise_body_from_block__] || Proc.new { |result| result }
+      @state = :unscheduled
+      @children = []
+    end
+
     # Aggregate a collection of zero or more promises under a composite promise,
     # execute the aggregated promises and collect them into a standard Ruby array,
     # call the given Ruby `Ennnumerable` predicate (such as `any?`, `all?`, `none?`,
@@ -406,7 +478,7 @@ module Concurrent
 
     # @!visibility private
     def set_pending
-      mutex.synchronize do
+      synchronize do
         @state = :pending
         @children.each { |c| c.set_pending }
       end
@@ -435,17 +507,22 @@ module Concurrent
       if_state(:rejected) { child.on_reject(@reason) }
     end
 
+    # @!visibility private
+    def complete(success, value, reason)
+      children_to_notify = synchronize do
+        set_state!(success, value, reason)
+        @children.dup
+      end
+
+      children_to_notify.each { |child| notify_child(child) }
+      observers.notify_and_delete_observers{ [Time.now, self.value, reason] }
+    end
+
     # @!visibility private
     def realize(task)
       @executor.post do
         success, value, reason = SafeTaskExecutor.new(task).execute(*@args)
-
-        children_to_notify = mutex.synchronize do
-          set_state!(success, value, reason)
-          @children.dup
-        end
-
-        children_to_notify.each { |child| notify_child(child) }
+        complete(success, value, reason)
       end
     end
 
@@ -457,10 +534,7 @@ module Concurrent
 
     # @!visibility private
     def synchronized_set_state!(success, value, reason)
-      mutex.lock
-      set_state!(success, value, reason)
-    ensure
-      mutex.unlock
+      synchronize { set_state!(success, value, reason) }
     end
   end
 end