concord 0.0.3 → 0.1.0

data/Changelog.md

@@ -1,3 +1,7 @@
+# v0.1.0 2013-05-15
+
+* [change] Set default attribute visibility to protected
+
 # v0.0.3 2013-03-08
 
 * [fix] 1.9.2 visibility problem

data/Gemfile.devtools

@@ -1,27 +1,26 @@
 # encoding: utf-8
 
 group :development do
-  gem 'rake',  '~> 10.0.3'
+  gem 'rake',  '~> 10.0.4'
   gem 'rspec', '~> 2.13.0'
-  gem 'yard',  '~> 0.8.5'
+  gem 'yard',  '~> 0.8.6.1'
 end
 
 group :yard do
-  gem 'kramdown', '~> 0.14.2'
+  gem 'kramdown', '~> 1.0.1'
 end
 
 group :guard do
-  gem 'guard',         '~> 1.6.2'
+  gem 'guard',         '~> 1.8.0'
   gem 'guard-bundler', '~> 1.0.0'
-  gem 'guard-rspec',   '~> 2.4.1'
+  gem 'guard-rspec',   '~> 2.5.4'
 
   # file system change event handling
+  gem 'listen',     '~> 1.0.2'
   gem 'rb-fchange', '~> 0.0.6', :require => false
   gem 'rb-fsevent', '~> 0.9.3', :require => false
   gem 'rb-inotify', '~> 0.9.0', :require => false
 
-  gem 'listen', '~> 0.7.3'
-
   # notification handling
   gem 'libnotify',               '~> 0.8.0', :require => false
   gem 'rb-notifu',               '~> 0.0.4', :require => false
@@ -29,14 +28,15 @@ group :guard do
 end
 
 group :metrics do
-  gem 'flay',            '~> 2.1.0'
-  gem 'flog',            '~> 3.2.2'
+  gem 'backports',       '~> 3.3', '>= 3.3.0'
+  gem 'coveralls',       '~> 0.6.6'
+  gem 'flay',            '~> 2.2.0'
+  gem 'flog',            '~> 4.0.0'
   gem 'reek',            '~> 1.3.1', :git => 'https://github.com/troessner/reek.git'
-  gem 'metric_fu-roodi', '~> 2.2.1'
-  gem 'yardstick',       '~> 0.9.4'
+  gem 'simplecov',       '~> 0.7.1'
+  gem 'yardstick',       '~> 0.9.6'
 
-  platforms :ruby_18, :ruby_19 do
-    # this indirectly depends on ffi which does not build on ruby-head
+  platforms :ruby_19 do
     gem 'yard-spellcheck', '~> 0.1.5'
   end
 
@@ -44,10 +44,6 @@ group :metrics do
     gem 'mutant', '~> 0.2.20'
   end
 
-  platforms :mri_19 do
-    gem 'simplecov', '~> 0.7.1'
-  end
-
   platforms :rbx do
     gem 'pelusa', '~> 0.2.2'
   end
@@ -59,6 +55,6 @@ end
 
 platform :jruby do
   group :jruby do
-    gem 'jruby-openssl', '~> 0.8.2'
+    gem 'jruby-openssl', '~> 0.8.5'
   end
 end

data/README.md

@@ -18,6 +18,7 @@ class ComposedObject
   # @api private
   #
   attr_reader :foo
+  protected :foo
 
   # Return bar
   #
@@ -26,6 +27,7 @@ class ComposedObject
   # @api private
   #
   attr_reader :bar
+  protected :bar
 
   # Initialize object
   #

data/concord.gemspec

@@ -2,7 +2,7 @@
 
 Gem::Specification.new do |s|
   s.name        = 'concord'
-  s.version     = '0.0.3'
+  s.version     = '0.1.0'
   s.authors     = ['Markus Schirp']
   s.email       = ['mbj@seonic.net']
   s.homepage    = 'https://github.com/mbj/composition'

data/config/flay.yml

@@ -1,3 +1,3 @@
 ---
-threshold: 2
-total_score: 8.0
+threshold: 5
+total_score: 13.0

data/config/{site.reek → reek.yml}

@@ -6,7 +6,7 @@ UncommunicativeParameterName:
   - !ruby/regexp /^.$/
   - !ruby/regexp /[0-9]$/
   - !ruby/regexp /[A-Z]/
-LargeClass:
+TooManyMethods:
   max_methods: 14
   enabled: true
   exclude: []
@@ -49,11 +49,11 @@ NestedIterators:
   exclude: []
   enabled: true
   max_allowed_nesting: 1
-LongMethod:
+TooManyStatements:
   max_statements: 5
   exclude: []
   enabled: true
-Duplication:
+DuplicateMethodCall:
   allow_calls: []
   exclude: []
   enabled: true
@@ -81,7 +81,7 @@ DataClump:
   enabled: true
   max_copies: 0
   min_clump_size: 2
-ControlCouple:
+ControlParameter:
   exclude: []
   enabled: true
 LongYieldList:

data/lib/concord.rb

@@ -66,7 +66,7 @@ private
   def define_readers(descendant)
     attribute_names = names
     descendant.send(:attr_reader, *attribute_names)
-    descendant.send(:public, *attribute_names)
+    descendant.send(:protected, *attribute_names)
   end
 
   # Define initializer

data/spec/unit/concord/universal_spec.rb

@@ -19,21 +19,29 @@ describe Concord do
     unless Devtools.jruby?
       it 'sets initializer correctly' do
         klass = Class.new
-        # Nicher way to assert this?
+        # Nicer way to assert this?
         klass.should_receive(:class_eval) do |code, file, line|
           file.should eql(File.expand_path('../../../../lib/concord.rb', __FILE__))
-          line.should be(82)
+          line.should be(83)
         end
         klass.send(:include, Concord.new)
       end
     end
   end
 
+  context 'visibiluty' do
+    it 'should set attribute readers to public' do
+      klass = Class.new
+      klass.send(:include, Concord.new(:foo))
+      klass.protected_instance_methods.map(&:to_sym).should == [:foo]
+    end
+  end
+
   context 'attribute behavior' do
     subject { instance_a }
 
-    its(:foo) { should be(foo) }
-    its(:bar) { should be(bar) }
+    specify { subject.send(:foo).should be(foo) }
+    specify { subject.send(:bar).should be(bar) }
   end
 
   context 'equalization behavior' do

metadata

@@ -1,7 +1,7 @@
 --- !ruby/object:Gem::Specification
 name: concord
 version: !ruby/object:Gem::Version
-  version: 0.0.3
+  version: 0.1.0
   prerelease: 
 platform: ruby
 authors:
@@ -9,7 +9,7 @@ authors:
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2013-03-08 00:00:00.000000000 Z
+date: 2013-05-15 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: adamantium
@@ -64,8 +64,8 @@ files:
 - config/flay.yml
 - config/flog.yml
 - config/mutant.yml
+- config/reek.yml
 - config/roodi.yml
-- config/site.reek
 - config/yardstick.yml
 - lib/concord.rb
 - spec/spec_helper.rb