concealer 0.0.2 → 0.1.0

data/.gitignore

@@ -1,2 +1,3 @@
 Gemfile.lock
-pkg/*
+pkg/*
+doc/*

data/.travis.yml

@@ -0,0 +1,8 @@
+rvm:
+  - ruby-head
+  - 1.9.2
+  - 1.8.7
+  - ree
+  - jruby
+  - rbx
+  - rbx-2.0.0pre

data/Rakefile

@@ -2,9 +2,21 @@ require 'bundler'
 require 'bundler/setup'
 
 require 'rspec/core/rake_task'
+require 'rdoc/task'
 
 Bundler::GemHelper.install_tasks
 
+spec = Gem::Specification.load("concealer.gemspec")
+
 RSpec::Core::RakeTask.new(:spec)
 
+RDoc::Task.new do |rdoc|
+  rdoc.rdoc_dir = 'doc'
+  rdoc.main = "README.rdoc"
+  rdoc.options += spec.rdoc_options
+  rdoc.rdoc_files.include(spec.extra_rdoc_files)
+  rdoc.rdoc_files.include('lib/**/*.rb')
+  rdoc.title = "#{spec.name} #{spec.version}"
+end
+
 task :default => :spec

data/concealer.gemspec

@@ -1,4 +1,5 @@
-# -*- encoding: utf-8 -*-
+# encoding: UTF-8
+
 $:.push File.expand_path("../lib", __FILE__)
 require "concealer/version"
 
@@ -19,6 +20,6 @@ Gem::Specification.new do |s|
 
   s.add_runtime_dependency('activesupport', ['~> 3.0'])
 
-  s.add_development_dependency('rspec', ['~> 2.3'])
+  s.add_development_dependency('rspec', ['~> 2.6'])
   s.add_development_dependency('rake')
 end

data/lib/concealer.rb

@@ -9,34 +9,70 @@ module Concealer
   autoload :Strategy, 'concealer/strategy'
   autoload :Fallback, 'concealer/fallback'
 
+  ##
+  # :singleton-method: default_fallback=
+  # :call-seq:
+  #   default_fallback=(fallback)
+  #
+
+  ##
+  # :singleton-method: default_fallback
+  # Returns the set default fallback. If not explicitly set to something else
+  # it is Concealer::Fallback::Nil.
   mattr_accessor :default_fallback
   @@default_fallback = Concealer::Fallback::Nil.new
 
+  ##
+  # Sets the strategy concealer uses to check permissions
+  #
   def self.strategy=(strategy)
     Thread.current[:concealer_strategy] = strategy
   end
 
+  ##
+  # Returns the strategy that's set for concealer. Default is Concealer::Strategy::Allow
+  #
   def self.strategy
     Thread.current[:concealer_strategy] || Concealer::Strategy::Allow.new
   end
 
+  ##
+  # Executes the block with the given strategy.
+  #
   def self.with_strategy(strategy)
     save, self.strategy = self.strategy, strategy
     yield
     self.strategy = save
   end
 
+  ##
+  # Registers a new fallback for the given method on the given model
+  #
   def self.register_fallback(model, method, fallback)
+    name = model.is_a?(Symbol) ? model : model.to_s.to_sym
     @@fallbacks ||= {}
-    @@fallbacks[model.to_s.to_sym] ||= {}
-    @@fallbacks[model.to_s.to_sym][method] = fallback
+    @@fallbacks[name] ||= {}
+    @@fallbacks[name][method] = fallback
   end
 
+  ##
+  # Returns the set fallback for the given method on the given model
+  # If none is set it returns the default fallback set with Concealer.default_fallback=
+  #
   def self.fallback_for(model, method)
     @@fallbacks ||= {}
     @@fallbacks.try(:[], model.class.to_s.to_sym).try(:[], method.to_sym) || @@default_fallback
   end
 
+  ##
+  # Accesses the current object using Concealer to check method calls
+  #
+  # Example:
+  #   Concealer.strategy = Concealer::Strategy::Deny.new
+  #   user = User.new(:name => "Christian")
+  #   user.name # => Christian
+  #   user.concealed.name # => nil
+  #
   def concealed
     Proxy.new(self, Concealer.strategy)
   end

data/lib/concealer/proxy.rb

@@ -10,7 +10,16 @@ module Concealer
     protected
 
     def method_missing(name, *args, &block)
-      if @strategy.allow?(@target, name, args)
+
+      check_concealed = /(.+)_allowed\?$/.match(name.to_s).try(:[], 1).try(:to_sym)
+      
+      if check_concealed && @target.respond_to?(check_concealed)
+        return @strategy.allow?(@target, check_concealed, args)
+      end
+      
+      if !@target.respond_to?(name)
+        raise NoMethodError, "#{@target} does not respond to #{name}"
+      elsif @strategy.allow?(@target, name, args)
         @target.send(name, *args, &block)
       else
         Concealer.fallback_for(@target, name).call(@target, name, args)

data/lib/concealer/strategy/multi_level.rb

@@ -7,7 +7,7 @@ class Concealer::Strategy::MultiLevel < Concealer::Strategy
 
   def allow?(model, method, args)
     required_level = required_level_for(model, method, args)
-    actual_level = @current_user.relation_level_to(owner_of(model))
+    actual_level = @current_user.try(:relation_level_to, owner_of(model)) || @levels.last
 
     raise "The level #{required_level} is not valid." unless @levels.include?(required_level)
     raise "The level #{actual_level} is not valid."   unless @levels.include?(actual_level)

data/lib/concealer/version.rb

@@ -1,3 +1,3 @@
 module Concealer
-  VERSION = "0.0.2"
+  VERSION = "0.1.0"
 end

data/spec/concealer/fallback/string_spec.rb

@@ -5,5 +5,9 @@ describe Concealer::Fallback::String do
     it "should return an empty string" do
       subject.call(nil, nil, nil).should eq("")
     end
+
+    it "should return the string given on initialization" do
+      Concealer::Fallback::String.new("some string").call(nil, nil, nil).should eq("some string")
+    end
   end
 end

data/spec/concealer/proxy_spec.rb

@@ -12,7 +12,7 @@ describe Concealer::Proxy do
     end
 
     it "should accept a target object and a strategy" do
-      expect { Concealer::Proxy.new(model, Concealer.strategy) }.to_not raise_error ArgumentError
+      expect { Concealer::Proxy.new(model, strategy) }.to_not raise_error ArgumentError
     end
   end
 
@@ -34,4 +34,17 @@ describe Concealer::Proxy do
 
     subject.allowed_method.should eq(:fallback)
   end
+  
+  it "should return false for allowed_method_allowed?" do
+    subject.allowed_method_allowed?.should be_true
+  end
+
+  it "should return true for denied_method_allowed?" do
+    strategy.stub!(:allow?).and_return(false)
+    subject.denied_method_allowed?.should be_false
+  end
+
+  it "should raise an NoMethodError when the target doesn't respond to a given method" do
+    expect { subject.some_missing_method }.to raise_error NoMethodError, /does not respond to some_missing_method/
+  end
 end

data/spec/concealer/strategy/multi_level_spec.rb

@@ -9,6 +9,18 @@ describe Concealer::Strategy::MultiLevel do
 
   subject { Concealer::Strategy::MultiLevel.new(current_user, levels) }
 
+  context 'with no current_user given' do
+    subject { Concealer::Strategy::MultiLevel.new(nil, levels) }
+
+    before(:each) do
+      subject.stub!(:required_level_for).and_return(:friends_of_friends)
+    end
+
+    it "should deny the call" do
+      subject.allow?(other_user, :name, nil).should be_false
+    end
+  end
+
   context 'required level higher than actual level' do
     before(:each) do
       subject.stub!(:required_level_for).and_return(:myself)

metadata

@@ -1,81 +1,61 @@
---- !ruby/object:Gem::Specification 
+--- !ruby/object:Gem::Specification
 name: concealer
-version: !ruby/object:Gem::Version 
-  hash: 27
-  prerelease: false
-  segments: 
-  - 0
-  - 0
-  - 2
-  version: 0.0.2
+version: !ruby/object:Gem::Version
+  version: 0.1.0
+  prerelease: 
 platform: ruby
-authors: 
+authors:
 - Benedikt Deicke
-- "Christian B\xC3\xA4uerlein"
+- Christian Bäuerlein
 autorequire: 
 bindir: bin
 cert_chain: []
-
-date: 2011-03-08 00:00:00 +01:00
-default_executable: 
-dependencies: 
-- !ruby/object:Gem::Dependency 
-  prerelease: false
-  version_requirements: &id001 !ruby/object:Gem::Requirement 
+date: 2012-02-15 00:00:00.000000000 Z
+dependencies:
+- !ruby/object:Gem::Dependency
+  name: activesupport
+  requirement: &70240046174920 !ruby/object:Gem::Requirement
     none: false
-    requirements: 
+    requirements:
     - - ~>
-      - !ruby/object:Gem::Version 
-        hash: 7
-        segments: 
-        - 3
-        - 0
-        version: "3.0"
-  requirement: *id001
-  name: activesupport
+      - !ruby/object:Gem::Version
+        version: '3.0'
   type: :runtime
-- !ruby/object:Gem::Dependency 
   prerelease: false
-  version_requirements: &id002 !ruby/object:Gem::Requirement 
+  version_requirements: *70240046174920
+- !ruby/object:Gem::Dependency
+  name: rspec
+  requirement: &70240046184280 !ruby/object:Gem::Requirement
     none: false
-    requirements: 
+    requirements:
     - - ~>
-      - !ruby/object:Gem::Version 
-        hash: 5
-        segments: 
-        - 2
-        - 3
-        version: "2.3"
-  requirement: *id002
-  name: rspec
+      - !ruby/object:Gem::Version
+        version: '2.6'
   type: :development
-- !ruby/object:Gem::Dependency 
   prerelease: false
-  version_requirements: &id003 !ruby/object:Gem::Requirement 
-    none: false
-    requirements: 
-    - - ">="
-      - !ruby/object:Gem::Version 
-        hash: 3
-        segments: 
-        - 0
-        version: "0"
-  requirement: *id003
+  version_requirements: *70240046184280
+- !ruby/object:Gem::Dependency
   name: rake
+  requirement: &70240046608520 !ruby/object:Gem::Requirement
+    none: false
+    requirements:
+    - - ! '>='
+      - !ruby/object:Gem::Version
+        version: '0'
   type: :development
+  prerelease: false
+  version_requirements: *70240046608520
 description: Privacy control your models with ease
-email: 
+email:
 - benedikt@synatic.net
 - fabrik42@gmail.com
 executables: []
-
 extensions: []
-
 extra_rdoc_files: []
-
-files: 
+files:
 - .gitignore
 - .rspec
+- .travis.yml
 - Gemfile
 - LICENSE
 - README.rdoc
@@ -114,41 +94,37 @@ files:
 - spec/support/concealed_model.rb
 - spec/support/paperclip.rb
 - spec/support/user.rb
-has_rdoc: true
 homepage: https://flinc.github.com/concealer
 licenses: []
-
 post_install_message: 
 rdoc_options: []
-
-require_paths: 
+require_paths:
 - lib
-required_ruby_version: !ruby/object:Gem::Requirement 
+required_ruby_version: !ruby/object:Gem::Requirement
   none: false
-  requirements: 
-  - - ">="
-    - !ruby/object:Gem::Version 
-      hash: 3
-      segments: 
+  requirements:
+  - - ! '>='
+    - !ruby/object:Gem::Version
+      version: '0'
+      segments:
       - 0
-      version: "0"
-required_rubygems_version: !ruby/object:Gem::Requirement 
+      hash: -1897724190148084110
+required_rubygems_version: !ruby/object:Gem::Requirement
   none: false
-  requirements: 
-  - - ">="
-    - !ruby/object:Gem::Version 
-      hash: 3
-      segments: 
+  requirements:
+  - - ! '>='
+    - !ruby/object:Gem::Version
+      version: '0'
+      segments:
       - 0
-      version: "0"
+      hash: -1897724190148084110
 requirements: []
-
 rubyforge_project: 
-rubygems_version: 1.3.7
+rubygems_version: 1.8.15
 signing_key: 
 specification_version: 3
 summary: Privacy control your models with ease
-test_files: 
+test_files:
 - spec/concealer/fallback/nil_spec.rb
 - spec/concealer/fallback/paperclip_spec.rb
 - spec/concealer/fallback/string_spec.rb