composable_operations 0.10.0 → 0.10.1

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA1:
-  metadata.gz: 16bacd4b97dcd28f11356d7a01dbc3957487b5a9
-  data.tar.gz: f622ff84700dccf7ed5fc89d99907706b124e0b5
+  metadata.gz: 1625a77cc6ddbf6e011cb4e2a967d5ab491e8689
+  data.tar.gz: 5f1c9270151db8f4b52efc01366d00d12e3975b8
 SHA512:
-  metadata.gz: 4a2bf743f4f0f86f5ab3f0c8265c68feedf626dbf76cf00c860184ae81e37dd4635a324adf46c9c4f0b7c90af675863ada47bcb0d12f732d4d47180e9683be57
-  data.tar.gz: 13dd02a2bdd146fab5bc27a265cf24a5180087303981c89b2aa23d89076a7fab70687be56971a6a63f6d8d78727267bb833b5080ec432776bed055963110eba7
+  metadata.gz: e014a75115eb0939b2b3616138c7c8c70fea8d93bbc5d07d5e0a54d211a22ea14a69bf999bfdfb8d47009a852f130a6cafdee1de7d0a9857a2181ba60c30e790
+  data.tar.gz: 451f1c59b1eb0a8163d8e7a63fc4fca418ec35483d0e79fcee76063120c5cef8489e3bba398eda83ccb6b5a92164ace4b6724f71189966dea5373b921c64612d

data/lib/composable_operations/operation.rb

@@ -4,10 +4,8 @@ module ComposableOperations
     include SmartProperties
 
     class << self
-      attr_writer :arguments
-
       def arguments
-        @arguments ||= []
+        []
       end
 
       def arity
@@ -64,10 +62,8 @@ module ComposableOperations
           when 0
             raise ArgumentError, "#{self}.#{__callee__} expects at least one argument"
           else
-            names.each_with_index do |name, index|
-              property(name, required: true) unless properties.key?(name)
-              arguments << name
-            end
+            names.each { |name| property(name, required: true) unless properties.key?(name) }
+            define_singleton_method(:arguments) { names }
           end
         end
 

data/lib/composable_operations/version.rb

@@ -1,3 +1,3 @@
 module ComposableOperations
-  VERSION = "0.10.0"
+  VERSION = "0.10.1"
 end

data/spec/composable_operations/operation_spec.rb

@@ -126,5 +126,66 @@ describe ComposableOperations::Operation do
 
     it { is_expected.to succeed_to_perform.when_initialized_with("-", 3).and_return("---") }
   end
+
+  context "inheritance" do
+    let(:base_operation) do
+      Class.new(described_class) do
+        processes :text
+      end
+    end
+
+    let(:sub_operation) do
+      Class.new(base_operation) do
+        def execute
+          text.upcase
+        end
+      end
+    end
+
+    let(:sub_operation_with_different_input) do
+      Class.new(base_operation) do
+        processes :text, :multiplier
+        def execute
+          text * multiplier
+        end
+      end
+    end
+
+    context "the base operation" do
+      subject! { base_operation }
+
+      it "should take one argument" do
+        expect(base_operation.arity).to eq(1)
+        expect(base_operation.arguments).to eq([:text])
+      end
+    end
+
+    context "the sub operation" do
+      subject! { sub_operation }
+
+      it "should take one argument" do
+        expect(base_operation.arity).to eq(1)
+        expect(base_operation.arguments).to eq([:text])
+      end
+
+      it { is_expected.to succeed_to_perform.when_initialized_with("lorem ipsum").and_return("LOREM IPSUM") }
+    end
+
+    context "the sub operation with different input" do
+      subject! { sub_operation_with_different_input }
+
+      it "should take two arguments" do
+        expect(sub_operation_with_different_input.arity).to eq(2)
+        expect(sub_operation_with_different_input.arguments).to eq([:text, :multiplier])
+      end
+
+      it "should not influence the arguments of base operation" do
+        expect(base_operation.arity).to eq(1)
+        expect(base_operation.arguments).to eq([:text])
+      end
+
+      it { is_expected.to succeed_to_perform.when_initialized_with("-", 3).and_return("---") }
+    end
+  end
 end
 

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: composable_operations
 version: !ruby/object:Gem::Version
-  version: 0.10.0
+  version: 0.10.1
 platform: ruby
 authors:
 - Konstantin Tennhard
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2015-10-20 00:00:00.000000000 Z
+date: 2015-11-17 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: smart_properties